[GitHub] [incubator-dubbo] ywww opened issue #2795: 如何关闭 dubbo telnet调试功能
由于安全问题, 需要关闭 dubbo telnet调试功能 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2795 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] ywww commented on issue #1220: Support disable `telnet` when using EnableDubbo or Annotation.
@chickenlj how to config [ Full content available at: https://github.com/apache/incubator-dubbo/issues/1220 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #2753: 服务端已发送服务调用结果，客户端无响应直至服务调用超时
好的。谢谢你的issue。 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2753 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] TeddyTsui commented on issue #2753: 服务端已发送服务调用结果，客户端无响应直至服务调用超时
@carryxyh 尝试了升级至2.6.0版本后，问题没能解决。暂时还提供不了复现问题的demo。 有进展我再打开，谢谢跟进。 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2753 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] TeddyTsui closed issue #2753: 服务端已发送服务调用结果，客户端无响应直至服务调用超时
[ issue closed by TeddyTsui ] [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2753 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #2794: dubbo注解方式为啥存在缓存
请自行查看文档。 http://dubbo.apache.org/zh-cn/docs/user/configuration/annotation.html [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2794 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh closed issue #2794: dubbo注解方式为啥存在缓存
[ issue closed by carryxyh ] [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2794 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] BellaJiangxia commented on issue #2794: dubbo注解方式为啥存在缓存
 使用这种注解方式后还需要有配置文件吗 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2794 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] netyjq commented on issue #2782: Dubbo2.6.4客户端调用dubbox2.8.4服务异常
这个问题我遇到了，找到了出错的地方，但是没太搞明白原因。 2.8.4 是当当改的dubbox 报错位置在 `com.alibaba.com.caucho.hessian.io.Hessian2Input` `readInt` 方法 ，switch 条件 tag 值为 116，最后执行了 default 模块，抛出了异常： `com.alibaba.com.caucho.hessian.io.HessianProtocolException: expected integer at 0x74 ` [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2782 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] BellaJiangxia opened issue #2794: dubbo注解方式为啥存在缓存
如题，，， [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2794 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] BellaJiangxia commented on issue #2792: dubbo如何清缓存？
这文件有啥用 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2792 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] BellaJiangxia commented on issue #2792: dubbo如何清缓存？
好像是这个日志文件，我把他删了重新运行就不行了，为啥呢   [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2792 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] BellaJiangxia commented on issue #2792: dubbo如何清缓存？
 发错了，是这个 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2792 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] BellaJiangxia commented on issue #2792: dubbo如何清缓存？
 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2792 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] BellaJiangxia commented on issue #2792: dubbo如何清缓存？
我使用了注解，就是在测试注解的方式 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2792 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh closed issue #2792: dubbo如何清缓存？
[ issue closed by carryxyh ] [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2792 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #2792: dubbo如何清缓存？
这不是dubbo的问题。 dubbo默认不会在zk上创建持久节点，也不会缓存配置文件。没有配置文件的情况下更不会启动成功（没有使用注解的情况下）。请你检查自己的服务器部署的jar包是不是最新版本或者其他操作是否有问题。 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2792 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #2792: dubbo如何清缓存？
这不是dubbo的问题。 dubbo默认不会在zk上创建持久节点。没有配置文件的情况下更不会启动成功（没有使用注解的情况下）。请你检查自己的服务器部署的jar包是不是最新版本或者其他操作是否有问题。 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2792 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] BellaJiangxia commented on issue #2792: dubbo如何清缓存？
 这意思是wo我那个服务的进程没有关闭吗 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2792 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] BellaJiangxia commented on issue #2792: dubbo如何清缓存？
 不存在了，会不会是我那个关闭服务的时候我是直接把命令窗口关了？还是要用命令关闭服务？ [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2792 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #2792: dubbo如何清缓存？
看一下打出来的包中是否还包含配置文件 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2792 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] gxcsoccer opened issue #2793: [Proposal] dubbo 和 Node.js 框架 egg.js 的对接
## Egg.js 是什么？ Egg.js （下面简称 Egg）是阿里开源的企业级的 Node.js Web 框架，在 Github 上已经超过 1 万个 Star，是目前国内 Node.js 社区最主流的框架。 ## Egg.js 的设计哲学 - `约定优于配置：`Egg 约定了统一的加载机制、生命周期以及扩展方式，这样可以最大程度降低开发人员的学习成本 - `插件机制：`Egg 本身是非常轻量的，它的能力更多依赖于其插件生态（目前 Egg 官方 group 下已经有超过 100 个插件） - `框架的框架：`提供基于 Egg 定制上层框架的能力。每个公司可以根据其实际情况将 Egg 和一系列插件组合起来定制出符合其业务的框架，这也是我们取名为 Egg 的重要原因 ## Egg.js 对于 Dubbo 的支持 简单来说，用户只需要开启 [egg-dubbo-rpc](https://github.com/eggjs/egg-dubbo-rpc) 这个插件，就可以实现 Dubbo 服务的发布和调用。 再详细一点，其中和 Dubbo 有关的模块有下面这些： - [egg-rpc](https://github.com/eggjs/egg-rpc) － 所有 RPC 插件的「父类」，提供了 consumer、provider、registry、test 等模块的抽象。我们希望通过这种抽象，使得在 Egg 生态中各种 RPC 的体验是一致，或者换句话说对于使用者来说甚至感知不到 RPC 的存在 - [egg-dubbo-rpc](https://github.com/eggjs/egg-dubbo-rpc) － 对 egg-rpc 做的 dubbo 定制化，包括协议、内置 dubbo zk registry 实现等 - [egg-rpc-generator](https://github.com/eggjs/egg-rpc-generator) － 这是一个配套的 RPC 工具，它的作用是根据不同的接口描述文件（pb、jar 包）生成 metadata 并进而生成调用的 proxy 代码，通过这个工具我们可以让使用者可以像调用本地方法一样调用 RPC - [jar2proxy](https://github.com/eggjs/jar2proxy) － dubbo 默认的序列化方式是 hessian，它是一种 java 友好的方式（因为接口定义就是一个 jar 包）但是对于多语言来说就比较棘手。jar2proxy 的作用就是从 jar 包导出接口的元数据，然后生成调用代码。（它已经被集成到 egg-rpc-generator 内部，这样用户只需要知道一个工具即可） - [dubbo-remoting](https://github.com/dubbo-js/dubbo-remoting) － 这个是我们对 dubbo 协议的实现，它被默认集成到 egg-dubbo-rpc 插件内部。关于协议这块也是可插拔的，我们采用了标准的 stream 接口，便于大家进行扩展  模块关系图 ## 如何贡献 Dubbo 社区 因为 Egg 本身是开放的，我们希望支持所有主流的 RPC，当然也包含 Dubbo。上面列出来的几个模块中有 dubbo-remoting 和 egg-dubbo-rpc 是和 dubbo 强绑定的，其余的都是对所有 RPC 通用的。所以我们希望向 dubbo 社区贡献这两个模块（是否需要将他们 transfer 到 dubbo group 我们想征求大家的意见），另外我们也注意到 dubbo group 下已经有了一个 Node.js 的实现叫 [dubbo2.js](https://github.com/dubbo/dubbo2.js)，我们也联系到了他的维护者 @hufeng，他也希望和我们一起共建官方的 dubbo Node.js 实现（很高兴他也是 Egg.js 的使用者），共同推动 dubbo 在 Node.js 社区的推广 谢谢大家 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2793 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] BellaJiangxia commented on issue #2792: dubbo如何清缓存？
可以成功，  最开始在有这个provider的时候通过 这种方式部署上去了，admin可以显示，后面把这个provider删除了依然重新打包重新启动依然可以注册成功 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2792 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #2792: dubbo如何清缓存？
删除配置文件之后重启可以成功么 不会注册成功的，没有zk的配置，怎么知道注册到哪个zk上呢，怎么还会有注册成功这一说。 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2792 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] BellaJiangxia commented on issue #2792: dubbo如何清缓存？
应该是那个zookeeper的，我配置文件都删了，还能注册成功 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2792 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #2792: dubbo如何清缓存？
没有配置文件应该是不能注册成功的。也不能启动成功。 不知道你想清理什么缓存，是zk的数据么 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2792 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #2792: dubbo如何清缓存？
没有配置文件应该是不能注册成功的。 不知道你想清理什么缓存，是zk的数据么 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2792 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] BellaJiangxia commented on issue #2792: dubbo如何清缓存？
启动服务是通过他自带的main方法启动的 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2792 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] BellaJiangxia opened issue #2792: dubbo如何清缓存？
最开始在服务器上部署了一个dubbo提供者的服务，然后在项目种删除掉该服务对应的dubbo配置文件，重新打包，为啥仍然可以注册服务成功？如何清除缓存？ [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2792 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] linuke commented on issue #2782: Dubbo2.6.4客户端调用dubbox2.8.4服务异常
https://github.com/dangdangdotcom/dubbox/commit/85b9ab1e3e209e5ee82b75a7d38a7a1bcee8b58b 看下这个，这次提交把协议都改了，所以你遇到这个问题。 这个也坑了我好久 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2782 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo]
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/1393 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] bee06 commented on issue #2789: 可以实现动态添加和删除filter吗
> 应该是可以的。 > 通过修改zk上的url。 不可以吧 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2789 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] edwardlee03 commented on issue #2770: Dubbo线程池满JStack日志中出现很多ValidationFilter的ClassLoader.loadClass线程BLOCK
> 感谢回复~ 验证参数在文档也看到了，有少数应用用了这个，目前已修改为程序中进行参数验证。 > Dubbo_JStack.log发dubbo钉钉群了的； > 线程池配置固定500，有1个文件里接近500个线程有这行日志 > com.alibaba.dubbo.validation.support.jvalidation.JValidator.validate(JValidator.java:241) > 其它日志文件，大概有5-200个左右，其它线程在在处理业务。 sorry，我没在Dubbo钉钉群里。 参数验证看看能否使用 Spring MVC 的 Validation 机制。 仔细看了你贴的异常堆栈信息，我的分析如下： 1、关键的异常信息 ```java "DubboServerHandler-10.1.5.43:20879-thread-178" Id=236 RUNNABLE at java.lang.ClassLoader.loadClass(ClassLoader.java:404) - locked java.lang.Object@1d72d35e < but blocks 93 other threads! at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Class.java:348) at com.alibaba.dubbo.validation.support.jvalidation.JValidator.validate(JValidator.java:241) ``` 从上述异常信息获取到的线索，`JValidator.validate(JValidator.java:241)`调用`Class.forName(Class.java:348)`，进而调用应用加载器加载类`Launcher$AppClassLoader.loadClass(Launcher.java:331)`，最终类加载器在加载类时`ClassLoader.loadClass(ClassLoader.java:404)`使用对象同步阻塞了93个其它线程`locked java.lang.Object@1d72d35e < but blocks 93 other threads!`。 2、通过源码验证上述分析    基于`ClassLoader`的源码，加载类时使用并行锁对象映射表来减少锁的竞争。我猜测问题的根源是`JValidator.validate(JValidator.java:241)`会频繁地加载类。 如何验证这个猜测，可以使用 [arthas](https://github.com/alibaba/arthas) 或 [greys-anatomy](https://github.com/oldmanpushcart/greys-anatomy) 查看加载了多少类。 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2770 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] edwardlee03 commented on issue #2770: Dubbo线程池满JStack日志中出现很多ValidationFilter的ClassLoader.loadClass线程BLOCK
> 感谢回复~ 验证参数在文档也看到了，有少数应用用了这个，目前已修改为程序中进行参数验证。 > Dubbo_JStack.log发dubbo钉钉群了的； > 线程池配置固定500，有1个文件里接近500个线程有这行日志 > com.alibaba.dubbo.validation.support.jvalidation.JValidator.validate(JValidator.java:241) > 其它日志文件，大概有5-200个左右，其它线程在在处理业务。 sorry，我没在Dubbo钉钉群里。 参数验证看看能否使用 Spring MVC 的 Validation 机制。 仔细看了你贴的异常堆栈信息，我的分析如下： 1、关键的异常信息 ```java "DubboServerHandler-10.1.5.43:20879-thread-178" Id=236 RUNNABLE at java.lang.ClassLoader.loadClass(ClassLoader.java:404) - locked java.lang.Object@1d72d35e < but blocks 93 other threads! at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Class.java:348) at com.alibaba.dubbo.validation.support.jvalidation.JValidator.validate(JValidator.java:241) ``` 从上述异常信息获取到的线索，`JValidator.validate(JValidator.java:241)`调用`Class.forName(Class.java:348)`，进而调用应用加载器加载类`Launcher$AppClassLoader.loadClass(Launcher.java:331)`，最终类加载器在加载类时`ClassLoader.loadClass(ClassLoader.java:404)`使用对象同步阻塞了93个其它线程`locked java.lang.Object@1d72d35e < but blocks 93 other threads!`。 2、通过源码验证上述分析    基于`ClassLoader`的源码，加载类时使用并行锁对象映射表来减少锁的竞争。我猜测问题的根源是`JValidator.validate(JValidator.java:241)`会频繁地加载不同的类。 如何验证这个猜测，可以使用 [arthas](https://github.com/alibaba/arthas) 或 [greys-anatomy](https://github.com/oldmanpushcart/greys-anatomy) 查看加载了多少类。 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2770 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] edwardlee03 commented on issue #2770: Dubbo线程池满JStack日志中出现很多ValidationFilter的ClassLoader.loadClass线程BLOCK
> 感谢回复~ 验证参数在文档也看到了，有少数应用用了这个，目前已修改为程序中进行参数验证。 > Dubbo_JStack.log发dubbo钉钉群了的； > 线程池配置固定500，有1个文件里接近500个线程有这行日志 > com.alibaba.dubbo.validation.support.jvalidation.JValidator.validate(JValidator.java:241) > 其它日志文件，大概有5-200个左右，其它线程在在处理业务。 sorry，我没在Dubbo钉钉群里。 参数验证看看能否使用 Spring MVC 的 Validation 机制。 仔细看了你贴的异常堆栈信息，我的分析如下： 1、关键的异常信息 ```java "DubboServerHandler-10.1.5.43:20879-thread-178" Id=236 RUNNABLE at java.lang.ClassLoader.loadClass(ClassLoader.java:404) - locked java.lang.Object@1d72d35e < but blocks 93 other threads! at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Class.java:348) at com.alibaba.dubbo.validation.support.jvalidation.JValidator.validate(JValidator.java:241) ``` 从上述异常信息获取到的线索，`JValidator.validate(JValidator.java:241)`调用`Class.forName(Class.java:348)`，进而调用应用加载器加载类`Launcher$AppClassLoader.loadClass(Launcher.java:331)`，最终类加载器在加载类时`loadClass(ClassLoader.java:404)`使用对象同步锁阻塞了93个其它线程`locked java.lang.Object@1d72d35e < but blocks 93 other threads!`。 2、通过源码验证上述分析    基于`ClassLoader`的源码，加载类时使用并行锁对象映射表来减少锁的竞争。我猜测问题的根源是`JValidator.validate(JValidator.java:241)`会频繁地加载不同的类。 如何验证这个猜测，可以使用 [arthas](https://github.com/alibaba/arthas) 或 [greys-anatomy](https://github.com/oldmanpushcart/greys-anatomy) 查看加载了多少类。 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2770 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh closed pull request #2790: Improvement on Parameters and CollectionUtils
[ pull request closed by carryxyh ] [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2790 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #2790: Improvement on Parameters and CollectionUtils
Seems like Parameters.java is deprecated and never init in dubbo now. But I think a little optimization is also good. LGTM. [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2790 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh closed pull request #2791: Fix typo
[ pull request closed by carryxyh ] [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2791 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #2791: Fix typo
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2791?src=pr=h1) Report > Merging > [#2791](https://codecov.io/gh/apache/incubator-dubbo/pull/2791?src=pr=desc) > into > [master](https://codecov.io/gh/apache/incubator-dubbo/commit/38a65115a5bff24dd6c8dc78eb7655443be84a69?src=pr=desc) > will **increase** coverage by `1.04%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/2791?src=pr=tree) ```diff @@Coverage Diff @@ ## master#2791 +/- ## == + Coverage 62.47% 63.51% +1.04% == Files 599 577 -22 Lines 2792425935-1989 Branches 4832 4544 -288 == - Hits1744516473 -972 + Misses 8214 7303 -911 + Partials 2265 2159 -106 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2791?src=pr=tree) | Coverage Δ | | |---|---|---| | [...mon/src/main/java/org/apache/dubbo/common/URL.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2791/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vVVJMLmphdmE=) | `46.67% <ø> (ø)` | :arrow_up: | | [...ache/dubbo/remoting/transport/AbstractChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2791/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDaGFubmVsLmphdmE=) | `75% <0%> (-12.5%)` | :arrow_down: | | [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2791/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50SGFuZGxlci5qYXZh) | `75% <0%> (-11.12%)` | :arrow_down: | | [...che/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2791/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNoYW5uZWwuamF2YQ==) | `39.47% <0%> (-10.53%)` | :arrow_down: | | [...he/dubbo/remoting/transport/netty/NettyClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2791/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNsaWVudC5qYXZh) | `72.88% <0%> (-8.48%)` | :arrow_down: | | [...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2791/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvQWN0aXZlTGltaXRGaWx0ZXIuamF2YQ==) | `83.33% <0%> (-5.56%)` | :arrow_down: | | [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2791/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL3RlbG5ldC9JbnZva2VUZWxuZXRIYW5kbGVyLmphdmE=) | `54.21% <0%> (-3.62%)` | :arrow_down: | | [...he/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2791/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eVNlcnZlci5qYXZh) | `67.85% <0%> (-3.58%)` | :arrow_down: | | [...pache/dubbo/remoting/transport/AbstractServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2791/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RTZXJ2ZXIuamF2YQ==) | `45.36% <0%> (-3.1%)` | :arrow_down: | | [...pache/dubbo/remoting/transport/AbstractClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2791/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDbGllbnQuamF2YQ==) | `65.94% <0%> (-2.17%)` | :arrow_down: | | ... and [30 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2791/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2791?src=pr=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2791?src=pr=footer). > Last update > [38a6511...83601ae](https://codecov.io/gh/apache/incubator-dubbo/pull/2791?src=pr=lastupdated). > Read the [comment
[GitHub] [incubator-dubbo] satansk opened pull request #2791: Fix typo
## What is the purpose of the change Small improvement in comment: * confilict -> conflict ## Brief changelog X ## Verifying this change X Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test). - [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide). [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2791 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #2790: Improvement on Parameters and CollectionUtils
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2790?src=pr=h1) Report > Merging > [#2790](https://codecov.io/gh/apache/incubator-dubbo/pull/2790?src=pr=desc) > into > [master](https://codecov.io/gh/apache/incubator-dubbo/commit/38a65115a5bff24dd6c8dc78eb7655443be84a69?src=pr=desc) > will **decrease** coverage by `0.05%`. > The diff coverage is `75%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/2790?src=pr=tree) ```diff @@Coverage Diff @@ ## master#2790 +/- ## == - Coverage63.6% 63.54% -0.06% == Files 577 577 Lines 2593525929 -6 Branches 4544 4541 -3 == - Hits1649516477 -18 - Misses 7283 7291 +8 - Partials 2157 2161 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2790?src=pr=tree) | Coverage Δ | | |---|---|---| | [.../main/java/org/apache/dubbo/common/Parameters.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2790/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vUGFyYW1ldGVycy5qYXZh) | `0% <0%> (ø)` | :arrow_up: | | [...org/apache/dubbo/common/utils/CollectionUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2790/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ29sbGVjdGlvblV0aWxzLmphdmE=) | `87.37% <100%> (ø)` | :arrow_up: | | [...ache/dubbo/remoting/transport/AbstractChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2790/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDaGFubmVsLmphdmE=) | `75% <0%> (-12.5%)` | :arrow_down: | | [...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2790/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvQWN0aXZlTGltaXRGaWx0ZXIuamF2YQ==) | `77.77% <0%> (-11.12%)` | :arrow_down: | | [...he/dubbo/remoting/transport/netty/NettyClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2790/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNsaWVudC5qYXZh) | `72.88% <0%> (-8.48%)` | :arrow_down: | | [...he/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2790/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eVNlcnZlci5qYXZh) | `67.85% <0%> (-3.58%)` | :arrow_down: | | [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2790/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `58.82% <0%> (-3.53%)` | :arrow_down: | | [...pache/dubbo/remoting/transport/AbstractClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2790/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDbGllbnQuamF2YQ==) | `65.94% <0%> (-2.17%)` | :arrow_down: | | [...e/dubbo/registry/integration/RegistryProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2790/diff?src=pr=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9pbnRlZ3JhdGlvbi9SZWdpc3RyeVByb3RvY29sLmphdmE=) | `81.25% <0%> (-1.93%)` | :arrow_down: | | [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2790/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNvZGVjQWRhcHRlci5qYXZh) | `54.68% <0%> (+1.56%)` | :arrow_up: | | ... and [2 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2790/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2790?src=pr=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2790?src=pr=footer). > Last update > [38a6511...58de88e](https://codecov.io/gh/apache/incubator-dubbo/pull/2790?src=pr=lastupdated). > Read the [comment
[GitHub] [incubator-dubbo] satansk opened pull request #2790: Improvement on Parameters and CollectionUtils
## What is the purpose of the change Use `CollectionUtils.toStringMap` to reduce duplicate code in `Parameters`, and use Java 8 type inference for collections. ## Brief changelog X ## Verifying this change X Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test). - [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide). [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2790 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #2789: 可以实现动态添加和删除filter吗
应该是可以的。 通过修改zk上的url。 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2789 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [incubator-dubbo] shuohao opened issue #2789: 可以实现动态添加和删除filter吗
目前添加和去掉自定义Filter需要项目启动前代码上设置filter或者"-"去掉，问下能否实现动态的添加和删除 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2789 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
