[GitHub] [dubbo] lak7 commented on issue #10850: Add deprecated method warn when called by user
lak7 commented on issue #10850: URL: https://github.com/apache/dubbo/issues/10850#issuecomment-1398578287 Can you assign this issue to me? Thank you. I would appreciate any reply. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-rust] yang20150702 merged pull request #102: 通过target_os使用Unix套接字连接器通信
yang20150702 merged PR #102: URL: https://github.com/apache/dubbo-rust/pull/102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-rust] yang20150702 commented on pull request #102: 通过target_os使用Unix套接字连接器通信
yang20150702 commented on PR #102: URL: https://github.com/apache/dubbo-rust/pull/102#issuecomment-1398437423 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] bobtthp commented on a diff in pull request #2186: Support Servicemapping Listener
bobtthp commented on code in PR #2186:
URL: https://github.com/apache/dubbo-go/pull/2186#discussion_r1082468070
##
registry/event/service_mapping_change_listener_impl.go:
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package event
+
+import (
+ "sync"
+)
+
+import (
+ gxset "github.com/dubbogo/gost/container/set"
+ "github.com/dubbogo/gost/gof/observer"
+)
+
+import (
+ "dubbo.apache.org/dubbo-go/v3/common"
+ "dubbo.apache.org/dubbo-go/v3/common/constant"
+ "dubbo.apache.org/dubbo-go/v3/common/extension"
+ "dubbo.apache.org/dubbo-go/v3/registry"
+)
+
+type ServiceMappingChangedListenerImpl struct {
+ oldServiceNames *gxset.HashSet
+ listenerregistry.NotifyListener
+ registryUrl *common.URL
+ serviceUrl *common.URL
+ mappingCache*sync.Map
+ stopint
+}
+
+const (
+ ServiceMappingListenerStart = iota
+ ServiceMappingListenerStop
+)
+
+func NewMappingListener(registryUrl *common.URL, serviceUrl *common.URL,
oldServiceNames *gxset.HashSet, listener registry.NotifyListener)
*ServiceMappingChangedListenerImpl {
+ return {
+ listener:listener,
+ oldServiceNames: oldServiceNames,
+ registryUrl: registryUrl,
+ serviceUrl: serviceUrl,
+ stop:ServiceMappingListenerStart,
+ mappingCache:{},
+ }
+}
+
+// OnEvent on ServiceMappingChangedEvent the service mapping change event
+func (lstn *ServiceMappingChangedListenerImpl) OnEvent(e observer.Event) error
{
+ var (
+ err error
+ reg registry.Registry
+ )
+ if lstn.stop == ServiceMappingListenerStop {
+ return nil
+ }
+ sm, ok := e.(*registry.ServiceMappingChangeEvent)
+ if !ok {
+ return nil
+ }
+ newServiceNames := sm.GetServiceNames()
+ oldServiceNames := lstn.oldServiceNames
+
+ // serviceMapping is orderly
+ if newServiceNames.Empty() || oldServiceNames.String() ==
newServiceNames.String() {
+ return nil
+ }
+
+ if newServiceNames.Size() > 0 && oldServiceNames.Empty() {
+ if reg, err =
extension.GetRegistry(constant.ServiceRegistryProtocol, lstn.registryUrl); err
!= nil {
+ return err
+ }
+ reg.SubscribeURL(lstn.serviceUrl, lstn.listener,
newServiceNames)
+ lstn.oldServiceNames = newServiceNames
+ return nil
+ }
+ for _, app := range newServiceNames.Values() {
+ if !oldServiceNames.Contains(app) {
+ lstn.mappingCache.Delete(oldServiceNames.String())
Review Comment:
重复的不会删除，我的理解是注册的时候可以规避一下重复注册问题哈
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] bobtthp commented on pull request #2186: Support Servicemapping Listener
bobtthp commented on PR #2186: URL: https://github.com/apache/dubbo-go/pull/2186#issuecomment-1398320538 > Hi @bobtthp, thanks for your contribution! There are too many non-relevant commits. Please rebase the latest 3.0 branch before this pull request steps forward. got it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] zeusbee commented on a diff in pull request #11353: 【fix】remove alibaba.spring-context #11078
zeusbee commented on code in PR #11353: URL: https://github.com/apache/dubbo/pull/11353#discussion_r1082356399 ## dubbo-common/src/main/java/org/apache/dubbo/common/utils/ObjectUtils.java: ## @@ -0,0 +1,24 @@ +package org.apache.dubbo.common.utils; Review Comment: OK, I'll also change the other documents -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #11358: Support native ci check
AlbumenJ merged PR #11358: URL: https://github.com/apache/dubbo/pull/11358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #11359: Introduce Invocation#getInvokedInvokers to get invokers for ClusterFilter
AlbumenJ merged PR #11359: URL: https://github.com/apache/dubbo/pull/11359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #11359: Introduce Invocation#getInvokedInvokers to get invokers for ClusterFilter
codecov-commenter commented on PR #11359: URL: https://github.com/apache/dubbo/pull/11359#issuecomment-1397895375 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/11359?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#11359](https://codecov.io/gh/apache/dubbo/pull/11359?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (32ff8f2) into [3.2](https://codecov.io/gh/apache/dubbo/commit/f0764b33b1968630a596c24d7889850b6e1939f8?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f0764b3) will **decrease** coverage by `4.56%`. > The diff coverage is `50.00%`. ```diff @@ Coverage Diff @@ ##3.2 #11359 +/- ## - Coverage 69.39% 64.83% -4.56% + Complexity 132 14 -118 Files 1514 1487 -27 Lines 8122362370 -18853 Branches 14407 9133-5274 - Hits 5636640439 -15927 + Misses2004317711-2332 + Partials 4814 4220 -594 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/11359?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rc/main/java/com/alibaba/dubbo/rpc/Invocation.java](https://codecov.io/gh/apache/dubbo/pull/11359?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9JbnZvY2F0aW9uLmphdmE=) | `8.33% <0.00%> (-0.56%)` | :arrow_down: | | [...main/java/com/alibaba/dubbo/rpc/RpcInvocation.java](https://codecov.io/gh/apache/dubbo/pull/11359?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9ScGNJbnZvY2F0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...src/main/java/org/apache/dubbo/rpc/Invocation.java](https://codecov.io/gh/apache/dubbo/pull/11359?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9JbnZvY2F0aW9uLmphdmE=) | `20.00% <ø> (ø)` | | | [...bo/rpc/cluster/support/AbstractClusterInvoker.java](https://codecov.io/gh/apache/dubbo/pull/11359?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9BYnN0cmFjdENsdXN0ZXJJbnZva2VyLmphdmE=) | `79.60% <100.00%> (-4.66%)` | :arrow_down: | | [.../main/java/org/apache/dubbo/rpc/RpcInvocation.java](https://codecov.io/gh/apache/dubbo/pull/11359?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNJbnZvY2F0aW9uLmphdmE=) | `70.00% <100.00%> (-2.12%)` | :arrow_down: | | [...luster/router/script/ScriptStateRouterFactory.java](https://codecov.io/gh/apache/dubbo/pull/11359?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3NjcmlwdC9TY3JpcHRTdGF0ZVJvdXRlckZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [...he/dubbo/test/common/impl/GreetingServiceImpl.java](https://codecov.io/gh/apache/dubbo/pull/11359?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vaW1wbC9HcmVldGluZ1NlcnZpY2VJbXBsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [...zookeeper/curator/CuratorZookeeperTransporter.java](https://codecov.io/gh/apache/dubbo/pull/11359?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3Rpbmctem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy96b29rZWVwZXIvY3VyYXRvci9DdXJhdG9yWm9va2VlcGVyVHJhbnNwb3J0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | |
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11359: Introduce Invocation#getInvokedInvokers to get invokers for ClusterFilter
sonarcloud[bot] commented on PR #11359: URL: https://github.com/apache/dubbo/pull/11359#issuecomment-1397893568 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo=11359) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11359=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11359=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo=11359=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11359=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11359=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo=11359=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11359=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11359=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11359=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11359=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11359=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_dubbo=11359=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo=11359=new_coverage=list) [50.0% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo=11359=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_dubbo=11359=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo=11359=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11352: metrics code optimization
sonarcloud[bot] commented on PR #11352: URL: https://github.com/apache/dubbo/pull/11352#issuecomment-1397889373 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo=11352) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11352=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11352=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11352=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=CODE_SMELL) [11 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo=11352=new_coverage=list) [80.1% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo=11352=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_dubbo=11352=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo=11352=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #11021: Added support for Micrometer Observation API
AlbumenJ commented on code in PR #11021:
URL: https://github.com/apache/dubbo/pull/11021#discussion_r1082079313
##
dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/filter/observation/AbstractDefaultDubboObservationConvention.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dubbo.metrics.filter.observation;
+
+import io.micrometer.common.KeyValues;
+import io.micrometer.common.docs.KeyName;
+import io.micrometer.common.lang.Nullable;
+import org.apache.dubbo.common.utils.StringUtils;
+import org.apache.dubbo.rpc.Invocation;
+import org.apache.dubbo.rpc.RpcContextAttachment;
+
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.NET_PEER_NAME;
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.NET_PEER_PORT;
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.RPC_METHOD;
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.RPC_SERVICE;
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.RPC_SYSTEM;
+
+class AbstractDefaultDubboObservationConvention {
+KeyValues getLowCardinalityKeyValues(Invocation invocation,
RpcContextAttachment rpcContextAttachment) {
+KeyValues keyValues =
KeyValues.of(RPC_SYSTEM.withValue("apache_dubbo"));
+String serviceName = StringUtils.hasText(invocation.getServiceName())
? invocation.getServiceName() :
readServiceName(invocation.getTargetServiceUniqueName());
+keyValues = appendNonNull(keyValues, RPC_SERVICE, serviceName);
+keyValues = appendNonNull(keyValues, RPC_METHOD,
invocation.getMethodName());
+keyValues = appendNonNull(keyValues, NET_PEER_NAME,
rpcContextAttachment.getRemoteHostName());
+if (rpcContextAttachment.getRemotePort() == 0) {
+return keyValues;
+}
+int port = rpcContextAttachment.getRemotePort() != 0 ?
rpcContextAttachment.getRemotePort() : rpcContextAttachment.getLocalPort();
Review Comment:
I have been submit a [PR](https://github.com/apache/dubbo/pull/11359)
related this feature, which may helps you to retrieve the invoked remote
invoker in `ClusterFilter#onResponse` and `ClusterFilter#onError`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #11358: Support native ci check
codecov-commenter commented on PR #11358: URL: https://github.com/apache/dubbo/pull/11358#issuecomment-1397879867 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/11358?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#11358](https://codecov.io/gh/apache/dubbo/pull/11358?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (976350f) into [3.1](https://codecov.io/gh/apache/dubbo/commit/945914b5046f8982b62a6021000d423c122825a8?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (945914b) will **increase** coverage by `0.23%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ##3.1 #11358 +/- ## + Coverage 64.58% 64.82% +0.23% Complexity 14 14 Files 1428 1487 +59 Lines 5977762360+2583 Branches 8794 9133 +339 + Hits 3860540422+1817 - Misses1710317719 +616 - Partials 4069 4219 +150 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/11358?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [.../serialize/hessian2/Hessian2SerializerFactory.java](https://codecov.io/gh/apache/dubbo/pull/11358?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yU2VyaWFsaXplckZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [...ommon/serialize/hessian2/Hessian2ObjectOutput.java](https://codecov.io/gh/apache/dubbo/pull/11358?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yT2JqZWN0T3V0cHV0LmphdmE=) | `0.00% <0.00%> (-37.84%)` | :arrow_down: | | [...common/serialize/hessian2/Hessian2ObjectInput.java](https://codecov.io/gh/apache/dubbo/pull/11358?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yT2JqZWN0SW5wdXQuamF2YQ==) | `0.00% <0.00%> (-37.50%)` | :arrow_down: | | [...mmon/serialize/hessian2/Hessian2Serialization.java](https://codecov.io/gh/apache/dubbo/pull/11358?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yU2VyaWFsaXphdGlvbi5qYXZh) | `57.14% <0.00%> (-28.58%)` | :arrow_down: | | [.../serialize/hessian2/Hessian2AllowClassManager.java](https://codecov.io/gh/apache/dubbo/pull/11358?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yQWxsb3dDbGFzc01hbmFnZXIuamF2YQ==) | `48.97% <0.00%> (-26.54%)` | :arrow_down: | | [...mon/serialize/hessian2/Hessian2FactoryManager.java](https://codecov.io/gh/apache/dubbo/pull/11358?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yRmFjdG9yeU1hbmFnZXIuamF2YQ==) | `14.28% <0.00%> (-24.49%)` | :arrow_down: | | [...bbo/remoting/buffer/ChannelBufferOutputStream.java](https://codecov.io/gh/apache/dubbo/pull/11358?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9idWZmZXIvQ2hhbm5lbEJ1ZmZlck91dHB1dFN0cmVhbS5qYXZh) | `68.75% <0.00%> (-18.75%)` | :arrow_down: | |
[GitHub] [dubbo] AlbumenJ opened a new pull request, #11359: Introduce Invocation#getInvokedInvokers to get invokers for ClusterFilter
AlbumenJ opened a new pull request, #11359: URL: https://github.com/apache/dubbo/pull/11359 ## What is the purpose of the change ```java /** * To add invoked invokers into invocation. Can be used in ClusterFilter or Filter for tracing or debugging purpose. * Currently, only support in consumer side. * * @param invoker invoked invokers */ void addInvokedInvoker(Invoker invoker); /** * Get all invoked invokers in current invocation. * NOTICE: A curtain invoker could be invoked for twice or more if retries. * * @return invokers */ List> getInvokedInvokers(); ``` ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11358: Support native ci check
sonarcloud[bot] commented on PR #11358: URL: https://github.com/apache/dubbo/pull/11358#issuecomment-1397879370 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_dubbo=11358) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11358=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11358=false=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo=11358=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11358=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11358=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo=11358=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11358=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11358=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11358=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11358=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11358=false=CODE_SMELL) [412 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo=11358=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo=11358=new_coverage=list) [53.6% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo=11358=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_dubbo=11358=new_duplicated_lines_density=list) [1.1% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo=11358=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11352: metrics code optimization
sonarcloud[bot] commented on PR #11352: URL: https://github.com/apache/dubbo/pull/11352#issuecomment-1397866970 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_dubbo=11352) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11352=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11352=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11352=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=CODE_SMELL) [11 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo=11352=new_coverage=list) [80.5% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo=11352=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_dubbo=11352=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo=11352=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #11352: metrics code optimization
codecov-commenter commented on PR #11352: URL: https://github.com/apache/dubbo/pull/11352#issuecomment-1397867259 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/11352?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#11352](https://codecov.io/gh/apache/dubbo/pull/11352?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1b237d9) into [3.2](https://codecov.io/gh/apache/dubbo/commit/d2eb0ef4589b956d1648d6809cffd0a9966f5eb6?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (d2eb0ef) will **decrease** coverage by `4.82%`. > The diff coverage is `85.06%`. > :exclamation: Current head 1b237d9 differs from pull request most recent head 9e6a099. Consider uploading reports for the commit 9e6a099 to get more accurate results ```diff @@ Coverage Diff @@ ##3.2 #11352 +/- ## - Coverage 69.62% 64.81% -4.82% + Complexity 133 14 -119 Files 1515 1490 -25 Lines 8228562353 -19932 Branches 14726 9139-5587 - Hits 5729540415 -16880 + Misses2014417715-2429 + Partials 4846 4223 -623 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/11352?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ubbo/registry/nacos/NacosNamingServiceWrapper.java](https://codecov.io/gh/apache/dubbo/pull/11352?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbmFjb3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlZ2lzdHJ5L25hY29zL05hY29zTmFtaW5nU2VydmljZVdyYXBwZXIuamF2YQ==) | `79.26% <ø> (-1.30%)` | :arrow_down: | | [...pache/dubbo/common/metrics/model/MethodMetric.java](https://codecov.io/gh/apache/dubbo/pull/11352?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9NZXRob2RNZXRyaWMuamF2YQ==) | `70.37% <57.14%> (+2.80%)` | :arrow_up: | | [...apache/dubbo/common/metrics/model/ServiceInfo.java](https://codecov.io/gh/apache/dubbo/pull/11352?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9TZXJ2aWNlSW5mby5qYXZh) | `61.53% <61.53%> (ø)` | | | [...e/dubbo/metrics/filter/MetricsCollectExecutor.java](https://codecov.io/gh/apache/dubbo/pull/11352?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9maWx0ZXIvTWV0cmljc0NvbGxlY3RFeGVjdXRvci5qYXZh) | `83.33% <85.71%> (-7.08%)` | :arrow_down: | | [...n/metrics/collector/stat/MetricsStatComposite.java](https://codecov.io/gh/apache/dubbo/pull/11352?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9jb2xsZWN0b3Ivc3RhdC9NZXRyaWNzU3RhdENvbXBvc2l0ZS5qYXZh) | `95.55% <92.00%> (-3.26%)` | :arrow_down: | | [...n/metrics/event/SimpleMetricsEventMulticaster.java](https://codecov.io/gh/apache/dubbo/pull/11352?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9ldmVudC9TaW1wbGVNZXRyaWNzRXZlbnRNdWx0aWNhc3Rlci5qYXZh) | `94.11% <94.11%> (ø)` | | | [...mon/metrics/collector/DefaultMetricsCollector.java](https://codecov.io/gh/apache/dubbo/pull/11352?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9jb2xsZWN0b3IvRGVmYXVsdE1ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `97.33% <97.05%> (-1.74%)` | :arrow_down: | |
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11352: metrics code optimization
sonarcloud[bot] commented on PR #11352: URL: https://github.com/apache/dubbo/pull/11352#issuecomment-1397865518 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_dubbo=11352) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11352=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11352=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11352=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=CODE_SMELL) [12 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo=11352=new_coverage=list) [80.2% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo=11352=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_dubbo=11352=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo=11352=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] CrazyHZM opened a new pull request, #11358: Support native ci check
CrazyHZM opened a new pull request, #11358: URL: https://github.com/apache/dubbo/pull/11358 ## What is the purpose of the change ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] CrazyHZM closed pull request #11350: Support native ci check
CrazyHZM closed pull request #11350: Support native ci check URL: https://github.com/apache/dubbo/pull/11350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] wxbty commented on a diff in pull request #11352: metrics code optimization
wxbty commented on code in PR #11352: URL: https://github.com/apache/dubbo/pull/11352#discussion_r1082048561 ## dubbo-dependencies-bom/pom.xml: ## @@ -184,7 +184,7 @@ 2.0 1.1.0 1.21 -3.2.0-beta.4-SNAPSHOT +3.2.0-beta.11-SNAPSHOT Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] KamToHung opened a new issue, #11357: channelHandlers has null object
KamToHung opened a new issue, #11357:
URL: https://github.com/apache/dubbo/issues/11357
- [x] I have searched the [issues](https://github.com/apache/dubbo/issues)
of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 3.2
* Operating System version: macOS Big Sur
* Java version: 8
### Steps to reproduce this issue
1. simple test
```java
public class NPETest {
protected WorldHandler handler = new WorldHandler();
@Test
void handlerIsNull() throws RemotingException {
Exchangers.bind("",null, handler);
}
}
```
2. handler is not null in this step
```java
public ChannelHandlerDispatcher(ChannelHandler... handlers) {
this(handlers == null ? null : Arrays.asList(handlers));
}
```
3. channelHandlers will add a null handler
```java
public ChannelHandlerDispatcher(Collection handlers) {
if (CollectionUtils.isNotEmpty(handlers)) {
this.channelHandlers.addAll(handlers);
}
}
```
4. connected, disconnected, sent and caught method will NPE
### Expected Behavior
channelHandlers have no null object
### Actual Behavior
channelHandlers have null object
### reason
```java
public ChannelHandlerDispatcher(ChannelHandler... handlers) {
this(handlers == null ? null : Arrays.asList(handlers));
}
public ChannelHandlerDispatcher(Collection handlers) {
if (CollectionUtils.isNotEmpty(handlers)) {
this.channelHandlers.addAll(handlers);
}
}
```
if handlers is null, it will cast to ChannelHandler and use the first method
then handlers is not null
we can filter the null object when add to channelHandlers
Can I fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] marcingrzejszczak commented on a diff in pull request #11021: Added support for Micrometer Observation API
marcingrzejszczak commented on code in PR #11021:
URL: https://github.com/apache/dubbo/pull/11021#discussion_r1081448498
##
dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/filter/observation/AbstractDefaultDubboObservationConvention.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dubbo.metrics.filter.observation;
+
+import io.micrometer.common.KeyValues;
+import io.micrometer.common.docs.KeyName;
+import io.micrometer.common.lang.Nullable;
+import org.apache.dubbo.common.utils.StringUtils;
+import org.apache.dubbo.rpc.Invocation;
+import org.apache.dubbo.rpc.RpcContextAttachment;
+
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.NET_PEER_NAME;
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.NET_PEER_PORT;
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.RPC_METHOD;
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.RPC_SERVICE;
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.RPC_SYSTEM;
+
+class AbstractDefaultDubboObservationConvention {
+KeyValues getLowCardinalityKeyValues(Invocation invocation,
RpcContextAttachment rpcContextAttachment) {
+KeyValues keyValues =
KeyValues.of(RPC_SYSTEM.withValue("apache_dubbo"));
+String serviceName = StringUtils.hasText(invocation.getServiceName())
? invocation.getServiceName() :
readServiceName(invocation.getTargetServiceUniqueName());
+keyValues = appendNonNull(keyValues, RPC_SERVICE, serviceName);
+keyValues = appendNonNull(keyValues, RPC_METHOD,
invocation.getMethodName());
+keyValues = appendNonNull(keyValues, NET_PEER_NAME,
rpcContextAttachment.getRemoteHostName());
+if (rpcContextAttachment.getRemotePort() == 0) {
+return keyValues;
+}
+int port = rpcContextAttachment.getRemotePort() != 0 ?
rpcContextAttachment.getRemotePort() : rpcContextAttachment.getLocalPort();
Review Comment:
I would like to retrieve the remote port and the remote host in the consumer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11021: Added support for Micrometer Observation API
sonarcloud[bot] commented on PR #11021: URL: https://github.com/apache/dubbo/pull/11021#issuecomment-1397143566 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo=11021) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11021=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11021=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo=11021=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11021=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11021=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo=11021=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11021=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11021=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11021=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11021=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11021=false=CODE_SMELL) [14 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo=11021=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo=11021=new_coverage=list) [40.7% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo=11021=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_dubbo=11021=new_duplicated_lines_density=list) [23.6% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo=11021=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ closed issue #11294: ConcurrentHashMap#computeIfAbsent have performance problem in jdk1.8
AlbumenJ closed issue #11294: ConcurrentHashMap#computeIfAbsent have performance problem in jdk1.8 URL: https://github.com/apache/dubbo/issues/11294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on pull request #11326: [ISSUE #11294] Optimize ConcurrentHashMap#computeIfAbsent have performance problem in jdk1.8
AlbumenJ commented on PR #11326: URL: https://github.com/apache/dubbo/pull/11326#issuecomment-1397120479 Thanks for your contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #11326: [ISSUE #11294] Optimize ConcurrentHashMap#computeIfAbsent have performance problem in jdk1.8
AlbumenJ merged PR #11326: URL: https://github.com/apache/dubbo/pull/11326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #11326: [ISSUE #11294] Optimize ConcurrentHashMap#computeIfAbsent have performance problem in jdk1.8
codecov-commenter commented on PR #11326: URL: https://github.com/apache/dubbo/pull/11326#issuecomment-1397111216 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/11326?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#11326](https://codecov.io/gh/apache/dubbo/pull/11326?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (4b6f548) into [3.2](https://codecov.io/gh/apache/dubbo/commit/0c1b7987c6f6122ecbe7e683a946995406d45175?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (0c1b798) will **decrease** coverage by `4.69%`. > The diff coverage is `84.00%`. ```diff @@ Coverage Diff @@ ##3.2 #11326 +/- ## - Coverage 69.51% 64.83% -4.69% + Complexity 339 14 -325 Files 1514 1487 -27 Lines 8121862360 -18858 Branches 14612 9133-5479 - Hits 5645640429 -16027 + Misses1995017712-2238 + Partials 4812 4219 -593 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/11326?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ache/dubbo/rpc/cluster/CacheableRouterFactory.java](https://codecov.io/gh/apache/dubbo/pull/11326?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvQ2FjaGVhYmxlUm91dGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | | | [...o/rpc/cluster/router/script/ScriptStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/11326?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3NjcmlwdC9TY3JpcHRTdGF0ZVJvdXRlci5qYXZh) | `0.00% <0.00%> (-73.34%)` | :arrow_down: | | [...enter/support/nacos/NacosDynamicConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/11326?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnY2VudGVyL2R1YmJvLWNvbmZpZ2NlbnRlci1uYWNvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29uZmlnY2VudGVyL3N1cHBvcnQvbmFjb3MvTmFjb3NEeW5hbWljQ29uZmlndXJhdGlvbi5qYXZh) | `33.80% <0.00%> (+0.14%)` | :arrow_up: | | [...gistry/client/ReflectionBasedServiceDiscovery.java](https://codecov.io/gh/apache/dubbo/pull/11326?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvUmVmbGVjdGlvbkJhc2VkU2VydmljZURpc2NvdmVyeS5qYXZh) | `0.00% <0.00%> (ø)` | | | [...bo/registry/multiple/MultipleServiceDiscovery.java](https://codecov.io/gh/apache/dubbo/pull/11326?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlZ2lzdHJ5L211bHRpcGxlL011bHRpcGxlU2VydmljZURpc2NvdmVyeS5qYXZh) | `0.00% <0.00%> (ø)` | | | [...o/registry/xds/util/protocol/AbstractProtocol.java](https://codecov.io/gh/apache/dubbo/pull/11326?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8teGRzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS94ZHMvdXRpbC9wcm90b2NvbC9BYnN0cmFjdFByb3RvY29sLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...che/dubbo/common/utils/ConcurrentHashMapUtils.java](https://codecov.io/gh/apache/dubbo/pull/11326?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ29uY3VycmVudEhhc2hNYXBVdGlscy5qYXZh) | `33.33% <33.33%> (ø)` | | | [...stry/client/ServiceDiscoveryRegistryDirectory.java](https://codecov.io/gh/apache/dubbo/pull/11326?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvU2VydmljZURpc2NvdmVyeVJlZ2lzdHJ5RGlyZWN0b3J5LmphdmE=) | `43.94% <50.00%> (-11.04%)` | :arrow_down: | |
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11326: [ISSUE #11294] Optimize ConcurrentHashMap#computeIfAbsent have performance problem in jdk1.8
sonarcloud[bot] commented on PR #11326: URL: https://github.com/apache/dubbo/pull/11326#issuecomment-1397107792 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_dubbo=11326) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11326=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11326=false=BUG) [4 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo=11326=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11326=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11326=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo=11326=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11326=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11326=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11326=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11326=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11326=false=CODE_SMELL) [44 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo=11326=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo=11326=new_coverage=list) [78.1% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo=11326=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_dubbo=11326=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo=11326=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11356: Bump protobuf-java from 3.19.6 to 3.21.12
sonarcloud[bot] commented on PR #11356: URL: https://github.com/apache/dubbo/pull/11356#issuecomment-1397103473 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo=11356) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11356=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11356=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo=11356=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11356=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11356=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo=11356=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11356=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11356=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11356=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11356=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11356=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo=11356=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo=11356=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_dubbo=11356=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #11356: Bump protobuf-java from 3.19.6 to 3.21.12
AlbumenJ merged PR #11356: URL: https://github.com/apache/dubbo/pull/11356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #11021: Added support for Micrometer Observation API
AlbumenJ commented on code in PR #11021:
URL: https://github.com/apache/dubbo/pull/11021#discussion_r1081346258
##
dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/filter/observation/AbstractDefaultDubboObservationConvention.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dubbo.metrics.filter.observation;
+
+import io.micrometer.common.KeyValues;
+import io.micrometer.common.docs.KeyName;
+import io.micrometer.common.lang.Nullable;
+import org.apache.dubbo.common.utils.StringUtils;
+import org.apache.dubbo.rpc.Invocation;
+import org.apache.dubbo.rpc.RpcContextAttachment;
+
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.NET_PEER_NAME;
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.NET_PEER_PORT;
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.RPC_METHOD;
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.RPC_SERVICE;
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.RPC_SYSTEM;
+
+class AbstractDefaultDubboObservationConvention {
+KeyValues getLowCardinalityKeyValues(Invocation invocation,
RpcContextAttachment rpcContextAttachment) {
+KeyValues keyValues =
KeyValues.of(RPC_SYSTEM.withValue("apache_dubbo"));
+String serviceName = StringUtils.hasText(invocation.getServiceName())
? invocation.getServiceName() :
readServiceName(invocation.getTargetServiceUniqueName());
+keyValues = appendNonNull(keyValues, RPC_SERVICE, serviceName);
+keyValues = appendNonNull(keyValues, RPC_METHOD,
invocation.getMethodName());
+keyValues = appendNonNull(keyValues, NET_PEER_NAME,
rpcContextAttachment.getRemoteHostName());
+if (rpcContextAttachment.getRemotePort() == 0) {
+return keyValues;
+}
+int port = rpcContextAttachment.getRemotePort() != 0 ?
rpcContextAttachment.getRemotePort() : rpcContextAttachment.getLocalPort();
Review Comment:
> I've added a commit that addresses most of the suggestions. The only
problem is with this part here and I left it as it was cause I don't know how
to retrieve this information in any other way
Do you mean that you want to retrieve the remote port in consumer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #11353: 【fix】remove alibaba.spring-context #11078
AlbumenJ commented on code in PR #11353: URL: https://github.com/apache/dubbo/pull/11353#discussion_r1081336441 ## dubbo-common/src/main/java/org/apache/dubbo/common/utils/ObjectUtils.java: ## @@ -0,0 +1,24 @@ +package org.apache.dubbo.common.utils; + +/** + * User: aini + * Date: 2023/1/19 15:38 Review Comment: Remove this two tags pls ## dubbo-common/src/main/java/org/apache/dubbo/common/utils/ObjectUtils.java: ## @@ -0,0 +1,24 @@ +package org.apache.dubbo.common.utils; Review Comment: Please add ASF license header -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #11352: metrics code optimization
AlbumenJ commented on code in PR #11352: URL: https://github.com/apache/dubbo/pull/11352#discussion_r1081334798 ## dubbo-dependencies-bom/pom.xml: ## @@ -184,7 +184,7 @@ 2.0 1.1.0 1.21 -3.2.0-beta.4-SNAPSHOT +3.2.0-beta.11-SNAPSHOT Review Comment: revert this line -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11334: Bump javassist from 3.28.0-GA to 3.29.2-GA
sonarcloud[bot] commented on PR #11334: URL: https://github.com/apache/dubbo/pull/11334#issuecomment-1396980703 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo=11334) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11334=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11334=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo=11334=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11334=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11334=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo=11334=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11334=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11334=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11334=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11334=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11334=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo=11334=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo=11334=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_dubbo=11334=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11334: Bump javassist from 3.28.0-GA to 3.29.2-GA
sonarcloud[bot] commented on PR #11334: URL: https://github.com/apache/dubbo/pull/11334#issuecomment-1396980444 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo=11334) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11334=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11334=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo=11334=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11334=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11334=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo=11334=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11334=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11334=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11334=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11334=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11334=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo=11334=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo=11334=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_dubbo=11334=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] mxsm commented on pull request #11326: [ISSUE #11294] Optimize ConcurrentHashMap#computeIfAbsent have performance problem in jdk1.8
mxsm commented on PR #11326: URL: https://github.com/apache/dubbo/pull/11326#issuecomment-1396979806 @AlbumenJ I has fixed it and re-submit again, PTAL~ Thks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11338: Bump resteasy_version from 3.0.20.Final to 3.15.3.Final
sonarcloud[bot] commented on PR #11338: URL: https://github.com/apache/dubbo/pull/11338#issuecomment-1396975326 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo=11338) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11338=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11338=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo=11338=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11338=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11338=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo=11338=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11338=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11338=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11338=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11338=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11338=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo=11338=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo=11338=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_dubbo=11338=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #11351: feat: fix deploy listener exception
AlbumenJ merged PR #11351: URL: https://github.com/apache/dubbo/pull/11351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] dependabot[bot] closed pull request #11330: Bump protobuf-java.version from 3.19.6 to 3.21.12
dependabot[bot] closed pull request #11330: Bump protobuf-java.version from 3.19.6 to 3.21.12 URL: https://github.com/apache/dubbo/pull/11330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] dependabot[bot] commented on pull request #11330: Bump protobuf-java.version from 3.19.6 to 3.21.12
dependabot[bot] commented on PR #11330: URL: https://github.com/apache/dubbo/pull/11330#issuecomment-1396952658 Looks like these dependencies are updatable in another way, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] dependabot[bot] opened a new pull request, #11356: Bump protobuf-java from 3.19.6 to 3.21.12
dependabot[bot] opened a new pull request, #11356: URL: https://github.com/apache/dubbo/pull/11356 Bumps [protobuf-java](https://github.com/protocolbuffers/protobuf) from 3.19.6 to 3.21.12. Release notes Sourced from https://github.com/protocolbuffers/protobuf/releases;>protobuf-java's releases. Protocol Buffers v3.20.3 Java Refactoring java full runtime to reuse sub-message builders and prepare to migrate parsing logic from parse constructor to builder. Move proto wireformat parsing functionality from the private parsing constructor to the Builder class. Change the Lite runtime to prefer merging from the wireformat into mutable messages rather than building up a new immutable object before merging. This way results in fewer allocations and copy operations. Make message-type extensions merge from wire-format instead of building up instances and merging afterwards. This has much better performance. Fix TextFormat parser to build up recurring (but supposedly not repeated) sub-messages directly from text rather than building a new sub-message and merging the fully formed message into the existing field. This release addresses a https://github.com/protocolbuffers/protobuf/security/advisories/GHSA-h4h5-3hr4-j3g2;>Security Advisory for Java users Protocol Buffers v3.20.2 C++ Reduce memory consumption of MessageSet parsing This release addresses a https://github.com/protocolbuffers/protobuf/security/advisories/GHSA-8gq9-2x98-w8hf;>Security Advisory for C++ and Python users Protocol Buffers v3.20.1 PHP Fix building packaged PHP extension (https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/9727;>#9727) Fixed composer.json to only advertise compatibility with PHP 7.0+. (https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/9819;>#9819) Ruby Disable the aarch64 build on macOS until it can be fixed. (https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/9816;>#9816) Other Fix versioning issues in 3.20.0 Protocol Buffers v3.20.1-rc1 PHP Fix building packaged PHP extension (https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/9727;>#9727) Other Fix versioning issues in 3.20.0 Protocol Buffers v3.20.0 2022-03-25 version 3.20.0 (C++/Java/Python/PHP/Objective-C/C#/Ruby/JavaScript) Ruby Dropped Ruby 2.3 and 2.4 support for CI and releases. (https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/9311;>#9311) Added Ruby 3.1 support for CI and releases (https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/9566;>#9566). Message.decode/encode: Add recursion_limit option (https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/9218;>#9218/https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/9486;>#9486) Allocate with xrealloc()/xfree() so message allocation is visible to the Ruby GC. In certain tests this leads to much lower memory usage due to more frequent GC runs (https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/9586;>#9586). Fix conversion of singleton classes in Ruby (https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/9342;>#9342) ... (truncated) Commits https://github.com/protocolbuffers/protobuf/commit/f0dc78d7e6e331b8c6bb2d5283e06aa26883ca7c;>f0dc78d Updating version.json and repo version numbers to: 21.12 https://github.com/protocolbuffers/protobuf/commit/7b0ca6995da9c895ac1ca0005b705fa01f009b7f;>7b0ca69 Updated release branch to latest upb. (https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/11258;>#11258) https://github.com/protocolbuffers/protobuf/commit/7c123c40e2725fa1d36b194040fc4e9f2fe8502c;>7c123c4 Merge pull request https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/11201;>#11201 from protocolbuffers/21.x-202212080033 https://github.com/protocolbuffers/protobuf/commit/44eafb2f651436fd583051f137556ffcf43bd1d9;>44eafb2 Update version.json to: 21.12-dev https://github.com/protocolbuffers/protobuf/commit/aea4a275e28329f648e046469c095eef74254bb2;>aea4a27 Updating changelog https://github.com/protocolbuffers/protobuf/commit/ffe65a5040ac721596055f89a55712a8b0dd8d8d;>ffe65a5 Merge pull request https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/11197;>#11197 from protocolbuffers/21.x-202212071935 https://github.com/protocolbuffers/protobuf/commit/a474c5b9ff43c4dda5d3132024eee8cef71b83fc;>a474c5b Updating version.json and repo version numbers to: 21.11 https://github.com/protocolbuffers/protobuf/commit/c0bc0cf0766ab7c24a0251f9b77e06ab1dd474f7;>c0bc0cf Merge pull request https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/11196;>#11196 from ericsalo/21.x
[GitHub] [dubbo] AlbumenJ commented on pull request #11330: Bump protobuf-java.version from 3.19.6 to 3.21.12
AlbumenJ commented on PR #11330: URL: https://github.com/apache/dubbo/pull/11330#issuecomment-1396948101 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #11338: Bump resteasy_version from 3.0.20.Final to 3.15.3.Final
AlbumenJ merged PR #11338: URL: https://github.com/apache/dubbo/pull/11338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #11340: Bump jetty-maven-plugin from 9.4.38.v20210224 to 9.4.50.v20221201
AlbumenJ merged PR #11340: URL: https://github.com/apache/dubbo/pull/11340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #11332: Bump jetty_version from 9.4.43.v20210629 to 9.4.50.v20221201
AlbumenJ merged PR #11332: URL: https://github.com/apache/dubbo/pull/11332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #11342: Bump eureka.version from 1.9.12 to 1.10.18
AlbumenJ merged PR #11342: URL: https://github.com/apache/dubbo/pull/11342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #11339: Bump javax.el-api from 2.2.4 to 2.2.5
AlbumenJ merged PR #11339: URL: https://github.com/apache/dubbo/pull/11339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #11329: Bump spring-boot-maven-plugin from 2.1.4.RELEASE to 2.7.7
AlbumenJ merged PR #11329: URL: https://github.com/apache/dubbo/pull/11329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #11334: Bump javassist from 3.28.0-GA to 3.29.2-GA
AlbumenJ merged PR #11334: URL: https://github.com/apache/dubbo/pull/11334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #11343: Bump maven-enforcer-plugin from 3.0.0-M3 to 3.1.0
AlbumenJ merged PR #11343: URL: https://github.com/apache/dubbo/pull/11343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] dependabot[bot] commented on pull request #11341: Bump zookeeper from 3.4.14 to 3.8.0
dependabot[bot] commented on PR #11341: URL: https://github.com/apache/dubbo/pull/11341#issuecomment-1396942369 OK, I won't notify you about org.apache.zookeeper:zookeeper again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] dependabot[bot] closed pull request #11341: Bump zookeeper from 3.4.14 to 3.8.0
dependabot[bot] closed pull request #11341: Bump zookeeper from 3.4.14 to 3.8.0 URL: https://github.com/apache/dubbo/pull/11341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on pull request #11341: Bump zookeeper from 3.4.14 to 3.8.0
AlbumenJ commented on PR #11341: URL: https://github.com/apache/dubbo/pull/11341#issuecomment-1396942254 @dependabot ignore this dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #11344: Bump spring-boot-dependencies from 2.3.1.RELEASE to 2.7.7
AlbumenJ merged PR #11344: URL: https://github.com/apache/dubbo/pull/11344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #11348: Bump slf4j-api from 1.7.25 to 1.7.36
AlbumenJ merged PR #11348: URL: https://github.com/apache/dubbo/pull/11348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #11347: Bump javax.el from 3.0.1-b08 to 3.0.1-b12
AlbumenJ merged PR #11347: URL: https://github.com/apache/dubbo/pull/11347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #11346: Bump maven-plugin-plugin from 3.6.0 to 3.7.1
AlbumenJ merged PR #11346: URL: https://github.com/apache/dubbo/pull/11346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #11345: Bump curator_version from 4.2.0 to 4.3.0
AlbumenJ merged PR #11345: URL: https://github.com/apache/dubbo/pull/11345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] marcingrzejszczak commented on a diff in pull request #11021: Added support for Micrometer Observation API
marcingrzejszczak commented on code in PR #11021:
URL: https://github.com/apache/dubbo/pull/11021#discussion_r1081221987
##
dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/filter/observation/AbstractDefaultDubboObservationConvention.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dubbo.metrics.filter.observation;
+
+import io.micrometer.common.KeyValues;
+import io.micrometer.common.docs.KeyName;
+import io.micrometer.common.lang.Nullable;
+import org.apache.dubbo.common.utils.StringUtils;
+import org.apache.dubbo.rpc.Invocation;
+import org.apache.dubbo.rpc.RpcContextAttachment;
+
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.NET_PEER_NAME;
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.NET_PEER_PORT;
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.RPC_METHOD;
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.RPC_SERVICE;
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.RPC_SYSTEM;
+
+class AbstractDefaultDubboObservationConvention {
+KeyValues getLowCardinalityKeyValues(Invocation invocation,
RpcContextAttachment rpcContextAttachment) {
+KeyValues keyValues =
KeyValues.of(RPC_SYSTEM.withValue("apache_dubbo"));
+String serviceName = StringUtils.hasText(invocation.getServiceName())
? invocation.getServiceName() :
readServiceName(invocation.getTargetServiceUniqueName());
+keyValues = appendNonNull(keyValues, RPC_SERVICE, serviceName);
+keyValues = appendNonNull(keyValues, RPC_METHOD,
invocation.getMethodName());
+keyValues = appendNonNull(keyValues, NET_PEER_NAME,
rpcContextAttachment.getRemoteHostName());
+if (rpcContextAttachment.getRemotePort() == 0) {
+return keyValues;
+}
+int port = rpcContextAttachment.getRemotePort() != 0 ?
rpcContextAttachment.getRemotePort() : rpcContextAttachment.getLocalPort();
Review Comment:
I've added a commit that addresses most of the suggestions. The only problem
is with this part here and I left it as it was cause I don't know how to
retrieve this information in any other way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on pull request #11338: Bump resteasy_version from 3.0.20.Final to 3.15.3.Final
AlbumenJ commented on PR #11338: URL: https://github.com/apache/dubbo/pull/11338#issuecomment-1396925694 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #11337: Bump javax.ws.rs-api from 2.0 to 2.1.1
AlbumenJ merged PR #11337: URL: https://github.com/apache/dubbo/pull/11337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #11336: Bump bouncycastle-bcprov_version from 1.69 to 1.70
AlbumenJ merged PR #11336: URL: https://github.com/apache/dubbo/pull/11336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #11335: Bump byte-buddy from 1.12.19 to 1.12.22
AlbumenJ merged PR #11335: URL: https://github.com/apache/dubbo/pull/11335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #11333: Bump fluent-hc from 4.5.5 to 4.5.14
AlbumenJ merged PR #11333: URL: https://github.com/apache/dubbo/pull/11333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11351: feat: fix deploy listener exception
sonarcloud[bot] commented on PR #11351: URL: https://github.com/apache/dubbo/pull/11351#issuecomment-1396923003 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_dubbo=11351) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11351=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11351=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo=11351=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11351=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11351=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo=11351=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11351=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11351=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11351=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11351=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11351=false=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo=11351=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo=11351=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo=11351=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_dubbo=11351=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo=11351=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #11331: Bump cglib-nodep from 2.2 to 2.2.2
AlbumenJ merged PR #11331: URL: https://github.com/apache/dubbo/pull/11331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] marcingrzejszczak commented on a diff in pull request #11021: Added support for Micrometer Observation API
marcingrzejszczak commented on code in PR #11021:
URL: https://github.com/apache/dubbo/pull/11021#discussion_r1081084317
##
dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/filter/observation/AbstractDefaultDubboObservationConvention.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dubbo.metrics.filter.observation;
+
+import io.micrometer.common.KeyValues;
+import io.micrometer.common.docs.KeyName;
+import io.micrometer.common.lang.Nullable;
+import org.apache.dubbo.common.utils.StringUtils;
+import org.apache.dubbo.rpc.Invocation;
+import org.apache.dubbo.rpc.RpcContextAttachment;
+
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.NET_PEER_NAME;
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.NET_PEER_PORT;
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.RPC_METHOD;
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.RPC_SERVICE;
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.RPC_SYSTEM;
+
+class AbstractDefaultDubboObservationConvention {
+KeyValues getLowCardinalityKeyValues(Invocation invocation,
RpcContextAttachment rpcContextAttachment) {
+KeyValues keyValues =
KeyValues.of(RPC_SYSTEM.withValue("apache_dubbo"));
+String serviceName = StringUtils.hasText(invocation.getServiceName())
? invocation.getServiceName() :
readServiceName(invocation.getTargetServiceUniqueName());
+keyValues = appendNonNull(keyValues, RPC_SERVICE, serviceName);
+keyValues = appendNonNull(keyValues, RPC_METHOD,
invocation.getMethodName());
+keyValues = appendNonNull(keyValues, NET_PEER_NAME,
rpcContextAttachment.getRemoteHostName());
+if (rpcContextAttachment.getRemotePort() == 0) {
+return keyValues;
+}
+int port = rpcContextAttachment.getRemotePort() != 0 ?
rpcContextAttachment.getRemotePort() : rpcContextAttachment.getLocalPort();
Review Comment:
Good catch, that's for the client
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md#http-client
and that's mandatory to be set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11352: metrics code optimization
sonarcloud[bot] commented on PR #11352: URL: https://github.com/apache/dubbo/pull/11352#issuecomment-1396844150 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_dubbo=11352) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11352=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11352=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11352=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=CODE_SMELL) [12 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo=11352=new_coverage=list) [80.2% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo=11352=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_dubbo=11352=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo=11352=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] songxiaosheng commented on issue #11354: Observability: about the design of the collector's domain
songxiaosheng commented on issue #11354: URL: https://github.com/apache/dubbo/issues/11354#issuecomment-1396829098 默认的收集器已经比较重了，目前几乎做了所有类型的数据收集，需要一个组合的收集器来处理不同类型的数据收集，组合的数据收集器负责产生的具体的收集器，转发指标数据到消费者收集器等功能不去做具体逻辑处理 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] songxiaosheng commented on issue #11355: Observability: about the design of the collector's domain
songxiaosheng commented on issue #11355: URL: https://github.com/apache/dubbo/issues/11355#issuecomment-1396784766 重复 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] songxiaosheng closed issue #11355: Observability: about the design of the collector's domain
songxiaosheng closed issue #11355: Observability: about the design of the collector's domain URL: https://github.com/apache/dubbo/issues/11355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] songxiaosheng opened a new issue, #11355: Observability: about the design of the collector's domain
songxiaosheng opened a new issue, #11355: URL: https://github.com/apache/dubbo/issues/11355 - [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate. ## Describe the proposal En: Observability: about the design of the collector's domain, There are two types of collectors. One is used to collect specific indicator data, called production data collectors. One is used for secondary processing of collected data, which is called consumer data collector. The collector of production data needs to collect data from all areas of Dubbo, so it needs to collect data from the collector that can collect data under the module level, application level application or framework level framework domain, and the collector of consumption data can belong to the domain container according to the actual scenario, and carry out data consumption processing according to the specific internal configuration 可观测性: 关于收集器所属域的一些设计。 收集器分为两种，一种是用来收集具体的指标数据的，称为生产数据的收集器。 一种是用来针对收集到的数据进行二次处理了，称为消费数据的收集器。 生产数据的收集器需要收集来自Dubbo所有范围内的数据因此需要无论在模块Module级，应用级Application或者框架级Framework域下可以拿到收集数据的收集器来收集数据，而消费数据的收集器可以根据实际场景归属在所属域容器中，根据内部的具体配置进行数据消费处理。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] marcingrzejszczak commented on a diff in pull request #11021: Added support for Micrometer Observation API
marcingrzejszczak commented on code in PR #11021:
URL: https://github.com/apache/dubbo/pull/11021#discussion_r1081084317
##
dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/filter/observation/AbstractDefaultDubboObservationConvention.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dubbo.metrics.filter.observation;
+
+import io.micrometer.common.KeyValues;
+import io.micrometer.common.docs.KeyName;
+import io.micrometer.common.lang.Nullable;
+import org.apache.dubbo.common.utils.StringUtils;
+import org.apache.dubbo.rpc.Invocation;
+import org.apache.dubbo.rpc.RpcContextAttachment;
+
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.NET_PEER_NAME;
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.NET_PEER_PORT;
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.RPC_METHOD;
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.RPC_SERVICE;
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.RPC_SYSTEM;
+
+class AbstractDefaultDubboObservationConvention {
+KeyValues getLowCardinalityKeyValues(Invocation invocation,
RpcContextAttachment rpcContextAttachment) {
+KeyValues keyValues =
KeyValues.of(RPC_SYSTEM.withValue("apache_dubbo"));
+String serviceName = StringUtils.hasText(invocation.getServiceName())
? invocation.getServiceName() :
readServiceName(invocation.getTargetServiceUniqueName());
+keyValues = appendNonNull(keyValues, RPC_SERVICE, serviceName);
+keyValues = appendNonNull(keyValues, RPC_METHOD,
invocation.getMethodName());
+keyValues = appendNonNull(keyValues, NET_PEER_NAME,
rpcContextAttachment.getRemoteHostName());
+if (rpcContextAttachment.getRemotePort() == 0) {
+return keyValues;
+}
+int port = rpcContextAttachment.getRemotePort() != 0 ?
rpcContextAttachment.getRemotePort() : rpcContextAttachment.getLocalPort();
Review Comment:
Good catch, that's for the client
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md#http-client
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] jojocodeX commented on pull request #11352: metrics code optimization
jojocodeX commented on PR #11352: URL: https://github.com/apache/dubbo/pull/11352#issuecomment-1396763658 > ## What is the purpose of the change > When I was writing registry metric implement, I will use some codes of metrics-api, and found that some codes might be optimized. > > ## Brief changelog > Mainly optimize the following aspects: > > 1. Object-oriented design optimization > > * The quadruple of interfaceName, methodName, group, version, which appears frequently and use together, can be replaced by an object > * Both DefaultMetricsCollector and MetricsStatComposite have the behavior of publishing MetricsEvent. MetricsStatComposite locates the data aggregation carrier and should only be responsible for the processing of internal data. Event registration and publishing should be managed by a separate class (refer to spring), and the separation of class responsibilities can be easier Scale and prevent single-class code bloat. > > 2. Optimization of memory usage > > * Every time the method (invoke, onResponse, onError) in MetricsFilter is triggered, the new temporary object MetricsCollectExecutor will be created. This is unnecessary. Changing to the statc method can reduce the number of yong gc. > * In addition, a simple object pool is used to obtain the previous quadruple object > > 3. Optimization of some repetitive codes > > 主要对以下几个方面做了优化： > > 1、面向对象的设计优化 > > * interfaceName, methodName, group, version 这个四元组，出现频率高且共同使用，可以使用对象代替 > * DefaultMetricsCollector 和 MetricsStatComposite 两个类都有发布MetricsEvent的行为，MetricsStatComposite定位数据聚合载体，应该只负责内部数据的处理，事件注册和发布应该由单独的类来管理（参考spring），类职责分离可以更容易扩展和防止单类代码膨胀。 > > 2、内存使用的优化 > > * MetricsFilter里的方法（invoke,onResponse,onError）每次触发，会new临时对象MetricsCollectExecutor，这是没必要的，改成statc方法可以减少yong gc次数。 > * 另外，使用了简单的对象池，来获取前面的四元组对象 > > 3、其他 一些重复代码的优化； 定义空事件类型，从而发布事件时不用考虑空指针异常； 这个优化是有必要的，比如consumer这侧的指标采集，consumer这侧和provider这侧其实有很多相同的地方，现在这种方式使用上不是太友好。对于不同场景下指标收集，api使用上不方便 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11352: metrics code optimization
sonarcloud[bot] commented on PR #11352: URL: https://github.com/apache/dubbo/pull/11352#issuecomment-1396763455 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_dubbo=11352) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11352=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11352=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11352=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=CODE_SMELL) [12 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo=11352=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo=11352=new_coverage=list) [80.1% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo=11352=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_dubbo=11352=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo=11352=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] songxiaosheng opened a new issue, #11354: Observability: about the design of the collector's domain
songxiaosheng opened a new issue, #11354: URL: https://github.com/apache/dubbo/issues/11354 - [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate. ## Describe the proposal En: Observability: about the design of the collector's domain, There are two types of collectors. One is used to collect specific indicator data, called production data collectors. One is used for secondary processing of collected data, which is called consumer data collector. The collector of production data needs to collect data from all areas of Dubbo, so it needs to collect data from the collector that can collect data under the module level, application level application or framework level framework domain, and the collector of consumption data can belong to the domain container according to the actual scenario, and carry out data consumption processing according to the specific internal configuration 可观测性: 关于收集器所属域的一些设计。 收集器分为两种，一种是用来收集具体的指标数据的，称为生产数据的收集器。 一种是用来针对收集到的数据进行二次处理了，称为消费数据的收集器。 生产数据的收集器需要收集来自Dubbo所有范围内的数据因此需要无论在模块Module级，应用级Application或者框架级Framework域下可以拿到收集数据的收集器来收集数据，而消费数据的收集器可以根据实际场景归属在所属域容器中，根据内部的具体配置进行数据消费处理。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] EnjoyWall commented on issue #4309: use consul with group and version
EnjoyWall commented on issue #4309: URL: https://github.com/apache/dubbo/issues/4309#issuecomment-1396717688 The code is still the same as this page shows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-rust] robberphex opened a new pull request, #103: implement service discovery
robberphex opened a new pull request, #103: URL: https://github.com/apache/dubbo-rust/pull/103 You may call `client.with_directory(Box::new(StaticDirectory::new()))` to call a static host. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] zeusbee opened a new pull request, #11353: 【fix】remove alibaba.spring-context #11078
zeusbee opened a new pull request, #11353: URL: https://github.com/apache/dubbo/pull/11353 ## What is the purpose of the change ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] wxbty opened a new pull request, #11352: metrics code optimization
wxbty opened a new pull request, #11352: URL: https://github.com/apache/dubbo/pull/11352 ## What is the purpose of the change When I was writing registry metric implement, I will use some codes of metrics-api, and found that some codes might be optimized. ## Brief changelog Mainly optimize the following aspects: 1. Object-oriented design optimization - The quadruple of interfaceName, methodName, group, version, which appears frequently and use together, can be replaced by an object - Both DefaultMetricsCollector and MetricsStatComposite have the behavior of publishing MetricsEvent. MetricsStatComposite locates the data aggregation carrier and should only be responsible for the processing of internal data. Event registration and publishing should be managed by a separate class (refer to spring), and the separation of class responsibilities can be easier Scale and prevent single-class code bloat. 2. Optimization of memory usage - Every time the method (invoke, onResponse, onError) in MetricsFilter is triggered, the new temporary object MetricsCollectExecutor will be created. This is unnecessary. Changing to the statc method can reduce the number of yong gc. - In addition, a simple object pool is used to obtain the previous quadruple object 3. Optimization of some repetitive codes 主要对以下几个方面做了优化： 1、面向对象的设计优化 - interfaceName, methodName, group, version 这个四元组，出现频率高且共同使用，可以使用对象代替 - DefaultMetricsCollector 和 MetricsStatComposite 两个类都有发布MetricsEvent的行为，MetricsStatComposite定位数据聚合载体，应该只负责内部数据的处理，事件注册和发布应该由单独的类来管理（参考spring），类职责分离可以更容易扩展和防止单类代码膨胀。 2、内存使用的优化 - MetricsFilter里的方法（invoke,onResponse,onError）每次触发，会new临时对象MetricsCollectExecutor，这是没必要的，改成statc方法可以减少yong gc次数。 - 另外，使用了简单的对象池，来获取前面的四元组对象 3、一些重复代码的优化 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-rust] robberphex closed pull request #101: add robberphex as collaborator
robberphex closed pull request #101: add robberphex as collaborator URL: https://github.com/apache/dubbo-rust/pull/101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11350: Support native ci check
sonarcloud[bot] commented on PR #11350: URL: https://github.com/apache/dubbo/pull/11350#issuecomment-139655 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo=11350) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11350=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11350=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo=11350=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11350=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11350=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo=11350=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11350=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11350=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11350=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11350=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11350=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo=11350=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo=11350=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_dubbo=11350=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] CrazyHZM commented on a diff in pull request #11021: Added support for Micrometer Observation API
CrazyHZM commented on code in PR #11021:
URL: https://github.com/apache/dubbo/pull/11021#discussion_r1080846615
##
dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/filter/observation/AbstractDefaultDubboObservationConvention.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dubbo.metrics.filter.observation;
+
+import io.micrometer.common.KeyValues;
+import io.micrometer.common.docs.KeyName;
+import io.micrometer.common.lang.Nullable;
+import org.apache.dubbo.common.utils.StringUtils;
+import org.apache.dubbo.rpc.Invocation;
+import org.apache.dubbo.rpc.RpcContextAttachment;
+
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.NET_PEER_NAME;
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.NET_PEER_PORT;
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.RPC_METHOD;
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.RPC_SERVICE;
+import static
org.apache.dubbo.metrics.filter.observation.DubboObservation.LowCardinalityKeyNames.RPC_SYSTEM;
+
+class AbstractDefaultDubboObservationConvention {
+KeyValues getLowCardinalityKeyValues(Invocation invocation,
RpcContextAttachment rpcContextAttachment) {
+KeyValues keyValues =
KeyValues.of(RPC_SYSTEM.withValue("apache_dubbo"));
+String serviceName = StringUtils.hasText(invocation.getServiceName())
? invocation.getServiceName() :
readServiceName(invocation.getTargetServiceUniqueName());
+keyValues = appendNonNull(keyValues, RPC_SERVICE, serviceName);
+keyValues = appendNonNull(keyValues, RPC_METHOD,
invocation.getMethodName());
Review Comment:
There is a `Generic` scenario here, you need to use the
`RpcUtils#getMethodName() `method to get
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] aamingaa opened a new pull request, #11351: feat: fix deploy listener exception
aamingaa opened a new pull request, #11351: URL: https://github.com/apache/dubbo/pull/11351 fix deploy listener exception. issue url: https://github.com/apache/dubbo/issues/11027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] CrazyHZM opened a new pull request, #11350: Support native ci check
CrazyHZM opened a new pull request, #11350: URL: https://github.com/apache/dubbo/pull/11350 ## What is the purpose of the change ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-samples] AlbumenJ merged pull request #674: Bump spring-framework-bom from 4.3.16.RELEASE to 4.3.29.RELEASE in /99-integration/dubbo-samples-prefer-serialization-test-31x
AlbumenJ merged PR #674: URL: https://github.com/apache/dubbo-samples/pull/674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] chickenlj merged pull request #11349: metrics key duplication
chickenlj merged PR #11349: URL: https://github.com/apache/dubbo/pull/11349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-rust] chickenlj commented on issue #99: [Proposal] integratable with other projects
chickenlj commented on issue #99: URL: https://github.com/apache/dubbo-rust/issues/99#issuecomment-1396497158 I think this proposal is very similar to https://github.com/apache/dubbo-rust/issues/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-rust] chickenlj commented on issue #100: [Proposal] Let Dubbo Rust could call other RPC services.
chickenlj commented on issue #100: URL: https://github.com/apache/dubbo-rust/issues/100#issuecomment-1396495674 `gRPC, Thrift, REST, static files? You name it. We serve them all.` The goal is kinda like the feature of this framework [Armeria](https://armeria.dev/) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-rust] robberphex opened a new issue, #100: [Proposal] Let Dubbo Rust could call other RPC service.
robberphex opened a new issue, #100: URL: https://github.com/apache/dubbo-rust/issues/100 At real business logics, there are always different RPC service to call. For example, 1, to call Dubbo/hessian service to get user info, 2, to call Rest/http (third-party) service to get user associated info, 3, call gRPC service to get AI/ML recommendation result, and combine above information. Currently, we have to use different client to call different RPC service. Like FeignClient, Dubbo Rust could let user define different protocol service as uniform interfaces, and use one client(DubboClient.rs) to call. I think we could call this PR as `build flat data plane`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-rust] robberphex opened a new issue, #99: [Proposal] integratable with other project
robberphex opened a new issue, #99: URL: https://github.com/apache/dubbo-rust/issues/99 Dubbo Rust will parse more than one protocol of Dubbo RPC, * Triple/gRPC protocol parsing ✅ * Hessian protocol parsing * Thrift protocol parsing * etc. Dubbo Rust could release protocol parsing as a library, and as a component of other project. Here is ideas: 1. Be protocol parsing component of [Linkerd Proxy](https://github.com/linkerd/linkerd2-proxy) 2. As RPC component of other framework. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-rust] robberphex opened a new issue, #98: [Proposal] add c binding
robberphex opened a new issue, #98: URL: https://github.com/apache/dubbo-rust/issues/98 Dubbo have different language binding for different scenario: * Dubbo Java for Java ecosystem. * Dubbo Go for Go ecosystem. * Dubbo Js for frontend scenario. * Dubbo Python for AI/ML scenario. Dubbo Rust should cover `low level programming`/`system programming`. At this system-programming scenario, It's required to provide C binding. Rust has standard build tool chain, Dubbo Rust's C binding is easier to build than pure C implement of Dubbo. So, Could we have `add c binding` in Dubbo Rust's tasks? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #11349: metrics key duplication
codecov-commenter commented on PR #11349: URL: https://github.com/apache/dubbo/pull/11349#issuecomment-1396395769 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/11349?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#11349](https://codecov.io/gh/apache/dubbo/pull/11349?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (952b995) into [3.2.0-beta.4-release](https://codecov.io/gh/apache/dubbo/commit/9ab01f49d0c084dd6da12d9acd107dfababd3188?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (9ab01f4) will **decrease** coverage by `1.05%`. > The diff coverage is `100.00%`. ```diff @@Coverage Diff @@ ## 3.2.0-beta.4-release #11349 +/- ## == - Coverage 65.89% 64.84% -1.05% + Complexity 20 14 -6 == Files1486 1486 Lines 6235662352 -4 Branches 9165 9132 -33 == - Hits4109140435 -656 - Misses 1707017718 +648 - Partials 4195 4199 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/11349?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...mon/metrics/collector/DefaultMetricsCollector.java](https://codecov.io/gh/apache/dubbo/pull/11349?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9jb2xsZWN0b3IvRGVmYXVsdE1ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `98.90% <100.00%> (ø)` | | | [.../apache/dubbo/common/metrics/model/MetricsKey.java](https://codecov.io/gh/apache/dubbo/pull/11349?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vbWV0cmljcy9tb2RlbC9NZXRyaWNzS2V5LmphdmE=) | `100.00% <100.00%> (ø)` | | | [...luster/router/script/ScriptStateRouterFactory.java](https://codecov.io/gh/apache/dubbo/pull/11349?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3NjcmlwdC9TY3JpcHRTdGF0ZVJvdXRlckZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [...he/dubbo/test/common/impl/GreetingServiceImpl.java](https://codecov.io/gh/apache/dubbo/pull/11349?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9jb21tb24vaW1wbC9HcmVldGluZ1NlcnZpY2VJbXBsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [...zookeeper/curator/CuratorZookeeperTransporter.java](https://codecov.io/gh/apache/dubbo/pull/11349?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3Rpbmctem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy96b29rZWVwZXIvY3VyYXRvci9DdXJhdG9yWm9va2VlcGVyVHJhbnNwb3J0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [.../serialize/hessian2/Hessian2SerializerFactory.java](https://codecov.io/gh/apache/dubbo/pull/11349?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yU2VyaWFsaXplckZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [.../apache/dubbo/test/spring/SpringXmlConfigTest.java](https://codecov.io/gh/apache/dubbo/pull/11349?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LXNwcmluZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vdGVzdC9zcHJpbmcvU3ByaW5nWG1sQ29uZmlnVGVzdC5qYXZh) | `0.00% <0.00%> (-96.16%)` | :arrow_down: | |
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11349: metrics key duplication
sonarcloud[bot] commented on PR #11349: URL: https://github.com/apache/dubbo/pull/11349#issuecomment-1396393677 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo=11349) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11349=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11349=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo=11349=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11349=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11349=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo=11349=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11349=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11349=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=11349=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11349=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo=11349=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo=11349=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo=11349=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo=11349=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_dubbo=11349=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo=11349=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] mxsm commented on pull request #11326: [ISSUE #11294] Optimize ConcurrentHashMap#computeIfAbsent have performance problem in jdk1.8
mxsm commented on PR #11326: URL: https://github.com/apache/dubbo/pull/11326#issuecomment-1396378948 @AlbumenJ PTAL~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] mxsm commented on a diff in pull request #11326: [ISSUE #11294] Optimize ConcurrentHashMap#computeIfAbsent have performance problem in jdk1.8
mxsm commented on code in PR #11326:
URL: https://github.com/apache/dubbo/pull/11326#discussion_r1080758607
##
dubbo-common/src/main/java/org/apache/dubbo/common/utils/ConcurrentHashMapUtils.java:
##
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.common.utils;
+
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+
+/**
+ * ConcurrentHashMap util
+ */
+
+public class ConcurrentHashMapUtils {
+
+private static final boolean IS_JAVA8;
+
+static {
+IS_JAVA8 = System.getProperty("java.version").startsWith("1.8.");
Review Comment:
@AlbumenJ good idea,i will fix it and re-submit later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] aamingaa commented on issue #10968: File name too long
aamingaa commented on issue #10968: URL: https://github.com/apache/dubbo/issues/10968#issuecomment-1396375818 assign me :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] mxsm commented on a diff in pull request #11326: [ISSUE #11294] Optimize ConcurrentHashMap#computeIfAbsent have performance problem in jdk1.8
mxsm commented on code in PR #11326:
URL: https://github.com/apache/dubbo/pull/11326#discussion_r1080758607
##
dubbo-common/src/main/java/org/apache/dubbo/common/utils/ConcurrentHashMapUtils.java:
##
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.common.utils;
+
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.Function;
+
+/**
+ * ConcurrentHashMap util
+ */
+
+public class ConcurrentHashMapUtils {
+
+private static final boolean IS_JAVA8;
+
+static {
+IS_JAVA8 = System.getProperty("java.version").startsWith("1.8.");
Review Comment:
@AlbumenJ i will fix it and re-submit later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] jojocodeX opened a new pull request, #11349: metrics key duplication
jojocodeX opened a new pull request, #11349: URL: https://github.com/apache/dubbo/pull/11349 metrics key duplication -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
