[GitHub] codecov-io commented on issue #1764: Remove unnecessary null check.
codecov-io commented on issue #1764: Remove unnecessary null check. URL: https://github.com/apache/incubator-dubbo/pull/1764#issuecomment-387691253 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1764?src=pr&el=h1) Report > Merging [#1764](https://codecov.io/gh/apache/incubator-dubbo/pull/1764?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/6ec0225cfa9b45c8349d19019f965d5c52d40a09?src=pr&el=desc) will **increase** coverage by `1.28%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1764?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#1764 +/- ## + Coverage 37.93% 39.22% +1.28% - Complexity 4023 4197 +174 Files 618 618 Lines 2972729745 +18 Branches 5241 5259 +18 + Hits 1127811667 +389 + Misses1660816222 -386 - Partials 1841 1856 +15 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1764?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...om/alibaba/dubbo/config/spring/AnnotationBean.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL0Fubm90YXRpb25CZWFuLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DaGFubmVsV3JhcHBlZEludm9rZXIuamF2YQ==) | `37.5% <0%> (-8.34%)` | `3% <0%> (ø)` | | | [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `83.33% <0%> (-5.56%)` | `6% <0%> (-1%)` | | | [...n/java/com/alibaba/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZy5qYXZh) | `39.81% <0%> (+0.46%)` | `43% <0%> (+1%)` | :arrow_up: | | [...m/alibaba/com/caucho/hessian/io/Hessian2Input.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr&el=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL2lvL0hlc3NpYW4ySW5wdXQuamF2YQ==) | `19.27% <0%> (+0.58%)` | `63% <0%> (+2%)` | :arrow_up: | | [...java/com/alibaba/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvUmVmZXJlbmNlQ29uZmlnLmphdmE=) | `48.7% <0%> (+0.73%)` | `37% <0%> (+1%)` | :arrow_up: | | [.../java/com/alibaba/dubbo/config/AbstractConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RDb25maWcuamF2YQ==) | `72.53% <0%> (+1.4%)` | `116% <0%> (+2%)` | :arrow_up: | | [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==) | `54.68% <0%> (+1.56%)` | `3% <0%> (ø)` | :arrow_down: | | [...alibaba/com/caucho/hessian/io/MapDeserializer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr&el=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL2lvL01hcERlc2VyaWFsaXplci5qYXZh) | `50.87% <0%> (+1.75%)` | `13% <0%> (+1%)` | :arrow_up: | | [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh) | `55.69% <0%> (+3.79%)` | `13% <0%> (+3%)` | :arrow_up: | | ... and [16 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](ht
[GitHub] codecov-io commented on issue #1764: Remove unnecessary null check.
codecov-io commented on issue #1764: Remove unnecessary null check. URL: https://github.com/apache/incubator-dubbo/pull/1764#issuecomment-387691253 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1764?src=pr&el=h1) Report > Merging [#1764](https://codecov.io/gh/apache/incubator-dubbo/pull/1764?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/6ec0225cfa9b45c8349d19019f965d5c52d40a09?src=pr&el=desc) will **increase** coverage by `1.29%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1764?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#1764 +/- ## + Coverage 37.93% 39.23% +1.29% - Complexity 4023 4198 +175 Files 618 618 Lines 2972729746 +19 Branches 5241 5259 +18 + Hits 1127811670 +392 + Misses1660816217 -391 - Partials 1841 1859 +18 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1764?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...om/alibaba/dubbo/config/spring/AnnotationBean.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL0Fubm90YXRpb25CZWFuLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `61.25% <0%> (-5%)` | `20% <0%> (-1%)` | | | [...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DaGFubmVsV3JhcHBlZEludm9rZXIuamF2YQ==) | `41.66% <0%> (-4.17%)` | `3% <0%> (ø)` | | | [...baba/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDbGllbnQuamF2YQ==) | `57.81% <0%> (-1.57%)` | `8% <0%> (-1%)` | | | [...n/java/com/alibaba/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZy5qYXZh) | `39.81% <0%> (+0.46%)` | `43% <0%> (+1%)` | :arrow_up: | | [...m/alibaba/com/caucho/hessian/io/Hessian2Input.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr&el=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL2lvL0hlc3NpYW4ySW5wdXQuamF2YQ==) | `19.27% <0%> (+0.58%)` | `63% <0%> (+2%)` | :arrow_up: | | [...java/com/alibaba/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvUmVmZXJlbmNlQ29uZmlnLmphdmE=) | `48.7% <0%> (+0.73%)` | `37% <0%> (+1%)` | :arrow_up: | | [.../java/com/alibaba/dubbo/config/AbstractConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RDb25maWcuamF2YQ==) | `72.53% <0%> (+1.4%)` | `116% <0%> (+2%)` | :arrow_up: | | [...alibaba/com/caucho/hessian/io/MapDeserializer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr&el=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL2lvL01hcERlc2VyaWFsaXplci5qYXZh) | `50.87% <0%> (+1.75%)` | `13% <0%> (+1%)` | :arrow_up: | | [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh) | `55.69% <0%> (+3.79%)` | `13% <0%> (+3%)` | :arrow_up: | | ... and [17 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov
[GitHub] codecov-io commented on issue #1764: Remove unnecessary null check.
codecov-io commented on issue #1764: Remove unnecessary null check. URL: https://github.com/apache/incubator-dubbo/pull/1764#issuecomment-387691253 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1764?src=pr&el=h1) Report > Merging [#1764](https://codecov.io/gh/apache/incubator-dubbo/pull/1764?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/6ec0225cfa9b45c8349d19019f965d5c52d40a09?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1764?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#1764 +/- ## - Coverage 37.93% 37.93% -0.01% + Complexity 4023 4022 -1 Files 618 618 Lines 2972729728 +1 Branches 5241 5241 - Hits 1127811277 -1 - Misses1660816611 +3 + Partials 1841 1840 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1764?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...om/alibaba/dubbo/config/spring/AnnotationBean.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL0Fubm90YXRpb25CZWFuLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DaGFubmVsV3JhcHBlZEludm9rZXIuamF2YQ==) | `41.66% <0%> (-4.17%)` | `3% <0%> (ø)` | | | [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==) | `54.68% <0%> (+1.56%)` | `3% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1764?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1764?src=pr&el=footer). Last update [6ec0225...3d4edd1](https://codecov.io/gh/apache/incubator-dubbo/pull/1764?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
