Re: [PR] bufix: add tlsHandshake timeout to prevent readtimeout cause dead loop [dubbo-getty]

[via GitHub]

AlexStocks merged PR #115:
URL: https://github.com/apache/dubbo-getty/pull/115


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

Re: [PR] bufix: add tlsHandshake timeout to prevent readtimeout cause dead loop [dubbo-getty]

[via GitHub]

AlexStocks commented on code in PR #115:
URL: https://github.com/apache/dubbo-getty/pull/115#discussion_r1527183228


##
session.go:
##
@@ -636,6 +639,18 @@ func (s *session) handleTCPPackage() error {
pktBuf = gxbytes.NewBuffer(nil)
 
conn = s.Connection.(*gettyTCPConn)
+   if tlsConn, ok := conn.conn.(*tls.Conn); ok {
+   tlsHandshaketime := defaultTLSHandshakeTimeout
+   if s.ReadTimeout() > 0 {
+   tlsHandshaketime = s.ReadTimeout()
+   }
+   ctx, cancle := context.WithTimeout(context.Background(), 
tlsHandshaketime)

Review Comment:
   cancle = cancel？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

Re: [PR] bufix: add tlsHandshake timeout to prevent readtimeout cause dead loop [dubbo-getty]

[via GitHub]

codecov-commenter commented on PR #115:
URL: https://github.com/apache/dubbo-getty/pull/115#issuecomment-2002006944

   ## 
[Codecov](https://app.codecov.io/gh/apache/dubbo-getty/pull/115?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 Report
   Attention: Patch coverage is `0%` with `9 lines` in your changes are missing 
coverage. Please review.
   > Project coverage is 67.34%. Comparing base 
[(`71b8185`)](https://app.codecov.io/gh/apache/dubbo-getty/commit/71b8185885e8905e3a0aac98837a7793d3ca9036?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 to head 
[(`66e4222`)](https://app.codecov.io/gh/apache/dubbo-getty/pull/115?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   
   > :exclamation: Current head 66e4222 differs from pull request most recent 
head 049efdf. Consider uploading reports for the commit 049efdf to get more 
accurate results
   
   | 
[Files](https://app.codecov.io/gh/apache/dubbo-getty/pull/115?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[session.go](https://app.codecov.io/gh/apache/dubbo-getty/pull/115?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c2Vzc2lvbi5nbw==)
 | 0.00% | [8 Missing and 1 partial :warning: 
](https://app.codecov.io/gh/apache/dubbo-getty/pull/115?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 |
   
   Additional details and impacted files
   
   
   ```diff
   @@Coverage Diff @@
   ##   master #115  +/-   ##
   ==
   - Coverage   67.74%   67.34%   -0.41% 
   ==
 Files   88  
 Lines1513 1522   +9 
   ==
 Hits 1025 1025  
   - Misses384  392   +8 
   - Partials  104  105   +1 
   ```
   
   
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/dubbo-getty/pull/115?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[PR] bufix: add tlsHandshake timeout to prevent readtimeout cause dead loop [dubbo-getty]

[via GitHub]

hongshengjie opened a new pull request, #115:
URL: https://github.com/apache/dubbo-getty/pull/115

   如title


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org