Re: [PR] Optimize subscription order [dubbo]
finefuture closed pull request #13942: Optimize subscription order URL: https://github.com/apache/dubbo/pull/13942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Optimize subscription order [dubbo]
laywin commented on PR #13942: URL: https://github.com/apache/dubbo/pull/13942#issuecomment-2009132663 > However, this still cannot resolve the ABC issue.  it seems a timing problem, there should be a timestamp or version from registry center. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Optimize subscription order [dubbo]
finefuture commented on PR #13942: URL: https://github.com/apache/dubbo/pull/13942#issuecomment-2008622802 > > 1. Add version to instance and compare version. > >This is a good idea. But is it supported by nacos? > > > 2. The registry center triggers an event push for all instances when a subscription request is received. > >Same like 1, should nacos support first. > > > 3. Lock getAllInstance and notify to ensure that getAllInstance is executed first. > >I think this cannot resolve it totally. This just make the probability smaller. Yes, register center support is required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Optimize subscription order [dubbo]
AlbumenJ commented on PR #13942: URL: https://github.com/apache/dubbo/pull/13942#issuecomment-2008549847 > 1. Add version to instance and compare version. This is a good idea. But is it supported by nacos? > 2. The registry center triggers an event push for all instances when a subscription request is received. Same like 1, should nacos support first. > 3. Lock getAllInstance and notify to ensure that getAllInstance is executed first. I think this cannot resolve it totally. This just make the probability smaller. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Optimize subscription order [dubbo]
finefuture commented on PR #13942: URL: https://github.com/apache/dubbo/pull/13942#issuecomment-2005684209 > However, this still cannot resolve the ABC issue.  I think there are three solutions: 1. Add version to instance and compare version. 2. The registry center triggers an event push for all instances when a subscription request is received. 3. Lock getAllInstance and notify to ensure that getAllInstance is executed first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Optimize subscription order [dubbo]
AlbumenJ commented on PR #13942: URL: https://github.com/apache/dubbo/pull/13942#issuecomment-2005602978 However, this still cannot resolve the ABC issue.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Optimize subscription order [dubbo]
AlbumenJ commented on code in PR #13942:
URL: https://github.com/apache/dubbo/pull/13942#discussion_r1529568448
##
dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/ServiceDiscoveryRegistry.java:
##
@@ -344,17 +344,12 @@ protected void subscribeURLs(URL url, NotifyListener
listener, Set servi
Lock appSubscriptionLock = getAppSubscription(serviceNamesKey);
try {
appSubscriptionLock.lock();
+boolean initialization = false;
Review Comment:
Add some comment to describe what is this variable working for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Optimize subscription order [dubbo]
sonarcloud[bot] commented on PR #13942: URL: https://github.com/apache/dubbo/pull/13942#issuecomment-2003569807 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=13942) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=13942=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=13942=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=13942=false=true)  [70.6% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=13942=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=13942=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=13942) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Optimize subscription order [dubbo]
sonarcloud[bot] commented on PR #13942: URL: https://github.com/apache/dubbo/pull/13942#issuecomment-2003467747 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=13942) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=13942=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=13942=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=13942=false=true)  [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=13942=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=13942=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=13942) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
