Re: [PR] fix(log): logger formatting [dubbo-go]
DMwangnima merged PR #2640: URL: https://github.com/apache/dubbo-go/pull/2640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] fix(log): logger formatting [dubbo-go]
codecov-commenter commented on PR #2640: URL: https://github.com/apache/dubbo-go/pull/2640#issuecomment-2002332925 ## [Codecov](https://app.codecov.io/gh/apache/dubbo-go/pull/2640?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `0%` with `9 lines` in your changes are missing coverage. Please review. > Project coverage is 47.37%. Comparing base [(`3165248`)](https://app.codecov.io/gh/apache/dubbo-go/commit/31652489c5df7335d9969b7a17105393e4dc27a1?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`f017b7d`)](https://app.codecov.io/gh/apache/dubbo-go/pull/2640?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 2 commits behind head on main. | [Files](https://app.codecov.io/gh/apache/dubbo-go/pull/2640?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [remoting/etcdv3/client.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2640?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cmVtb3RpbmcvZXRjZHYzL2NsaWVudC5nbw==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go/pull/2640?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [config\_center/nacos/client.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2640?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go/pull/2640?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [registry/zookeeper/registry.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2640?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go/pull/2640?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [remoting/zookeeper/client.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2640?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go/pull/2640?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## main#2640 +/- ## === Coverage 47.36% 47.37% === Files 341 341 Lines 2512225122 === + Hits1189911901+2 + Misses 1207912077-2 Partials 1144 1144 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo-go/pull/2640?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] fix(log): logger formatting [dubbo-go]
sonarcloud[bot] commented on PR #2640: URL: https://github.com/apache/dubbo-go/pull/2640#issuecomment-2002328991 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_dubbo-go=2640) **Quality Gate passed** Issues ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [1 New issue](https://sonarcloud.io/project/issues?id=apache_dubbo-go=2640=false=true) ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go=2640=new_accepted_issues=list) Measures ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go=2640=false=true) ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png '') No data about Coverage ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go=2640=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go=2640) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org