Re: [PR] refactor(dubbo-samples-environment-keys): upgrade samples [dubbo-samples]

2024-03-17 Thread via GitHub


chickenlj merged PR #1075:
URL: https://github.com/apache/dubbo-samples/pull/1075


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] refactor(dubbo-samples-environment-keys): upgrade samples [dubbo-samples]

2024-03-17 Thread via GitHub


chickenlj commented on code in PR #1075:
URL: https://github.com/apache/dubbo-samples/pull/1075#discussion_r1527736260


##
2-advanced/dubbo-samples-environment-keys/dubbo-samples-environment-keys-provider/pom.xml:
##
@@ -0,0 +1,64 @@
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+4.0.0
+
+org.apache.dubbo
+dubbo-samples-environment-keys
+1.0-SNAPSHOT
+
+
+dubbo-samples-environment-keys-provider
+
+
+11
+11

Review Comment:
   jdk 17 please



##
2-advanced/dubbo-samples-environment-keys/dubbo-samples-environment-keys-consumer/pom.xml:
##
@@ -0,0 +1,64 @@
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+4.0.0
+
+org.apache.dubbo
+dubbo-samples-environment-keys
+1.0-SNAPSHOT
+
+
+dubbo-samples-environment-keys-consumer
+
+
+11
+11

Review Comment:
   jdk 17 please



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org