[GitHub] [dubbo-go] AlexStocks closed pull request #205: fix issue:204

2019-09-17 Thread GitHub
[ pull request closed by AlexStocks ]

[ Full content available at: https://github.com/apache/dubbo-go/pull/205 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] kiwiflydream opened issue #5074: Use the echo test to throw a ClassCastException

2019-09-17 Thread GitHub
### Environment

* Dubbo version: 2.7.3
* Operating System version: mac
* Java version: 1.8

### Steps to reproduce this issue
```
@Service
public class DubboEchoService {

@Reference(version="1.0.0")
private DemoService demoService;

public void test(){
EchoService echoService = (EchoService) demoService;
Object status = echoService.$echo("OK");
System.out.println(status);
}
}
```

```
java.lang.ClassCastException: com.sun.proxy.$Proxy55 cannot be cast to 
org.apache.dubbo.rpc.service.EchoService
```

I found all the examples were through  
, but we have no XML file in spring boot and can only use the annotation, but 
found the error








[ Full content available at: https://github.com/apache/dubbo/issues/5074 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] cvictory closed pull request #5072: [Dubbo-4340]Throws exception whenever SPI extensions are in abnormal status during loading.

2019-09-17 Thread GitHub
[ pull request closed by cvictory ]

[ Full content available at: https://github.com/apache/dubbo/pull/5072 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] chickenlj closed pull request #4365: fix 4340 bug:duplicate extension

2019-09-17 Thread GitHub
[ pull request closed by chickenlj ]

[ Full content available at: https://github.com/apache/dubbo/pull/4365 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on issue #206: fix issue:204, branch develop

2019-09-17 Thread GitHub
LGTM

[ Full content available at: https://github.com/apache/dubbo-go/pull/206 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #206: fix issue:204, branch develop

2019-09-17 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/206?src=pr=h1) Report
> Merging [#206](https://codecov.io/gh/apache/dubbo-go/pull/206?src=pr=desc) 
> into 
> [develop](https://codecov.io/gh/apache/dubbo-go/commit/92b20556a8c79e9c08a48967d39bf96fbb9b5b99?src=pr=desc)
>  will **increase** coverage by `1.06%`.
> The diff coverage is `0%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/dubbo-go/pull/206/graphs/tree.svg?width=650=dcPE6RyFAL=150=pr)](https://codecov.io/gh/apache/dubbo-go/pull/206?src=pr=tree)

```diff
@@ Coverage Diff @@
##   develop #206  +/-   ##
===
+ Coverage66.76%   67.82%   +1.06% 
===
  Files   94   94  
  Lines 5847 5847  
===
+ Hits  3904 3966  +62 
+ Misses1544 1478  -66 
- Partials   399  403   +4
```


| [Impacted 
Files](https://codecov.io/gh/apache/dubbo-go/pull/206?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/206/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv)
 | `70.94% <0%> (ø)` | :arrow_up: |
| 
[protocol/dubbo/server.go](https://codecov.io/gh/apache/dubbo-go/pull/206/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vc2VydmVyLmdv)
 | `66.25% <0%> (ø)` | :arrow_up: |
| 
[protocol/jsonrpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/206/diff?src=pr=tree#diff-cHJvdG9jb2wvanNvbnJwYy9zZXJ2ZXIuZ28=)
 | `59.79% <0%> (-1.51%)` | :arrow_down: |
| 
[registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/206/diff?src=pr=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv)
 | `56.25% <0%> (-1.14%)` | :arrow_down: |
| 
[protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/206/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==)
 | `70.37% <0%> (+2.46%)` | :arrow_up: |
| 
[protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/206/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=)
 | `82.35% <0%> (+5.88%)` | :arrow_up: |
| 
[protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/206/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=)
 | `64.02% <0%> (+14.02%)` | :arrow_up: |
| 
[protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/206/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==)
 | `73.6% <0%> (+15.73%)` | :arrow_up: |
| 
[cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/206/diff?src=pr=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=)
 | `71.69% <0%> (+16.98%)` | :arrow_up: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/dubbo-go/pull/206?src=pr=continue).
> **Legend** - [Click here to learn 
> more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
> Powered by 
> [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/206?src=pr=footer). 
> Last update 
> [92b2055...e35d29c](https://codecov.io/gh/apache/dubbo-go/pull/206?src=pr=lastupdated).
>  Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/206 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-go] hxmhlt commented on issue #200: URL.params concurrent map read and map write problem

2019-09-17 Thread GitHub
resolved

[ Full content available at: https://github.com/apache/dubbo-go/issues/200 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-go] hxmhlt commented on issue #146: fatal error: concurrent map read and map write

2019-09-17 Thread GitHub
resolved by #201 

[ Full content available at: https://github.com/apache/dubbo-go/issues/146 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] xingguang2013 opened issue #5077: Some coding problems

2019-09-17 Thread GitHub
- [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of 
this repository and believe that this is not a duplicate.
- [x] I have checked the 
[FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository 
and believe that this is not a duplicate.

### Environment

* Dubbo version: 2.7.3
* Operating System version: Mac
* Java version: 1.8

### Steps to reproduce this issue

1.  `org/apache/dubbo/registry/support/ProviderConsumerRegTable.java:65` Type 
'ProviderInvokerWrapper<>' does not define hashCode(), but is used in a hashing 
data-structure.
2. Class overrides equals but not hashCode.
* org.apache.dubbo.config.AbstractConfig
* org.apache.dubbo.registry.support.ProviderInvokerWrapper
* org.apache.dubbo.remoting.buffer.AbstractChannelBuffer

Pls. provide [GitHub address] to reproduce this issue.

### Expected Result

Whether the above suggestions can be fixed or have other considerations

### Actual Result

Is it considered a bug? Will it fix?


[ Full content available at: https://github.com/apache/dubbo/issues/5077 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #5071: Revert 1 2.7.2 release

2019-09-17 Thread GitHub
[![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=5071)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you all sign our [Contributor License 
Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=5071) before we 
can accept your contribution.**3** out of **6** committers have signed the 
CLA.:white_check_mark: beiwei30:white_check_mark: 
ralf0131:white_check_mark: chickenlj:x: cvictory:x: 
uglycow:x: wuwenhui**wuwenhui** seems not to be a GitHub user. 
You need a GitHub account to be able to sign the CLA. If you have already a 
GitHub account, please [add the email address used for this commit to your 
account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).You
 have signed the CLA already but the status is still pending? Let us [
 recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=5071) 
it.

[ Full content available at: https://github.com/apache/dubbo/pull/5071 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] sonymoon commented on issue #5080: Flaky EtcdMetadataReportTest.testStoreConsumer:NoClassDefFoundError

2019-09-17 Thread GitHub
`jetcd-core` needs `guava` dependency which is absent in test classpath

[ Full content available at: https://github.com/apache/dubbo/issues/5080 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #202: Add token support

2019-09-17 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=h1) Report
> Merging [#202](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=desc) 
> into 
> [develop](https://codecov.io/gh/apache/dubbo-go/commit/ef14088239f409a85d351c960f1bb02e5691e995?src=pr=desc)
>  will **increase** coverage by `1.03%`.
> The diff coverage is `68.96%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/dubbo-go/pull/202/graphs/tree.svg?width=650=dcPE6RyFAL=150=pr)](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=tree)

```diff
@@ Coverage Diff @@
##   develop #202  +/-   ##
===
+ Coverage65.22%   66.26%   +1.03% 
===
  Files   95   96   +1 
  Lines 6416 6444  +28 
===
+ Hits  4185 4270  +85 
+ Misses1791 1732  -59 
- Partials   440  442   +2
```


| [Impacted 
Files](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-Y29tbW9uL3VybC5nbw==)
 | `68.97% <0%> (-1.64%)` | :arrow_down: |
| 
[config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv)
 | `65.11% <100%> (+0.83%)` | :arrow_up: |
| 
[protocol/dubbo/dubbo\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9faW52b2tlci5nbw==)
 | `84.09% <100%> (+1.16%)` | :arrow_up: |
| 
[filter/impl/token\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-ZmlsdGVyL2ltcGwvdG9rZW5fZmlsdGVyLmdv)
 | `87.5% <87.5%> (ø)` | |
| 
[remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==)
 | `64.45% <0%> (+0.57%)` | :arrow_up: |
| 
[remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv)
 | `47.93% <0%> (+1.03%)` | :arrow_up: |
| 
[protocol/jsonrpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-cHJvdG9jb2wvanNvbnJwYy9zZXJ2ZXIuZ28=)
 | `61.3% <0%> (+1.5%)` | :arrow_up: |
| 
[protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==)
 | `70.37% <0%> (+2.46%)` | :arrow_up: |
| 
[config\_center/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvbGlzdGVuZXIuZ28=)
 | `86.95% <0%> (+4.34%)` | :arrow_up: |
| ... and [3 
more](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree-more) 
| |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=continue).
> **Legend** - [Click here to learn 
> more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
> Powered by 
> [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=footer). 
> Last update 
> [ef14088...0888326](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=lastupdated).
>  Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/202 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #5051: specify service annotation protocol

2019-09-17 Thread GitHub
[![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=5051)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you sign our [Contributor License 
Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=5051) before we 
can accept your contribution.**vghy顾海洋** seems not to be a GitHub 
user. You need a GitHub account to be able to sign the CLA. If you have already 
a GitHub account, please [add the email address used for this commit to your 
account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).You
 have signed the CLA already but the status is still pending? Let us 
[recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=5051) 
it.

[ Full content available at: https://github.com/apache/dubbo/pull/5051 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #4811: remove duplicated references from ServiceConfig and ReferenceConfig, keep them in ConfigManager

2019-09-17 Thread GitHub
[![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=4811)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you all sign our [Contributor License 
Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=4811) before we 
can accept your contribution.**1** out of **2** committers have signed the 
CLA.:white_check_mark: mzorro:x: 君时**君时** seems not to 
be a GitHub user. You need a GitHub account to be able to sign the CLA. If you 
have already a GitHub account, please [add the email address used for this 
commit to your 
account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).You
 have signed the CLA already but the status is still pending? Let us 
[recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=4811) 
it.

[ Full content available at: https://github.com/apache/dubbo/pull/4811 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #5071: Revert 1 2.7.2 release

2019-09-17 Thread GitHub
[![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=5071)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you all sign our [Contributor License 
Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=5071) before we 
can accept your contribution.**3** out of **6** committers have signed the 
CLA.:white_check_mark: chickenlj:white_check_mark: 
ralf0131:white_check_mark: beiwei30:x: uglycow:x: 
cvictory:x: wuwenhui**wuwenhui** seems not to be a GitHub user. 
You need a GitHub account to be able to sign the CLA. If you have already a 
GitHub account, please [add the email address used for this commit to your 
account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).You
 have signed the CLA already but the status is still pending? Let us [
 recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=5071) 
it.

[ Full content available at: https://github.com/apache/dubbo/pull/5071 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #4463: Add back compatible classes: ResponseFuture and FutureAdapter

2019-09-17 Thread GitHub
[![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=4463)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you all sign our [Contributor License 
Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=4463) before we 
can accept your contribution.**5** out of **9** committers have signed the 
CLA.:white_check_mark: mercyblitz:white_check_mark: 
chickenlj:white_check_mark: htynkn:white_check_mark: 
shoukai:white_check_mark: ralf0131:x: cvictory:x: 
haiyang1985:x: zishinan:x: vio-linYou have signed the CLA 
already but the status is still pending? Let us 
[recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=4463) 
it.

[ Full content available at: https://github.com/apache/dubbo/pull/4463 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #5075: dubbo:registry标签 username & password 生效

2019-09-17 Thread GitHub
[![CLA assistant 
check](https://cla-assistant.io/pull/badge/signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=5075)
 All committers have signed the CLA.

[ Full content available at: https://github.com/apache/dubbo/pull/5075 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #4235: AMS realize dubbo Proxy

2019-09-17 Thread GitHub
[![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=4235)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you all sign our [Contributor License 
Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=4235) before we 
can accept your contribution.**0** out of **2** committers have signed the 
CLA.:x: githublaohu:x: 
2372554...@qq.com**2372554...@qq.com** seems not to be a GitHub user. 
You need a GitHub account to be able to sign the CLA. If you have already a 
GitHub account, please [add the email address used for this commit to your 
account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).You
 have signed the CLA already but the status is still pending? Let us 
[recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=4235) 
it.

[ Full content available at: https://github.com/apache/dubbo/pull/4235 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks closed pull request #202: Add token support

2019-09-17 Thread GitHub
[ pull request closed by AlexStocks ]

[ Full content available at: https://github.com/apache/dubbo-go/pull/202 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-go] gaoxinge commented on issue #202: Add token support

2019-09-17 Thread GitHub
LGTM.

[ Full content available at: https://github.com/apache/dubbo-go/pull/202 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] sonymoon commented on issue #5070: [Dubbo-4331] Improve api doc #4331

2019-09-17 Thread GitHub
I would be very appreciated if you help review @htynkn. 

[ Full content available at: https://github.com/apache/dubbo/pull/5070 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #202: Add token support

2019-09-17 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=h1) Report
> Merging [#202](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=desc) 
> into 
> [develop](https://codecov.io/gh/apache/dubbo-go/commit/ef14088239f409a85d351c960f1bb02e5691e995?src=pr=desc)
>  will **increase** coverage by `2.68%`.
> The diff coverage is `68.96%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/dubbo-go/pull/202/graphs/tree.svg?width=650=dcPE6RyFAL=150=pr)](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=tree)

```diff
@@ Coverage Diff @@
##   develop #202  +/-   ##
===
+ Coverage65.22%   67.91%   +2.68% 
===
  Files   95   95  
  Lines 6416 5875 -541 
===
- Hits  4185 3990 -195 
+ Misses1791 1483 -308 
+ Partials   440  402  -38
```


| [Impacted 
Files](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-Y29tbW9uL3VybC5nbw==)
 | `73.94% <0%> (+3.33%)` | :arrow_up: |
| 
[config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv)
 | `66.66% <100%> (+2.38%)` | :arrow_up: |
| 
[protocol/dubbo/dubbo\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9faW52b2tlci5nbw==)
 | `84.09% <100%> (+1.16%)` | :arrow_up: |
| 
[filter/impl/token\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-ZmlsdGVyL2ltcGwvdG9rZW5fZmlsdGVyLmdv)
 | `87.5% <87.5%> (ø)` | |
| 
[registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==)
 | `78.3% <0%> (-8.13%)` | :arrow_down: |
| 
[registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=)
 | `75% <0%> (-6.74%)` | :arrow_down: |
| 
[config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv)
 | `60.81% <0%> (-3.81%)` | :arrow_down: |
| 
[registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv)
 | `72.97% <0%> (-3.78%)` | :arrow_down: |
| 
[config/application\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-Y29uZmlnL2FwcGxpY2F0aW9uX2NvbmZpZy5nbw==)
 | `40% <0%> (-1.67%)` | :arrow_down: |
| ... and [34 
more](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree-more) 
| |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=continue).
> **Legend** - [Click here to learn 
> more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
> Powered by 
> [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=footer). 
> Last update 
> [ef14088...c88b789](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=lastupdated).
>  Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/202 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] sonymoon opened issue #5080: Flaky EtcdMetadataReportTest.testStoreConsumer:NoClassDefFoundError

2019-09-17 Thread GitHub
- [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of 
this repository and believe that this is not a duplicate.
- [x] I have checked the 
[FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository 
and believe that this is not a duplicate.

### Environment

* Dubbo version: 2.7.4-SNAPSHOT
* Operating System version: "mac os x", version: "10.12.6", arch: "x86_64", 
family: "mac"
* Java version: 1.8.0_131

### Steps to reproduce this issue

1. just run UT `EtcdMetadataReportTest.testStoreConsumer` in IDEA
or `mvn clean install -DskipTests=false` from cmd.

### Expected Result
UT succeeds

### Actual Result
Ex:
 IDEA
```
java.lang.NoClassDefFoundError: com/google/common/base/Preconditions

at io.etcd.jetcd.ClientBuilder.endpoints(ClientBuilder.java:82)
at 
org.apache.dubbo.metadata.store.etcd.EtcdMetadataReportTest.setUp(EtcdMetadataReportTest.java:64
```

 mvn build with clean install
```
[ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 1, Time elapsed: 4.798 s 
<<< FAILURE! - in org.apache.dubbo.metadata.store.etcd.EtcdMetadataReportTest
[ERROR] testStoreConsumer  Time elapsed: 2.127 s  <<< ERROR!
java.lang.NoClassDefFoundError: com/google/common/base/Preconditions
at 
org.apache.dubbo.metadata.store.etcd.EtcdMetadataReportTest.setUp(EtcdMetadataReportTest.java:64)
Caused by: java.lang.ClassNotFoundException: 
com.google.common.base.Preconditions
at 
org.apache.dubbo.metadata.store.etcd.EtcdMetadataReportTest.setUp(EtcdMetadataReportTest.java:64)



[ Full content available at: https://github.com/apache/dubbo/issues/5080 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-spring-boot-project] MrEric125 commented on issue #424: 0.2.1.RELEASE dubbo rest protocol not support tomcat 9

2019-09-17 Thread GitHub
the problem still exists in dubbo version 2.7.3 and spirng boot version 2.1.6

[ Full content available at: 
https://github.com/apache/dubbo-spring-boot-project/issues/424 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #202: Add token support

2019-09-17 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=h1) Report
> Merging [#202](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=desc) 
> into 
> [develop](https://codecov.io/gh/apache/dubbo-go/commit/ef14088239f409a85d351c960f1bb02e5691e995?src=pr=desc)
>  will **increase** coverage by `2.68%`.
> The diff coverage is `68.96%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/dubbo-go/pull/202/graphs/tree.svg?width=650=dcPE6RyFAL=150=pr)](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=tree)

```diff
@@ Coverage Diff @@
##   develop #202  +/-   ##
===
+ Coverage65.22%   67.91%   +2.68% 
===
  Files   95   95  
  Lines 6416 5875 -541 
===
- Hits  4185 3990 -195 
+ Misses1791 1483 -308 
+ Partials   440  402  -38
```


| [Impacted 
Files](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-Y29tbW9uL3VybC5nbw==)
 | `73.94% <0%> (+3.33%)` | :arrow_up: |
| 
[config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv)
 | `66.66% <100%> (+2.38%)` | :arrow_up: |
| 
[protocol/dubbo/dubbo\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9faW52b2tlci5nbw==)
 | `84.09% <100%> (+1.16%)` | :arrow_up: |
| 
[filter/impl/token\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-ZmlsdGVyL2ltcGwvdG9rZW5fZmlsdGVyLmdv)
 | `87.5% <87.5%> (ø)` | |
| 
[registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==)
 | `78.3% <0%> (-8.13%)` | :arrow_down: |
| 
[registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=)
 | `75% <0%> (-6.74%)` | :arrow_down: |
| 
[config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv)
 | `60.81% <0%> (-3.81%)` | :arrow_down: |
| 
[registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv)
 | `72.97% <0%> (-3.78%)` | :arrow_down: |
| 
[config/application\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-Y29uZmlnL2FwcGxpY2F0aW9uX2NvbmZpZy5nbw==)
 | `40% <0%> (-1.67%)` | :arrow_down: |
| ... and [34 
more](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree-more) 
| |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=continue).
> **Legend** - [Click here to learn 
> more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
> Powered by 
> [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=footer). 
> Last update 
> [ef14088...bb37d14](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=lastupdated).
>  Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/202 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #202: Add token support

2019-09-17 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=h1) Report
> Merging [#202](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=desc) 
> into 
> [develop](https://codecov.io/gh/apache/dubbo-go/commit/ef14088239f409a85d351c960f1bb02e5691e995?src=pr=desc)
>  will **increase** coverage by `1.03%`.
> The diff coverage is `68.96%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/dubbo-go/pull/202/graphs/tree.svg?width=650=dcPE6RyFAL=150=pr)](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=tree)

```diff
@@ Coverage Diff @@
##   develop #202  +/-   ##
===
+ Coverage65.22%   66.26%   +1.03% 
===
  Files   95   96   +1 
  Lines 6416 6444  +28 
===
+ Hits  4185 4270  +85 
+ Misses1791 1732  -59 
- Partials   440  442   +2
```


| [Impacted 
Files](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-Y29tbW9uL3VybC5nbw==)
 | `68.97% <0%> (-1.64%)` | :arrow_down: |
| 
[config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv)
 | `65.11% <100%> (+0.83%)` | :arrow_up: |
| 
[protocol/dubbo/dubbo\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9faW52b2tlci5nbw==)
 | `84.09% <100%> (+1.16%)` | :arrow_up: |
| 
[filter/impl/token\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-ZmlsdGVyL2ltcGwvdG9rZW5fZmlsdGVyLmdv)
 | `87.5% <87.5%> (ø)` | |
| 
[remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==)
 | `64.45% <0%> (+0.57%)` | :arrow_up: |
| 
[remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv)
 | `47.93% <0%> (+1.03%)` | :arrow_up: |
| 
[protocol/jsonrpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-cHJvdG9jb2wvanNvbnJwYy9zZXJ2ZXIuZ28=)
 | `61.3% <0%> (+1.5%)` | :arrow_up: |
| 
[protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==)
 | `70.37% <0%> (+2.46%)` | :arrow_up: |
| 
[config\_center/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvbGlzdGVuZXIuZ28=)
 | `86.95% <0%> (+4.34%)` | :arrow_up: |
| ... and [3 
more](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree-more) 
| |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=continue).
> **Legend** - [Click here to learn 
> more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
> Powered by 
> [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=footer). 
> Last update 
> [ef14088...07ef064](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=lastupdated).
>  Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/202 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #202: Add token support

2019-09-17 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=h1) Report
> Merging [#202](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=desc) 
> into 
> [develop](https://codecov.io/gh/apache/dubbo-go/commit/ef14088239f409a85d351c960f1bb02e5691e995?src=pr=desc)
>  will **increase** coverage by `0.05%`.
> The diff coverage is `68.96%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/dubbo-go/pull/202/graphs/tree.svg?width=650=dcPE6RyFAL=150=pr)](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=tree)

```diff
@@ Coverage Diff @@
##   develop #202  +/-   ##
===
+ Coverage65.22%   65.28%   +0.05% 
===
  Files   95   96   +1 
  Lines 6416 6444  +28 
===
+ Hits  4185 4207  +22 
- Misses1791 1798   +7 
+ Partials   440  439   -1
```


| [Impacted 
Files](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-Y29tbW9uL3VybC5nbw==)
 | `68.97% <0%> (-1.64%)` | :arrow_down: |
| 
[protocol/dubbo/dubbo\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9faW52b2tlci5nbw==)
 | `84.09% <100%> (+1.16%)` | :arrow_up: |
| 
[config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv)
 | `65.11% <100%> (+0.83%)` | :arrow_up: |
| 
[filter/impl/token\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-ZmlsdGVyL2ltcGwvdG9rZW5fZmlsdGVyLmdv)
 | `87.5% <87.5%> (ø)` | |
| 
[protocol/jsonrpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-cHJvdG9jb2wvanNvbnJwYy9zZXJ2ZXIuZ28=)
 | `61.3% <0%> (+1.5%)` | :arrow_up: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=continue).
> **Legend** - [Click here to learn 
> more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
> Powered by 
> [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=footer). 
> Last update 
> [ef14088...0888326](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=lastupdated).
>  Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/202 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #202: Add token support

2019-09-17 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=h1) Report
> Merging [#202](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=desc) 
> into 
> [develop](https://codecov.io/gh/apache/dubbo-go/commit/ef14088239f409a85d351c960f1bb02e5691e995?src=pr=desc)
>  will **increase** coverage by `1%`.
> The diff coverage is `68.96%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/dubbo-go/pull/202/graphs/tree.svg?width=650=dcPE6RyFAL=150=pr)](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=tree)

```diff
@@   Coverage Diff@@
##   develop #202   +/-   ##

+ Coverage65.22%   66.23%   +1% 

  Files   95   96+1 
  Lines 6416 6444   +28 

+ Hits  4185 4268   +83 
+ Misses1791 1734   -57 
- Partials   440  442+2
```


| [Impacted 
Files](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-Y29tbW9uL3VybC5nbw==)
 | `68.97% <0%> (-1.64%)` | :arrow_down: |
| 
[config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv)
 | `65.11% <100%> (+0.83%)` | :arrow_up: |
| 
[protocol/dubbo/dubbo\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9faW52b2tlci5nbw==)
 | `84.09% <100%> (+1.16%)` | :arrow_up: |
| 
[filter/impl/token\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-ZmlsdGVyL2ltcGwvdG9rZW5fZmlsdGVyLmdv)
 | `87.5% <87.5%> (ø)` | |
| 
[registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv)
 | `50.5% <0%> (-1.02%)` | :arrow_down: |
| 
[remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==)
 | `64.45% <0%> (+0.57%)` | :arrow_up: |
| 
[remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv)
 | `47.93% <0%> (+1.03%)` | :arrow_up: |
| 
[protocol/jsonrpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-cHJvdG9jb2wvanNvbnJwYy9zZXJ2ZXIuZ28=)
 | `61.3% <0%> (+1.5%)` | :arrow_up: |
| 
[protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==)
 | `70.37% <0%> (+2.46%)` | :arrow_up: |
| ... and [4 
more](https://codecov.io/gh/apache/dubbo-go/pull/202/diff?src=pr=tree-more) 
| |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=continue).
> **Legend** - [Click here to learn 
> more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
> Powered by 
> [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=footer). 
> Last update 
> [ef14088...c88b789](https://codecov.io/gh/apache/dubbo-go/pull/202?src=pr=lastupdated).
>  Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/202 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #3897: add socks5 proxy support to 2.6.x netty4 client

2019-09-17 Thread GitHub
[![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=3897)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you sign our [Contributor License 
Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=3897) before we 
can accept your contribution.**骄龙** seems not to be a GitHub user. 
You need a GitHub account to be able to sign the CLA. If you have already a 
GitHub account, please [add the email address used for this commit to your 
account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).You
 have signed the CLA already but the status is still pending? Let us 
[recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=3897) 
it.

[ Full content available at: https://github.com/apache/dubbo/pull/3897 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on issue #194: Add: new feature to support dynamic config center which compatible with dubbo 2.6.x & 2.7.x

2019-09-17 Thread GitHub
LGTM

[ Full content available at: https://github.com/apache/dubbo-go/pull/194 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks closed pull request #194: Add: new feature to support dynamic config center which compatible with dubbo 2.6.x & 2.7.x

2019-09-17 Thread GitHub
[ pull request closed by AlexStocks ]

[ Full content available at: https://github.com/apache/dubbo-go/pull/194 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] chickenlj commented on issue #4342: parameters config in properties will not take effect

2019-09-17 Thread GitHub
related https://github.com/apache/dubbo/issues/4882

[ Full content available at: https://github.com/apache/dubbo/issues/4342 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #5051: specify service annotation protocol

2019-09-17 Thread GitHub
[![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=5051)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you sign our [Contributor License 
Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=5051) before we 
can accept your contribution.**vghy顾海洋** seems not to be a GitHub 
user. You need a GitHub account to be able to sign the CLA. If you have already 
a GitHub account, please [add the email address used for this commit to your 
account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).You
 have signed the CLA already but the status is still pending? Let us 
[recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=5051) 
it.

[ Full content available at: https://github.com/apache/dubbo/pull/5051 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #5075: dubbo:registry标签 username & password 生效

2019-09-17 Thread GitHub
[![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=5075)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you sign our [Contributor License 
Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=5075) before we 
can accept your contribution.You have signed the CLA already but the 
status is still pending? Let us 
[recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=5075) 
it.

[ Full content available at: https://github.com/apache/dubbo/pull/5075 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #5071: Revert 1 2.7.2 release

2019-09-17 Thread GitHub
[![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=5071)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you all sign our [Contributor License 
Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=5071) before we 
can accept your contribution.**3** out of **6** committers have signed the 
CLA.:white_check_mark: chickenlj:white_check_mark: 
ralf0131:white_check_mark: beiwei30:x: wuwenhui:x: 
uglycow:x: cvictory**wuwenhui** seems not to be a GitHub user. 
You need a GitHub account to be able to sign the CLA. If you have already a 
GitHub account, please [add the email address used for this commit to your 
account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).You
 have signed the CLA already but the status is still pending? Let us [
 recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=5071) 
it.

[ Full content available at: https://github.com/apache/dubbo/pull/5071 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #4811: remove duplicated references from ServiceConfig and ReferenceConfig, keep them in ConfigManager

2019-09-17 Thread GitHub
[![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=4811)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you all sign our [Contributor License 
Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=4811) before we 
can accept your contribution.**1** out of **2** committers have signed the 
CLA.:white_check_mark: mzorro:x: 君时**君时** seems not to 
be a GitHub user. You need a GitHub account to be able to sign the CLA. If you 
have already a GitHub account, please [add the email address used for this 
commit to your 
account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).You
 have signed the CLA already but the status is still pending? Let us 
[recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=4811) 
it.

[ Full content available at: https://github.com/apache/dubbo/pull/4811 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] chickenlj closed issue #4926: 启动报错“Unsupported generic type false”

2019-09-17 Thread GitHub
[ issue closed by chickenlj ]

[ Full content available at: https://github.com/apache/dubbo/issues/4926 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] chickenlj closed pull request #4829: [Dubbo-3629]fix set generic method error

2019-09-17 Thread GitHub
[ pull request closed by chickenlj ]

[ Full content available at: https://github.com/apache/dubbo/pull/4829 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] chickenlj opened pull request #5079: fix set generic method error

2019-09-17 Thread GitHub
## What is the purpose of the change

fixes #3629, #4926

related pr https://github.com/apache/dubbo/pull/4829
related commit 3f7430758f3a15e9b51fbdeaad7455be693579f4

## Brief changelog

X

## Verifying this change

X

Follow this checklist to help us incorporate your contribution quickly and 
easily:

- [x] Make sure there is a 
[GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change 
(usually before you start working on it). Trivial changes like typos do not 
require a GITHUB issue. Your pull request should address just this issue, 
without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when 
host config not exist #XXX`. Each commit in the pull request should have a 
meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a 
little better when cross module dependency exist. If the new feature or 
significant change is committed, please remember to add sample in [dubbo 
samples](https://github.com/apache/dubbo-samples) project.
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile 
failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation 
Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/dubbo/pull/5079 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org