Re: [I] Improve documentation (Web aspect) [dubbo-js]
0808zhongshang commented on issue #374: URL: https://github.com/apache/dubbo-js/issues/374#issuecomment-2078490799 done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] trim application name of old mapping content [dubbo]
sonarcloud[bot] commented on PR #14133: URL: https://github.com/apache/dubbo/pull/14133#issuecomment-2078569260 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=14133) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=14133=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=14133=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=14133=false=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14133=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14133=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=14133) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Triple protocol http1 upgrade support [dubbo]
walklown commented on PR #14026: URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2078563393 > I think so, but we need to confirm whether adding ALPN support cause a regression in protocols other than Triple, such as the Dubbo protocol. Submitted a commit. Please take a look, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[I] [Bug] When calling the interface of the TRIPLE protocol, after a long time of free, it always fails for the first time [dubbo]
Alleninggx opened a new issue, #14131:
URL: https://github.com/apache/dubbo/issues/14131
### Pre-check
- [X] I am sure that all the content I provide is in English.
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/dubbo/issues?q=is%3Aissue) and found no
similar issues.
### Apache Dubbo Component
Java SDK (apache/dubbo)
### Dubbo Version
Dubbo java 3.2.5
Java 21
Spring Boot 3.2.3
Alibaba Spring Cloud 2023.0.0.0-RC1
Seata 2.0
Nacos
### Steps to reproduce this issue
我有一个triple协议的服务，提供了一个读文件的服务端流（详见最底的proto文件，read函数）。
I have a Triple protocol service, which provides a server stream for reading
files (see the bottom Proto file for details, read function).
问题：
Question:
服务启动时，访问此接口是正常的（能打印“bbb”），我命名这次为 Action-A。
但是不做操作过1~2个小时候后，调此接口，就没有再执行成功了（没有打印出“bbb”），我命名这次为 Action-B。
然后紧接着再调用此接口，又正常了，我命名这次为 Action-C。
When the service starts, the access to this interface is normal (it can
print "BBB"), and I named this time Action-A.
However, after 1 to 2 hours, the interface was adjusted, and it was not
successfully executed (the "BBB" was not printed). I named it Action-B this
time.
Then call this interface immediately, it is normal, I named this time
Action-C.
```java
@DubboService(protocol = "tri", retries = 1) // Has been tried to
0 or 1
@RequiredArgsConstructor
public class ExcelFileResourceDubboGrpcImpl implements
ExcelFileResourceDubboGrpc {
@Override
public void read(ReadRequest readRequest, StreamObserver
responseObserver) {
System.err.println("bbb"); // Looking forward to printing
"bbb", but not
}
}
```
```proto
syntax = "proto3";
option java_multiple_files = true;
option java_package = "com.xxx.protobuf.ExcelFileResource";
package proto.ExcelFileResource;
service ExcelFileResourceDubboGrpc {
// 读取
rpc read(ReadRequest) returns (stream ReadResult) {}
// 写出
rpc write(stream WriteRequest) returns (stream WriteResult){}
}
// - 读取 -
message ReadRequest {
string key = 1; // 唯一标识
bool stopWhenError = 2; // 遇到异常是否停止
}
message ReadResult {
ReadStatus status = 1; // 状态
string message = 2; // 消息
int32 rowIndex = 3; // 行号
repeated ReadCol col = 4; // 列数据
repeated ReadHead head = 5;// 头数据，每一行都会携带
}
message ReadHead {
int32 index = 1;// 列号
string name = 2;// 列名
optional string groupName = 3; // 分组名
}
message ReadCol {
int32 index = 1;// 列号
string name = 2;// 列名
string value = 3; // 值
}
enum ReadStatus {
RS_SUCCESS = 0; // 读成功
RS_ERROR = 1; // 读失败
}
// - 写出 -
message WriteRequest {
string orgId = 1; // 机构ID
string service = 2; // 服务名
string excelKey = 3;// 唯一标识
string excelName = 4; // 文件名
string sheetName = 5; // 表名
repeated WriteHead head = 6; // 头数据
repeated WriteRow row = 7; // 行数据
}
message WriteHead {
repeated string head = 1; // 头数据
}
message WriteRow {
repeated string col = 1;// 行数据
}
message WriteResult {
WriteStatus status = 1; // 状态
optional string message = 2;// 消息
}
enum WriteStatus {
WS_CONTINUE = 0;// 继续
WS_SUCCESS = 1; // 写成功
WS_ERROR = 2; // 写失败
}
```
### What you expected to happen
期初我以为是dubbo有关于“长时间空闲”的策略，但是我没找到相关信息。
At first I thought dubbo had a "long idle" policy, but I couldn't find that
information.
然后我尝试增加重试次数，但意外的是，它并不像是“失败”，而是“无响应”，并没触发重试。
I then tried to increase the number of retries, but to my surprise, it
didn't look like "failed", it looked like "no response" and didn't trigger a
retry.
### Anything else
_No response_
### Are you willing to submit a pull request to fix on your own?
- [ ] Yes I am willing to submit a pull request on my own!
### Code of Conduct
- [X] I agree to follow this project's [Code of
Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] fix: Server return with Attachment [dubbo-go]
chickenlj merged PR #2648: URL: https://github.com/apache/dubbo-go/pull/2648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Feature] Move Mesh Rule Router to SPI Extensions [dubbo]
heliang666s commented on issue #13957: URL: https://github.com/apache/dubbo/issues/13957#issuecomment-2078519387 This issue is basically done, I've filed it at apache/dubbo-spi-extensions#307 and the merge was successful. I was a bit busy a while ago and had a little problem left in the msater branch, and I'll fix it recently. Thank you for your concern @wcy666103 @walkinggo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] trim application name of old mapping content [dubbo]
zrlw opened a new pull request, #14133: URL: https://github.com/apache/dubbo/pull/14133 ## What is the purpose of the change enhance MetadataServiceNameMapping to avoid registering duplication service name mapping. see #14132 ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Cherry-pick bug fix from master into 3.1.0 branch [dubbo-spi-extensions]
songxiaosheng merged PR #334: URL: https://github.com/apache/dubbo-spi-extensions/pull/334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Bump to 3.2.1-SNAPSHOT [dubbo-spi-extensions]
songxiaosheng merged PR #333: URL: https://github.com/apache/dubbo-spi-extensions/pull/333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix: After the streaming call ends, client response.tailer() returns empty [dubbo-go]
sonarcloud[bot] commented on PR #2658: URL: https://github.com/apache/dubbo-go/pull/2658#issuecomment-2078512606 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go=2658) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go=2658=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go=2658=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go=2658=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go=2658=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go=2658) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] Improve documentation (Web aspect) [dubbo-js]
0808zhongshang commented on issue #374: URL: https://github.com/apache/dubbo-js/issues/374#issuecomment-2078628513 done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] Improve documentation (Web aspect) [dubbo-js]
0808zhongshang commented on issue #371: URL: https://github.com/apache/dubbo-js/issues/371#issuecomment-2078629116 done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[I] [Feature] enhance service name mapping [dubbo]
zrlw opened a new issue, #14132: URL: https://github.com/apache/dubbo/issues/14132 ### Pre-check - [X] I am sure that all the content I provide is in English. ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dubbo/issues?q=is%3Aissue) and found no similar feature requirement. ### Apache Dubbo Component Java SDK (apache/dubbo) ### Descriptions Some times MetadataReport#getConfigItem will return a service name which is ended by a space character, MetadataServiceNameMapping#map will treat it as a different old service name. Worse still, the service name mapping content will be updated to duplicated format such as "serviceA ,serviceA". Worse still, dubbo client will try to subscribe both "serviceA " and "serviceA", but "serviceA " will not be accepted by Nacos server and the subscription will be broken down by a illegal service name exception. ### Related issues _No response_ ### Are you willing to submit a pull request to fix on your own? - [X] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Triple protocol http1 upgrade support [dubbo]
sonarcloud[bot] commented on PR #14026: URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2078594018 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=14026) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=14026=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=14026=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=14026=false=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14026=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14026=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=14026) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] feat(master): dubbo-samples-triple-reactor proto add java_outer_classname [dubbo-samples]
chickenlj merged PR #1137: URL: https://github.com/apache/dubbo-samples/pull/1137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Feature] Move Mesh Rule Router to SPI Extensions [dubbo]
wcy666103 commented on issue #13957: URL: https://github.com/apache/dubbo/issues/13957#issuecomment-2076523022 Is this issue completed? Is there any progress? I am very interested in this and want to join. @heliang666s -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[I] [Bug] The actual number of connections established is twice what I configured [dubbo]
lpcy opened a new issue, #14129: URL: https://github.com/apache/dubbo/issues/14129 ### Pre-check - [X] I am sure that all the content I provide is in English. ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dubbo/issues?q=is%3Aissue) and found no similar issues. ### Apache Dubbo Component Java SDK (apache/dubbo) ### Dubbo Version Dubbo Java 3.2.5, JDK 1.8, Linux ### Steps to reproduce this issue ### provider config(spring xml) ```xml ``` ### consumer config(spring xml) ```xml ``` ### What you expected to happen After upgrading from Dubbo2 to Dubbo3.2.5, with the same configuration, the actual number of connections is twice normal, meaning that a consumer sends 14 connections to a provider. ### Anything else _No response_ ### Are you willing to submit a pull request to fix on your own? - [ ] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] support custom dubbo invoke retry times [dubbo-go-pixiu]
sonarcloud[bot] commented on PR #625: URL: https://github.com/apache/dubbo-go-pixiu/pull/625#issuecomment-2076503053 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu=625) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu=625=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu=625=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu=625=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu=625) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] support custom dubbo invoke retry times [dubbo-go-pixiu]
mark4z merged PR #625: URL: https://github.com/apache/dubbo-go-pixiu/pull/625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Triple protocol http1 upgrade support [dubbo]
oxsean commented on PR #14026: URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2076522474 > > Test `org.apache.dubbo.demo.provider.ApiProvider` with curl: > > ``` > > curl.exe -v --http2 -k -H "Content-Type: application/json" -d '"asd"' http://127.0.0.1:50051/org.apache.dubbo.demo.GreeterService/sayHelloAsync > > ``` > > > > > > > > > > > > > > > > > > > > > > > > but upgrade failed, could you please take a look?  > > Because you specified a http scheme (and not https), and asked curl to use HTTP/2, then curl will attempt to perform a HTTP/1.1 upgrade to HTTP/2, as can be seen from the logs. > > Typical HTTP/1.1 upgrades are performed using GET, not POST, notably the HTTP/1.1 upgrade to WebSocket. > > The server does not seem to be prepared to accept a POST with a body as an attempt to upgrade and replies with 413 because it does not expect a body. > > If you try a GET without body it will likely succeed. > > Alternatively, if you know that port 8889 accepts prior-knowledge clear-text HTTP/2 (that is, you can send directly HTTP/2 bytes to that port without having to perform a HTTP/1.1 upgrade), you can try: > > `curl -v --http2-prior-knowledge -X POST -k -H "content-type:application/json" -d '["myFirstParameter"]' http://127.0.0.1:50052/org.apache.dubbo.springboot.demo.DemoService/sayHello` > >  > > `$ curl -v --http2-prior-knowledge -X POST -k -H "content-type:application/json" -d '["myFirstParameter"]' http://127.0.0.1:50052/org.apache.dubbo.springboot.demo.DemoService/sayHello Note: Unnecessary use of -X or --request, POST is already inferred. > > * Trying 127.0.0.1:50052... > * Connected to 127.0.0.1 (127.0.0.1) port 50052 > * [HTTP/2] [1] OPENED stream for http://127.0.0.1:50052/org.apache.dubbo.springboot.demo.DemoService/sayHello > * [HTTP/2] [1] [:method: POST] > * [HTTP/2] [1] [:scheme: http] > * [HTTP/2] [1] [:authority: 127.0.0.1:50052] > * [HTTP/2] [1] [:path: /org.apache.dubbo.springboot.demo.DemoService/sayHello] > * [HTTP/2] [1] [user-agent: curl/8.5.0] > * [HTTP/2] [1] [accept: _/_] > * [HTTP/2] [1] [content-type: application/json] > * [HTTP/2] [1] [content-length: 20] > > > POST /org.apache.dubbo.springboot.demo.DemoService/sayHello HTTP/2 > > Host: 127.0.0.1:50052 > > User-Agent: curl/8.5.0 > > Accept: _/_ > > content-type:application/json > > Content-Length: 20 > > < HTTP/2 200 < te: trailers < content-type: application/json < > > * Connection #0 to host 127.0.0.1 left intact > "Hello myFirstParameter"` > > Test `org.apache.dubbo.demo.provider.ApiProvider` with curl: > > ``` > > curl.exe -v --http2 -k -H "Content-Type: application/json" -d '"asd"' http://127.0.0.1:50051/org.apache.dubbo.demo.GreeterService/sayHelloAsync > > ``` > > > > > > > > > > > > > > > > > > > > > > > > but upgrade failed, could you please take a look?
Re: [PR] docs [dubbo-js]
chickenlj merged PR #389: URL: https://github.com/apache/dubbo-js/pull/389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2076624455 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=14073) **Quality Gate passed** Issues  [6 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=14073=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=14073=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=14073=false=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14073=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14073=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=14073) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Task] Introduce new script routing in apache/dubbo-spi-extensions [dubbo]
wcy666103 commented on issue #13864: URL: https://github.com/apache/dubbo/issues/13864#issuecomment-2076528742 Is this issue completed? Is there any progress? I am very interested in this and want to join. @tritone-l -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] docs: common errors & supported browsers and frameworks & getting-started (web aspect) [dubbo-js]
chickenlj merged PR #388: URL: https://github.com/apache/dubbo-js/pull/388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] feat: add commit lint and husky [dubbo-js]
chickenlj merged PR #392: URL: https://github.com/apache/dubbo-js/pull/392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] feat: add commit lint and husky [dubbo-js]
sonarcloud[bot] commented on PR #392: URL: https://github.com/apache/dubbo-js/pull/392#issuecomment-2076439246 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-js=392) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-js=392=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-js=392=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-js=392=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-js=392=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-js=392) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Triple protocol http1 upgrade support [dubbo]
walklown commented on PR #14026: URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2076455166 > Test `org.apache.dubbo.demo.provider.ApiProvider` with curl: > > ``` > curl.exe -v --http2 -k -H "Content-Type: application/json" -d '"asd"' http://127.0.0.1:50051/org.apache.dubbo.demo.GreeterService/sayHelloAsync > ``` > > but upgrade failed, could you please take a look?  Because you specified a http scheme (and not https), and asked curl to use HTTP/2, then curl will attempt to perform a HTTP/1.1 upgrade to HTTP/2, as can be seen from the logs. Typical HTTP/1.1 upgrades are performed using GET, not POST, notably the HTTP/1.1 upgrade to WebSocket. The server does not seem to be prepared to accept a POST with a body as an attempt to upgrade and replies with 413 because it does not expect a body. If you try a GET without body it will likely succeed. Alternatively, if you know that port 8889 accepts prior-knowledge clear-text HTTP/2 (that is, you can send directly HTTP/2 bytes to that port without having to perform a HTTP/1.1 upgrade), you can try: `curl -v --http2-prior-knowledge -X POST -k -H "content-type:application/json" -d '["myFirstParameter"]' http://127.0.0.1:50052/org.apache.dubbo.springboot.demo.DemoService/sayHello`  `$ curl -v --http2-prior-knowledge -X POST -k -H "content-type:application/json" -d '["myFirstParameter"]' http://127.0.0.1:50052/org.apache.dubbo.springboot.demo.DemoService/sayHello Note: Unnecessary use of -X or --request, POST is already inferred. * Trying 127.0.0.1:50052... * Connected to 127.0.0.1 (127.0.0.1) port 50052 * [HTTP/2] [1] OPENED stream for http://127.0.0.1:50052/org.apache.dubbo.springboot.demo.DemoService/sayHello * [HTTP/2] [1] [:method: POST] * [HTTP/2] [1] [:scheme: http] * [HTTP/2] [1] [:authority: 127.0.0.1:50052] * [HTTP/2] [1] [:path: /org.apache.dubbo.springboot.demo.DemoService/sayHello] * [HTTP/2] [1] [user-agent: curl/8.5.0] * [HTTP/2] [1] [accept: */*] * [HTTP/2] [1] [content-type: application/json] * [HTTP/2] [1] [content-length: 20] > POST /org.apache.dubbo.springboot.demo.DemoService/sayHello HTTP/2 > Host: 127.0.0.1:50052 > User-Agent: curl/8.5.0 > Accept: */* > content-type:application/json > Content-Length: 20 > < HTTP/2 200 < te: trailers < content-type: application/json < * Connection #0 to host 127.0.0.1 left intact "Hello myFirstParameter"` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
(dubbo-samples) branch master updated: dubbo-samples-triple-reactor proto add java_outer_classname (#1137)
This is an automated email from the ASF dual-hosted git repository. liujun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git The following commit(s) were added to refs/heads/master by this push: new 8a0a9fd43 dubbo-samples-triple-reactor proto add java_outer_classname (#1137) 8a0a9fd43 is described below commit 8a0a9fd436db7c0e2a7f0de1db47f6822d4e5ade Author: caoyanan666 <55247691+caoyanan...@users.noreply.github.com> AuthorDate: Thu Apr 25 16:31:03 2024 +0800 dubbo-samples-triple-reactor proto add java_outer_classname (#1137) Co-authored-by: caoyanan --- .../protocol/dubbo-samples-triple-reactor/src/main/proto/greeter.proto | 1 + 1 file changed, 1 insertion(+) diff --git a/3-extensions/protocol/dubbo-samples-triple-reactor/src/main/proto/greeter.proto b/3-extensions/protocol/dubbo-samples-triple-reactor/src/main/proto/greeter.proto index 98c726a9d..0270d5633 100644 --- a/3-extensions/protocol/dubbo-samples-triple-reactor/src/main/proto/greeter.proto +++ b/3-extensions/protocol/dubbo-samples-triple-reactor/src/main/proto/greeter.proto @@ -1,6 +1,7 @@ syntax = "proto3"; option java_multiple_files = true; +option java_outer_classname = "GreeterProto"; package org.apache.dubbo.samples.triple.reactor; - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Bug] Dubbo Service was called failed in afterPropertiesSet while application built in native-image [dubbo]
imgoby closed issue #14128: [Bug] Dubbo Service was called failed in afterPropertiesSet while application built in native-image URL: https://github.com/apache/dubbo/issues/14128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Feat security [dubbo-go]
YarBor commented on code in PR #2643:
URL: https://github.com/apache/dubbo-go/pull/2643#discussion_r1579138736
##
istio/channel/xds_client_api_store.go:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package channel
+
+import (
+ "sync"
+
+ "github.com/envoyproxy/go-control-plane/pkg/resource/v3"
+)
+
+type ResponseInfo struct {
+ ResponseNonce string
+ VersionInfo string
+ ResourceNames []string
+}
+
+type ApiStore struct {
+ mutex sync.Mutex
+ responses map[string]*ResponseInfo
+ rdsMutex sync.Mutex
Review Comment:
`rdsMutex`
may be unused field ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Triple protocol http1 upgrade support [dubbo]
walklown commented on PR #14026: URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2076766699 > Please look into whether Application-Layer Protocol Negotiation is supported in addition to h2c: https://matthewparrilla.com/post/negotiation-http2-alpn-tls-handshake/ https://imququ.com/post/protocol-negotiation-in-http2.html > Please look into whether Application-Layer Protocol Negotiation is supported in addition to h2c: https://matthewparrilla.com/post/negotiation-http2-alpn-tls-handshake/ https://imququ.com/post/protocol-negotiation-in-http2.html The current common implementation of ALPN is through extended TLS. TLS processing in Dubbo is in ‘org.apache.dubbo.remoting.transport.netty4.NettyPortUnificationServerHandler’, before confirming the RPC protocol. Extensions to this implementation will have an impact on all RPC protocols. Could you please confirm whether support is needed at this level? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] ignore .iml file for idea and fix eslint error for single quote and semi [dubbo-js]
openlg closed pull request #384: ignore .iml file for idea and fix eslint error for single quote and semi URL: https://github.com/apache/dubbo-js/pull/384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Triple protocol http1 upgrade support [dubbo]
oxsean commented on PR #14026: URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2076845063 > > Please look into whether Application-Layer Protocol Negotiation is supported in addition to h2c: https://matthewparrilla.com/post/negotiation-http2-alpn-tls-handshake/ https://imququ.com/post/protocol-negotiation-in-http2.html > > > Please look into whether Application-Layer Protocol Negotiation is supported in addition to h2c: https://matthewparrilla.com/post/negotiation-http2-alpn-tls-handshake/ https://imququ.com/post/protocol-negotiation-in-http2.html > > The current common implementation of ALPN is through extended TLS. TLS processing in Dubbo is in ‘org.apache.dubbo.remoting.transport.netty4.NettyPortUnificationServerHandler’, before confirming the RPC protocol. Extensions to this implementation will have an impact on all RPC protocols. Could you please confirm whether support is needed at this level? I think so, but we need to confirm whether adding ALPN support cause a regression in protocols other than Triple, such as the Dubbo protocol. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Triple protocol http1 upgrade support [dubbo]
walklown commented on PR #14026: URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2076889743 > > > Test `org.apache.dubbo.demo.provider.ApiProvider` with curl: > > > ``` > > > curl.exe -v --http2 -k -H "Content-Type: application/json" -d '"asd"' http://127.0.0.1:50051/org.apache.dubbo.demo.GreeterService/sayHelloAsync > > > ``` > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > but upgrade failed, could you please take a look?  > > > > > > Because you specified a http scheme (and not https), and asked curl to use HTTP/2, then curl will attempt to perform a HTTP/1.1 upgrade to HTTP/2, as can be seen from the logs. > > Typical HTTP/1.1 upgrades are performed using GET, not POST, notably the HTTP/1.1 upgrade to WebSocket. > > The server does not seem to be prepared to accept a POST with a body as an attempt to upgrade and replies with 413 because it does not expect a body. > > If you try a GET without body it will likely succeed. > > Alternatively, if you know that port 8889 accepts prior-knowledge clear-text HTTP/2 (that is, you can send directly HTTP/2 bytes to that port without having to perform a HTTP/1.1 upgrade), you can try: > > `curl -v --http2-prior-knowledge -X POST -k -H "content-type:application/json" -d '["myFirstParameter"]' http://127.0.0.1:50052/org.apache.dubbo.springboot.demo.DemoService/sayHello` > >  > > `$ curl -v --http2-prior-knowledge -X POST -k -H "content-type:application/json" -d '["myFirstParameter"]' http://127.0.0.1:50052/org.apache.dubbo.springboot.demo.DemoService/sayHello Note: Unnecessary use of -X or --request, POST is already inferred. > > > > * Trying 127.0.0.1:50052... > > * Connected to 127.0.0.1 (127.0.0.1) port 50052 > > * [HTTP/2] [1] OPENED stream for http://127.0.0.1:50052/org.apache.dubbo.springboot.demo.DemoService/sayHello > > * [HTTP/2] [1] [:method: POST] > > * [HTTP/2] [1] [:scheme: http] > > * [HTTP/2] [1] [:authority: 127.0.0.1:50052] > > * [HTTP/2] [1] [:path: /org.apache.dubbo.springboot.demo.DemoService/sayHello] > > * [HTTP/2] [1] [user-agent: curl/8.5.0] > > * [HTTP/2] [1] [accept: _/_] > > * [HTTP/2] [1] [content-type: application/json] > > * [HTTP/2] [1] [content-length: 20] > > > > > POST /org.apache.dubbo.springboot.demo.DemoService/sayHello HTTP/2 > > > Host: 127.0.0.1:50052 > > > User-Agent: curl/8.5.0 > > > Accept: _/_ > > > content-type:application/json > > > Content-Length: 20 > > > > > > < HTTP/2 200 < te: trailers < content-type: application/json < > > > > * Connection #0 to host 127.0.0.1 left intact > > "Hello myFirstParameter"` > > > > Test `org.apache.dubbo.demo.provider.ApiProvider` with curl: > > > ``` > > > curl.exe -v --http2 -k -H "Content-Type: application/json" -d '"asd"' http://127.0.0.1:50051/org.apache.dubbo.demo.GreeterService/sayHelloAsync > > > ``` > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > but upgrade failed, could you please take a look?
Re: [PR] Triple protocol http1 upgrade support [dubbo]
walklown commented on PR #14026: URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2076895079 > > > Please look into whether Application-Layer Protocol Negotiation is supported in addition to h2c: https://matthewparrilla.com/post/negotiation-http2-alpn-tls-handshake/ https://imququ.com/post/protocol-negotiation-in-http2.html > > > > > > > Please look into whether Application-Layer Protocol Negotiation is supported in addition to h2c: https://matthewparrilla.com/post/negotiation-http2-alpn-tls-handshake/ https://imququ.com/post/protocol-negotiation-in-http2.html > > > > > > The current common implementation of ALPN is through extended TLS. TLS processing in Dubbo is in ‘org.apache.dubbo.remoting.transport.netty4.NettyPortUnificationServerHandler’, before confirming the RPC protocol. Extensions to this implementation will have an impact on all RPC protocols. Could you please confirm whether support is needed at this level? > > I think so, but we need to confirm whether adding ALPN support cause a regression in protocols other than Triple, such as the Dubbo protocol. OK, I will submit a commit try to implement it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Feature] Remove zk3.4 support in 3.3 [dubbo]
wcy666103 commented on issue #13960: URL: https://github.com/apache/dubbo/issues/13960#issuecomment-2076967246 Is this issue completed? Is there any progress? I am very interested in this and want to join. @Stellar1999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Triple protocol http1 upgrade support [dubbo]
sonarcloud[bot] commented on PR #14026: URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2076968043 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=14026) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=14026=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=14026=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=14026=false=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14026=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=14026=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=14026) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Feature] Remove zk3.4 support in 3.3 [dubbo]
Stellar1999 commented on issue #13960: URL: https://github.com/apache/dubbo/issues/13960#issuecomment-2077051833 > Is this issue completed? Is there any progress? I am very interested in this and want to join. @Stellar1999 I believe it's nearly complete and just awaiting merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] fix: closing websocket connection returns invalid status code [dubbo-getty]
AlexStocks merged PR #118: URL: https://github.com/apache/dubbo-getty/pull/118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] fix issue116: limit the reconnect times or duration [dubbo-getty]
AlexStocks merged PR #117: URL: https://github.com/apache/dubbo-getty/pull/117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] Is it correct to continue to maintain the connection pool when a connection encounters an error? [dubbo-getty]
AlexStocks closed issue #116: Is it correct to continue to maintain the connection pool when a connection encounters an error? URL: https://github.com/apache/dubbo-getty/issues/116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Triple protocol http1 upgrade support [dubbo]
walklown commented on code in PR #14026:
URL: https://github.com/apache/dubbo/pull/14026#discussion_r1579263649
##
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java:
##
@@ -143,13 +148,63 @@ public void configServerProtocolHandler(URL url,
ChannelOperator operator) {
}
private void configurerHttp1Handlers(URL url, List
handlers) {
-handlers.add(new ChannelHandlerPretender(new HttpServerCodec()));
+final HttpServerCodec sourceCodec = new HttpServerCodec();
+handlers.add(new ChannelHandlerPretender(sourceCodec));
+// Triple protocol http1 upgrade support
+handlers.add(new ChannelHandlerPretender(new
HttpServerUpgradeHandler(sourceCodec, protocol -> {
+if
(!AsciiString.contentEquals(Http2CodecUtil.HTTP_UPGRADE_PROTOCOL_NAME,
protocol)) {
+// Not upgrade request
+return null;
+}
+return buildHttp2ServerUpgradeCodec(url);
+})));
+// If the upgrade was successful, remove the message from the output
list
+// so that it's not propagated to the next handler. This request will
+// be propagated as a user event instead.
handlers.add(new ChannelHandlerPretender(new
HttpObjectAggregator(Integer.MAX_VALUE)));
handlers.add(new ChannelHandlerPretender(new NettyHttp1Codec()));
handlers.add(new ChannelHandlerPretender(new
NettyHttp1ConnectionHandler(
url, frameworkModel,
DefaultHttp11ServerTransportListenerFactory.INSTANCE)));
}
+private Http2ServerUpgradeCodec buildHttp2ServerUpgradeCodec(URL url) {
+Configuration config =
ConfigurationUtils.getGlobalConfiguration(url.getOrDefaultApplicationModel());
+final Http2FrameCodec codec = TripleHttp2FrameCodecBuilder.forServer()
Review Comment:
Down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] fix(3.2): ReactorDubbo3TripleStub.mustache add schema registry [dubbo]
sonarcloud[bot] commented on PR #14035: URL: https://github.com/apache/dubbo/pull/14035#issuecomment-2076736412 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=14035) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=14035=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=14035=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=14035=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=14035) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] Improve documentation (Node aspect) [dubbo-js]
6iKUN6 commented on issue #367: URL: https://github.com/apache/dubbo-js/issues/367#issuecomment-2077629745 I am sorry that I cannot complete this task within the prescribed time due to my study and work. TvT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
