[GitHub] mikewalch closed pull request #204: Updated default Accumulo & Hadoop versions
mikewalch closed pull request #204: Updated default Accumulo & Hadoop versions
URL: https://github.com/apache/fluo-uno/pull/204
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/conf/accumulo/2/accumulo.properties
b/conf/accumulo/2/accumulo.properties
index 49636dd..d0251bf 100755
--- a/conf/accumulo/2/accumulo.properties
+++ b/conf/accumulo/2/accumulo.properties
@@ -5,6 +5,4 @@ instance.volumes=hdfs://UNO_HOST:8020/accumulo
instance.zookeeper.host=UNO_HOST:2181
table.durability=flush
tserver.memory.maps.native.enabled=ACCUMULO_USE_NATIVE_MAP
-tserver.readahead.concurrent.max=64
-tserver.server.threads.minimum=64
tserver.walog.max.size=512M
diff --git a/conf/checksums b/conf/checksums
index b088a55..f8205b5 100644
--- a/conf/checksums
+++ b/conf/checksums
@@ -1,3 +1,4 @@
+accumulo:2.0.0-alpha-1:fbb5a09c9b9033409281a5a7211b7666ad7ddf1b87c9fff15cb961a84ba8f755a383c213f5907a8016dee2cc0490c2e02fcbef3ba7a84c2d64e9d8ed4479d2d3
accumulo:1.9.2:3018d55284940ca22946389c546db3c0dcaca682d49aee8fc031e25321badb8e1e518d5c086906e03e8c53926db5bb79a97daecaee5d1aa5417d46ee2b8a2419
accumulo:1.9.1:7239561833359edf8dcdbee250b27df13feef35bfbf91a6c45f252c6c7712c51d543c21f7621e27b901db20b5a61d11cc8770f10e6e503b6ca42d12ba3657487
accumulo:1.9.0:f68a6145029a9ea843b0305c90a7f5f0334d8a8ceeea94734267ec36421fe7fe
diff --git a/conf/uno.conf b/conf/uno.conf
index b1c20e1..3b6fd53 100644
--- a/conf/uno.conf
+++ b/conf/uno.conf
@@ -3,9 +3,9 @@
# Versions
#
-export HADOOP_VERSION=${HADOOP_VERSION:-2.8.4}
+export HADOOP_VERSION=${HADOOP_VERSION:-3.1.1}
export ZOOKEEPER_VERSION=${ZOOKEEPER_VERSION:-3.4.13}
-export ACCUMULO_VERSION=${ACCUMULO_VERSION:-1.9.2}
+export ACCUMULO_VERSION=${ACCUMULO_VERSION:-2.0.0-alpha-1}
export SPARK_VERSION=${SPARK_VERSION:-1.6.3}
export FLUO_VERSION=${FLUO_VERSION:-1.2.0}
export FLUO_YARN_VERSION=${FLUO_YARN_VERSION:-1.0.0}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] keith-turner commented on a change in pull request #204: Updated default Accumulo & Hadoop versions
keith-turner commented on a change in pull request #204: Updated default Accumulo & Hadoop versions URL: https://github.com/apache/fluo-uno/pull/204#discussion_r225680825 ## File path: conf/accumulo/2/accumulo.properties ## @@ -5,6 +5,5 @@ instance.volumes=hdfs://UNO_HOST:8020/accumulo instance.zookeeper.host=UNO_HOST:2181 table.durability=flush tserver.memory.maps.native.enabled=ACCUMULO_USE_NATIVE_MAP -tserver.readahead.concurrent.max=64 tserver.server.threads.minimum=64 Review comment: I think it makes sense to also remove this setting if removing the other one. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] keith-turner commented on a change in pull request #204: Updated default Accumulo & Hadoop versions
keith-turner commented on a change in pull request #204: Updated default Accumulo & Hadoop versions URL: https://github.com/apache/fluo-uno/pull/204#discussion_r225680576 ## File path: conf/accumulo/2/accumulo.properties ## @@ -5,6 +5,5 @@ instance.volumes=hdfs://UNO_HOST:8020/accumulo instance.zookeeper.host=UNO_HOST:2181 table.durability=flush tserver.memory.maps.native.enabled=ACCUMULO_USE_NATIVE_MAP -tserver.readahead.concurrent.max=64 tserver.server.threads.minimum=64 Review comment: ```suggestion ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] keith-turner closed issue #1003: Refactor remove and init apis to check if running
keith-turner closed issue #1003: Refactor remove and init apis to check if running URL: https://github.com/apache/fluo/issues/1003 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] keith-turner closed pull request #1052: Issue 1003 - Refactor remove and init apis to check if running
keith-turner closed pull request #1052: Issue 1003 - Refactor remove and init
apis to check if running
URL: https://github.com/apache/fluo/pull/1052
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/modules/command/src/main/java/org/apache/fluo/command/FluoInit.java
b/modules/command/src/main/java/org/apache/fluo/command/FluoInit.java
index 7d83f344..c73d8bcd 100644
--- a/modules/command/src/main/java/org/apache/fluo/command/FluoInit.java
+++ b/modules/command/src/main/java/org/apache/fluo/command/FluoInit.java
@@ -134,13 +134,6 @@ public static void main(String[] args) {
try (FluoAdminImpl admin = new FluoAdminImpl(config)) {
- if (admin.applicationRunning()) {
-System.err.println("Error - The Fluo '" + config.getApplicationName()
+ "' application"
-+ " is already running and must be stopped before running 'fluo
init'. "
-+ " Aborted initialization.");
-System.exit(-1);
- }
-
FluoAdmin.InitializationOptions initOpts = new
FluoAdmin.InitializationOptions();
if (opts.getUpdate()) {
@@ -185,14 +178,16 @@ public static void main(String[] args) {
System.out.println("Initializing Fluo '" + config.getApplicationName()
+ "' application using " + opts.getAppPropsPath());
- try {
-admin.initialize(initOpts);
- } catch (Exception e) {
-System.out.println("Initialization failed due to the following
exception:");
-e.printStackTrace();
-System.exit(-1);
- }
+
+ admin.initialize(initOpts);
System.out.println("Initialization is complete.");
+} catch (FluoAdmin.AlreadyInitializedException e) {
+ System.err.println(e.getMessage());
+ System.exit(-1);
+} catch (Exception e) {
+ System.out.println("Initialization failed due to the following
exception:");
+ e.printStackTrace();
+ System.exit(-1);
}
}
}
diff --git
a/modules/command/src/main/java/org/apache/fluo/command/FluoRemove.java
b/modules/command/src/main/java/org/apache/fluo/command/FluoRemove.java
index 0c337d23..5426e414 100644
--- a/modules/command/src/main/java/org/apache/fluo/command/FluoRemove.java
+++ b/modules/command/src/main/java/org/apache/fluo/command/FluoRemove.java
@@ -15,7 +15,9 @@
package org.apache.fluo.command;
+import org.apache.fluo.api.client.FluoAdmin;
import org.apache.fluo.api.config.FluoConfiguration;
+import org.apache.fluo.api.exceptions.FluoException;
import org.apache.fluo.core.client.FluoAdminImpl;
public class FluoRemove {
@@ -30,22 +32,16 @@ public static void main(String[] args) {
config = FluoAdminImpl.mergeZookeeperConfig(config);
try (FluoAdminImpl admin = new FluoAdminImpl(config)) {
- if (admin.applicationRunning()) {
-System.err.println("Error - The Fluo '" + config.getApplicationName()
+ "' application"
-+ " is already running and must be stopped before running 'fluo
remove'. "
-+ " Aborted remove.");
-System.exit(-1);
- }
System.out.println("Removing Fluo '" + config.getApplicationName());
- try {
-admin.remove();
- } catch (Exception e) {
-System.out.println("Remove failed due to the following exception:");
-e.printStackTrace();
-System.exit(-1);
- }
+ admin.remove();
System.out.println("Remove is complete.");
-
+} catch (FluoException e) {
+ System.err.println(e.getMessage());
+ System.exit(-1);
+} catch (Exception e) {
+ System.out.println("Remove failed due to the following exception:");
+ e.printStackTrace();
+ System.exit(-1);
}
}
}
diff --git
a/modules/core/src/main/java/org/apache/fluo/core/client/FluoAdminImpl.java
b/modules/core/src/main/java/org/apache/fluo/core/client/FluoAdminImpl.java
index 8bea85f5..40563665 100644
--- a/modules/core/src/main/java/org/apache/fluo/core/client/FluoAdminImpl.java
+++ b/modules/core/src/main/java/org/apache/fluo/core/client/FluoAdminImpl.java
@@ -107,7 +107,11 @@ public void initialize(InitializationOptions opts)
Preconditions.checkArgument(
config.getObserverJarsUrl().isEmpty() ||
config.getObserverInitDir().isEmpty(),
"Only one of 'fluo.observer.init.dir' and 'fluo.observer.jars.url' can
be set");
-
+if (applicationRunning()) {
+ throw new AlreadyInitializedException("Error - The Fluo '" +
config.getApplicationName()
+ + "' application" + " is already running and must be stopped before
initializing. "
+ + " Aborted initialization.");
+}
if (zookeeperInitialized() && !opts.getClearZookeeper()) {
throw new AlreadyInitializedException(
"Fluo application already initialized at " +
[GitHub] mikewalch commented on issue #204: Updated default Accumulo & Hadoop versions
mikewalch commented on issue #204: Updated default Accumulo & Hadoop versions URL: https://github.com/apache/fluo-uno/pull/204#issuecomment-430297862 Added another commit to remove deprecated property This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
