[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313718#comment-16313718
 ] 

ASF GitHub Bot commented on FREEMARKER-55:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-freemarker/pull/42


> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it 
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring 
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are 
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is 
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the 
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313714#comment-16313714
 ] 

ASF GitHub Bot commented on FREEMARKER-55:
--

GitHub user woonsan opened a pull request:

https://github.com/apache/incubator-freemarker/pull/42

FREEMARKER-55: cleanups by improving StringToIndexMap and CallableUtils



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/woonsan/incubator-freemarker 
feature/FREEMARKER-55-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-freemarker/pull/42.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #42


commit 0f45c1da0b372b56d3c3808837a4060778c97834
Author: Woonsan Ko 
Date:   2018-01-05T18:54:03Z

FREEMARKER-55: cleanups with new #of(StringToIndexMap, Entry...)

commit ba39a0bc5031dc1fe02b422895f0518ce7a5e713
Author: Woonsan Ko 
Date:   2018-01-05T18:56:49Z

FREEMARKER-55: remove unused _ArrayUtils

commit ce78134ece2ad0df653538ebdd244bd0a5806679
Author: Woonsan Ko 
Date:   2018-01-05T19:20:40Z

FREEMARKER-55: moving #getLastPredefinedNamedArgumentIndex() to 
CallableUtils




> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it 
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring 
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are 
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is 
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the 
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311932#comment-16311932
 ] 

ASF GitHub Bot commented on FREEMARKER-55:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-freemarker/pull/41


> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it 
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring 
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are 
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is 
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the 
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309125#comment-16309125
 ] 

ASF GitHub Bot commented on FREEMARKER-55:
--

GitHub user woonsan opened a pull request:

https://github.com/apache/incubator-freemarker/pull/41

FREEMARKER-55: Spring MVC Form Support (1) - :form and :input directives



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/woonsan/incubator-freemarker 
feature/FREEMARKER-55-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-freemarker/pull/41.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #41


commit 150ad7f6039446e2d0e3ee66010abe5be920d8d1
Author: Woonsan Ko 
Date:   2017-12-23T04:21:37Z

FREEMARKER-55: skeletal design

commit fb2ae5cc81c4160c7bc694e0d85b8d979a61db49
Author: Woonsan Ko 
Date:   2017-12-23T22:43:33Z

FREEMARKER-55: skeletal unit test for input tag

commit ff2feb0402d806731bd64e6132952d1c14026b85
Author: Woonsan Ko 
Date:   2017-12-27T05:29:52Z

FREEMARKER-55: Adding TagOutputter

commit 2b5e9b7cb8bda5065e475339f3ec9dd854848b0a
Author: Woonsan Ko 
Date:   2017-12-28T06:26:54Z

FREEMARKER-55: make attribute arguments explicit

commit ae94a3d494ac1da64c89e70a4f021170f064730c
Author: Woonsan Ko 
Date:   2017-12-30T04:54:07Z

FREEMARKER-55: unit tests for form.input directive

commit aa264af1bce93e0891c9551b8c494185471e5727
Author: Woonsan Ko 
Date:   2017-12-30T04:59:13Z

FREEMARKER-55: make it public for consistency

commit 1f7100cee9ca2e1c2c28e4bc5bded6e4857677ec
Author: Woonsan Ko 
Date:   2017-12-30T06:07:12Z

FREEMARKER-55: Adding skeletal form directive

commit 045c980cfcbc96b258334aaf467145914864
Author: Woonsan Ko 
Date:   2018-01-03T04:03:55Z

FREEMARKER-55: Adding tests and polishing




> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it 
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring 
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are 
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is 
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the 
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171156#comment-16171156
 ] 

ASF GitHub Bot commented on FREEMARKER-55:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-freemarker/pull/36


> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it 
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring 
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are 
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is 
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the 
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167951#comment-16167951
 ] 

ASF GitHub Bot commented on FREEMARKER-55:
--

GitHub user woonsan opened a pull request:

https://github.com/apache/incubator-freemarker/pull/36

FREEMARKER-55: stringifying string/boolean/date model in url function…

…. otherwise exception

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/woonsan/incubator-freemarker 
feature/FREEMARKER-55-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-freemarker/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #36


commit 4779234b67bb9c6ab0f0812d72ebe4b2152de04a
Author: Woonsan Ko 
Date:   2017-09-15T14:39:26Z

FREEMARKER-55: stringifying string/boolean/date model in url function. 
otherwise exception




> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it 
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring 
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are 
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is 
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the 
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164923#comment-16164923
 ] 

ASF GitHub Bot commented on FREEMARKER-55:
--

GitHub user woonsan opened a pull request:

https://github.com/apache/incubator-freemarker/pull/35

FREEMARKER-55: 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/woonsan/incubator-freemarker 
feature/FREEMARKER-55-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-freemarker/pull/35.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #35


commit 40bd07b718262e30345c082ec4794ab2535b5fd8
Author: Woonsan Ko 
Date:   2017-09-13T14:49:36Z

FREEMARKER-55: narrow class/method visibilities as possible.

commit 3f6ee183ab87e193c4eaa465652d5d8b204cd992
Author: Woonsan Ko 
Date:   2017-09-13T16:14:08Z

FREEMARKER-55: introducing CallableUtils#getAndUnwrap...(...) utils.

commit f6abc3054e1fb571c221d874c2c2ed37bb8ecf7c
Author: Woonsan Ko 
Date:   2017-09-13T16:21:10Z

FREEMARKER-55: simplifying test examples with no interim vars




> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it 
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring 
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are 
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is 
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the 
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164402#comment-16164402
 ] 

ASF GitHub Bot commented on FREEMARKER-55:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-freemarker/pull/34


> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it 
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring 
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are 
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is 
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the 
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164044#comment-16164044
 ] 

ASF GitHub Bot commented on FREEMARKER-55:
--

GitHub user woonsan opened a pull request:

https://github.com/apache/incubator-freemarker/pull/34

FREEMARKER-55: Spring Directives/Functions to replace spring.tld tags



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/woonsan/incubator-freemarker 
feature/FREEMARKER-55-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-freemarker/pull/34.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #34


commit 6709117683e29b34a6e155cac30a160f86f95745
Author: Woonsan Ko 
Date:   2017-08-26T05:17:07Z

FREEMARKER-55: trying with a directive to replace spring:bind jsp tag.

commit 19a3277c5809e30243a921a2ee42d3a40ecf9ebc
Author: Woonsan Ko 
Date:   2017-08-29T03:11:12Z

FREEMARKER-55: using namespace variable for status variable.

commit b656f1e1f7c1b0875526f2224db1fc793e1172d2
Author: Woonsan Ko 
Date:   2017-08-29T18:58:34Z

FREEMARKER-55: use nested content parameter instead of variable

commit aeaf0307736008b2921c7efa42cf7d31b2df6dbc
Author: Woonsan Ko 
Date:   2017-08-30T03:02:21Z

FREEMARKER-55: splitting abstract class to keep common things

commit 64adad829926532b17ce5a5965a2c40e594dd6fc
Author: Woonsan Ko 
Date:   2017-08-30T03:07:29Z

FREEMARKER-55: simple clean up

commit 2de73b082f1bf7c36d616263688f77d27bc50227
Author: Woonsan Ko 
Date:   2017-08-30T13:07:02Z

FREEMARKER-55: code clean ups

commit 63f42c3dfcb06b7873e7aec58c90894e8b291ced
Author: Woonsan Ko 
Date:   2017-08-30T13:21:55Z

FREEMARKER-55: Adding javadocs

commit f1e8a4df1a745164bcf48ab9a92cec5beb598bc2
Author: Woonsan Ko 
Date:   2017-09-03T02:11:45Z

Merge branch '3' into feature/FREEMARKER-55-2

commit 3b83475f111019842b6070581ca310890ba199d1
Author: Woonsan Ko 
Date:   2017-09-03T03:49:38Z

FREEMARKER-55: Adding initial message function.

commit 8f5eaaaf2df1914fef461802f2d7b511d4a99870
Author: Woonsan Ko 
Date:   2017-09-03T04:08:31Z

FREEMARKER-55: read message args from positioned vargs.

commit b0aceddab9ac55c622fb596d2ed03444c2ff0884
Author: Woonsan Ko 
Date:   2017-09-03T04:27:08Z

FREEMARKER-55: use vargs for code and args

commit a8e73ec77a735b643be986e0c190205f3b7a2192
Author: Woonsan Ko 
Date:   2017-09-05T12:33:55Z

Using CallableUtils to throw exceptions; use positional param for code

commit 12f70fff2db494e91bbc9926c76e529d781f4f18
Author: Woonsan Ko 
Date:   2017-09-06T14:01:10Z

FREEMARKER-55: Adding more spring callable models.

commit d0bd43c8e42a9b5b2834a2d5c139401fcb8fda2d
Author: Woonsan Ko 
Date:   2017-09-06T14:02:01Z

Merge branch '3' into feature/FREEMARKER-55-2

commit 234f96ec2c2868c72f797bda42a8d0c854e63b87
Author: Woonsan Ko 
Date:   2017-09-08T16:21:53Z

FREEMARKER-55: Adding more functions.

commit 9eedd86da2dc6aeac011e0e1553871599b80ab18
Author: Woonsan Ko 
Date:   2017-09-11T17:41:52Z

Merge branch '3' into feature/FREEMARKER-55-2

commit 6f025c79534117a0f87eb17445e1a76cf06be418
Author: Woonsan Ko 
Date:   2017-09-11T18:13:56Z

FREEMARKER-55: use Environment variables instead of pageContext in eval 
function.

commit 8bdc5fdcf6507a00113e8f396cdf9a90c8c3857c
Author: Woonsan Ko 
Date:   2017-09-11T19:45:46Z

FREEMARKER-55: Adding url function

commit 075bd88777888a12a194844f8b961c8bd7333a49
Author: Woonsan Ko 
Date:   2017-09-11T19:51:01Z

FREEMARKER-55: fixing NPE when there's no params

commit 834abd7d6f338ee7fcc5bdaa060ce2d36495fc8b
Author: Woonsan Ko 
Date:   2017-09-11T20:50:45Z

FREEMARKER-55: code cleanups

commit 2076c5e83786b5253ea80651f4a47ea87f263fd0
Author: Woonsan Ko 
Date:   2017-09-11T21:14:39Z

FREEMARKER-55: Removing mvcUrl function as it's not in earlier version of 
spring 4.0.x

commit 96c038d9ccc4a5d38cc8896370870d27af46af1f
Author: Woonsan Ko 
Date:   2017-09-12T03:21:50Z

FREEMARKER-55: unit test template code

commit d5c31a1b4e5753e7dbbeb1b1971c3b9bcf5643e4
Author: Woonsan Ko 
Date:   2017-09-12T03:24:37Z

FREEMARKER-55: unit test template code

commit 77b7f30c5f61158c138f42e0f61c3b47b8df6d2d
Author: Woonsan Ko 
Date:   2017-09-12T14:58:28Z

[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

[Daniel Dekany (JIRA)]

[ 
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115740#comment-16115740
 ] 

Daniel Dekany commented on FREEMARKER-55:
-

See answer on the mailing list!

> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it 
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring 
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are 
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is 
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the 
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115649#comment-16115649
 ] 

ASF GitHub Bot commented on FREEMARKER-55:
--

GitHub user woonsan opened a pull request:

https://github.com/apache/incubator-freemarker/pull/31

FREEMARKER-55: spring.ftl marco lib support

- Support <#import "/spring.ftl" as spring> like Spring Framework does.
- By default, the system lib from /spring.ftl is read from the specific 
classpath, not from app's template path.
   The system template aliases map can be customized through 
SpringResourceTemplateLoader.systemTemplateAliases property.
- The same macros and functions are defined in /spring.ftl as Spring 
Framework's, with syntax changes to comply with FM3.
- Note: As the system template lib support is handled by 
SpringTemplateLoader in this PR, it means developers should always use 
SpringTemplateLoader directly or indirectly in order to use the system macro 
library. Please review this decision.
- TODOs: review/test/refine each macro and functions in spring.ftl.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/woonsan/incubator-freemarker 
feature/FREEMARKER-55

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-freemarker/pull/31.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #31


commit 8e0f33c419d982279d7fb22a9dfdc66f47abaf2c
Author: Woonsan Ko 
Date:   2017-07-14T15:27:17Z

FREEMARKER-55: Renaming Freemarker to FreeMarker

commit ec8d687d4ce2c0e1bb3e3ca073b139eacc198527
Author: Woonsan Ko 
Date:   2017-07-14T15:53:51Z

Merge branch '3' into feature/FREEMARKER-55

commit e7cb6f7cfc241689c85527971bf6e1ea7ced9127
Author: Woonsan Ko 
Date:   2017-07-14T17:57:29Z

Merge branch '3' into feature/FREEMARKER-55

commit c6eb09de91e57035c1e0e3c4d3490b3b96622bab
Author: Woonsan Ko 
Date:   2017-07-16T18:24:55Z

Merge branch '3' into feature/FREEMARKER-55

commit 870209fa8e0acd0bb3186053dfd549b5c758e37d
Author: Woonsan Ko 
Date:   2017-07-18T00:38:03Z

Merge branch '3' into feature/FREEMARKER-55

commit 4481406a2f4eeb30d6d044a4ac158efab7ba7a7b
Author: Woonsan Ko 
Date:   2017-08-06T01:28:54Z

Merge branch '3' into feature/FREEMARKER-55

commit fcd9e672ec515e3042bc5efd229b7d12c23e7d88
Author: Woonsan Ko 
Date:   2017-08-06T05:09:12Z

FREEMARKER-55: system template lib for spring app: spring.ftl.




> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it 
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring 
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are 
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is 
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the 
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090837#comment-16090837
 ] 

ASF GitHub Bot commented on FREEMARKER-55:
--

Github user woonsan closed the pull request at:

https://github.com/apache/incubator-freemarker/pull/28


> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it 
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring 
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are 
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is 
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the 
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087489#comment-16087489
 ] 

ASF GitHub Bot commented on FREEMARKER-55:
--

GitHub user woonsan opened a pull request:

https://github.com/apache/incubator-freemarker/pull/28

FREEMARKER-55: Renaming Freemarker to FreeMarker



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/woonsan/incubator-freemarker 
feature/FREEMARKER-55

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-freemarker/pull/28.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #28


commit 8e0f33c419d982279d7fb22a9dfdc66f47abaf2c
Author: Woonsan Ko 
Date:   2017-07-14T15:27:17Z

FREEMARKER-55: Renaming Freemarker to FreeMarker




> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it 
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring 
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are 
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is 
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the 
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

[Woonsan Ko (JIRA)]

[ 
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087480#comment-16087480
 ] 

Woonsan Ko commented on FREEMARKER-55:
--

{{AbstractTemplateView}} has an option to put every attribute to model, but the 
option is turned off by default.
And, 
{{org.springframework.web.servlet.view.freemarker.FreeMarkerView#buildTemplateModel(Map, HttpServletRequest, HttpServletResponse)}} does put the 
{{FreemarkerServlet}} variables again *for some reason*.
My guess is probably {{FreemarkerServlet}} variables are more efficient than 
iterating and copying the attributes in {{AbstractTemplateView}}. Anyway, 
that's my guess. So did I.
I'll create a new pull request with renaming *Freemarker* to *FreeMarker*.

> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it 
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring 
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are 
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is 
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the 
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087172#comment-16087172
 ] 

ASF GitHub Bot commented on FREEMARKER-55:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-freemarker/pull/27


> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it 
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring 
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are 
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is 
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the 
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

[Daniel Dekany (JIRA)]

[ 
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087039#comment-16087039
 ] 

Daniel Dekany commented on FREEMARKER-55:
-

At the first glance {{RequestContext }} doesn't expose the 
request/session/application attributes and request parameters. However, there 
are options in {{AbstractTemplateView}} to add such attributes to the model 
(not grouped by scope though). I haven't dig into this, but maybe then these 
{{FreemarkerServlet}} variables shouldn't be there in Spring. Just a thought 
tho', I have no experience with this.

BTW, the official name of the project is {{FreeMarker}} with capital {{M}}. The 
{{FreemarkerServlet}} class from FM2 is not consistent with that, and it should 
be renamed in FM3. The new {{FreemarkerView}} and {{AbstractFreemarkerView}} 
classes should also be renamed.

> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it 
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring 
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are 
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is 
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the 
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

[Woonsan Ko (JIRA)]

[ 
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086481#comment-16086481
 ] 

Woonsan Ko commented on FREEMARKER-55:
--

Yeah, {{org.springframework.web.servlet.view.AbstractTemplateView}} puts the 
{{RequestContext}} object (by name of {{springMacroRequestContext}}) into 
{{model}}.
As our {{FreemarkerView}} extends it, the attribute should still exist as well 
in the model.

> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it 
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring 
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are 
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is 
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the 
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

[Daniel Dekany (JIRA)]

[ 
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086339#comment-16086339
 ] 

Daniel Dekany commented on FREEMARKER-55:
-

BTW, as of to expose or not to expose the Servlet request and such to 
templates, seems that the Spring MVC way is accessing such technical objects 
through {{springMacroRequestContext}}. (I have just bumped into this here: 
https://stackoverflow.com/questions/45086859/how-to-get-a-request-object-in-freemarker)

> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it 
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring 
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are 
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is 
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the 
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

[Daniel Dekany (JIRA)]

[ 
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086333#comment-16086333
 ] 

Daniel Dekany commented on FREEMARKER-55:
-

I have commented on the last pull request (#27) on Github... seems Jira doesn't 
pick it up, so see there.

> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it 
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring 
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are 
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is 
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the 
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086310#comment-16086310
 ] 

ASF GitHub Bot commented on FREEMARKER-55:
--

GitHub user woonsan opened a pull request:

https://github.com/apache/incubator-freemarker/pull/27

FREEMARKER-55: Add default tld sources



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/woonsan/incubator-freemarker 
feature/FREEMARKER-55

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-freemarker/pull/27.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #27


commit 576b0ff3b266da40b26e46a8d66efe6353884a36
Author: Woonsan Ko 
Date:   2017-07-13T19:42:19Z

FREEMARKER-55: Add default tld sources (tld files in web-inf/lib/*.jar) 
like FreemarkerServlet does.

commit 36e04dfceff14d6604067e3e05e59f0cf8b042f7
Author: Woonsan Ko 
Date:   2017-07-13T19:43:26Z

Merge branch '3' into feature/FREEMARKER-55




> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it 
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring 
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are 
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is 
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the 
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

[Daniel Dekany (JIRA)]

[ 
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16076169#comment-16076169
 ] 

Daniel Dekany commented on FREEMARKER-55:
-

I wanted to fix some JavaDoc build errors, and was "carried away" and changed a 
few other small things along the way... hope it's not a problem; see the commit 
messages for details.

As of exposing things in {{FreemarkerViewResolver}}, originally I was only 
referred to exposing things to the templates. Like, if you have the 
{{Request}}, {{Session}}, and {{Application}} variables in templates. On second 
thought, as we allow calling JSP taglibs, we might as well should expose those. 
I'm not sure yet.

> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it 
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring 
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are 
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is 
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the 
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16076147#comment-16076147
 ] 

ASF GitHub Bot commented on FREEMARKER-55:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-freemarker/pull/26


> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it 
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring 
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are 
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is 
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the 
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

[Woonsan Ko (JIRA)]

[ 
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075734#comment-16075734
 ] 

Woonsan Ko commented on FREEMARKER-55:
--

Hi [~ddekany],

I've created a new PR based on your reviews like the following:
- Switched Servlet spec dependency to 3.0 and jsp-api/EL dependencies to 2.2.
- I've set the spring dependency version to 4.0.x (4.0.9.RELEASE) as a minimal 
servlet-spec 3.0 based framework.
- Made {{TaglibFactory}} immutable and add {{Builder}} extending 
{{CommonBuilder}} inside the {{TaglibFactory}}.
- Moved {{SpringResourceTemplateLoader}} to {{org.apache.freemarker.spring}} 
package.

Regarding "the existing Spring macros/functions", yes, I agree. We'll need to 
add new macros/functions.

Regarding "FreemarkerViewResolver exposing things like FreemarkerServlet: ...", 
{{FreemarkerViewResolver}} doesn't expose {{FreemarkerServlet}}, but it uses 
only constants defined in the {{FreemarkerServlet}} to use the same attribute 
names, for instance. It used to expose some 'protected' getters/setters for the 
internal {{GenericServlet}} (for page object in JSP taglibs), {{ObjectWrapper}} 
and {{ServletContextModel}}, but those were removed now. Used only internally 
now.
BTW, {{View}} of Spring Framework is dependent on {{HttpServletRequest}} and 
{{HttpServletResponse}}. So, {{pageContextServlet}}, {{servletContextModel}} 
and {{taglibFactory}} in {{FreemarkerView}} (passed by 
{{FreemarkerViewResolver}}) should be okay.

Regards,

Woonsan

> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it 
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring 
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are 
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is 
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the 
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

[Daniel Dekany (JIRA)]

[ 
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073381#comment-16073381
 ] 

Daniel Dekany commented on FREEMARKER-55:
-

Even if the existing Spring macros/function work now (haven't checked it), they 
won't for very long, as the FM3 template language will become quite different. 
So eventually we will have to rewrite them anyway.

As of switching {{freemarker-servlet}} to Servlet 3.0, I guess that's fine (and 
then JSP switches to 2.2 too).

I have noticed that we depend on a very specific Spring version, 4.3.9.RELEASE. 
Note sure if it was a conscious decision.
Will that be the minimum required version? 4.3.x is quite recent.

As of {{TaglibFactoryBuilder}}, since {{TaglibFactory}} is mutable, I'm not 
sure how introducing {{TaglibFactoryBuilder}} helps at the moment. Yes,
there are some functionality there that wasn't public earlier, but technically, 
that could have been added to {{TaglibFactory}}
as well. But, probably it would be nicer if {{TaglibFactory}} is immutable, and 
then a builder is needed of course. 
Also, I think it would be good to stick to the particular builder flavor that 
we have introduced for {{Configuration}} and such.
(That is, {{Builder}} is a nested class that implements {{CommonBuilder}}, the 
built object is immutable, etc.)

{{FreemarkerViewResolver}} exposing things like {{FreemarkerServlet}}: I don't 
know what the Spring-ish way is. Exposing HTTP- and Servlet-specific objects to 
FreeMarker templates stinks in general, but I know little about the Spring 
front-end development reality, and thus if it's practical to expose them. In 
the case of {{FreemarkerServlet}} it clearly was, as the goal was to help 
integration with legacy JSP-based frameworks, where playing with these 
Serlvet-specific objects in views was normal. Also, I don't know if Spring has 
its own utilities to access these things (which it exposes to views), because 
then we might don't want to duplicate that functionality.

I think we will be better of with 
{{org.apache.freemarker.spring.SpringResourceTemplateLoader}}
than with 
{{org.apache.freemarker.spring.templateresolver.SpringResourceTemplateLoader}} 
(package name differs). The idea
is that, in general, classes people commonly use (in this case in the Spring 
configuration) should be
in the root package of the module ({{org.apache.freemarker.spring}}). So both 
{{ConfigurationFactoryBean}}
and {{SpringResourceTemplateLoader}} should be there (unless we will have much 
more "templatresolver"-related classes).

Side note: As of {{}} in the example, note that 
unlike in FM2's spring integration, in reality that should only be used to 
apply a piece of configuration that comes from a .properties file or other 
externally provided {{Properties}} object. That is, almost never. We might 
discover some things to improve if we try do things with the setter methods 
only (like, creating the {{CacheStorage}} will be kind of awkward, and so might 
need improvement).

Eventually, the short description changes should be added to 
{{FM3-CHANGE-LOG.txt}}.


> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it 
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring 
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are 
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is 
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the 
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073253#comment-16073253
 ] 

ASF GitHub Bot commented on FREEMARKER-55:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-freemarker/pull/25


> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it 
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring 
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are 
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is 
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the 
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

[Woonsan Ko (JIRA)]

[ 
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073099#comment-16073099
 ] 

Woonsan Ko commented on FREEMARKER-55:
--

Initial pull request submitted:
- https://github.com/apache/incubator-freemarker/pull/25

This initial pull request contains the following:
- FreemarkerView and FreemarkerViewResolver. So, it is now possible to use this 
new view and resolver with the ConfigurationFactoryBean, I think, with a 
configuration like the following:
{code}
  

  

  

  
UTF-8
true
strong:20, soft:250
 
   
   
  


  


  

  

  
{code}
- So, we don't need something like {{FreeMarkerConfigurer}} which is referred 
to implicitly by type in spring lib, but the view resolver should be configured 
with a {{Configuration}} explicitly.
- As {{FreeMarkerViewResolver}} extends {{AbstractTemplateViewResolver}} of 
spring, I believe the existing macros of spring should be supported as-is. I 
didn't verify this though.
- Still we will probably need to consider how we can provide better "custom 
directives/methods" for templating in spring env than the existing ones in 
spring lib.
- FreemarkerViewResolver exposes servlet context model, request 
attribute/parameter models, session model and JSP TaglibFactory,  by default, 
like FreemarkerServlet does.
  (I just thought it wouldn't do any harm by providing those by default. Not 
sure yet if we should make them optional.)

TODOs:
- See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is 
hard coded into ViewResolverRegistry, which we can't modify)
- Consider better "custom directives/methods" for templating in spring env.
- Integration testing in a simple web application module?

> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it 
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring 
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are 
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is 
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the 
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073085#comment-16073085
 ] 

ASF GitHub Bot commented on FREEMARKER-55:
--

GitHub user woonsan opened a pull request:

https://github.com/apache/incubator-freemarker/pull/25

FREEMARKER-55: Freemarker View and ViewResolver implementation



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/woonsan/incubator-freemarker 
feature/FREEMARKER-55

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-freemarker/pull/25.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #25


commit 584b46b86aee16134f1f1c9e6d2cdb79bb7f8016
Author: Woonsan Ko 
Date:   2017-06-28T20:18:14Z

FREEMARKER-55: Adding skeletal FreemarkerView

commit ec2d37c6dbf19ec4aca839b9bea737e0881e0f02
Author: Woonsan Ko 
Date:   2017-06-28T20:19:19Z

Merge branch '3' into feature/FREEMARKER-55

commit 334d9cde950f06e480027d3064e53b6c1cfa54e2
Author: Woonsan Ko 
Date:   2017-06-29T03:36:49Z

FREEMARKER-55: adding model building code.

commit 36b0694f335c319946f908729be95f1808f23b2a
Author: Woonsan Ko 
Date:   2017-06-29T04:41:17Z

FREEMARKER-55: Adding more tests regarding FreemarkerView's model

commit 8e8c724b6f2ae003c67c4bc0c41fb026c0b9f6ad
Author: Woonsan Ko 
Date:   2017-06-29T05:21:40Z

FREEMARKER-55: Adding test for Application attributes.

commit cb4fab3ae483d2fb645d296aff0ab94c78a8d4b9
Author: Woonsan Ko 
Date:   2017-06-30T03:30:47Z

FREEMARKER-55: Add TaglibFactoryBuilder to reuse TaglibFactory creation 
logic

commit c2589eeb0517006715d427b591d186fafff7a32b
Author: Woonsan Ko 
Date:   2017-06-30T03:31:44Z

Merge branch '3' into feature/FREEMARKER-55

commit 83e896c01ebe2fd3fa5b0997f6ee177ccbeed2f5
Author: Woonsan Ko 
Date:   2017-06-30T03:56:20Z

FREEMARKER-55: Adding FreemarkerViewResolver

commit 9083de1ba04d9d54b80109ed86941da72337cba5
Author: Woonsan Ko 
Date:   2017-07-02T05:25:01Z

Adding FreemarkerViewResolver and improving FreemarkerViewTest with 
JspTaglibFactory and example.

commit b375e1478f3ef3f5c12ac51890454c810e3dc057
Author: Woonsan Ko 
Date:   2017-07-02T05:25:49Z

Merge branch '3' into feature/FREEMARKER-55

commit 4088f91f62b678d2c4bebc25375d7fc822f47420
Author: Woonsan Ko 
Date:   2017-07-02T06:22:52Z

FREEMARKER-55: Adding FreemarkerViewResolverTest

commit 6ff7849be9bc71ee6fe81f4db6ab3530d7c8296e
Author: Woonsan Ko 
Date:   2017-07-04T02:23:05Z

Merge branch '3' into feature/FREEMARKER-55

commit c5e9fe30857c3175a777df62416caff283ed6fea
Author: Woonsan Ko 
Date:   2017-07-04T04:03:43Z

polishing API and javadocs.

commit 53d9ef941514945310f6df642faf558d996256bf
Author: Woonsan Ko 
Date:   2017-07-04T04:13:26Z

FREEMARKER-55: polising javadocs




> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it 
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring 
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are 
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is 
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the 
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)