[GitHub] [geode] demery-pivotal opened a new pull request #5425: DO NOT REVIEW: Use ephemeral port knocking to find and "reserve" free ports.
demery-pivotal opened a new pull request #5425:
URL: https://github.com/apache/geode/pull/5425
Co-Authored-by Jacob Barrett
Co-Authored-by: Dale Emery
diff --git
a/geode-core/src/distributedTest/java/org/apache/geode/cache30/ReconnectWithClusterConfigurationDUnitTest.java
b/geode-core/src/distributedTest/java/org/apache/geode/cache30/ReconnectWithClusterConfigurationDUnitTest.java
index 1c8f92c282..cc66ac198b 100644
---
a/geode-core/src/distributedTest/java/org/apache/geode/cache30/ReconnectWithClusterConfigurationDUnitTest.java
+++
b/geode-core/src/distributedTest/java/org/apache/geode/cache30/ReconnectWithClusterConfigurationDUnitTest.java
@@ -33,7 +33,6 @@ import java.io.IOException;
import java.io.Serializable;
import java.net.UnknownHostException;
import java.nio.file.Paths;
-import java.util.List;
import java.util.Properties;
import java.util.concurrent.TimeUnit;
@@ -49,7 +48,6 @@ import org.apache.geode.distributed.DistributedSystem;
import org.apache.geode.distributed.Locator;
import org.apache.geode.distributed.internal.InternalLocator;
import
org.apache.geode.distributed.internal.membership.api.MembershipManagerHelper;
-import org.apache.geode.internal.AvailablePort;
import org.apache.geode.internal.AvailablePortHelper;
import org.apache.geode.internal.inet.LocalHostUtil;
import org.apache.geode.test.awaitility.GeodeAwaitility;
@@ -79,18 +77,12 @@ public class ReconnectWithClusterConfigurationDUnitTest
implements Serializable
@Before
public void setup() throws IOException {
-List randomAvailableTCPPortKeepers =
-AvailablePortHelper.getRandomAvailableTCPPortKeepers(NUM_LOCATORS);
-for (int i = 0; i < NUM_LOCATORS; i++) {
- AvailablePort.Keeper keeper = randomAvailableTCPPortKeepers.get(i);
- locatorPorts[i] = keeper.getPort();
-}
+locatorPorts =
AvailablePortHelper.getRandomAvailableTCPPorts(NUM_LOCATORS);
final int[] locPorts = locatorPorts;
Invoke.invokeInEveryVM("set locator ports", () -> locatorPorts =
locPorts);
for (int i = 0; i < NUM_LOCATORS; i++) {
final String workingDir =
temporaryFolder.newFolder().getAbsolutePath();
final int locatorNumber = i;
- randomAvailableTCPPortKeepers.get(locatorNumber).release();
VM.getVM(i).invoke("start locator", () -> {
try {
Disconnect.disconnectFromDS();
diff --git
a/geode-core/src/distributedTest/java/org/apache/geode/distributed/DistributedSystemDUnitTest.java
b/geode-core/src/distributedTest/java/org/apache/geode/distributed/DistributedSystemDUnitTest.java
index bde5458fd6..5bdf35c950 100644
---
a/geode-core/src/distributedTest/java/org/apache/geode/distributed/DistributedSystemDUnitTest.java
+++
b/geode-core/src/distributedTest/java/org/apache/geode/distributed/DistributedSystemDUnitTest.java
@@ -102,7 +102,7 @@ public class DistributedSystemDUnitTest extends
JUnit4DistributedTestCase {
this.locatorPort = getRandomAvailablePort(SOCKET);
this.tcpPort = getRandomAvailablePort(SOCKET);
-int[] portRange = getRandomAvailableTCPPortRange(3, true);
+int[] portRange = getRandomAvailableTCPPortRange(3);
this.lowerBoundOfPortRange = portRange[0];
this.upperBoundOfPortRange = portRange[portRange.length - 1];
}
diff --git
a/geode-core/src/distributedTest/java/org/apache/geode/distributed/LocatorDUnitTest.java
b/geode-core/src/distributedTest/java/org/apache/geode/distributed/LocatorDUnitTest.java
index 2a01cd6430..4d86091fe5 100644
---
a/geode-core/src/distributedTest/java/org/apache/geode/distributed/LocatorDUnitTest.java
+++
b/geode-core/src/distributedTest/java/org/apache/geode/distributed/LocatorDUnitTest.java
@@ -1115,13 +1115,12 @@ public class LocatorDUnitTest implements
Serializable {
@Test
public void testConcurrentLocatorStartup() throws Exception {
-List portKeepers =
-AvailablePortHelper.getRandomAvailableTCPPortKeepers(4);
+final int[] ports = AvailablePortHelper.getRandomAvailableTCPPorts(4);
StringBuilder sb = new StringBuilder(100);
-for (int i = 0; i < portKeepers.size(); i++) {
- AvailablePort.Keeper keeper = portKeepers.get(i);
- sb.append("localhost[").append(keeper.getPort()).append("]");
- if (i < portKeepers.size() - 1) {
+for (int i = 0; i < ports.length; i++) {
+ final int port = ports[i];
+ sb.append("localhost[").append(port).append("]");
+ if (i < ports.length - 1) {
sb.append(',');
}
}
@@ -1129,12 +1128,10 @@ public class LocatorDUnitTest implements
Serializable {
Properties dsProps = getClusterProperties(locators, "false");
-List> asyncInvocations = new
ArrayList<>(portKeepers.size());
+List> asyncInvocation
[GitHub] [geode] davebarnes97 merged pull request #5423: GEODE-8401: User Guide - incorrect method name on "forced disconnect"…
davebarnes97 merged pull request #5423: URL: https://github.com/apache/geode/pull/5423 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] demery-pivotal closed pull request #5406: DO NOT REVIEW Wip/available ports
demery-pivotal closed pull request #5406: URL: https://github.com/apache/geode/pull/5406 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] agingade opened a new pull request #5424: GEODE-8394: Rewind the message Part on command failure
agingade opened a new pull request #5424: URL: https://github.com/apache/geode/pull/5424 This change rewinds the message part on command failure. Without this during retry on failure, the message (Part) is sent from the place where it was previously failed, instead of starting from the beginning, causing it to transmit partial data. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [Y] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [Y] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [Y] Is your initial contribution a single, squashed commit? - [Y] Does `gradlew build` run cleanly? - [Y] Have you written or updated unit tests to verify your changes? - [NA] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #5390: ClassLoader isolation
lgtm-com[bot] commented on pull request #5390: URL: https://github.com/apache/geode/pull/5390#issuecomment-668876145 This pull request **introduces 2 alerts** and **fixes 2** when merging c50c3429756811ed64e13675f2faa83b49daa71f into 53abb22cd295441f8794e15550b72ec81113ec05 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-f91407182dc9824056f00ce3dba01a7e9cf1c7fd) **new alerts:** * 2 for Potential input resource leak **fixed alerts:** * 2 for Unused variable, import, function or class This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] davebarnes97 opened a new pull request #5423: GEODE-8401: User Guide - incorrect method name on "forced disconnect"…
davebarnes97 opened a new pull request #5423: URL: https://github.com/apache/geode/pull/5423 … page `Cache.waitForReconnect(long, TimeUnit)` should be `Cache.waitUntilReconnected(long, TimeUnit)` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] bschuchardt opened a new pull request #5422: GEODE-6950: hot loop in PrimaryHandler.processRequest()
bschuchardt opened a new pull request #5422: URL: https://github.com/apache/geode/pull/5422 The ticket had a suggested fix for the locator's hot loop and I've implemented that. I modified PrimaryHandler to make the issue testable and added a couple of other tests for registered and fallback request handlers. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #5390: ClassLoader isolation
lgtm-com[bot] commented on pull request #5390: URL: https://github.com/apache/geode/pull/5390#issuecomment-668746687 This pull request **introduces 2 alerts** and **fixes 2** when merging f855cfcb31700189d22469648e8584b483c006ba into 53abb22cd295441f8794e15550b72ec81113ec05 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-f97fceacbf49c3cf2581689ae3ba930cdebc609d) **new alerts:** * 2 for Potential input resource leak **fixed alerts:** * 2 for Unused variable, import, function or class This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-native] alb3rtobr commented on pull request #628: GEODE-8344: Add GatewaySenderEventCallbackArgument class
alb3rtobr commented on pull request #628: URL: https://github.com/apache/geode-native/pull/628#issuecomment-668701694 Sorry for the late answer, I have been on vacation. I have changed the PR to draft because Im still working on the tests. I have added some functionality to the integration test framework in order to reproduce configure two clusters to reproduce the error, but I still have a problem with a disk access exception when configuring gateway senders. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode
onichols-pivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r465158361 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +cd .. +git clone --config transfer.fsckObjects=false https://github.com/prettyClouds/redis.git +cd redis +git checkout tests-geode-redis + +JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64" \ Review comment: If Robert were around today he might know a way to get it from gradle's testJVM property when gradle invokes the redis script, but this might work too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode
onichols-pivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r465158361 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +cd .. +git clone --config transfer.fsckObjects=false https://github.com/prettyClouds/redis.git +cd redis +git checkout tests-geode-redis + +JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64" \ Review comment: If Robert were around today he might know a way to get it from gradle's testJVM property when gradle invokes the redis script, but this works too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode
sabbeyPivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r465148577 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +cd .. +git clone --config transfer.fsckObjects=false https://github.com/prettyClouds/redis.git +cd redis +git checkout tests-geode-redis + +JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64" \ Review comment: Just pushed an update to execute_tests.sh that sets the JAVA_TEST_PATH variable so it's accessible inside the execute_redis_tests script. It passes here: https://concourse.gemfire-ci.info/teams/developer/pipelines/sabbeypivotal-new-pr-pr/jobs/RedisTestOpenJDK11/builds/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] bschuchardt closed pull request #5265: work in progress
bschuchardt closed pull request #5265: URL: https://github.com/apache/geode/pull/5265 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode
sabbeyPivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r464665951 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +cd .. +git clone --config transfer.fsckObjects=false https://github.com/prettyClouds/redis.git +cd redis +git checkout tests-geode-redis + +JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64" \ Review comment: I updated this, but I'm wondering if we'll have access to the JAVA_TEST_PATH variable in this script? Attempting to check it now... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
