[GitHub] [geode] PurelyApplied commented on issue #2569: GEODE-5804: Improve checkPom task
It seems like the actual `checkPom` task is only examining `` blocks and not any other data. So, on the one hand, the existing behavior was "copy the actual pom to the expected pom" is what's happening, but a developer will then need to examine which difference should actually be added to their commit. So that's strange and we should decide if `checkPom` should also be checking, for instance, the `` for consistency. Or decide that what goes into a diff is just developer responsibility. [ Full content available at: https://github.com/apache/geode/pull/2569 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on issue #2569: GEODE-5804: Improve checkPom task
I had been poking at it to make sure it's still good. I was getting some strange behavior where `./gradlew uEP` updates the assembly pom with ``` diff --git a/geode-assembly/src/test/resources/expected-pom.xml b/geode-assembly/src/test/resources/expected-pom.xml index 3f8abf5e57..b22bc8f393 100644 --- a/geode-assembly/src/test/resources/expected-pom.xml +++ b/geode-assembly/src/test/resources/expected-pom.xml @@ -20,7 +20,7 @@ org.apache.geode apache-geode 1.8.0-SNAPSHOT - pom + tgz Apache Geode Apache Geode provides a database-like consistency model, reliable transaction processing and a shared-nothing architecture to maintain very low latency performance with high concurrency processing http://geode.apache.org ``` It had been the dependency block I'd messed with to make sure I hadn't broken `checkPom`, so I don't know if there is just some dirty artifact there. Need to play with it a little more. [ Full content available at: https://github.com/apache/geode/pull/2569 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
