[GitHub] [geode] PurelyApplied commented on pull request #2915: GEODE-6117: Makes modules out of geode-core and geode-cq
Ah, makes sense and good to hear. [ Full content available at: https://github.com/apache/geode/pull/2915 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on pull request #2915: GEODE-6117: Makes modules out of geode-core and geode-cq
Always love to see these simple sorts of cleanups. [ Full content available at: https://github.com/apache/geode/pull/2915 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on pull request #2915: GEODE-6117: Makes modules out of geode-core and geode-cq
Just a reminder that, by popular request, `spotless` will no longer remove extra whitespace within a line, even if the result will no longer exceed the 80-width limit. For instance, this line's diff isn't necessary for spotless (but I assume it was at some point during your iteration). [ Full content available at: https://github.com/apache/geode/pull/2915 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on pull request #2915: GEODE-6117: Makes modules out of geode-core and geode-cq
I'm really not a fan of bloating out the `ext` in our project / subprojects. Is there a reason this shouldn't just be in-lined below? [ Full content available at: https://github.com/apache/geode/pull/2915 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on pull request #2915: GEODE-6117: Makes modules out of geode-core and geode-cq
Ditto `ext` comment in core. [ Full content available at: https://github.com/apache/geode/pull/2915 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on pull request #2915: GEODE-6117: Makes modules out of geode-core and geode-cq
I don't really know what this file is documenting, but every other version here is wildly out of date [ Full content available at: https://github.com/apache/geode/pull/2915 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
