[GitHub] [geode] dschneider-pivotal commented on pull request #2950: GEODE-6142: Check JDBC mapping before destroy region

2018-12-06 Thread GitHub
will do

[ Full content available at: https://github.com/apache/geode/pull/2950 ]
This message was relayed via gitbox.apache.org for 
notifications@geode.apache.org


[GitHub] [geode] dschneider-pivotal commented on pull request #2950: GEODE-6142: Check JDBC mapping before destroy region

2018-12-06 Thread GitHub
will do

[ Full content available at: https://github.com/apache/geode/pull/2950 ]
This message was relayed via gitbox.apache.org for 
notifications@geode.apache.org


[GitHub] [geode] dschneider-pivotal commented on pull request #2950: GEODE-6142: Check JDBC mapping before destroy region

2018-12-06 Thread GitHub
apis do not change cluster config. Other than that api region destroy does what 
it always has done. The only additional thing you would want to remove when 
using the apis is the async queue on the cache. Of course this is already true 
for the apis; if the region is the last one using the queue then destroy region 
does not remove that queue.

[ Full content available at: https://github.com/apache/geode/pull/2950 ]
This message was relayed via gitbox.apache.org for 
notifications@geode.apache.org


[GitHub] [geode] dschneider-pivotal commented on pull request #2950: GEODE-6142: Check JDBC mapping before destroy region

2018-12-05 Thread GitHub
Because the only public way we have of destroying a jdbc-mapping is a gfsh 
command. All those other examples also have public apis that let you remove the 
other thing. Although at least some of your examples do not prevent a region 
from being destroyed (cache writer and loader; I don't know about cqs and 
indexes). The goal here is to help the gfsh user but not the api user.

[ Full content available at: https://github.com/apache/geode/pull/2950 ]
This message was relayed via gitbox.apache.org for 
notifications@geode.apache.org