[GitHub] [geode] gesterzhou commented on a change in pull request #5391: GEODE-7846: Adding Stats for Partitioned Region Clear

2020-08-03 Thread GitBox 


gesterzhou commented on a change in pull request #5391:
URL: https://github.com/apache/geode/pull/5391#discussion_r464583502



##
File path: 
geode-core/src/main/java/org/apache/geode/internal/cache/CachePerfStats.java
##
@@ -274,7 +278,14 @@
 "Current number of regions configured for reliablity that are missing 
required roles with Limited access";
 final String reliableRegionsMissingNoAccessDesc =
 "Current number of regions configured for reliablity that are missing 
required roles with No access";
-final String clearsDesc = "The total number of times a clear has been done 
on this cache.";
+final String regionClearsDesc =
+"The total number of times a clear has been done on this cache.";
+final String bucketClearsDesc =
+"The total number of times a clear has been done on this region and 
it's bucket regions";
+final String partitionedRegionClearLocalDurationDesc =
+"The time in nanoseconds partitioned region clear has been running for 
the region on this member";

Review comment:
   we have to follow other duration stats's timeunit. If other duration 
stats used nanoseconds, we use it too. Otherwise, we should not.  





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [geode] gesterzhou commented on a change in pull request #5391: GEODE-7846: Adding Stats for Partitioned Region Clear

2020-08-03 Thread GitBox 


gesterzhou commented on a change in pull request #5391:
URL: https://github.com/apache/geode/pull/5391#discussion_r464581367



##
File path: 
geode-core/src/main/java/org/apache/geode/internal/cache/CachePerfStats.java
##
@@ -274,7 +278,14 @@
 "Current number of regions configured for reliablity that are missing 
required roles with Limited access";
 final String reliableRegionsMissingNoAccessDesc =
 "Current number of regions configured for reliablity that are missing 
required roles with No access";
-final String clearsDesc = "The total number of times a clear has been done 
on this cache.";
+final String regionClearsDesc =
+"The total number of times a clear has been done on this cache.";

Review comment:
   on this cache? or on this region?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [geode] gesterzhou commented on a change in pull request #5391: GEODE-7846: Adding Stats for Partitioned Region Clear

2020-08-03 Thread GitBox 


gesterzhou commented on a change in pull request #5391:
URL: https://github.com/apache/geode/pull/5391#discussion_r464551192



##
File path: 
geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java
##
@@ -344,7 +344,12 @@ void incClearCount(LocalRegion lr) {
 if (lr != null && !(lr instanceof HARegion)) {
   CachePerfStats stats = lr.getCachePerfStats();
   if (stats != null) {
-stats.incClearCount();
+if (lr instanceof BucketRegion) {

Review comment:
   Usually we use:  if (owner.isUsedForPartitionedRegionBucket()) { 
instead. 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org