[GitHub] [geode] mkevo commented on pull request #7368: GEODE-10055: fix AbstractLauncher to print info and debug with stdout
mkevo commented on PR #7368: URL: https://github.com/apache/geode/pull/7368#issuecomment-1154808661 > I am quite certain this is intentional. Perhaps it is worth a conversation on dev@geode to see if we want to change this. Hi @pivotal-jbarrett, why do you think that this is intentional? I saw that it prints messages like _'Getting Locator status using working directory'_. Not sure that this should be printed as an error, maybe I'm wrong, but need some clarification of your thoughts. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mkevo commented on pull request #7368: GEODE-10055: fix AbstractLauncher to print info and debug with stdout
mkevo commented on PR #7368: URL: https://github.com/apache/geode/pull/7368#issuecomment-1144863457 @echobravopapa, @kamilla1201, @Bill, can you please review this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mkevo commented on pull request #7368: GEODE-10055: fix AbstractLauncher to print info and debug with stdout
mkevo commented on PR #7368: URL: https://github.com/apache/geode/pull/7368#issuecomment-1120843776 @echobravopapa, @kamilla1201, @Bill, can you please review this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mkevo commented on pull request #7368: GEODE-10055: fix AbstractLauncher to print info and debug with stdout
mkevo commented on PR #7368: URL: https://github.com/apache/geode/pull/7368#issuecomment-1116101659 @echobravopapa, @kamilla1201, @Bill, can you please review this small change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mkevo commented on pull request #7368: GEODE-10055: fix AbstractLauncher to print info and debug with stdout
mkevo commented on PR #7368: URL: https://github.com/apache/geode/pull/7368#issuecomment-1103729509 > This change should be ok, but I think it needs some sort of test. Hi @kirklund , The PR only changes the log level of some messages, so I don't think that we need test as we don't change any functionality. BR, Mario -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mkevo commented on pull request #7368: GEODE-10055: fix AbstractLauncher to print info and debug with stdout
mkevo commented on pull request #7368: URL: https://github.com/apache/geode/pull/7368#issuecomment-1073655740 @echobravopapa, @Bill, @kirklund, @kamilla1201, can you please add your review on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
