[GitHub] [geode-native] gaussianrecurrence commented on pull request #969: GEODE-10276: Refactor PDX (de)serialization code
gaussianrecurrence commented on PR #969: URL: https://github.com/apache/geode-native/pull/969#issuecomment-1130249492 @pivotal-jbarrett I've addressed all of your comments, plus I've fixed some logic issues and introduced some changes, mostly to cover all edge cases. Additionally, added a bunch of new tests to verify the functionality refactored by the change. So long store sort, I've marked the PR as ready for review, any comments are welcomed :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-native] gaussianrecurrence commented on pull request #969: GEODE-10276: Refactor PDX (de)serialization code
gaussianrecurrence commented on PR #969: URL: https://github.com/apache/geode-native/pull/969#issuecomment-1122476087 > I realize this is a draft but was excited to take a peek and noticed this one right away. Yes, this is a WIP, there are some minor changes i yet want to make, and whole lot more of tests that I want to add, given the size of the change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
