[GitHub] [geode] joeymcallister commented on pull request #3932: GEODE 6872: Add Non-Sticky configuration information to Tomcat Session module documentation
I'm confused about changing the title to "non-sticky" and changing the description to "non-stick." [ Full content available at: https://github.com/apache/geode/pull/3932 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] mcmellawatt closed pull request #3933: GEODE-7090: Copy message to isolate filter info calculation
[ pull request closed by mcmellawatt ] [ Full content available at: https://github.com/apache/geode/pull/3933 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] bschuchardt closed pull request #3930: DO NOT REVIEW: Remove dependency on DataSerializer from membership classes
[ pull request closed by bschuchardt ] [ Full content available at: https://github.com/apache/geode/pull/3930 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kirklund closed pull request #3904: GEODE-7070: Remove AlertAppender usage from GMSMembershipManager
[ pull request closed by kirklund ] [ Full content available at: https://github.com/apache/geode/pull/3904 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kirklund commented on issue #3904: GEODE-7070: Remove AlertAppender usage from GMSMembershipManager
Closing this PR to investigate potential for appender recursion more. [ Full content available at: https://github.com/apache/geode/pull/3904 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] pivotal-jbarrett commented on issue #3921: GEODE-7083: Adds statistics to PeerTypeRegistration
I defaulted to the interface and class name but don’t have a strong preference either way. PDX is likely more recognizable by customers. [ Full content available at: https://github.com/apache/geode/pull/3921 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] mcmellawatt opened pull request #3939: GEODE-7088: Copy message to isolate filter info calculation
This fix is to handle a very specific race condition scenario as described here: Subscription HA is enabled and a server is providing a client queue image to a peer (serializing the queue). Meanwhile, a client is also just finished client subscription registration with that same server and is recalculating its filter info to determine if the client needs the event. Recalculating the filter info results in the client message in the HAContainer to be mutated, which causes a ConcurrentModificationException to occur in the GII provider thread. The fix we landed on is to make a copy of the client update message when recalculating the filter info in the drain logic from the client registration queue. This guarantees that there will be no shared state between the GII thread and the client registration thread, and it also covers the case that multiple clients are calculating the filter info on the same event and potentially in contention. Co-authored-by: Ryan McMahon Co-authored-by: Donal Evans Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [X] Is your initial contribution a single, squashed commit? - [X] Does `gradlew build` run cleanly? - [X] Have you written or updated unit tests to verify your changes? - [N/A] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. [ Full content available at: https://github.com/apache/geode/pull/3939 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] upthewaterspout opened pull request #3940: GEODE-7085: Add dunit test of recovery with large versions
Adding a dunit test that we can recover from disk store files with a large gc version. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. [ Full content available at: https://github.com/apache/geode/pull/3940 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] codecov-io commented on issue #510: GEODE-7086: coding impacts for support of IPv6
# [Codecov](https://codecov.io/gh/apache/geode-native/pull/510?src=pr=h1) Report > Merging > [#510](https://codecov.io/gh/apache/geode-native/pull/510?src=pr=desc) > into > [develop](https://codecov.io/gh/apache/geode-native/commit/be5013eee46360fa8a962fe4f7da91de22bd83cf?src=pr=desc) > will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/geode-native/pull/510?src=pr=tree) ```diff @@ Coverage Diff@@ ## develop #510 +/- ## Coverage73.25% 73.25% Files 648 648 Lines5185551855 Hits 3798837988 Misses 1386713867 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/geode-native/pull/510?src=pr=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/geode-native/pull/510?src=pr=footer). > Last update > [be5013e...19070db](https://codecov.io/gh/apache/geode-native/pull/510?src=pr=lastupdated). > Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). [ Full content available at: https://github.com/apache/geode-native/pull/510 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] joeymcallister commented on pull request #3932: GEODE 6872: Add Non-Sticky configuration information to Tomcat Session module documentation
I don't have a strong preference between "non-sticky" and "non-stick," but I do think that we ought to use one term consistently, both within this section/page and across other pages within the documentation. [ Full content available at: https://github.com/apache/geode/pull/3932 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] joeymcallister commented on pull request #3932: GEODE 6872: Add Non-Sticky configuration information to Tomcat Session module documentation
"compilter" > "compiler" [ Full content available at: https://github.com/apache/geode/pull/3932 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] Bill commented on issue #3937: GEODE-7092: increase flaky test MEMBER_TIMEOUT
@mcmellawatt please review and merge if you are happy [ Full content available at: https://github.com/apache/geode/pull/3937 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] demery-pivotal opened pull request #3942: GEODE-7099: Clean up MeterSubregistryReconnectDistributedTest
Co-authored-by: Dale Emery Co-authored-by: Kirk Lund Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [X] Is your initial contribution a single, squashed commit? - [X] Does `gradlew build` run cleanly? - [X] Have you written or updated unit tests to verify your changes? Please review @aaronlindsey [ Full content available at: https://github.com/apache/geode/pull/3942 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on issue #3936: GEODE-6945: expand the type to related xml attributes
@dschneider-pivotal please re-review. I changed the approach: instead of not expanding the attributes in `CreateRegionCommand`, I chose to expand it everywhere, including the `RegionConverter`. This is because I found the subsequent code kind of relying on the DataPolicy being set all the time in xml configuration objects. If we don't do this, we get NPE everywhere, so it's easier just to expand it. [ Full content available at: https://github.com/apache/geode/pull/3936 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] mcmellawatt closed pull request #3937: GEODE-7092: increase flaky test MEMBER_TIMEOUT
[ pull request closed by mcmellawatt ] [ Full content available at: https://github.com/apache/geode/pull/3937 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] mcmellawatt closed pull request #3916: DO NOT REVIEW: Replacing queue map with list
[ pull request closed by mcmellawatt ] [ Full content available at: https://github.com/apache/geode/pull/3916 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kirklund closed pull request #3938: GEODE-7091: Add Micrometer binders to meter registry
[ pull request closed by kirklund ] [ Full content available at: https://github.com/apache/geode/pull/3938 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] mivanac commented on pull request #510: GEODE-7086: coding impacts for support of IPv6
Tried this proposal, and in test, in case hostname is not resolved, get_addr() returns pointer (it is not nullptr). [ Full content available at: https://github.com/apache/geode-native/pull/510 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
