[GitHub] [geode] onichols-pivotal merged pull request #7770: GEODE-10355: Bump spring-security from 5.2.12 to 5.5.8
onichols-pivotal merged PR #7770: URL: https://github.com/apache/geode/pull/7770 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] onichols-pivotal merged pull request #7769: GEODE-10355: Bump spring-security from 5.4.8 to 5.6.5
onichols-pivotal merged PR #7769: URL: https://github.com/apache/geode/pull/7769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] smgoller opened a new pull request, #7800: [GEODE-10369] if scratch ssd is used, fall back to n1 machine type.
smgoller opened a new pull request, #7800: URL: https://github.com/apache/geode/pull/7800 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] pivotal-jbarrett commented on pull request #7211: GEODE-10354: Convert enum like classes to enum.
pivotal-jbarrett commented on PR #7211: URL: https://github.com/apache/geode/pull/7211#issuecomment-1154370976 @upthewaterspout, this brings up an excellent question. Does the use of the `Serializable` interface outside of the direct API, which does not utilize it, constitute part of the binary compatibility contract for a public class. Our API or internals do not transmit the classes in question as serializables but the test framework does. As a result of having the `Serializable` interface on the class are we stuck making sure that external use of this class maintains serialization compatibility? If the answer to this is yes, then it will likely put a damper on future mutation of types that either directly or indirectly, like `enum`, implement `Serializable`. There are many issues with versioning `Serializable` classes that may force us to consider `@Deprecated` annotations on these sorts of types and making new types to replace them anytime we want to mutate them. If the answer is no, then how should we communicate this to users? We could define a `@NotSerializable` annotation and Javadoc tag to hopefully inform the user not to use it in serialization. We could implement the write/readObject methods and throw exceptions to prevent it at runtime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] mkevo merged pull request #7643: GEODE-10267: fix creating gw sender with non-existent disk store
mkevo merged PR #7643: URL: https://github.com/apache/geode/pull/7643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] albertogpz commented on a diff in pull request #7747: GEODE-10334: Send alert when thread stuck for long
albertogpz commented on code in PR #7747:
URL: https://github.com/apache/geode/pull/7747#discussion_r89587
##
geode-core/src/main/java/org/apache/geode/internal/monitoring/executor/AbstractExecutor.java:
##
@@ -51,9 +56,25 @@ protected AbstractExecutor(String groupName, long threadID) {
public void handleExpiry(long stuckTime, Map
threadInfoMap) {
incNumIterationsStuck();
+sendAlertForThreadStuckForLong(stuckTime, threadInfoMap);
logger.warn(createThreadReport(stuckTime, threadInfoMap));
}
+ private void sendAlertForThreadStuckForLong(long stuckTime, Map threadInfoMap) {
+if (maxThreadStuckTime <= 0) {
+ return;
+}
+if (threadInfoMap.get(threadID) == null) {
+ return;
+}
+if (stuckForGood) {
+ return;
+}
+if (stuckTime > maxThreadStuckTime) {
+ stuckForGood = true;
+ logger.fatal(createThreadReport(stuckTime, threadInfoMap));
Review Comment:
@kirklund I think the alert will not be generated by default if `error` is
used. In order to see the alert when using `error`, the `alertLevel` in the
`DistributedMXBean` should be changed from `severe` to a lower level.
See
https://geode.apache.org/docs/guide/114/managing/management/notification_federation_and_alerts.html
Anyhow, I agree with you that it makes sense to use `error` given that
having a thread stuck is not necessarily a catastrophic failure that may result
in data corruption.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] smgoller merged pull request #7798: GEODE-10369 part 2 Fix hardcoded gcp project reference and adjust windows unit test cpu/ram usage.
smgoller merged PR #7798: URL: https://github.com/apache/geode/pull/7798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on a diff in pull request #7759: Fixes for cleaning GCP resources from pipelines
onichols-pivotal commented on code in PR #7759: URL: https://github.com/apache/geode/pull/7759#discussion_r895956599 ## ci/pipelines/clean_fork_pipelines.sh: ## @@ -22,10 +25,11 @@ while [ -h "$SOURCE" ]; do # resolve $SOURCE until the file is no longer a symli done SCRIPTDIR="$( cd -P "$( dirname "$SOURCE" )" && pwd )" -TARGET=geode +TARGET=concourse.apachegeode-ci.info Review Comment: should be `concourse.apachegeode-ci.info-main` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] smgoller opened a new pull request, #7798: GEODE-10369 part 2 Fix hardcoded gcp project reference and adjust windows unit test cpu/ram usage.
smgoller opened a new pull request, #7798: URL: https://github.com/apache/geode/pull/7798 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
