[jira] [Commented] (GROOVY-8623) Groovy Object Browser within Groovy Console could show Groovy version in about help
[ https://issues.apache.org/jira/browse/GROOVY-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16535005#comment-16535005 ] Jacek Musiał commented on GROOVY-8623: -- Hello, World! I have made pull request to solve this task. [https://github.com/apache/groovy/pull/771] > Groovy Object Browser within Groovy Console could show Groovy version in > about help > --- > > Key: GROOVY-8623 > URL: https://issues.apache.org/jira/browse/GROOVY-8623 > Project: Groovy > Issue Type: Improvement >Reporter: Paul King >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GROOVY-8623) Groovy Object Browser within Groovy Console could show Groovy version in about help
[ https://issues.apache.org/jira/browse/GROOVY-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16535000#comment-16535000 ] ASF GitHub Bot commented on GROOVY-8623: GitHub user jacekmusial opened a pull request: https://github.com/apache/groovy/pull/771 GROOVY-8623: Show Groovy version in about help Show current version of the Groovy in Groovy Object Browser in about->help Jira: https://issues.apache.org/jira/browse/GROOVY-8623 How it looks like:  You can merge this pull request into a Git repository by running: $ git pull https://github.com/jacekmusial/groovy master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/groovy/pull/771.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #771 commit bb62f662b6ccb5fcba8380d71d5a60b6dac534a0 Author: Jacek Musiał Date: 2018-07-06T15:30:16Z GROOVY-8623: Show Groovy version in about help Show current version of the Groovy in Groovy Object Browser in about->help > Groovy Object Browser within Groovy Console could show Groovy version in > about help > --- > > Key: GROOVY-8623 > URL: https://issues.apache.org/jira/browse/GROOVY-8623 > Project: Groovy > Issue Type: Improvement >Reporter: Paul King >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] groovy pull request #771: GROOVY-8623: Show Groovy version in about help
GitHub user jacekmusial opened a pull request: https://github.com/apache/groovy/pull/771 GROOVY-8623: Show Groovy version in about help Show current version of the Groovy in Groovy Object Browser in about->help Jira: https://issues.apache.org/jira/browse/GROOVY-8623 How it looks like:  You can merge this pull request into a Git repository by running: $ git pull https://github.com/jacekmusial/groovy master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/groovy/pull/771.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #771 commit bb62f662b6ccb5fcba8380d71d5a60b6dac534a0 Author: Jacek MusiaÅ Date: 2018-07-06T15:30:16Z GROOVY-8623: Show Groovy version in about help Show current version of the Groovy in Groovy Object Browser in about->help ---
[jira] [Commented] (GROOVY-8690) Bump picocli version to 3.2.0 from 3.1.0
[ https://issues.apache.org/jira/browse/GROOVY-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534824#comment-16534824 ] ASF GitHub Bot commented on GROOVY-8690: GitHub user remkop opened a pull request: https://github.com/apache/groovy/pull/770 GROOVY-8690 bump picocli to v3.2.0 from 3.1.0 Details in https://issues.apache.org/jira/browse/GROOVY-8690 You can merge this pull request into a Git repository by running: $ git pull https://github.com/remkop/groovy GROOVY-8690-upgrade-to-picocli-v3.2.0 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/groovy/pull/770.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #770 commit 82b6bd5d96cb93667dd51f410388dee8394b6de4 Author: Remko Popma Date: 2018-07-06T13:31:51Z GROOVY-8690 bump picocli to v3.2.0 from 3.1.0 > Bump picocli version to 3.2.0 from 3.1.0 > > > Key: GROOVY-8690 > URL: https://issues.apache.org/jira/browse/GROOVY-8690 > Project: Groovy > Issue Type: Dependency upgrade > Components: command line processing >Affects Versions: 2.5.0 >Reporter: Remko Popma >Priority: Major > Fix For: 2.5.1 > > > Many improvements. For Groovy users, perhaps most interesting is better > support for completion candidates (both bash completion scripts and JLine > interactive applications). > The description for options and positional parameters can contain variables > that expand to the default value or completion candidates. > For more details, see https://github.com/remkop/picocli/releases/tag/v3.2.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] groovy pull request #770: GROOVY-8690 bump picocli to v3.2.0 from 3.1.0
GitHub user remkop opened a pull request: https://github.com/apache/groovy/pull/770 GROOVY-8690 bump picocli to v3.2.0 from 3.1.0 Details in https://issues.apache.org/jira/browse/GROOVY-8690 You can merge this pull request into a Git repository by running: $ git pull https://github.com/remkop/groovy GROOVY-8690-upgrade-to-picocli-v3.2.0 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/groovy/pull/770.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #770 commit 82b6bd5d96cb93667dd51f410388dee8394b6de4 Author: Remko Popma Date: 2018-07-06T13:31:51Z GROOVY-8690 bump picocli to v3.2.0 from 3.1.0 ---
[jira] [Closed] (GROOVY-8646) Bump picocli version to 3.1.0 from 3.0.2
[ https://issues.apache.org/jira/browse/GROOVY-8646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma closed GROOVY-8646. --- Resolution: Done > Bump picocli version to 3.1.0 from 3.0.2 > > > Key: GROOVY-8646 > URL: https://issues.apache.org/jira/browse/GROOVY-8646 > Project: Groovy > Issue Type: Dependency upgrade > Components: command line processing >Affects Versions: 2.5.0 >Reporter: Remko Popma >Priority: Major > Fix For: 2.5.1 > > > Picocli [3.1.0|https://github.com/remkop/picocli/releases/tag/v3.1.0] fixes a > bug where an AnnotationFormatError "Duplicate annotation for class" occurred > on Groovy scripts annotated with with @PicocliScript when the script contains > classes. This release also adds support for command aliases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (GROOVY-7404) final fields on trait can't be set in constructor
[
https://issues.apache.org/jira/browse/GROOVY-7404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul King closed GROOVY-7404.
-
Resolution: Cannot Reproduce
Assignee: Paul King
I believe this has been fixed by other issues. If you are still having
problems, please reopen and supply a test case. Thanks.
> final fields on trait can't be set in constructor
> -
>
> Key: GROOVY-7404
> URL: https://issues.apache.org/jira/browse/GROOVY-7404
> Project: Groovy
> Issue Type: Bug
>Affects Versions: 2.4.3
>Reporter: Christopher Smith
>Assignee: Paul King
>Priority: Minor
>
> I have some exception classes that each carry some tracking information about
> the nature of the exception in final fields. I tried to pull these fields out
> into a trait, but attempting to set their values in the constructor using
> {{this.key = key}} results in a "cannot set read-only property" error.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (GROOVY-7515) static initializers on trait fields are discarded
[
https://issues.apache.org/jira/browse/GROOVY-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul King closed GROOVY-7515.
-
Resolution: Duplicate
Assignee: Paul King
I believe this is a duplicate. Since the other issue has a test case. I'll
close this one.
> static initializers on trait fields are discarded
> -
>
> Key: GROOVY-7515
> URL: https://issues.apache.org/jira/browse/GROOVY-7515
> Project: Groovy
> Issue Type: Bug
>Affects Versions: 2.4.4
>Reporter: Christopher Smith
>Assignee: Paul King
>Priority: Major
>
> Related to GROOVY-7514, I found that in addition to the {{final}} qualifier
> being discarded, the initializer is discarded as well, so the {{private
> static final}} field is {{null}} at runtime.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (GROOVY-7536) Problem with Java Stubs Related to a Trait with Property
[
https://issues.apache.org/jira/browse/GROOVY-7536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul King resolved GROOVY-7536.
---
Resolution: Duplicate
Assignee: Paul King
Fix Version/s: 2.5.1
2.4.16
I believe this is a duplicate.
> Problem with Java Stubs Related to a Trait with Property
>
>
> Key: GROOVY-7536
> URL: https://issues.apache.org/jira/browse/GROOVY-7536
> Project: Groovy
> Issue Type: Bug
> Components: Stub generator / Joint compiler
>Affects Versions: 2.4.4
>Reporter: Wisen Tanasa
>Assignee: Paul King
>Priority: Major
> Fix For: 2.4.16, 2.5.1
>
> Attachments: traitinheritance GROOVY-7536.zip
>
>
> Similar with GROOVY-7113 but the Trait contains property. Attached is the zip
> with modified source.
> {code:title=src/main/groovy/demo/DemoTrait.groovy|borderStyle=solid}
> package demo
> trait DemoTrait {
> int myproperty
> int getMagicNumber() {
> 42
> }
> }
> {code}
> *Error message*
> {code}
> /Users/ceilfors/Downloads/traitinheritance/build/tmp/groovy-java-stubs/demo/DemoClass.java:10:
> error: DemoClass is not abstract and does not override abstract method
> setMyproperty(int) in DemoTrait
> public class DemoClass
>^
> 1 error
> startup failed:
> Compilation failed; see the compiler error output for details.
> 1 error
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (GROOVY-8689) New line between constructor call and {}
Daniil Ovchinnikov created GROOVY-8689:
--
Summary: New line between constructor call and {}
Key: GROOVY-8689
URL: https://issues.apache.org/jira/browse/GROOVY-8689
Project: Groovy
Issue Type: Bug
Components: parser-antlr4
Affects Versions: 3.0.0-alpha-3
Reporter: Daniil Ovchinnikov
{code:groovy}
new A()
{}
{code}
is parsed as {{this.(new A())({})}} i.e. method call with constructor call as
method expression.
This results in invocation of whatever `#toString()` returns which doesn't make
sense.
In older version it was parsed as {{new A().call({})}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (GROOVY-8688) AsmDecompiler.parseClass fails against a Java 11 JEP 181 class
[
https://issues.apache.org/jira/browse/GROOVY-8688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul King resolved GROOVY-8688.
---
Resolution: Fixed
Assignee: Paul King
Fix Version/s: 3.0.0-alpha-4
Proposed PR merged. I have 3.0 as fix version for now. I'll update if merged
into 2.5.
> AsmDecompiler.parseClass fails against a Java 11 JEP 181 class
> --
>
> Key: GROOVY-8688
> URL: https://issues.apache.org/jira/browse/GROOVY-8688
> Project: Groovy
> Issue Type: Bug
> Components: bytecode
>Affects Versions: 2.5.0
>Reporter: Robert Stupp
>Assignee: Paul King
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
>
> If {{AsmDecompiler.parseClass}} is invoked on Java 11 for a class that
> already uses [nest-based access control|http://openjdk.java.net/jeps/181],
> parsing with asm (on master) will fail with an
> {{UnsupportedOperationException}} in
> {{org.objectweb.asm.ClassVisitor#visitNestMemberExperimental}} or
> {{visitNestHostExperimental}}.
> A trivial fix is to bump
> {{org.codehaus.groovy.control.CompilerConfiguration#ASM_API_VERSION}} to
> {{ASM7_EXPERIMENTAL}} with asm 6.2.
> For the 2.5.x-branch, an upgrade from asm 6.1.1 to 6.2 is necessary.
>
> [PR for GROOVY_2_5_x branch|https://github.com/apache/groovy/pull/768]
> [PR for master branch|https://github.com/apache/groovy/pull/769]
> {{./gradlew test}} is clean for both branches.
>
> Side note: I've added the maven plugin to allow deployment of the artifacts
> into the local maven repo. I suspect, it should to removed from the PRs?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] groovy pull request #769: Make Groovy/master work with Java 11 / JSR 181 + a...
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/769 ---
[GitHub] groovy pull request #768: Make Groovy/2.5.x work with Java 11 / JSR 181 + ad...
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/768 ---
[jira] [Updated] (GROOVY-8636) Bump asm to 6.2
[ https://issues.apache.org/jira/browse/GROOVY-8636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King updated GROOVY-8636: -- Fix Version/s: 2.5.1 > Bump asm to 6.2 > --- > > Key: GROOVY-8636 > URL: https://issues.apache.org/jira/browse/GROOVY-8636 > Project: Groovy > Issue Type: Dependency upgrade >Reporter: Daniel Sun >Assignee: Daniel Sun >Priority: Major > Fix For: 2.6.0-alpha-4, 3.0.0-alpha-3, 2.5.1 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (GROOVY-8688) AsmDecompiler.parseClass fails against a Java 11 JEP 181 class
[
https://issues.apache.org/jira/browse/GROOVY-8688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534743#comment-16534743
]
Robert Stupp edited comment on GROOVY-8688 at 7/6/18 11:57 AM:
---
Thanks for the fast reply. I've removed the maven plugin from the PRs.
{quote}wait until ASM7 was non experimental
{quote}
Yea - I tried to find out when asm7 will be release, but no luck.
was (Author: snazy):
Thanks for the fast reply. I've removed the maven plugin from the PRs.
{quote}wait until ASM7 was non experimental
{quote}
Yea - I tried too find out when asm7 will be release, but no luck.
> AsmDecompiler.parseClass fails against a Java 11 JEP 181 class
> --
>
> Key: GROOVY-8688
> URL: https://issues.apache.org/jira/browse/GROOVY-8688
> Project: Groovy
> Issue Type: Bug
> Components: bytecode
>Affects Versions: 2.5.0
>Reporter: Robert Stupp
>Priority: Major
>
> If {{AsmDecompiler.parseClass}} is invoked on Java 11 for a class that
> already uses [nest-based access control|http://openjdk.java.net/jeps/181],
> parsing with asm (on master) will fail with an
> {{UnsupportedOperationException}} in
> {{org.objectweb.asm.ClassVisitor#visitNestMemberExperimental}} or
> {{visitNestHostExperimental}}.
> A trivial fix is to bump
> {{org.codehaus.groovy.control.CompilerConfiguration#ASM_API_VERSION}} to
> {{ASM7_EXPERIMENTAL}} with asm 6.2.
> For the 2.5.x-branch, an upgrade from asm 6.1.1 to 6.2 is necessary.
>
> [PR for GROOVY_2_5_x branch|https://github.com/apache/groovy/pull/768]
> [PR for master branch|https://github.com/apache/groovy/pull/769]
> {{./gradlew test}} is clean for both branches.
>
> Side note: I've added the maven plugin to allow deployment of the artifacts
> into the local maven repo. I suspect, it should to removed from the PRs?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GROOVY-8688) AsmDecompiler.parseClass fails against a Java 11 JEP 181 class
[
https://issues.apache.org/jira/browse/GROOVY-8688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534743#comment-16534743
]
Robert Stupp commented on GROOVY-8688:
--
Thanks for the fast reply. I've removed the maven plugin from the PRs.
{quote}wait until ASM7 was non experimental
{quote}
Yea - I tried too find out when asm7 will be release, but no luck.
> AsmDecompiler.parseClass fails against a Java 11 JEP 181 class
> --
>
> Key: GROOVY-8688
> URL: https://issues.apache.org/jira/browse/GROOVY-8688
> Project: Groovy
> Issue Type: Bug
> Components: bytecode
>Affects Versions: 2.5.0
>Reporter: Robert Stupp
>Priority: Major
>
> If {{AsmDecompiler.parseClass}} is invoked on Java 11 for a class that
> already uses [nest-based access control|http://openjdk.java.net/jeps/181],
> parsing with asm (on master) will fail with an
> {{UnsupportedOperationException}} in
> {{org.objectweb.asm.ClassVisitor#visitNestMemberExperimental}} or
> {{visitNestHostExperimental}}.
> A trivial fix is to bump
> {{org.codehaus.groovy.control.CompilerConfiguration#ASM_API_VERSION}} to
> {{ASM7_EXPERIMENTAL}} with asm 6.2.
> For the 2.5.x-branch, an upgrade from asm 6.1.1 to 6.2 is necessary.
>
> [PR for GROOVY_2_5_x branch|https://github.com/apache/groovy/pull/768]
> [PR for master branch|https://github.com/apache/groovy/pull/769]
> {{./gradlew test}} is clean for both branches.
>
> Side note: I've added the maven plugin to allow deployment of the artifacts
> into the local maven repo. I suspect, it should to removed from the PRs?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GROOVY-8688) AsmDecompiler.parseClass fails against a Java 11 JEP 181 class
[
https://issues.apache.org/jira/browse/GROOVY-8688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534684#comment-16534684
]
Paul King commented on GROOVY-8688:
---
Thanks for the PR. I've noticed the parseClass failure on JDK11 too recently
and was going to explore something similar. I was hoping to wait until ASM7 was
non experimental but with JDK versions moving so quickly, I don't think we have
that luxury.
P.S. You should be able to use the "install" task to publish to the local maven
repo.
> AsmDecompiler.parseClass fails against a Java 11 JEP 181 class
> --
>
> Key: GROOVY-8688
> URL: https://issues.apache.org/jira/browse/GROOVY-8688
> Project: Groovy
> Issue Type: Bug
> Components: bytecode
>Affects Versions: 2.5.0
>Reporter: Robert Stupp
>Priority: Major
>
> If {{AsmDecompiler.parseClass}} is invoked on Java 11 for a class that
> already uses [nest-based access control|http://openjdk.java.net/jeps/181],
> parsing with asm (on master) will fail with an
> {{UnsupportedOperationException}} in
> {{org.objectweb.asm.ClassVisitor#visitNestMemberExperimental}} or
> {{visitNestHostExperimental}}.
> A trivial fix is to bump
> {{org.codehaus.groovy.control.CompilerConfiguration#ASM_API_VERSION}} to
> {{ASM7_EXPERIMENTAL}} with asm 6.2.
> For the 2.5.x-branch, an upgrade from asm 6.1.1 to 6.2 is necessary.
>
> [PR for GROOVY_2_5_x branch|https://github.com/apache/groovy/pull/768]
> [PR for master branch|https://github.com/apache/groovy/pull/769]
> {{./gradlew test}} is clean for both branches.
>
> Side note: I've added the maven plugin to allow deployment of the artifacts
> into the local maven repo. I suspect, it should to removed from the PRs?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (GROOVY-8688) AsmDecompiler.parseClass fails against a Java 11 JEP 181 class
Robert Stupp created GROOVY-8688:
Summary: AsmDecompiler.parseClass fails against a Java 11 JEP 181
class
Key: GROOVY-8688
URL: https://issues.apache.org/jira/browse/GROOVY-8688
Project: Groovy
Issue Type: Bug
Components: bytecode
Affects Versions: 2.5.0
Reporter: Robert Stupp
If {{AsmDecompiler.parseClass}} is invoked on Java 11 for a class that already
uses [nest-based access control|http://openjdk.java.net/jeps/181], parsing with
asm (on master) will fail with an {{UnsupportedOperationException}} in
{{org.objectweb.asm.ClassVisitor#visitNestMemberExperimental}} or
{{visitNestHostExperimental}}.
A trivial fix is to bump
{{org.codehaus.groovy.control.CompilerConfiguration#ASM_API_VERSION}} to
{{ASM7_EXPERIMENTAL}} with asm 6.2.
For the 2.5.x-branch, an upgrade from asm 6.1.1 to 6.2 is necessary.
[PR for GROOVY_2_5_x branch|https://github.com/apache/groovy/pull/768]
[PR for master branch|https://github.com/apache/groovy/pull/769]
{{./gradlew test}} is clean for both branches.
Side note: I've added the maven plugin to allow deployment of the artifacts
into the local maven repo. I suspect, it should to removed from the PRs?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] groovy pull request #769: Make Groovy/master work with Java 11 / JSR 181 + a...
GitHub user snazy opened a pull request: https://github.com/apache/groovy/pull/769 Make Groovy/master work with Java 11 / JSR 181 + add maven plugin You can merge this pull request into a Git repository by running: $ git pull https://github.com/snazy/groovy java11-master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/groovy/pull/769.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #769 commit b06433eb9d1f9c89e20c700208e177dcdf5728bb Author: Robert Stupp Date: 2018-07-04T14:10:42Z Make Groovy work with Java 11 + add maven plugin ---
[GitHub] groovy pull request #768: Make Groovy/2.5.x work with Java 11 / JSR 181 + ad...
GitHub user snazy opened a pull request: https://github.com/apache/groovy/pull/768 Make Groovy/2.5.x work with Java 11 / JSR 181 + add maven plugin You can merge this pull request into a Git repository by running: $ git pull https://github.com/snazy/groovy java11-2_5_X Alternatively you can review and apply these changes as the patch at: https://github.com/apache/groovy/pull/768.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #768 commit a86e2527d5577c606a579c0fca12b0a344ddc770 Author: Robert Stupp Date: 2018-07-04T14:10:42Z Make Groovy work with Java 11 + add maven plugin ---
