[jira] [Commented] (GROOVY-8727) JDK 11 Compilation Failure: ClassVisitor.visitNestMemberExperimental throws UnsupportedOperationException

2018-10-13 Thread Paul King (JIRA)


[ 
https://issues.apache.org/jira/browse/GROOVY-8727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649147#comment-16649147
 ] 

Paul King commented on GROOVY-8727:
---

You can subscribe to or peruse the dev mailing list:

https://lists.apache.org/thread.html/6a61f4fc57943b1edfe82e523d5bd1f454080be53e97764ad30ad67b@%3Cdev.groovy.apache.org%3E

TL;DR: One day to go on the VOTE thread as per Apache release guidelines.

Cheers, Paul.


> JDK 11 Compilation Failure: ClassVisitor.visitNestMemberExperimental throws 
> UnsupportedOperationException 
> --
>
> Key: GROOVY-8727
> URL: https://issues.apache.org/jira/browse/GROOVY-8727
> Project: Groovy
>  Issue Type: Bug
>  Components: Compiler
>Affects Versions: 2.5.2
>Reporter: Misagh Moayyed
>Assignee: Paul King
>Priority: Major
> Fix For: 3.0.0-alpha-4, 2.5.3
>
>
> *Description:*
> Using JDK 11 and Gradle 4.9, the following compilation error is seen:
>  
> {code:java}
> > Task :core:cas-server-core-tickets:compileTestGroovy FAILED
> startup failed:
> General error during class generation: java.lang.UnsupportedOperationException
> java.lang.UnsupportedOperationException
>   at 
> groovyjarjarasm.asm.ClassVisitor.visitNestMemberExperimental(ClassVisitor.java:248)
>   at groovyjarjarasm.asm.ClassReader.accept(ClassReader.java:651)
>   at groovyjarjarasm.asm.ClassReader.accept(ClassReader.java:391)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmDecompiler.parseClass(AsmDecompiler.java:83)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.findDecompiled(ClassNodeResolver.java:254)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.tryAsLoaderClassOrScript(ClassNodeResolver.java:192)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.findClassNode(ClassNodeResolver.java:172)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.resolveName(ClassNodeResolver.java:128)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmReferenceResolver.resolveClassNullable(AsmReferenceResolver.java:59)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmReferenceResolver.resolveClass(AsmReferenceResolver.java:46)
>   at 
> org.codehaus.groovy.ast.decompiled.TypeSignatureParser.visitEnd(TypeSignatureParser.java:112)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.parseType(SignatureReader.java:206)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.parseType(SignatureReader.java:235)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.accept(SignatureReader.java:114)
>   at 
> org.codehaus.groovy.ast.decompiled.MemberSignatureParser.createMethodNode(MemberSignatureParser.java:95)
>   at 
> org.codehaus.groovy.ast.decompiled.DecompiledClassNode.lazyInitMembers(DecompiledClassNode.java:195)
>   at 
> org.codehaus.groovy.ast.decompiled.DecompiledClassNode.getMethods(DecompiledClassNode.java:103)
>   at org.codehaus.groovy.ast.ClassNode.getMethods(ClassNode.java:399)
>   at 
> org.codehaus.groovy.classgen.AnnotationVisitor.checkIfMandatoryAnnotationValuesPassed(AnnotationVisitor.java:168)
>   at 
> org.codehaus.groovy.classgen.AnnotationVisitor.visit(AnnotationVisitor.java:80)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitAnnotation(ExtendedVerifier.java:311)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitAnnotations(ExtendedVerifier.java:157)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitConstructorOrMethod(ExtendedVerifier.java:112)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitMethod(ExtendedVerifier.java:108)
>   at org.codehaus.groovy.ast.ClassNode.visitContents(ClassNode.java:1103)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitClass(ExtendedVerifier.java:91)
>   at 
> org.codehaus.groovy.control.CompilationUnit$18.call(CompilationUnit.java:827)
>   at 
> org.codehaus.groovy.control.CompilationUnit.applyToPrimaryClassNodes(CompilationUnit.java:1087)
>   at 
> org.codehaus.groovy.control.CompilationUnit.doPhaseOperation(CompilationUnit.java:631)
>   at 
> org.codehaus.groovy.control.CompilationUnit.processPhaseOperations(CompilationUnit.java:609)
>   at 
> org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:586)
>   at 
> org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:565)
>   at 
> org.gradle.api.internal.tasks.compile.ApiGroovyCompiler.execute(ApiGroovyCompiler.java:179)
>   at 
> org.gradle.api.internal.tasks.compile.ApiGroovyCompiler.execute(ApiGroovyCompiler.java:57)
>   at 
> org.gradle.api.internal.tasks.compile.GroovyCompilerFactory$DaemonSideCompiler.execute(GroovyCompilerFactory.java:77)
>   at 
> 

[jira] [Commented] (GROOVY-8727) JDK 11 Compilation Failure: ClassVisitor.visitNestMemberExperimental throws UnsupportedOperationException

2018-10-13 Thread Fabian Depry (JIRA)


[ 
https://issues.apache.org/jira/browse/GROOVY-8727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649072#comment-16649072
 ] 

Fabian Depry commented on GROOVY-8727:
--

Is there a tentative release date for 2.5.3? Or a way to check on the status 
somewhere?

With Java 11 released more than 2 weeks ago, and the deadline on Java 8 getting 
closer, it seems this fix is becoming more and more important for the folks 
using Groovy.

Thanks.

 

> JDK 11 Compilation Failure: ClassVisitor.visitNestMemberExperimental throws 
> UnsupportedOperationException 
> --
>
> Key: GROOVY-8727
> URL: https://issues.apache.org/jira/browse/GROOVY-8727
> Project: Groovy
>  Issue Type: Bug
>  Components: Compiler
>Affects Versions: 2.5.2
>Reporter: Misagh Moayyed
>Assignee: Paul King
>Priority: Major
> Fix For: 3.0.0-alpha-4, 2.5.3
>
>
> *Description:*
> Using JDK 11 and Gradle 4.9, the following compilation error is seen:
>  
> {code:java}
> > Task :core:cas-server-core-tickets:compileTestGroovy FAILED
> startup failed:
> General error during class generation: java.lang.UnsupportedOperationException
> java.lang.UnsupportedOperationException
>   at 
> groovyjarjarasm.asm.ClassVisitor.visitNestMemberExperimental(ClassVisitor.java:248)
>   at groovyjarjarasm.asm.ClassReader.accept(ClassReader.java:651)
>   at groovyjarjarasm.asm.ClassReader.accept(ClassReader.java:391)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmDecompiler.parseClass(AsmDecompiler.java:83)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.findDecompiled(ClassNodeResolver.java:254)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.tryAsLoaderClassOrScript(ClassNodeResolver.java:192)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.findClassNode(ClassNodeResolver.java:172)
>   at 
> org.codehaus.groovy.control.ClassNodeResolver.resolveName(ClassNodeResolver.java:128)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmReferenceResolver.resolveClassNullable(AsmReferenceResolver.java:59)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmReferenceResolver.resolveClass(AsmReferenceResolver.java:46)
>   at 
> org.codehaus.groovy.ast.decompiled.TypeSignatureParser.visitEnd(TypeSignatureParser.java:112)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.parseType(SignatureReader.java:206)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.parseType(SignatureReader.java:235)
>   at 
> groovyjarjarasm.asm.signature.SignatureReader.accept(SignatureReader.java:114)
>   at 
> org.codehaus.groovy.ast.decompiled.MemberSignatureParser.createMethodNode(MemberSignatureParser.java:95)
>   at 
> org.codehaus.groovy.ast.decompiled.DecompiledClassNode.lazyInitMembers(DecompiledClassNode.java:195)
>   at 
> org.codehaus.groovy.ast.decompiled.DecompiledClassNode.getMethods(DecompiledClassNode.java:103)
>   at org.codehaus.groovy.ast.ClassNode.getMethods(ClassNode.java:399)
>   at 
> org.codehaus.groovy.classgen.AnnotationVisitor.checkIfMandatoryAnnotationValuesPassed(AnnotationVisitor.java:168)
>   at 
> org.codehaus.groovy.classgen.AnnotationVisitor.visit(AnnotationVisitor.java:80)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitAnnotation(ExtendedVerifier.java:311)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitAnnotations(ExtendedVerifier.java:157)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitConstructorOrMethod(ExtendedVerifier.java:112)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitMethod(ExtendedVerifier.java:108)
>   at org.codehaus.groovy.ast.ClassNode.visitContents(ClassNode.java:1103)
>   at 
> org.codehaus.groovy.classgen.ExtendedVerifier.visitClass(ExtendedVerifier.java:91)
>   at 
> org.codehaus.groovy.control.CompilationUnit$18.call(CompilationUnit.java:827)
>   at 
> org.codehaus.groovy.control.CompilationUnit.applyToPrimaryClassNodes(CompilationUnit.java:1087)
>   at 
> org.codehaus.groovy.control.CompilationUnit.doPhaseOperation(CompilationUnit.java:631)
>   at 
> org.codehaus.groovy.control.CompilationUnit.processPhaseOperations(CompilationUnit.java:609)
>   at 
> org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:586)
>   at 
> org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:565)
>   at 
> org.gradle.api.internal.tasks.compile.ApiGroovyCompiler.execute(ApiGroovyCompiler.java:179)
>   at 
> org.gradle.api.internal.tasks.compile.ApiGroovyCompiler.execute(ApiGroovyCompiler.java:57)
>   at 
> org.gradle.api.internal.tasks.compile.GroovyCompilerFactory$DaemonSideCompiler.execute(GroovyCompilerFactory.java:77)
>   at 
> 

[jira] [Updated] (GROOVY-8842) Implement a smart highlighter for groovy console editor

2018-10-13 Thread Daniel Sun (JIRA)


 [ 
https://issues.apache.org/jira/browse/GROOVY-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Sun updated GROOVY-8842:
---
Description: 
Implement a source code highlighter based on Parrot's lexer, the new 
highlighter should be smarter. e.g.

It can show different colors in GString `"abc${'123' + 123}def${a + b}"`

P.S. Currently the new highlighter will render all source code for each 
editing, so it is NOT recommended to be enable for large source code for the 
time being. 
   The new highlighter is NOT enabled by default.  Check the checkbox 
"Enable smart highlighter" in "View" menu to enable the new highlighter




  was:
Implement a source code highlighter based on Parrot's lexer, the new 
highlighter should be smarter. e.g.

It can show different colors in GString `"abc${'123' + 123}def${a + b}"`

P.S. Currently the new highlighter will render all source code for each 
editing, so it is NOT recommended to be enable for large source code for the 
time being(The new highlighter is NOT enabled by default)





> Implement a smart highlighter for groovy console editor
> ---
>
> Key: GROOVY-8842
> URL: https://issues.apache.org/jira/browse/GROOVY-8842
> Project: Groovy
>  Issue Type: New Feature
>Reporter: Daniel Sun
>Assignee: Daniel Sun
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
>
> Implement a source code highlighter based on Parrot's lexer, the new 
> highlighter should be smarter. e.g.
> It can show different colors in GString `"abc${'123' + 123}def${a + b}"`
> P.S. Currently the new highlighter will render all source code for each 
> editing, so it is NOT recommended to be enable for large source code for the 
> time being. 
>The new highlighter is NOT enabled by default.  Check the checkbox 
> "Enable smart highlighter" in "View" menu to enable the new highlighter



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GROOVY-8842) Implement a smart highlighter for groovy console editor

2018-10-13 Thread Daniel Sun (JIRA)


 [ 
https://issues.apache.org/jira/browse/GROOVY-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Sun updated GROOVY-8842:
---
Description: 
Implement a source code highlighter based on Parrot's lexer, the new 
highlighter should be smarter. e.g.

It can show different colors in GString `"abc${'123' + 123}def${a + b}"`

P.S. Currently the new highlighter will render all source code for each 
editing, so it is NOT recommended to be enable for large source code for the 
time being(The new highlighter is NOT enabled by default)




  was:
Implement a source code highlighter based on Parrot's lexer, the new 
highlighter should be smarter. e.g.

It can show different colors in GString `"abc${'123' + 123}def${a + b}"`

P.S. Currently the new highlighter will render all source code for each 
editing, so it can not be used to render large source code. The new highlighter 
is NOT enabled by default





> Implement a smart highlighter for groovy console editor
> ---
>
> Key: GROOVY-8842
> URL: https://issues.apache.org/jira/browse/GROOVY-8842
> Project: Groovy
>  Issue Type: New Feature
>Reporter: Daniel Sun
>Assignee: Daniel Sun
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
>
> Implement a source code highlighter based on Parrot's lexer, the new 
> highlighter should be smarter. e.g.
> It can show different colors in GString `"abc${'123' + 123}def${a + b}"`
> P.S. Currently the new highlighter will render all source code for each 
> editing, so it is NOT recommended to be enable for large source code for the 
> time being(The new highlighter is NOT enabled by default)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (GROOVY-8842) Implement a smart highlighter for groovy console editor

2018-10-13 Thread Daniel Sun (JIRA)


 [ 
https://issues.apache.org/jira/browse/GROOVY-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Sun resolved GROOVY-8842.

Resolution: Fixed

Fixed by 
https://github.com/apache/groovy/commit/4ee262fe2d6c760df66d8f32752dd9f96ab05c9c

> Implement a smart highlighter for groovy console editor
> ---
>
> Key: GROOVY-8842
> URL: https://issues.apache.org/jira/browse/GROOVY-8842
> Project: Groovy
>  Issue Type: New Feature
>Reporter: Daniel Sun
>Assignee: Daniel Sun
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
>
> Implement a source code highlighter based on Parrot's lexer, the new 
> highlighter should be smarter. e.g.
> It can show different colors in GString `"abc${'123' + 123}def${a + b}"`
> P.S. Currently the new highlighter will render all source code for each 
> editing, so it can not be used to render large source code. The new 
> highlighter is NOT enabled by default



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GROOVY-8842) Implement a smart highlighter for groovy console editor

2018-10-13 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/GROOVY-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648926#comment-16648926
 ] 

ASF GitHub Bot commented on GROOVY-8842:


Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/809


> Implement a smart highlighter for groovy console editor
> ---
>
> Key: GROOVY-8842
> URL: https://issues.apache.org/jira/browse/GROOVY-8842
> Project: Groovy
>  Issue Type: New Feature
>Reporter: Daniel Sun
>Assignee: Daniel Sun
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
>
> Implement a source code highlighter based on Parrot's lexer, the new 
> highlighter should be smarter. e.g.
> It can show different colors in GString `"abc${'123' + 123}def${a + b}"`
> P.S. Currently the new highlighter will render all source code for each 
> editing, so it can not be used to render large source code. The new 
> highlighter is NOT enabled by default



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] groovy pull request #809: GROOVY-8842: Implement a smart highlighter for gro...

2018-10-13 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/809


---


[jira] [Updated] (GROOVY-8842) Implement a smart highlighter for groovy console editor

2018-10-13 Thread Daniel Sun (JIRA)


 [ 
https://issues.apache.org/jira/browse/GROOVY-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Sun updated GROOVY-8842:
---
Description: 
Implement a source code highlighter based on Parrot's lexer, the new 
highlighter should be smarter. e.g.

It can show different colors in GString `"abc${'123' + 123}def${a + b}"`

P.S. Currently the new highlighter will render all source code for each 
editing, so it can not be used to render large source code. The new highlighter 
is NOT enabled by default




  was:
Implement a source code highlighter based on Parrot's lexer, the new 
highlighter should be smarter. e.g.

It can show different colors in GString `"abc${'123' + 123}def${a + b}"`

P.S. Currently the new highlighter will render all source code for each 
editing, so it can not be used to render large source code.





> Implement a smart highlighter for groovy console editor
> ---
>
> Key: GROOVY-8842
> URL: https://issues.apache.org/jira/browse/GROOVY-8842
> Project: Groovy
>  Issue Type: New Feature
>Reporter: Daniel Sun
>Assignee: Daniel Sun
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
>
> Implement a source code highlighter based on Parrot's lexer, the new 
> highlighter should be smarter. e.g.
> It can show different colors in GString `"abc${'123' + 123}def${a + b}"`
> P.S. Currently the new highlighter will render all source code for each 
> editing, so it can not be used to render large source code. The new 
> highlighter is NOT enabled by default



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GROOVY-8842) Implement a smart highlighter for groovy console editor

2018-10-13 Thread Daniel Sun (JIRA)


 [ 
https://issues.apache.org/jira/browse/GROOVY-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Sun updated GROOVY-8842:
---
Issue Type: New Feature  (was: Improvement)

> Implement a smart highlighter for groovy console editor
> ---
>
> Key: GROOVY-8842
> URL: https://issues.apache.org/jira/browse/GROOVY-8842
> Project: Groovy
>  Issue Type: New Feature
>Reporter: Daniel Sun
>Assignee: Daniel Sun
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
>
> Implement a source code highlighter based on Parrot's lexer, the new 
> highlighter should be smarter. e.g.
> It can show different colors in GString `"abc${'123' + 123}def${a + b}"`
> P.S. Currently the new highlighter will render all source code for each 
> editing, so it can not be used to render large source code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GROOVY-8842) Implement a smart highlighter for groovy console editor

2018-10-13 Thread Daniel Sun (JIRA)


 [ 
https://issues.apache.org/jira/browse/GROOVY-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Sun updated GROOVY-8842:
---
Description: 
Implement a source code highlighter based on Parrot's lexer, the new 
highlighter should be smarter. e.g.

It can show different colors in GString `"abc${'123' + 123}def${a + b}"`

P.S. Currently the new highlighter will render all source code for each 
editing, so it can not be used to render large source code.




  was:
Implement a source code highlighter based on Parrot's lexer, the new 
highlighter should be smarter. e.g.

It can show different colors in GString `"abc${'123' + 123}def${a + b}"`



> Implement a smart highlighter for groovy console editor
> ---
>
> Key: GROOVY-8842
> URL: https://issues.apache.org/jira/browse/GROOVY-8842
> Project: Groovy
>  Issue Type: Improvement
>Reporter: Daniel Sun
>Assignee: Daniel Sun
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
>
> Implement a source code highlighter based on Parrot's lexer, the new 
> highlighter should be smarter. e.g.
> It can show different colors in GString `"abc${'123' + 123}def${a + b}"`
> P.S. Currently the new highlighter will render all source code for each 
> editing, so it can not be used to render large source code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GROOVY-8842) Implement a smart highlighter for groovy console editor

2018-10-13 Thread Daniel Sun (JIRA)


 [ 
https://issues.apache.org/jira/browse/GROOVY-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Sun updated GROOVY-8842:
---
Summary: Implement a smart highlighter for groovy console editor  (was: 
Refine highlighting source code in groovy console editor)

> Implement a smart highlighter for groovy console editor
> ---
>
> Key: GROOVY-8842
> URL: https://issues.apache.org/jira/browse/GROOVY-8842
> Project: Groovy
>  Issue Type: Improvement
>Reporter: Daniel Sun
>Assignee: Daniel Sun
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
>
> Implement a source code highlighter based on Parrot's lexer, the new 
> highlighter should be smarter. e.g.
> It can show different colors in GString `"abc${'123' + 123}def${a + b}"`



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)