[jira] [Commented] (GROOVY-8913) Parrot Parser: partially-parenthesized binary expression parsed as cast and unary plus
[
https://issues.apache.org/jira/browse/GROOVY-8913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713853#comment-16713853
]
Daniel Sun commented on GROOVY-8913:
Some ambiguity issue have to be fixed
> Parrot Parser: partially-parenthesized binary expression parsed as cast and
> unary plus
> --
>
> Key: GROOVY-8913
> URL: https://issues.apache.org/jira/browse/GROOVY-8913
> Project: Groovy
> Issue Type: Bug
> Components: parser-antlr4
>Affects Versions: 2.6.0-alpha-4
>Reporter: Eric Milles
>Assignee: Daniel Sun
>Priority: Major
>
> Groovy 2.6 (and possibly/probably 3.0) is parsing this expression differently
> from 2.5:
> {code:groovy}
> def x = (a.b) + c()
> {code}
> In Groovy 2.5, this is a DeclarationExpression with a VariableExpression for
> the left expression and a BinaryExpression (with PLUS operator) for the right
> expression. Parrot Parser is seeing the right expression as a CastExpression
> with a UnaryPlusExpression.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (GROOVY-8915) [Parrot] Make groovydoc configuration flexible
[ https://issues.apache.org/jira/browse/GROOVY-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun resolved GROOVY-8915. Resolution: Fixed Fixed by https://github.com/apache/groovy/commit/13507791fd521ee54674908fda59450bcf966335 > [Parrot] Make groovydoc configuration flexible > -- > > Key: GROOVY-8915 > URL: https://issues.apache.org/jira/browse/GROOVY-8915 > Project: Groovy > Issue Type: Improvement > Components: parser-antlr4 >Reporter: Daniel Sun >Assignee: Daniel Sun >Priority: Major > Fix For: 3.0.0-alpha-4 > > > Current configuration for groovydoc are all global(set via JVM properties), > which is not flexible. We should configure how to handle groovydoc via > setting CompilerConfiguration -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] groovy pull request #836: GROOVY-8915: [Parrot] Make groovydoc configuration...
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/836 ---
[jira] [Commented] (GROOVY-8915) [Parrot] Make groovydoc configuration flexible
[ https://issues.apache.org/jira/browse/GROOVY-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713669#comment-16713669 ] ASF GitHub Bot commented on GROOVY-8915: GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/836 GROOVY-8915: [Parrot] Make groovydoc configuration flexible You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy GROOVY-8915 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/groovy/pull/836.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #836 commit ad507fe8dc18ab1e08c47b7e66e35349b1af520a Author: danielsun1106 Date: 2018-12-08T12:39:57Z GROOVY-8915: [Parrot] Make groovydoc configuration flexible > [Parrot] Make groovydoc configuration flexible > -- > > Key: GROOVY-8915 > URL: https://issues.apache.org/jira/browse/GROOVY-8915 > Project: Groovy > Issue Type: Improvement > Components: parser-antlr4 >Reporter: Daniel Sun >Assignee: Daniel Sun >Priority: Major > Fix For: 3.0.0-alpha-4 > > > Current configuration for groovydoc are all global(set via JVM properties), > which is not flexible. We should configure how to handle groovydoc via > setting CompilerConfiguration -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] groovy pull request #836: GROOVY-8915: [Parrot] Make groovydoc configuration...
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/836 GROOVY-8915: [Parrot] Make groovydoc configuration flexible You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy GROOVY-8915 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/groovy/pull/836.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #836 commit ad507fe8dc18ab1e08c47b7e66e35349b1af520a Author: danielsun1106 Date: 2018-12-08T12:39:57Z GROOVY-8915: [Parrot] Make groovydoc configuration flexible ---
[jira] [Assigned] (GROOVY-8913) Parrot Parser: partially-parenthesized binary expression parsed as cast and unary plus
[
https://issues.apache.org/jira/browse/GROOVY-8913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jochen Theodorou reassigned GROOVY-8913:
Assignee: Daniel Sun
> Parrot Parser: partially-parenthesized binary expression parsed as cast and
> unary plus
> --
>
> Key: GROOVY-8913
> URL: https://issues.apache.org/jira/browse/GROOVY-8913
> Project: Groovy
> Issue Type: Bug
> Components: parser-antlr4
>Affects Versions: 2.6.0-alpha-4
>Reporter: Eric Milles
>Assignee: Daniel Sun
>Priority: Major
>
> Groovy 2.6 (and possibly/probably 3.0) is parsing this expression differently
> from 2.5:
> {code:groovy}
> def x = (a.b) + c()
> {code}
> In Groovy 2.5, this is a DeclarationExpression with a VariableExpression for
> the left expression and a BinaryExpression (with PLUS operator) for the right
> expression. Parrot Parser is seeing the right expression as a CastExpression
> with a UnaryPlusExpression.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (GROOVY-8915) [Parrot] Make groovydoc configuration flexible
Daniel Sun created GROOVY-8915: -- Summary: [Parrot] Make groovydoc configuration flexible Key: GROOVY-8915 URL: https://issues.apache.org/jira/browse/GROOVY-8915 Project: Groovy Issue Type: Improvement Components: parser-antlr4 Reporter: Daniel Sun Assignee: Daniel Sun Fix For: 3.0.0-alpha-4 Current configuration for groovydoc are all global(set via JVM properties), which is not flexible. We should configure how to handle groovydoc via setting CompilerConfiguration -- This message was sent by Atlassian JIRA (v7.6.3#76005)
