[GitHub] [groovy] paulk-asert opened a new pull request #1196: GROOVY-9442: GEP: Support for the new JDK14 string escape sequence (\…
paulk-asert opened a new pull request #1196: GROOVY-9442: GEP: Support for the new JDK14 string escape sequence (\… URL: https://github.com/apache/groovy/pull/1196 …s for single space) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [groovy] danielsun1106 commented on issue #1195: GroovyLexer: Eliminate duplication in JavaLetter[OrDigit]InGString
danielsun1106 commented on issue #1195: GroovyLexer: Eliminate duplication in JavaLetter[OrDigit]InGString URL: https://github.com/apache/groovy/pull/1195#issuecomment-599807520 LGTM. I will check it with the tests of groovy-parser too later. https://github.com/danielsun1106/groovy-parser This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (GROOVY-9472) Static import causes unresolved reference to become resolved
[
https://issues.apache.org/jira/browse/GROOVY-9472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniil Ovchinnikov updated GROOVY-9472:
---
Description:
{code:groovy|title=com/foo/Person.groovy}
package com.foo
@groovy.transform.builder.Builder
class Person {
String name
}
{code}
1.
{code:groovy|title=Main.groovy}
import com.foo.Person
class Main {
static void main(String[] args) {
Person.PersonBuilder pb = Person.builder()
println(pb.build())
}
}
{code}
Trying to use it without a static import yields {{unable to resolve class
Person.PersonBuilder}}, which is another issue.
2. Let's add a static import
{code:groovy|title=Main.groovy}
import com.foo.Person
import static com.foo.Person.PersonBuilder
class Main {
static void main(String[] args) {
PersonBuilder pb = Person.builder()
println(pb.build())
}
}
{code}
The code compiles, but fails with {{java.lang.NoClassDefFoundError:
PersonBuilder}} when run.
3. Let's add {{@CompileStatic}}
{code:groovy|title=Main.groovy}
import com.foo.Person
import static com.foo.Person.PersonBuilder
import groovy.transform.CompileStatic
@CompileStatic
class Main {
static void main(String[] args) {
PersonBuilder pb = Person.builder()
println(pb.build())
}
}
{code}
Compilation fails with:
{{Cannot assign value of type com.foo.Person$PersonBuilder to variable of type
PersonBuilder}} and {{Cannot find matching method PersonBuilder#build()}}
was:
{code:groovy|title=com/foo/Person.groovy}
package com.foo
@groovy.transform.builder.Builder
class Person {
String name
}
{code}
1.
{code:groovy|title=Main.groovy}
import com.foo.Person
class Main {
static void main(String[] args) {
Person.PersonBuilder pb = Person.builder()
println(pb.build())
}
}
{code}
Trying to use it without a static import yields {{unable to resolve class
Person.PersonBuilder}}, which is another issue.
2. Let's add a static import
{code:groovy|title=Main.groovy}
import com.foo.Person
import static com.foo.Person.PersonBuilder
class Main {
static void main(String[] args) {
PersonBuilder pb = Person.builder()
println(pb.build())
}
}
{code}
The code compiles, but fails with {{java.lang.NoClassDefFoundError:
PersonBuilder}} when run.
3. Let's add {{@CompileStatic}}
{code:groovy|title=Main.groovy}
import com.foo.Person
import static com.foo.Person.PersonBuilder
class Main {
static void main(String[] args) {
PersonBuilder pb = Person.builder()
println(pb.build())
}
}
{code}
Compilation fails with:
{{Cannot assign value of type com.foo.Person$PersonBuilder to variable of type
PersonBuilder}} and {{Cannot find matching method PersonBuilder#build()}}
> Static import causes unresolved reference to become resolved
>
>
> Key: GROOVY-9472
> URL: https://issues.apache.org/jira/browse/GROOVY-9472
> Project: Groovy
> Issue Type: Bug
> Components: Compiler, Static Type Checker
>Affects Versions: 2.5.10
>Reporter: Daniil Ovchinnikov
>Priority: Major
>
> {code:groovy|title=com/foo/Person.groovy}
> package com.foo
> @groovy.transform.builder.Builder
> class Person {
> String name
> }
> {code}
> 1.
> {code:groovy|title=Main.groovy}
> import com.foo.Person
> class Main {
> static void main(String[] args) {
> Person.PersonBuilder pb = Person.builder()
> println(pb.build())
> }
> }
> {code}
> Trying to use it without a static import yields {{unable to resolve class
> Person.PersonBuilder}}, which is another issue.
> 2. Let's add a static import
> {code:groovy|title=Main.groovy}
> import com.foo.Person
> import static com.foo.Person.PersonBuilder
> class Main {
> static void main(String[] args) {
> PersonBuilder pb = Person.builder()
> println(pb.build())
> }
> }
> {code}
> The code compiles, but fails with {{java.lang.NoClassDefFoundError:
> PersonBuilder}} when run.
> 3. Let's add {{@CompileStatic}}
> {code:groovy|title=Main.groovy}
> import com.foo.Person
> import static com.foo.Person.PersonBuilder
> import groovy.transform.CompileStatic
> @CompileStatic
> class Main {
> static void main(String[] args) {
> PersonBuilder pb = Person.builder()
> println(pb.build())
> }
> }
> {code}
> Compilation fails with:
> {{Cannot assign value of type com.foo.Person$PersonBuilder to variable of
> type PersonBuilder}} and {{Cannot find matching method PersonBuilder#build()}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GROOVY-9472) Static import causes unresolved reference to become resolved
Daniil Ovchinnikov created GROOVY-9472:
--
Summary: Static import causes unresolved reference to become
resolved
Key: GROOVY-9472
URL: https://issues.apache.org/jira/browse/GROOVY-9472
Project: Groovy
Issue Type: Bug
Components: Compiler, Static Type Checker
Affects Versions: 2.5.10
Reporter: Daniil Ovchinnikov
{code:groovy|title=com/foo/Person.groovy}
package com.foo
@groovy.transform.builder.Builder
class Person {
String name
}
{code}
1.
{code:groovy|title=Main.groovy}
import com.foo.Person
class Main {
static void main(String[] args) {
Person.PersonBuilder pb = Person.builder()
println(pb.build())
}
}
{code}
Trying to use it without a static import yields {{unable to resolve class
Person.PersonBuilder}}, which is another issue.
2. Let's add a static import
{code:groovy|title=Main.groovy}
import com.foo.Person
import static com.foo.Person.PersonBuilder
class Main {
static void main(String[] args) {
PersonBuilder pb = Person.builder()
println(pb.build())
}
}
{code}
The code compiles, but fails with {{java.lang.NoClassDefFoundError:
PersonBuilder}} when run.
3. Let's add {{@CompileStatic}}
{code:groovy|title=Main.groovy}
import com.foo.Person
import static com.foo.Person.PersonBuilder
class Main {
static void main(String[] args) {
PersonBuilder pb = Person.builder()
println(pb.build())
}
}
{code}
Compilation fails with:
{{Cannot assign value of type com.foo.Person$PersonBuilder to variable of type
PersonBuilder}} and {{Cannot find matching method PersonBuilder#build()}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [groovy] paulk-asert commented on issue #811: GROOVY-8843: Fix illegal reflective access within o.c.g.vmplugin.v7.J…
paulk-asert commented on issue #811: GROOVY-8843: Fix illegal reflective access within o.c.g.vmplugin.v7.J… URL: https://github.com/apache/groovy/pull/811#issuecomment-599750409 The general answers to your question are: - use JDK8 - move to a later Groovy version - ignore the warnings (they don't affect any operation) - alter the startup scripts to turn off warnings (FileBot seems to have some of this in place already, maybe it could be extended) I don't really know much about FileBot. You could contact the authors and ask them to upgrade Groovy. But just having a quick look, it does look like a FileBot install (I looked at portable version) has a `jar` directory. You could simply replace the 9 groovy jars in that directory. You could try with 2.5.10 first and if that doesn't work, try 3.0.2. Make sure to back up your install before tweaking it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [groovy] eric-milles opened a new pull request #1195: GroovyLexer: Eliminate duplication in JavaLetter[OrDigit]InGString
eric-milles opened a new pull request #1195: GroovyLexer: Eliminate duplication in JavaLetter[OrDigit]InGString URL: https://github.com/apache/groovy/pull/1195 Define them in terms of JavaLetter[OrDigit] with semantic predicate NOTE: I want to propose a change to JavaLetter, JavaLetterOrDigit, JavaLetterInGString and JavaLetterOrDigitInGString. But first, I wanted to reduce the duplication. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (GROOVY-9471) NCDFE: nested class in middle class via static import resolution
Daniil Ovchinnikov created GROOVY-9471:
--
Summary: NCDFE: nested class in middle class via static import
resolution
Key: GROOVY-9471
URL: https://issues.apache.org/jira/browse/GROOVY-9471
Project: Groovy
Issue Type: Bug
Affects Versions: 2.5.10
Reporter: Daniil Ovchinnikov
{code}
import static Child.Nested
class Parent {
Nested xxx
}
class Middle extends Parent {
static class Nested {}
}
class Child extends Middle {}
println(new Parent()) // java.lang.NoClassDefFoundError: Nested
{code}
The same exception when using star import.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [groovy] plittlefield commented on issue #811: GROOVY-8843: Fix illegal reflective access within o.c.g.vmplugin.v7.J…
plittlefield commented on issue #811: GROOVY-8843: Fix illegal reflective access within o.c.g.vmplugin.v7.J… URL: https://github.com/apache/groovy/pull/811#issuecomment-599558736 How do I do that for FileBot which requests the groovy amc plugin remotely? https://github.com/filebot/scripts Thanks, Paully This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [groovy] danielsun1106 commented on issue #811: GROOVY-8843: Fix illegal reflective access within o.c.g.vmplugin.v7.J…
danielsun1106 commented on issue #811: GROOVY-8843: Fix illegal reflective access within o.c.g.vmplugin.v7.J… URL: https://github.com/apache/groovy/pull/811#issuecomment-599521944 Please try 3.0.2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [groovy] plittlefield commented on issue #811: GROOVY-8843: Fix illegal reflective access within o.c.g.vmplugin.v7.J…
plittlefield commented on issue #811: GROOVY-8843: Fix illegal reflective access within o.c.g.vmplugin.v7.J… URL: https://github.com/apache/groovy/pull/811#issuecomment-599508757 This does not work for me... I have set the environment variable and still get the warnings... ``` $ env | grep GROOVY GROOVY_TURN_OFF_JAVA_WARNINGS=true ``` ...and when I run FileBot I get... ``` WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.codehaus.groovy.vmplugin.v7.Java7$1 (file:/usr/share/filebot/jar/groovy.jar) to constructor java.lang.invoke.MethodHandles$Lookup(java.lang.Class,int) WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.vmplugin.v7.Java7$1 WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release ``` Here is my system information... ``` FileBot 4.9.0 (r6899) JNA Native: 4.0.1 MediaInfo: 19.09.20200314 p7zip: p7zip Version 9.20 (locale=en_GB.UTF-8,Utf16=on,HugeFiles=on,4 CPUs) unrar: UNRAR 5.30 beta 2 freeware Extended Attributes: OK Unicode Filesystem: OK Script Bundle: 2020-03-02 (r625) Groovy: 2.5.8 JRE: Java(TM) SE Runtime Environment 13.0.2 JVM: 64-bit Java HotSpot(TM) 64-Bit Server VM ``` Thanks, Paully This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
