[GitHub] groovy pull request #820: GROOVY-8872: Populate parameter names from byte co...
GitHub user jameskleeh opened a pull request: https://github.com/apache/groovy/pull/820 GROOVY-8872: Populate parameter names from byte code when available I'm not sure how to create a test for this. I verified the change works locally in the example project I linked and uploaded in the jira issue. I think adding or modifying a test in AsmDecompilerTest would be the best thing, but I'm not sure how to inform Groovy to compile the Java source with parameters. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jameskleeh/groovy decompiled_param_names Alternatively you can review and apply these changes as the patch at: https://github.com/apache/groovy/pull/820.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #820 commit b2c31ff4f3a4038d6fbd16a89e2a14e6af4f83c2 Author: jameskleeh Date: 2018-11-09T04:44:59Z Populate the parameter names from the byte code when available ---
[GitHub] groovy pull request #779: GROOVY-8726: Store the method node reference in Pa...
Github user jameskleeh closed the pull request at: https://github.com/apache/groovy/pull/779 ---
[GitHub] groovy pull request #779: GROOVY-8726: Store the method node reference in Pa...
GitHub user jameskleeh opened a pull request: https://github.com/apache/groovy/pull/779 GROOVY-8726: Store the method node reference in Parameter This implementation copies all parameters when they are passed to the method node constructor. While there will be some waste in this process, I find it much easier and maintainable compared to changing all of the places in the codebase where parameters are reused. Note that the build on my fork is failing with an unrelated compilation error You can merge this pull request into a Git repository by running: $ git pull https://github.com/jameskleeh/groovy master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/groovy/pull/779.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #779 commit 6710d938b557dbf709924d3112d84c8de8e97a99 Author: jameskleeh Date: 2018-08-02T04:03:41Z GROOVY-8726: Store the method node reference in Parameter ---
[GitHub] groovy pull request #457: If a converter is found, further process the resul...
GitHub user jameskleeh opened a pull request: https://github.com/apache/groovy/pull/457 If a converter is found, further process the result You can merge this pull request into a Git repository by running: $ git pull https://github.com/jameskleeh/groovy master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/groovy/pull/457.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #457 commit 814facaa1732fcf1bc297fb9d11b7637530e60ea Author: jameskleeh <james.kl...@gmail.com> Date: 2016-11-05T22:36:49Z If a converter is found, further process the result --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
