[GitHub] [groovy] paulk-asert commented on a change in pull request #1243: GROOVY-9546: groovydoc: fix annotation rendering
paulk-asert commented on a change in pull request #1243: URL: https://github.com/apache/groovy/pull/1243#discussion_r422963560 ## File path: subprojects/groovy-groovydoc/src/test/groovy/org/codehaus/groovy/tools/groovydoc/testfiles/anno/Groovy.groovy ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.codehaus.groovy.tools.groovydoc.testfiles.anno + +import groovy.transform.EqualsAndHashCode +import groovy.transform.NamedParam +import groovy.transform.NamedVariant + +// The annotations that are used here don't really matter, +// since groovydoc shows all annotations, not just @Documented ones. Review comment: That's the one. :-) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert commented on a change in pull request #1243: GROOVY-9546: groovydoc: fix annotation rendering
paulk-asert commented on a change in pull request #1243: URL: https://github.com/apache/groovy/pull/1243#discussion_r422955255 ## File path: subprojects/groovy-groovydoc/src/test/groovy/org/codehaus/groovy/tools/groovydoc/testfiles/anno/Groovy.groovy ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.codehaus.groovy.tools.groovydoc.testfiles.anno + +import groovy.transform.EqualsAndHashCode +import groovy.transform.NamedParam +import groovy.transform.NamedVariant + +// The annotations that are used here don't really matter, +// since groovydoc shows all annotations, not just @Documented ones. Review comment: We do plan to correct this one day. We currently try to minimise resolving classes when not needed but we will likely change that at some point. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert commented on a change in pull request #1243: GROOVY-9546: groovydoc: fix annotation rendering
paulk-asert commented on a change in pull request #1243: URL: https://github.com/apache/groovy/pull/1243#discussion_r422955255 ## File path: subprojects/groovy-groovydoc/src/test/groovy/org/codehaus/groovy/tools/groovydoc/testfiles/anno/Groovy.groovy ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.codehaus.groovy.tools.groovydoc.testfiles.anno + +import groovy.transform.EqualsAndHashCode +import groovy.transform.NamedParam +import groovy.transform.NamedVariant + +// The annotations that are used here don't really matter, +// since groovydoc shows all annotations, not just @Documented ones. Review comment: We do plan to correct @Documented behaviour one day. We currently try to minimise resolving classes when not needed but we will likely change that at some point. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
