[jira] [Comment Edited] (GROOVY-9342) SC: Lambda in static initializer that uses static field on LHS of += produces errors

2019-12-19 Thread Eric Milles (Jira)


[ 
https://issues.apache.org/jira/browse/GROOVY-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17000318#comment-17000318
 ] 

Eric Milles edited comment on GROOVY-9342 at 12/19/19 7:30 PM:
---

"Cannot find matching method int#plus(java.lang.Object)..." is still an issue 
because  {{StaticTypeCheckingVisitor#inferSAMType}} cannot collect generics 
correctly from {{forEach(Consumer c)}} and so the param type is 
Object.

PR #1126 fixes the assignment case, which is handled by separate methods:
{code:groovy}
int sum = 0
java.util.function.Consumer add = i -> sum += i
{code}



was (Author: emilles):
"Cannot resolve method int#plus(Object)..." is still an issue because  
{{StaticTypeCheckingVisitor#inferSAMType}} cannot collect generics correctly 
from {{forEach(Consumer c)}} and so the param type is Object.

PR #1126 fixes the assignment case, which is handled by separate methods:
{code:groovy}
int sum = 0
java.util.function.Consumer add = i -> sum += i
{code}


> SC: Lambda in static initializer that uses static field on LHS of += produces 
> errors
> 
>
> Key: GROOVY-9342
> URL: https://issues.apache.org/jira/browse/GROOVY-9342
> Project: Groovy
>  Issue Type: Bug
>Affects Versions: 3.0.0-rc-2
>Reporter: Eric Milles
>Assignee: Eric Milles
>Priority: Major
> Fix For: 3.0.0-rc-3
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Follow up to GROOVY-9332 and GROOVY-9333.  Consider the following:
> {code:groovy}
> @groovy.transform.CompileStatic
> class Test1 {
> static int acc = 1
> static { [1, 2, 3].forEach(e -> acc += e) }
> }
> assert Test1.acc == 7
> {code}
> {code}
> org.codehaus.groovy.control.MultipleCompilationErrorsException: startup 
> failed:
> TestScript60.groovy: 5: [Static type checking] - Cannot find matching 
> method int#plus(java.lang.Object). Please check if the declared type is 
> correct and if the method exists.
>  @ line 5, column 49.
>atic { [1, 2, 3].forEach(e -> acc += e)
>  ^
> 1 error
> at 
> org.codehaus.groovy.control.ErrorCollector.failIfErrors(ErrorCollector.java:287)
> at 
> org.codehaus.groovy.control.CompilationUnit.applyToPrimaryClassNodes(CompilationUnit.java:1091)
> at 
> org.codehaus.groovy.control.CompilationUnit.doPhaseOperation(CompilationUnit.java:633)
> at 
> org.codehaus.groovy.control.CompilationUnit.processPhaseOperations(CompilationUnit.java:612)
> at 
> org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:589)
> at 
> groovy.lang.GroovyClassLoader.doParseClass(GroovyClassLoader.java:367)
> at 
> groovy.lang.GroovyClassLoader.lambda$parseClass$2(GroovyClassLoader.java:310)
> ...
> {code}
> and a different error if lambda uses specific parameter type:
> {code:groovy}
> @groovy.transform.CompileStatic
> class Test1 {
> static int acc = 1
> static { [1, 2, 3].forEach((Integer i) -> acc += i) }
> }
> assert Test1.acc == 7
> {code}
> {code}
> java.lang.ExceptionInInitializerError\r\n
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\r\n
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\r\n
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\r\n
>   at java.lang.reflect.Method.invoke(Method.java:498)\r\n
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (GROOVY-9342) SC: Lambda in static initializer that uses static field on LHS of += produces errors

2019-12-19 Thread Eric Milles (Jira)


[ 
https://issues.apache.org/jira/browse/GROOVY-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17000318#comment-17000318
 ] 

Eric Milles edited comment on GROOVY-9342 at 12/19/19 7:25 PM:
---

"Cannot resolve method int#plus(Object)..." is still an issue because  
{{StaticTypeCheckingVisitor#inferSAMType}} cannot collect generics correctly 
from {{forEach(Consumer c)}} and so the param type is Object.

PR #1126 fixes the assignment case, which is handled by separate methods:
{code:groovy}
int sum = 0
java.util.function.Consumer add = i -> sum += i
{code}



was (Author: emilles):
"Cannot resolve method int#plus(Object)..." is still an issue because  
{{StaticTypeCheckingVisitor#inferSAMType}} cannot collect generics correctly 
from {{forEach(Consumer c)}}.

PR #1126 fixes the assignment case, which is handled by separate methods:
{code:groovy}
int sum = 0
java.util.function.Consumer add = i -> sum += i
{code}


> SC: Lambda in static initializer that uses static field on LHS of += produces 
> errors
> 
>
> Key: GROOVY-9342
> URL: https://issues.apache.org/jira/browse/GROOVY-9342
> Project: Groovy
>  Issue Type: Bug
>Affects Versions: 3.0.0-rc-2
>Reporter: Eric Milles
>Assignee: Eric Milles
>Priority: Major
> Fix For: 3.0.0-rc-3
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Follow up to GROOVY-9332 and GROOVY-9333.  Consider the following:
> {code:groovy}
> @groovy.transform.CompileStatic
> class Test1 {
> static int acc = 1
> static { [1, 2, 3].forEach(e -> acc += e) }
> }
> assert Test1.acc == 7
> {code}
> {code}
> org.codehaus.groovy.control.MultipleCompilationErrorsException: startup 
> failed:
> TestScript60.groovy: 5: [Static type checking] - Cannot find matching 
> method int#plus(java.lang.Object). Please check if the declared type is 
> correct and if the method exists.
>  @ line 5, column 49.
>atic { [1, 2, 3].forEach(e -> acc += e)
>  ^
> 1 error
> at 
> org.codehaus.groovy.control.ErrorCollector.failIfErrors(ErrorCollector.java:287)
> at 
> org.codehaus.groovy.control.CompilationUnit.applyToPrimaryClassNodes(CompilationUnit.java:1091)
> at 
> org.codehaus.groovy.control.CompilationUnit.doPhaseOperation(CompilationUnit.java:633)
> at 
> org.codehaus.groovy.control.CompilationUnit.processPhaseOperations(CompilationUnit.java:612)
> at 
> org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:589)
> at 
> groovy.lang.GroovyClassLoader.doParseClass(GroovyClassLoader.java:367)
> at 
> groovy.lang.GroovyClassLoader.lambda$parseClass$2(GroovyClassLoader.java:310)
> ...
> {code}
> and a different error if lambda uses specific parameter type:
> {code:groovy}
> @groovy.transform.CompileStatic
> class Test1 {
> static int acc = 1
> static { [1, 2, 3].forEach((Integer i) -> acc += i) }
> }
> assert Test1.acc == 7
> {code}
> {code}
> java.lang.ExceptionInInitializerError\r\n
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\r\n
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\r\n
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\r\n
>   at java.lang.reflect.Method.invoke(Method.java:498)\r\n
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)