[jira] [Commented] (GROOVY-9548) groovydoc: properties claim to be "private" and don't show annotations

2020-05-23 Thread Jira


[ 
https://issues.apache.org/jira/browse/GROOVY-9548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114700#comment-17114700
 ] 

Mikko Värri commented on GROOVY-9548:
-

Added a PR where we copy the annotations, since connection between property and 
backing field is kind of lost by the time template is rendered.

 

Properties deduced from methods don't have annotations. This seems to be same 
with Groovy 2.5.

> groovydoc: properties claim to be "private" and don't show annotations 
> ---
>
> Key: GROOVY-9548
> URL: https://issues.apache.org/jira/browse/GROOVY-9548
> Project: Groovy
>  Issue Type: Bug
>  Components: GroovyDoc
>Affects Versions: 3.0.3
>Reporter: Mikko Värri
>Priority: Major
> Attachments: groovy-property-2_5_11.png, groovy-property-3_0_3.png
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> In 2.5.11, properties don't have visibility modifiers and the annotations are 
> shown:
> !groovy-property-2_5_11.png!
>  
> In 3.0.3, they are claimed to be private (although, -private groovydoc flag 
> wasn't used) and annotations are missing:
> !groovy-property-3_0_3.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GROOVY-9548) groovydoc: properties claim to be "private" and don't show annotations

2020-05-22 Thread Jira


[ 
https://issues.apache.org/jira/browse/GROOVY-9548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114204#comment-17114204
 ] 

Mikko Värri commented on GROOVY-9548:
-

Created a PR that fixes the visibility modifier.

 

But would it be right to just copy all annotations from the field to the 
property?

 

> groovydoc: properties claim to be "private" and don't show annotations 
> ---
>
> Key: GROOVY-9548
> URL: https://issues.apache.org/jira/browse/GROOVY-9548
> Project: Groovy
>  Issue Type: Bug
>  Components: GroovyDoc
>Affects Versions: 3.0.3
>Reporter: Mikko Värri
>Priority: Major
> Attachments: groovy-property-2_5_11.png, groovy-property-3_0_3.png
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In 2.5.11, properties don't have visibility modifiers and the annotations are 
> shown:
> !groovy-property-2_5_11.png!
>  
> In 3.0.3, they are claimed to be private (although, -private groovydoc flag 
> wasn't used) and annotations are missing:
> !groovy-property-3_0_3.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)