[GitHub] nva commented on a change in pull request #6185: IGNITE-11386 Actualized configuration of local event listeners.

2019-02-26 Thread GitBox
nva commented on a change in pull request #6185: IGNITE-11386 Actualized 
configuration of local event listeners.
URL: https://github.com/apache/ignite/pull/6185#discussion_r260618871
 
 

 ##
 File path: 
modules/web-console/frontend/app/configuration/generator/generator/JavaTransformer.service.js
 ##
 @@ -837,6 +847,18 @@ export default class IgniteJavaTransformer extends 
AbstractTransformer {
 imports.push(`${grp.class}.${grp.value}`);
 });
 
+break;
+
+case 'MAP':
+if (prop.valClsNameShow === 'ARRAY_EVENTS') {
+_.forEach(prop.entries, (lnr) => {
+_.forEach(lnr.eventTypes, (type) => {
+console.log(type);
 
 Review comment:
   console.log should be removed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] nva commented on a change in pull request #6185: IGNITE-11386 Actualized configuration of local event listeners.

2019-02-26 Thread GitBox
nva commented on a change in pull request #6185: IGNITE-11386 Actualized 
configuration of local event listeners.
URL: https://github.com/apache/ignite/pull/6185#discussion_r260619041
 
 

 ##
 File path: 
modules/web-console/frontend/app/configuration/generator/generator/JavaTransformer.service.js
 ##
 @@ -383,6 +383,12 @@ export default class IgniteJavaTransformer extends 
AbstractTransformer {
 static _toObject(clsName, val) {
 const items = _.isArray(val) ? val : [val];
 
+if (clsName === 'ARRAY_EVENTS') {
 
 Review comment:
   Please rename to EVENTS


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] nva commented on a change in pull request #6185: IGNITE-11386 Actualized configuration of local event listeners.

2019-02-26 Thread GitBox
nva commented on a change in pull request #6185: IGNITE-11386 Actualized 
configuration of local event listeners.
URL: https://github.com/apache/ignite/pull/6185#discussion_r260622589
 
 

 ##
 File path: 
modules/web-console/frontend/app/configuration/generator/generator/Beans.js
 ##
 @@ -367,8 +367,11 @@ export class Bean extends EmptyBean {
 keyClsName: dflt.keyClsName,
 keyField: dflt.keyField || 'name',
 valClsName: dflt.valClsName,
+valClsNameShow: dflt.valClsNameShow,
 valField: dflt.valField || 'value',
-entries
+entries,
+keyClsGenericName: dflt.keyClsGenericName,
+keyClsGenericExtends: dflt.keyClsGenericExtends
 
 Review comment:
   ```suggestion
   isKeyClsGenericTypeExtended: dflt.isKeyClsGenericTypeExtended
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] nva commented on a change in pull request #6185: IGNITE-11386 Actualized configuration of local event listeners.

2019-02-26 Thread GitBox
nva commented on a change in pull request #6185: IGNITE-11386 Actualized 
configuration of local event listeners.
URL: https://github.com/apache/ignite/pull/6185#discussion_r260626890
 
 

 ##
 File path: 
modules/web-console/frontend/app/configuration/generator/generator/JavaTransformer.service.js
 ##
 @@ -514,11 +520,12 @@ export default class IgniteJavaTransformer extends 
AbstractTransformer {
 
 static _constructMap(sb, map, vars = []) {
 const keyClsName = this.javaTypes.shortClassName(map.keyClsName);
+const keyClsGeneric = map.keyClsGenericName ? 
`<${map.keyClsGenericExtends ? '? extends ' : 
''}${this.javaTypes.shortClassName(map.keyClsGenericName)}>` : '';
 
 Review comment:
   Please try to simplify this expression, may be will be better to separate 
for two lines or add braces.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] nva commented on a change in pull request #6185: IGNITE-11386 Actualized configuration of local event listeners.

2019-02-26 Thread GitBox
nva commented on a change in pull request #6185: IGNITE-11386 Actualized 
configuration of local event listeners.
URL: https://github.com/apache/ignite/pull/6185#discussion_r260622443
 
 

 ##
 File path: 
modules/web-console/frontend/app/configuration/generator/generator/Beans.js
 ##
 @@ -367,8 +367,11 @@ export class Bean extends EmptyBean {
 keyClsName: dflt.keyClsName,
 keyField: dflt.keyField || 'name',
 valClsName: dflt.valClsName,
+valClsNameShow: dflt.valClsNameShow,
 valField: dflt.valField || 'value',
-entries
+entries,
+keyClsGenericName: dflt.keyClsGenericName,
 
 Review comment:
   ```suggestion
   keyClsGenericType: dflt.keyClsGenericType,
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit closed pull request #6047: IGNITE-11236 DistributedMetaStorage was added to IgniteFeatures.

2019-02-26 Thread GitBox
asfgit closed pull request #6047: IGNITE-11236 DistributedMetaStorage was added 
to IgniteFeatures.
URL: https://github.com/apache/ignite/pull/6047
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit closed pull request #6170: IGNITE-11390 DistributedMetaStorage start is incorrect for in-memory cluster

2019-02-26 Thread GitBox
asfgit closed pull request #6170: IGNITE-11390 DistributedMetaStorage start is 
incorrect for in-memory cluster
URL: https://github.com/apache/ignite/pull/6170
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit closed pull request #6164: IGNITE-10904: [ML] Refactor all examples with regression to use RegressionMetrics

2019-02-26 Thread GitBox
asfgit closed pull request #6164: IGNITE-10904: [ML] Refactor all examples with 
regression to use RegressionMetrics
URL: https://github.com/apache/ignite/pull/6164
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit closed pull request #6164: IGNITE-10904: [ML] Refactor all examples with regression to use RegressionMetrics

2019-02-26 Thread GitBox
asfgit closed pull request #6164: IGNITE-10904: [ML] Refactor all examples with 
regression to use RegressionMetrics
URL: https://github.com/apache/ignite/pull/6164
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit closed pull request #6163: IGNITE-10903: [ML] Provide an example with training of regression model and its evaluation

2019-02-26 Thread GitBox
asfgit closed pull request #6163: IGNITE-10903: [ML] Provide an example with 
training of regression model and its evaluation
URL: https://github.com/apache/ignite/pull/6163
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit closed pull request #6163: IGNITE-10903: [ML] Provide an example with training of regression model and its evaluation

2019-02-26 Thread GitBox
asfgit closed pull request #6163: IGNITE-10903: [ML] Provide an example with 
training of regression model and its evaluation
URL: https://github.com/apache/ignite/pull/6163
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] ibessonov opened a new pull request #6190: IGNITE-11416 DistributedMetaStorage improvements

2019-02-26 Thread GitBox
ibessonov opened a new pull request #6190: IGNITE-11416 DistributedMetaStorage 
improvements
URL: https://github.com/apache/ignite/pull/6190
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] ibessonov opened a new pull request #6190: IGNITE-11416 DistributedMetaStorage improvements

2019-02-26 Thread GitBox
ibessonov opened a new pull request #6190: IGNITE-11416 DistributedMetaStorage 
improvements
URL: https://github.com/apache/ignite/pull/6190
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] usingsky opened a new pull request #6189: IGNITE-11423: Multiple configurations to SpringCacheManager

2019-02-26 Thread GitBox
usingsky opened a new pull request #6189: IGNITE-11423: Multiple configurations 
to SpringCacheManager
URL: https://github.com/apache/ignite/pull/6189
 
 
   When I create SpringCacheManger, the functions that can be applied only to 
each configuration according to the cache name (Eg expire policy)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] usingsky opened a new pull request #6189: IGNITE-11423: Multiple configurations to SpringCacheManager

2019-02-26 Thread GitBox
usingsky opened a new pull request #6189: IGNITE-11423: Multiple configurations 
to SpringCacheManager
URL: https://github.com/apache/ignite/pull/6189
 
 
   When I create SpringCacheManger, the functions that can be applied only to 
each configuration according to the cache name (Eg expire policy)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit closed pull request #6168: IGNITE-6578 Too many diagnostic: Found long running cache future

2019-02-26 Thread GitBox
asfgit closed pull request #6168: IGNITE-6578 Too many diagnostic: Found long 
running cache future
URL: https://github.com/apache/ignite/pull/6168
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit closed pull request #6168: IGNITE-6578 Too many diagnostic: Found long running cache future

2019-02-26 Thread GitBox
asfgit closed pull request #6168: IGNITE-6578 Too many diagnostic: Found long 
running cache future
URL: https://github.com/apache/ignite/pull/6168
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit closed pull request #6015: IGNITE-11050: The map call was moved outside of topology read lock in…

2019-02-26 Thread GitBox
asfgit closed pull request #6015: IGNITE-11050: The map call was moved outside 
of topology read lock in…
URL: https://github.com/apache/ignite/pull/6015
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit closed pull request #6015: IGNITE-11050: The map call was moved outside of topology read lock in…

2019-02-26 Thread GitBox
asfgit closed pull request #6015: IGNITE-11050: The map call was moved outside 
of topology read lock in…
URL: https://github.com/apache/ignite/pull/6015
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] gromtech commented on a change in pull request #6168: IGNITE-6578 Too many diagnostic: Found long running cache future

2019-02-26 Thread GitBox
gromtech commented on a change in pull request #6168: IGNITE-6578 Too many 
diagnostic: Found long running cache future
URL: https://github.com/apache/ignite/pull/6168#discussion_r260274376
 
 

 ##
 File path: 
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCachePartitionExchangeManager.java
 ##
 @@ -1856,14 +1860,17 @@ public void dumpDebugInfo(@Nullable 
GridDhtPartitionsExchangeFuture exchFut) thr
 exchWorker.dumpExchangeDebugInfo();
 
 if (!readyFuts.isEmpty()) {
-U.warn(diagnosticLog, "First 5 pending affinity ready futures 
[total=" + readyFuts.size() + ']');
+int warningsLimit = 
IgniteSystemProperties.getInteger(IGNITE_DIAGNOSTIC_WARN_LIMIT, 5);
+
+U.warn(diagnosticLog, "First " + warningsLimit + " pending 
affinity ready futures [total=" +
+readyFuts.size() + ']');
 
 int cnt = 0;
 
 for (AffinityReadyFuture fut : readyFuts.values()) {
 U.warn(diagnosticLog, ">>> " + fut);
 
-if (++cnt == 5)
+if (++cnt == warningsLimit)
 
 Review comment:
   That's a good point. Fixed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] gromtech commented on a change in pull request #6168: IGNITE-6578 Too many diagnostic: Found long running cache future

2019-02-26 Thread GitBox
gromtech commented on a change in pull request #6168: IGNITE-6578 Too many 
diagnostic: Found long running cache future
URL: https://github.com/apache/ignite/pull/6168#discussion_r260274376
 
 

 ##
 File path: 
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCachePartitionExchangeManager.java
 ##
 @@ -1856,14 +1860,17 @@ public void dumpDebugInfo(@Nullable 
GridDhtPartitionsExchangeFuture exchFut) thr
 exchWorker.dumpExchangeDebugInfo();
 
 if (!readyFuts.isEmpty()) {
-U.warn(diagnosticLog, "First 5 pending affinity ready futures 
[total=" + readyFuts.size() + ']');
+int warningsLimit = 
IgniteSystemProperties.getInteger(IGNITE_DIAGNOSTIC_WARN_LIMIT, 5);
+
+U.warn(diagnosticLog, "First " + warningsLimit + " pending 
affinity ready futures [total=" +
+readyFuts.size() + ']');
 
 int cnt = 0;
 
 for (AffinityReadyFuture fut : readyFuts.values()) {
 U.warn(diagnosticLog, ">>> " + fut);
 
-if (++cnt == 5)
+if (++cnt == warningsLimit)
 
 Review comment:
   That's a good point. Fixed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit closed pull request #6120: IGNITE-11332 Add jmx ability to exclude node from topology.

2019-02-26 Thread GitBox
asfgit closed pull request #6120: IGNITE-11332 Add jmx ability to exclude node 
from topology.
URL: https://github.com/apache/ignite/pull/6120
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit closed pull request #6120: IGNITE-11332 Add jmx ability to exclude node from topology.

2019-02-26 Thread GitBox
asfgit closed pull request #6120: IGNITE-11332 Add jmx ability to exclude node 
from topology.
URL: https://github.com/apache/ignite/pull/6120
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] alamar commented on a change in pull request #6168: IGNITE-6578 Too many diagnostic: Found long running cache future

2019-02-26 Thread GitBox
alamar commented on a change in pull request #6168: IGNITE-6578 Too many 
diagnostic: Found long running cache future
URL: https://github.com/apache/ignite/pull/6168#discussion_r260267244
 
 

 ##
 File path: 
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCachePartitionExchangeManager.java
 ##
 @@ -1856,14 +1860,17 @@ public void dumpDebugInfo(@Nullable 
GridDhtPartitionsExchangeFuture exchFut) thr
 exchWorker.dumpExchangeDebugInfo();
 
 if (!readyFuts.isEmpty()) {
-U.warn(diagnosticLog, "First 5 pending affinity ready futures 
[total=" + readyFuts.size() + ']');
+int warningsLimit = 
IgniteSystemProperties.getInteger(IGNITE_DIAGNOSTIC_WARN_LIMIT, 5);
+
+U.warn(diagnosticLog, "First " + warningsLimit + " pending 
affinity ready futures [total=" +
+readyFuts.size() + ']');
 
 int cnt = 0;
 
 for (AffinityReadyFuture fut : readyFuts.values()) {
 U.warn(diagnosticLog, ">>> " + fut);
 
-if (++cnt == 5)
+if (++cnt == warningsLimit)
 
 Review comment:
   It looks like we can't have IGNITE_DIAGNOSTIC_WARN_LIMIT = 0 since at least 
one message will always be printed. Can we move this check up (while avoiding 
off-by-one error) so that we could completely disable those messages with 
IGNITE_DIAGNOSTIC_WARN_LIMIT=0? Here and below, everywhere where it is checked.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] alamar commented on a change in pull request #6168: IGNITE-6578 Too many diagnostic: Found long running cache future

2019-02-26 Thread GitBox
alamar commented on a change in pull request #6168: IGNITE-6578 Too many 
diagnostic: Found long running cache future
URL: https://github.com/apache/ignite/pull/6168#discussion_r260267244
 
 

 ##
 File path: 
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCachePartitionExchangeManager.java
 ##
 @@ -1856,14 +1860,17 @@ public void dumpDebugInfo(@Nullable 
GridDhtPartitionsExchangeFuture exchFut) thr
 exchWorker.dumpExchangeDebugInfo();
 
 if (!readyFuts.isEmpty()) {
-U.warn(diagnosticLog, "First 5 pending affinity ready futures 
[total=" + readyFuts.size() + ']');
+int warningsLimit = 
IgniteSystemProperties.getInteger(IGNITE_DIAGNOSTIC_WARN_LIMIT, 5);
+
+U.warn(diagnosticLog, "First " + warningsLimit + " pending 
affinity ready futures [total=" +
+readyFuts.size() + ']');
 
 int cnt = 0;
 
 for (AffinityReadyFuture fut : readyFuts.values()) {
 U.warn(diagnosticLog, ">>> " + fut);
 
-if (++cnt == 5)
+if (++cnt == warningsLimit)
 
 Review comment:
   It looks like we can't have IGNITE_DIAGNOSTIC_WARN_LIMIT = 0 since at least 
one message will always be printed. Can we move this check up (while avoiding 
off-by-one error) so that we could completely disable those messages with 
IGNITE_DIAGNOSTIC_WARN_LIMIT=0? Here and below, everywhere where it is checked.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit closed pull request #6057: IGNITE-11171 Race on tx prepare/lock/rollback

2019-02-26 Thread GitBox
asfgit closed pull request #6057: IGNITE-11171 Race on tx prepare/lock/rollback
URL: https://github.com/apache/ignite/pull/6057
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit closed pull request #6057: IGNITE-11171 Race on tx prepare/lock/rollback

2019-02-26 Thread GitBox
asfgit closed pull request #6057: IGNITE-11171 Race on tx prepare/lock/rollback
URL: https://github.com/apache/ignite/pull/6057
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] gromtech commented on a change in pull request #6168: IGNITE-6578 Too many diagnostic: Found long running cache future

2019-02-26 Thread GitBox
gromtech commented on a change in pull request #6168: IGNITE-6578 Too many 
diagnostic: Found long running cache future
URL: https://github.com/apache/ignite/pull/6168#discussion_r260257559
 
 

 ##
 File path: 
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCachePartitionExchangeManager.java
 ##
 @@ -3366,4 +3396,99 @@ private AffinityReadyFuture(AffinityTopologyVersion 
topVer) {
 return S.toString(AffinityReadyFuture.class, this, 
super.toString());
 }
 }
+
+/**
+ * Class to print only limited number of warnings.
+ */
+private static class WarningsGroup {
+/** */
+private final IgniteLogger log;
+
+/** */
+private final int warningsLimit;
+
+/** */
+private List messages;
+
+/** */
+private int warningsTotal;
+
+/**
+ * @param log Target logger.
+ * @param warningsLimit Warnings limit.
+ */
+private WarningsGroup(IgniteLogger log, int warningsLimit) {
+this.log = log;
+
+this.warningsLimit = warningsLimit;
+}
+
+/**
+ * @param msg Warning message.
+ * @return {@code true} if message is added to list.
+ */
+private boolean add(String msg) {
+boolean added = false;
+
+if (canAddMessage()) {
+if (messages == null)
+messages = new ArrayList<>(warningsLimit);
+
+messages.add(msg);
+
+added = true;
+}
+
+warningsTotal++;
+
+return added;
+}
+
+/**
+ * @return {@code true} if messages list size less than limit.
+ */
+private boolean canAddMessage() {
+return warningsTotal < warningsLimit;
+}
+
+/**
+ * Increase total number of warnings.
+ */
+private void incTotal() {
+warningsTotal++;
+}
+
+/**
+ * Print warnings block title and messages.
+ *
+ * @param title Title template.
+ */
+private void flush(String title) {
 
 Review comment:
   Done


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] gromtech commented on a change in pull request #6168: IGNITE-6578 Too many diagnostic: Found long running cache future

2019-02-26 Thread GitBox
gromtech commented on a change in pull request #6168: IGNITE-6578 Too many 
diagnostic: Found long running cache future
URL: https://github.com/apache/ignite/pull/6168#discussion_r260257559
 
 

 ##
 File path: 
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCachePartitionExchangeManager.java
 ##
 @@ -3366,4 +3396,99 @@ private AffinityReadyFuture(AffinityTopologyVersion 
topVer) {
 return S.toString(AffinityReadyFuture.class, this, 
super.toString());
 }
 }
+
+/**
+ * Class to print only limited number of warnings.
+ */
+private static class WarningsGroup {
+/** */
+private final IgniteLogger log;
+
+/** */
+private final int warningsLimit;
+
+/** */
+private List messages;
+
+/** */
+private int warningsTotal;
+
+/**
+ * @param log Target logger.
+ * @param warningsLimit Warnings limit.
+ */
+private WarningsGroup(IgniteLogger log, int warningsLimit) {
+this.log = log;
+
+this.warningsLimit = warningsLimit;
+}
+
+/**
+ * @param msg Warning message.
+ * @return {@code true} if message is added to list.
+ */
+private boolean add(String msg) {
+boolean added = false;
+
+if (canAddMessage()) {
+if (messages == null)
+messages = new ArrayList<>(warningsLimit);
+
+messages.add(msg);
+
+added = true;
+}
+
+warningsTotal++;
+
+return added;
+}
+
+/**
+ * @return {@code true} if messages list size less than limit.
+ */
+private boolean canAddMessage() {
+return warningsTotal < warningsLimit;
+}
+
+/**
+ * Increase total number of warnings.
+ */
+private void incTotal() {
+warningsTotal++;
+}
+
+/**
+ * Print warnings block title and messages.
+ *
+ * @param title Title template.
+ */
+private void flush(String title) {
 
 Review comment:
   Done


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] gromtech commented on a change in pull request #6168: IGNITE-6578 Too many diagnostic: Found long running cache future

2019-02-26 Thread GitBox
gromtech commented on a change in pull request #6168: IGNITE-6578 Too many 
diagnostic: Found long running cache future
URL: https://github.com/apache/ignite/pull/6168#discussion_r260257526
 
 

 ##
 File path: 
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCachePartitionExchangeManager.java
 ##
 @@ -1936,40 +1944,62 @@ private boolean dumpLongRunningOperations0(long 
timeout) {
 new IgniteDiagnosticPrepareContext(cctx.localNodeId()) : null;
 
 if (tm != null) {
+WarningsGroup warnings = new WarningsGroup(diagnosticLog, 
DIAGNOSTIC_WARN_LIMIT);
+
 for (IgniteInternalTx tx : tm.activeTransactions()) {
 if (curTime - tx.startTime() > timeout) {
 found = true;
 
-U.warn(diagnosticLog, "Found long running transaction 
[startTime=" + formatTime(tx.startTime()) +
-", curTime=" + formatTime(curTime) + ", tx=" + tx + 
']');
+if (warnings.canAddMessage()) {
+warnings.add(">>> Transaction [startTime=" + 
formatTime(tx.startTime()) +
+", curTime=" + formatTime(curTime) + ", tx=" + tx 
+ ']');
+}
+else
+warnings.incTotal();
 }
 }
+
+warnings.flush("First %d long running transactions [total=%d]");
 }
 
 if (mvcc != null) {
+WarningsGroup warnings = new WarningsGroup(diagnosticLog, 
DIAGNOSTIC_WARN_LIMIT);
+
 for (GridCacheFuture fut : mvcc.activeFutures()) {
 if (curTime - fut.startTime() > timeout) {
 found = true;
 
-U.warn(diagnosticLog, "Found long running cache future 
[startTime=" + formatTime(fut.startTime()) +
-", curTime=" + formatTime(curTime) + ", fut=" + fut + 
']');
+if (warnings.canAddMessage()) {
+warnings.add(">>> Future [startTime=" + 
formatTime(fut.startTime()) +
+", curTime=" + formatTime(curTime) + ", fut=" + 
fut + ']');
+}
+else
+warnings.incTotal();
 
 if (diagCtx != null && fut instanceof 
IgniteDiagnosticAware)
 
((IgniteDiagnosticAware)fut).addDiagnosticRequest(diagCtx);
 }
 }
 
+warnings.flush("First %d long running cache futures [total=%d]", 
true);
 
 Review comment:
   Done


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] gromtech commented on a change in pull request #6168: IGNITE-6578 Too many diagnostic: Found long running cache future

2019-02-26 Thread GitBox
gromtech commented on a change in pull request #6168: IGNITE-6578 Too many 
diagnostic: Found long running cache future
URL: https://github.com/apache/ignite/pull/6168#discussion_r260257526
 
 

 ##
 File path: 
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCachePartitionExchangeManager.java
 ##
 @@ -1936,40 +1944,62 @@ private boolean dumpLongRunningOperations0(long 
timeout) {
 new IgniteDiagnosticPrepareContext(cctx.localNodeId()) : null;
 
 if (tm != null) {
+WarningsGroup warnings = new WarningsGroup(diagnosticLog, 
DIAGNOSTIC_WARN_LIMIT);
+
 for (IgniteInternalTx tx : tm.activeTransactions()) {
 if (curTime - tx.startTime() > timeout) {
 found = true;
 
-U.warn(diagnosticLog, "Found long running transaction 
[startTime=" + formatTime(tx.startTime()) +
-", curTime=" + formatTime(curTime) + ", tx=" + tx + 
']');
+if (warnings.canAddMessage()) {
+warnings.add(">>> Transaction [startTime=" + 
formatTime(tx.startTime()) +
+", curTime=" + formatTime(curTime) + ", tx=" + tx 
+ ']');
+}
+else
+warnings.incTotal();
 }
 }
+
+warnings.flush("First %d long running transactions [total=%d]");
 }
 
 if (mvcc != null) {
+WarningsGroup warnings = new WarningsGroup(diagnosticLog, 
DIAGNOSTIC_WARN_LIMIT);
+
 for (GridCacheFuture fut : mvcc.activeFutures()) {
 if (curTime - fut.startTime() > timeout) {
 found = true;
 
-U.warn(diagnosticLog, "Found long running cache future 
[startTime=" + formatTime(fut.startTime()) +
-", curTime=" + formatTime(curTime) + ", fut=" + fut + 
']');
+if (warnings.canAddMessage()) {
+warnings.add(">>> Future [startTime=" + 
formatTime(fut.startTime()) +
+", curTime=" + formatTime(curTime) + ", fut=" + 
fut + ']');
+}
+else
+warnings.incTotal();
 
 if (diagCtx != null && fut instanceof 
IgniteDiagnosticAware)
 
((IgniteDiagnosticAware)fut).addDiagnosticRequest(diagCtx);
 }
 }
 
+warnings.flush("First %d long running cache futures [total=%d]", 
true);
 
 Review comment:
   Done


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit closed pull request #6149: IGNITE-11333 SQL: Deprecate H2 console

2019-02-26 Thread GitBox
asfgit closed pull request #6149: IGNITE-11333 SQL: Deprecate H2 console
URL: https://github.com/apache/ignite/pull/6149
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit closed pull request #6149: IGNITE-11333 SQL: Deprecate H2 console

2019-02-26 Thread GitBox
asfgit closed pull request #6149: IGNITE-11333 SQL: Deprecate H2 console
URL: https://github.com/apache/ignite/pull/6149
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] agoncharuk opened a new pull request #6188: Ignite-2.7-10898

2019-02-26 Thread GitBox
agoncharuk opened a new pull request #6188: Ignite-2.7-10898
URL: https://github.com/apache/ignite/pull/6188
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] agoncharuk opened a new pull request #6187: Ignite 2.5-10898

2019-02-26 Thread GitBox
agoncharuk opened a new pull request #6187: Ignite 2.5-10898
URL: https://github.com/apache/ignite/pull/6187
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] alamar commented on a change in pull request #6168: IGNITE-6578 Too many diagnostic: Found long running cache future

2019-02-26 Thread GitBox
alamar commented on a change in pull request #6168: IGNITE-6578 Too many 
diagnostic: Found long running cache future
URL: https://github.com/apache/ignite/pull/6168#discussion_r260224384
 
 

 ##
 File path: 
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCachePartitionExchangeManager.java
 ##
 @@ -1936,40 +1944,62 @@ private boolean dumpLongRunningOperations0(long 
timeout) {
 new IgniteDiagnosticPrepareContext(cctx.localNodeId()) : null;
 
 if (tm != null) {
+WarningsGroup warnings = new WarningsGroup(diagnosticLog, 
DIAGNOSTIC_WARN_LIMIT);
+
 for (IgniteInternalTx tx : tm.activeTransactions()) {
 if (curTime - tx.startTime() > timeout) {
 found = true;
 
-U.warn(diagnosticLog, "Found long running transaction 
[startTime=" + formatTime(tx.startTime()) +
-", curTime=" + formatTime(curTime) + ", tx=" + tx + 
']');
+if (warnings.canAddMessage()) {
+warnings.add(">>> Transaction [startTime=" + 
formatTime(tx.startTime()) +
+", curTime=" + formatTime(curTime) + ", tx=" + tx 
+ ']');
+}
+else
+warnings.incTotal();
 }
 }
+
+warnings.flush("First %d long running transactions [total=%d]");
 }
 
 if (mvcc != null) {
+WarningsGroup warnings = new WarningsGroup(diagnosticLog, 
DIAGNOSTIC_WARN_LIMIT);
+
 for (GridCacheFuture fut : mvcc.activeFutures()) {
 if (curTime - fut.startTime() > timeout) {
 found = true;
 
-U.warn(diagnosticLog, "Found long running cache future 
[startTime=" + formatTime(fut.startTime()) +
-", curTime=" + formatTime(curTime) + ", fut=" + fut + 
']');
+if (warnings.canAddMessage()) {
+warnings.add(">>> Future [startTime=" + 
formatTime(fut.startTime()) +
+", curTime=" + formatTime(curTime) + ", fut=" + 
fut + ']');
+}
+else
+warnings.incTotal();
 
 if (diagCtx != null && fut instanceof 
IgniteDiagnosticAware)
 
((IgniteDiagnosticAware)fut).addDiagnosticRequest(diagCtx);
 }
 }
 
+warnings.flush("First %d long running cache futures [total=%d]", 
true);
 
 Review comment:
   My suggestion is to have two Warnings instances 
activeWarnings/atomicWarnings instead, removing the need of clear=true.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] alamar commented on a change in pull request #6168: IGNITE-6578 Too many diagnostic: Found long running cache future

2019-02-26 Thread GitBox
alamar commented on a change in pull request #6168: IGNITE-6578 Too many 
diagnostic: Found long running cache future
URL: https://github.com/apache/ignite/pull/6168#discussion_r260224635
 
 

 ##
 File path: 
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCachePartitionExchangeManager.java
 ##
 @@ -3366,4 +3396,99 @@ private AffinityReadyFuture(AffinityTopologyVersion 
topVer) {
 return S.toString(AffinityReadyFuture.class, this, 
super.toString());
 }
 }
+
+/**
+ * Class to print only limited number of warnings.
+ */
+private static class WarningsGroup {
+/** */
+private final IgniteLogger log;
+
+/** */
+private final int warningsLimit;
+
+/** */
+private List messages;
+
+/** */
+private int warningsTotal;
+
+/**
+ * @param log Target logger.
+ * @param warningsLimit Warnings limit.
+ */
+private WarningsGroup(IgniteLogger log, int warningsLimit) {
+this.log = log;
+
+this.warningsLimit = warningsLimit;
+}
+
+/**
+ * @param msg Warning message.
+ * @return {@code true} if message is added to list.
+ */
+private boolean add(String msg) {
+boolean added = false;
+
+if (canAddMessage()) {
+if (messages == null)
+messages = new ArrayList<>(warningsLimit);
+
+messages.add(msg);
+
+added = true;
+}
+
+warningsTotal++;
+
+return added;
+}
+
+/**
+ * @return {@code true} if messages list size less than limit.
+ */
+private boolean canAddMessage() {
+return warningsTotal < warningsLimit;
+}
+
+/**
+ * Increase total number of warnings.
+ */
+private void incTotal() {
+warningsTotal++;
+}
+
+/**
+ * Print warnings block title and messages.
+ *
+ * @param title Title template.
+ */
+private void flush(String title) {
 
 Review comment:
   Thus you can only keep one flush() method and simplify it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] alamar commented on a change in pull request #6168: IGNITE-6578 Too many diagnostic: Found long running cache future

2019-02-26 Thread GitBox
alamar commented on a change in pull request #6168: IGNITE-6578 Too many 
diagnostic: Found long running cache future
URL: https://github.com/apache/ignite/pull/6168#discussion_r260224047
 
 

 ##
 File path: 
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCachePartitionExchangeManager.java
 ##
 @@ -153,6 +154,9 @@
 private final long IGNITE_EXCHANGE_MERGE_DELAY =
 
IgniteSystemProperties.getLong(IgniteSystemProperties.IGNITE_EXCHANGE_MERGE_DELAY,
 0);
 
+/** */
+private final int DIAGNOSTIC_WARN_LIMIT = 
IgniteSystemProperties.getInteger(IGNITE_DIAGNOSTIC_WARN_LIMIT, 10);
 
 Review comment:
   Private final fields should not be in ALL_CAPS and should go after private 
static final. My suggestion is to compute it in dumpDebugInfo() every time. We 
are trying to avoid static fields since they have side-effects when running a 
lot of tests (can't change mid-flight).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] agoncharuk opened a new pull request #6186: Ignite-2.4.15 reconnect

2019-02-26 Thread GitBox
agoncharuk opened a new pull request #6186: Ignite-2.4.15 reconnect
URL: https://github.com/apache/ignite/pull/6186
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit closed pull request #6158: IGNITE-6609: Skip expired rows.

2019-02-26 Thread GitBox
asfgit closed pull request #6158: IGNITE-6609: Skip expired rows.
URL: https://github.com/apache/ignite/pull/6158
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit closed pull request #5906: Ignite 2.5.1 p164

2019-02-26 Thread GitBox
asfgit closed pull request #5906: Ignite 2.5.1 p164
URL: https://github.com/apache/ignite/pull/5906
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services