[GitHub] [ignite] zaleslaw commented on issue #6907: IGNITE-11723: IgniteSpark integration should support skipStore option for internal dataStreamer (IgniteRdd and Ignite DataFrame)
zaleslaw commented on issue #6907: IGNITE-11723: IgniteSpark integration should support skipStore option for internal dataStreamer (IgniteRdd and Ignite DataFrame) URL: https://github.com/apache/ignite/pull/6907#issuecomment-536663474 @nizhikov Could you please revisit your review (I've improved formatting and added special test-case for the skipStore enabling behaviour This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] agura closed pull request #6921: IGNITE-12238 Fixed RobinHoodBackwardShiftHashMap bug on big endian architectures
agura closed pull request #6921: IGNITE-12238 Fixed RobinHoodBackwardShiftHashMap bug on big endian architectures URL: https://github.com/apache/ignite/pull/6921 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] agura commented on issue #6921: IGNITE-12238 Fixed RobinHoodBackwardShiftHashMap bug on big endian architectures
agura commented on issue #6921: IGNITE-12238 Fixed RobinHoodBackwardShiftHashMap bug on big endian architectures URL: https://github.com/apache/ignite/pull/6921#issuecomment-536631062 Merged to master branch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] agura commented on issue #6879: IGNITE-12197 Fixed method of getting value of persistent enabled in CacheGroupMetricsImpl
agura commented on issue #6879: IGNITE-12197 Fixed method of getting value of persistent enabled in CacheGroupMetricsImpl URL: https://github.com/apache/ignite/pull/6879#issuecomment-536614070 Merged to master branch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] agura closed pull request #6879: IGNITE-12197 Fixed method of getting value of persistent enabled in CacheGroupMetricsImpl
agura closed pull request #6879: IGNITE-12197 Fixed method of getting value of persistent enabled in CacheGroupMetricsImpl URL: https://github.com/apache/ignite/pull/6879 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] nizhikov opened a new pull request #6927: IGNITE-12212: Cluster nodes system view added.
nizhikov opened a new pull request #6927: IGNITE-12212: Cluster nodes system view added. URL: https://github.com/apache/ignite/pull/6927 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] ptupitsyn merged pull request #6925: IGNITE-12242 .NET: Add tests for Thin Client async continuation behavior
ptupitsyn merged pull request #6925: IGNITE-12242 .NET: Add tests for Thin Client async continuation behavior URL: https://github.com/apache/ignite/pull/6925 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] zaleslaw opened a new pull request #6926: IGNITE-12247: [Spark] Add initial support of Spark 2.4
zaleslaw opened a new pull request #6926: IGNITE-12247: [Spark] Add initial support of Spark 2.4 URL: https://github.com/apache/ignite/pull/6926 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] asfgit closed pull request #6903: IGNITE-12226 Improve BinaryObjectException message.
asfgit closed pull request #6903: IGNITE-12226 Improve BinaryObjectException message. URL: https://github.com/apache/ignite/pull/6903 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] ptupitsyn opened a new pull request #6925: IGNITE-12242 .NET: Add tests for Thin Client async continuation behavior
ptupitsyn opened a new pull request #6925: IGNITE-12242 .NET: Add tests for Thin Client async continuation behavior URL: https://github.com/apache/ignite/pull/6925 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] tledkov-gridgain opened a new pull request #6924: Gg 24457
tledkov-gridgain opened a new pull request #6924: Gg 24457 URL: https://github.com/apache/ignite/pull/6924 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] pavlukhin commented on a change in pull request #6490: IGNITE-7285 Add default query timeout
pavlukhin commented on a change in pull request #6490: IGNITE-7285 Add default
query timeout
URL: https://github.com/apache/ignite/pull/6490#discussion_r329478355
##
File path:
modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/QueryParser.java
##
@@ -134,6 +136,51 @@ public QueryParserResult parse(String schemaName,
SqlFieldsQuery qry, boolean re
return res;
}
+/**
+ * Create parameters from query.
+ *
+ * @param qry Query.
+ * @return Parameters.
+ */
+public QueryParameters queryParameters(SqlFieldsQuery qry) {
+NestedTxMode nestedTxMode = NestedTxMode.DEFAULT;
+boolean autoCommit = true;
+List batchedArgs = null;
+
+if (qry instanceof SqlFieldsQueryEx) {
+SqlFieldsQueryEx qry0 = (SqlFieldsQueryEx)qry;
+
+if (qry0.getNestedTxMode() != null)
+nestedTxMode = qry0.getNestedTxMode();
+
+autoCommit = qry0.isAutoCommit();
+
+batchedArgs = qry0.batchedArguments();
+}
+
+int timeout;
+
+if (qry.getTimeout() >= 0) {
+timeout = qry.getTimeout();
+}
+else {
+timeout =
(int)idx.kernalContext().config().getDefaultQueryTimeout();
+A.ensure(timeout >= 0 && timeout <= Integer.MAX_VALUE, "timeout
value should be valid Integer.");
Review comment:
It seems not valid place for validation. `timeout` has type `int` and will
be definitely in `[0, Integer.MAX_VALUE]` range. I suggest to place validation
inside a `IgniteConfiguration.setDefaultQueryTimeout` method.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] pavlukhin commented on a change in pull request #6490: IGNITE-7285 Add default query timeout
pavlukhin commented on a change in pull request #6490: IGNITE-7285 Add default
query timeout
URL: https://github.com/apache/ignite/pull/6490#discussion_r329477190
##
File path:
modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/QueryParser.java
##
@@ -134,6 +136,51 @@ public QueryParserResult parse(String schemaName,
SqlFieldsQuery qry, boolean re
return res;
}
+/**
+ * Create parameters from query.
+ *
+ * @param qry Query.
+ * @return Parameters.
+ */
+public QueryParameters queryParameters(SqlFieldsQuery qry) {
+NestedTxMode nestedTxMode = NestedTxMode.DEFAULT;
+boolean autoCommit = true;
+List batchedArgs = null;
+
+if (qry instanceof SqlFieldsQueryEx) {
+SqlFieldsQueryEx qry0 = (SqlFieldsQueryEx)qry;
+
+if (qry0.getNestedTxMode() != null)
+nestedTxMode = qry0.getNestedTxMode();
+
+autoCommit = qry0.isAutoCommit();
+
+batchedArgs = qry0.batchedArguments();
+}
+
+int timeout;
+
+if (qry.getTimeout() >= 0) {
Review comment:
Curly braces are redundant according to code style.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] pavlukhin commented on a change in pull request #6490: IGNITE-7285 Add default query timeout
pavlukhin commented on a change in pull request #6490: IGNITE-7285 Add default
query timeout
URL: https://github.com/apache/ignite/pull/6490#discussion_r329473755
##
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/platform/client/cache/ClientCacheSqlFieldsQueryRequest.java
##
@@ -82,8 +82,11 @@ public ClientCacheSqlFieldsQueryRequest(BinaryRawReaderEx
reader) {
.setReplicatedOnly(replicatedOnly)
.setEnforceJoinOrder(enforceJoinOrder)
.setCollocated(collocated)
-.setLazy(lazy)
-.setTimeout(timeout, TimeUnit.MILLISECONDS);
+.setLazy(lazy);
+
+if (timeout >= 0) {
Review comment:
Curly braces are redundant according to code style.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] pavlukhin commented on a change in pull request #6490: IGNITE-7285 Add default query timeout
pavlukhin commented on a change in pull request #6490: IGNITE-7285 Add default
query timeout
URL: https://github.com/apache/ignite/pull/6490#discussion_r329473442
##
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/odbc/OdbcRequestHandler.java
##
@@ -338,9 +338,12 @@ private SqlFieldsQueryEx makeQuery(String schema, String
sql, Object[] args, int
SqlFieldsQueryEx qry = makeQuery(schema, sql);
qry.setArgs(args);
-qry.setTimeout(timeout, TimeUnit.SECONDS);
qry.setAutoCommit(autoCommit);
+if (timeout >= 0) {
Review comment:
Curly braces are redundant according to code style.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] tledkov-gridgain closed pull request #6922: Gg 23157
tledkov-gridgain closed pull request #6922: Gg 23157 URL: https://github.com/apache/ignite/pull/6922 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] nizhikov commented on a change in pull request #6896: IGNITE-12209: Transactions system view.
nizhikov commented on a change in pull request #6896: IGNITE-12209:
Transactions system view.
URL: https://github.com/apache/ignite/pull/6896#discussion_r329435333
##
File path:
modules/core/src/main/java/org/apache/ignite/spi/systemview/view/TransactionView.java
##
@@ -0,0 +1,190 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.spi.systemview.view;
+
+import java.util.Objects;
+import java.util.UUID;
+import org.apache.ignite.internal.managers.systemview.walker.Order;
+import
org.apache.ignite.internal.processors.cache.transactions.IgniteInternalTx;
+import org.apache.ignite.internal.util.GridIntList;
+import org.apache.ignite.internal.util.typedef.internal.SB;
+import org.apache.ignite.internal.util.typedef.internal.U;
+import org.apache.ignite.lang.IgniteUuid;
+import org.apache.ignite.transactions.TransactionConcurrency;
+import org.apache.ignite.transactions.TransactionIsolation;
+import org.apache.ignite.transactions.TransactionState;
+
+/**
+ * Transaction representation for a {@link SystemView}.
+ */
+public class TransactionView {
+/** Transaction. */
+private final IgniteInternalTx tx;
+
+/**
+ * @param tx Transaction.
+ */
+public TransactionView(IgniteInternalTx tx) {
+this.tx = tx;
+}
+
+/** @return Local node ID. */
Review comment:
Fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
