[GitHub] [ignite] asfgit closed pull request #6549: IGNITE-11856 Allow ignite.sh to work when JMX_MON is not set
asfgit closed pull request #6549: IGNITE-11856 Allow ignite.sh to work when JMX_MON is not set URL: https://github.com/apache/ignite/pull/6549 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] asfgit closed pull request #6920: IGNITE-9836 Java version check can now deal with letter suffixes
asfgit closed pull request #6920: IGNITE-9836 Java version check can now deal with letter suffixes URL: https://github.com/apache/ignite/pull/6920 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] xtern closed pull request #6929: IGNITE-12181 Fixed assertion for non-persisted group in PDS enabled cluster.
xtern closed pull request #6929: IGNITE-12181 Fixed assertion for non-persisted group in PDS enabled cluster. URL: https://github.com/apache/ignite/pull/6929 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] xtern opened a new pull request #6929: IGNITE-12181 Fixed assertion for non-persisted group in PDS enabled cluster.
xtern opened a new pull request #6929: IGNITE-12181 Fixed assertion for non-persisted group in PDS enabled cluster. URL: https://github.com/apache/ignite/pull/6929 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] denis-chudov opened a new pull request #6930: IGNITE-2.5.11
denis-chudov opened a new pull request #6930: IGNITE-2.5.11 URL: https://github.com/apache/ignite/pull/6930 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] xtern opened a new pull request #6929: IGNITE-12069 Fixed assertion for non-persisted group in PDS enabled cluster.
xtern opened a new pull request #6929: IGNITE-12069 Fixed assertion for non-persisted group in PDS enabled cluster. URL: https://github.com/apache/ignite/pull/6929 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] asfgit closed pull request #6906: IGNITE-12230 Partition eviction during cache stop / deactivation may …
asfgit closed pull request #6906: IGNITE-12230 Partition eviction during cache stop / deactivation may … URL: https://github.com/apache/ignite/pull/6906 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] ololo3000 commented on a change in pull request #6928: IGNITE-12250 Adds rest requests processing logging.
ololo3000 commented on a change in pull request #6928: IGNITE-12250 Adds rest
requests processing logging.
URL: https://github.com/apache/ignite/pull/6928#discussion_r330087750
##
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/rest/GridRestProcessor.java
##
@@ -1039,6 +1043,30 @@ private void startProtocol(GridRestProtocol proto)
throws IgniteCheckedException
X.println(">>> handlersSize: " + handlers.size());
}
+/**
+ * Logs REST request processing result.
+ *
+ * @param req Received REST request.
+ * @param fut Result of REST request processing.
+ */
+private void logRestRequestResult(GridRestRequest req,
IgniteInternalFuture fut) {
+if (log == null || !log.isDebugEnabled())
Review comment:
My mistake. Ignite log4j logger is used if no specified. Done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] ololo3000 commented on a change in pull request #6928: IGNITE-12250 Adds rest requests processing logging.
ololo3000 commented on a change in pull request #6928: IGNITE-12250 Adds rest
requests processing logging.
URL: https://github.com/apache/ignite/pull/6928#discussion_r330087714
##
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/rest/GridRestProcessor.java
##
@@ -1039,6 +1043,30 @@ private void startProtocol(GridRestProtocol proto)
throws IgniteCheckedException
X.println(">>> handlersSize: " + handlers.size());
}
+/**
+ * Logs REST request processing result.
+ *
+ * @param req Received REST request.
+ * @param fut Result of REST request processing.
+ */
+private void logRestRequestResult(GridRestRequest req,
IgniteInternalFuture fut) {
+if (log == null || !log.isDebugEnabled())
+return;
+
+GridRestResponse resp = null;
+
+IgniteCheckedException reqProcErr = null;
+
+try {
+resp = fut.get();
Review comment:
Done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] nizhikov commented on a change in pull request #6928: IGNITE-12250 Adds rest requests processing logging.
nizhikov commented on a change in pull request #6928: IGNITE-12250 Adds rest
requests processing logging.
URL: https://github.com/apache/ignite/pull/6928#discussion_r330068897
##
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/rest/GridRestProcessor.java
##
@@ -1039,6 +1043,30 @@ private void startProtocol(GridRestProtocol proto)
throws IgniteCheckedException
X.println(">>> handlersSize: " + handlers.size());
}
+/**
+ * Logs REST request processing result.
+ *
+ * @param req Received REST request.
+ * @param fut Result of REST request processing.
+ */
+private void logRestRequestResult(GridRestRequest req,
IgniteInternalFuture fut) {
+if (log == null || !log.isDebugEnabled())
Review comment:
Seems, we can do not register listener in case debug disabled.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] nizhikov commented on a change in pull request #6928: IGNITE-12250 Adds rest requests processing logging.
nizhikov commented on a change in pull request #6928: IGNITE-12250 Adds rest
requests processing logging.
URL: https://github.com/apache/ignite/pull/6928#discussion_r330067247
##
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/rest/GridRestProcessor.java
##
@@ -1039,6 +1043,30 @@ private void startProtocol(GridRestProtocol proto)
throws IgniteCheckedException
X.println(">>> handlersSize: " + handlers.size());
}
+/**
+ * Logs REST request processing result.
+ *
+ * @param req Received REST request.
+ * @param fut Result of REST request processing.
+ */
+private void logRestRequestResult(GridRestRequest req,
IgniteInternalFuture fut) {
+if (log == null || !log.isDebugEnabled())
+return;
+
+GridRestResponse resp = null;
+
+IgniteCheckedException reqProcErr = null;
+
+try {
+resp = fut.get();
Review comment:
Can we use `fut.error() == null` here or `fut.isCancelled()` and not use try
catch logic?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] nizhikov commented on a change in pull request #6928: IGNITE-12250 Adds rest requests processing logging.
nizhikov commented on a change in pull request #6928: IGNITE-12250 Adds rest
requests processing logging.
URL: https://github.com/apache/ignite/pull/6928#discussion_r330066102
##
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/rest/GridRestProcessor.java
##
@@ -1039,6 +1043,30 @@ private void startProtocol(GridRestProtocol proto)
throws IgniteCheckedException
X.println(">>> handlersSize: " + handlers.size());
}
+/**
+ * Logs REST request processing result.
+ *
+ * @param req Received REST request.
+ * @param fut Result of REST request processing.
+ */
+private void logRestRequestResult(GridRestRequest req,
IgniteInternalFuture fut) {
+if (log == null || !log.isDebugEnabled())
Review comment:
When log may be null?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] nizhikov commented on a change in pull request #6928: IGNITE-12250 Adds rest requests processing logging.
nizhikov commented on a change in pull request #6928: IGNITE-12250 Adds rest
requests processing logging.
URL: https://github.com/apache/ignite/pull/6928#discussion_r330065837
##
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/rest/GridRestProcessor.java
##
@@ -150,7 +150,11 @@
}
@Override public IgniteInternalFuture
handleAsync(GridRestRequest req) {
-return handleAsync0(req);
+IgniteInternalFuture res = handleAsync0(req);
+
+res.listen(fut -> logRestRequestResult(req, fut));
Review comment:
```
res.listen(fut -> {
});
```
Why this wouldn't work?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] nizhikov commented on a change in pull request #6928: IGNITE-12250 Adds rest requests processing logging.
nizhikov commented on a change in pull request #6928: IGNITE-12250 Adds rest
requests processing logging.
URL: https://github.com/apache/ignite/pull/6928#discussion_r330065837
##
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/rest/GridRestProcessor.java
##
@@ -150,7 +150,11 @@
}
@Override public IgniteInternalFuture
handleAsync(GridRestRequest req) {
-return handleAsync0(req);
+IgniteInternalFuture res = handleAsync0(req);
+
+res.listen(fut -> logRestRequestResult(req, fut));
Review comment:
```
res.listen(fuct -> {
});
```
Why this wouldn't work?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] ololo3000 commented on a change in pull request #6928: IGNITE-12250 Adds rest requests processing logging.
ololo3000 commented on a change in pull request #6928: IGNITE-12250 Adds rest
requests processing logging.
URL: https://github.com/apache/ignite/pull/6928#discussion_r330064260
##
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/rest/GridRestProcessor.java
##
@@ -1039,6 +1043,30 @@ private void startProtocol(GridRestProtocol proto)
throws IgniteCheckedException
X.println(">>> handlersSize: " + handlers.size());
}
+/**
+ * Logs REST request processing result.
+ *
+ * @param req Received REST request.
+ * @param fut Result of REST request processing.
+ */
+private void logRestRequestResult(GridRestRequest req,
IgniteInternalFuture fut) {
+if (log == null || !log.isInfoEnabled())
+return;
+
+GridRestResponse resp = null;
+
+IgniteCheckedException reqProcErr = null;
+
+try {
+resp = fut.get();
+}
+catch (IgniteCheckedException e) {
+reqProcErr = e;
+}
+
+log.info(String.format("REST request handled [req=%s, resp=%s,
err=%s].", req, resp, reqProcErr));
Review comment:
Done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] ololo3000 commented on a change in pull request #6928: IGNITE-12250 Adds rest requests processing logging.
ololo3000 commented on a change in pull request #6928: IGNITE-12250 Adds rest
requests processing logging.
URL: https://github.com/apache/ignite/pull/6928#discussion_r330063254
##
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/rest/GridRestProcessor.java
##
@@ -150,7 +150,11 @@
}
@Override public IgniteInternalFuture
handleAsync(GridRestRequest req) {
-return handleAsync0(req);
+IgniteInternalFuture res = handleAsync0(req);
+
+res.listen(fut -> logRestRequestResult(req, fut));
Review comment:
No, we can't. We need GridRestRequest to be logged and IgniteInternalFuture
result doesn't provide it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] zaleslaw commented on issue #6909: IGNITE-12054: Upgrade Spark module to 2.4
zaleslaw commented on issue #6909: IGNITE-12054: Upgrade Spark module to 2.4 URL: https://github.com/apache/ignite/pull/6909#issuecomment-537039949 This is an experimental PR, it shouldn't be merged, but it needs for review purposes This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] zaleslaw commented on issue #6907: IGNITE-11723: IgniteSpark integration should support skipStore option for internal dataStreamer (IgniteRdd and Ignite DataFrame)
zaleslaw commented on issue #6907: IGNITE-11723: IgniteSpark integration should support skipStore option for internal dataStreamer (IgniteRdd and Ignite DataFrame) URL: https://github.com/apache/ignite/pull/6907#issuecomment-537038432 @nizhikov Thanks a lot, will run all required suites This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] nizhikov commented on a change in pull request #6928: IGNITE-12250 Adds rest requests processing logging.
nizhikov commented on a change in pull request #6928: IGNITE-12250 Adds rest
requests processing logging.
URL: https://github.com/apache/ignite/pull/6928#discussion_r330055253
##
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/rest/GridRestProcessor.java
##
@@ -1039,6 +1043,30 @@ private void startProtocol(GridRestProtocol proto)
throws IgniteCheckedException
X.println(">>> handlersSize: " + handlers.size());
}
+/**
+ * Logs REST request processing result.
+ *
+ * @param req Received REST request.
+ * @param fut Result of REST request processing.
+ */
+private void logRestRequestResult(GridRestRequest req,
IgniteInternalFuture fut) {
+if (log == null || !log.isInfoEnabled())
+return;
+
+GridRestResponse resp = null;
+
+IgniteCheckedException reqProcErr = null;
+
+try {
+resp = fut.get();
+}
+catch (IgniteCheckedException e) {
+reqProcErr = e;
+}
+
+log.info(String.format("REST request handled [req=%s, resp=%s,
err=%s].", req, resp, reqProcErr));
Review comment:
Why do we need `info` level here? I think every parameter of every request
should be on `debug` or even `trace` level.
You need use `if (log.isDebugEnabled())` to pervent unnecessary string
construction when log turned off.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] nizhikov commented on a change in pull request #6928: IGNITE-12250 Adds rest requests processing logging.
nizhikov commented on a change in pull request #6928: IGNITE-12250 Adds rest
requests processing logging.
URL: https://github.com/apache/ignite/pull/6928#discussion_r330055253
##
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/rest/GridRestProcessor.java
##
@@ -1039,6 +1043,30 @@ private void startProtocol(GridRestProtocol proto)
throws IgniteCheckedException
X.println(">>> handlersSize: " + handlers.size());
}
+/**
+ * Logs REST request processing result.
+ *
+ * @param req Received REST request.
+ * @param fut Result of REST request processing.
+ */
+private void logRestRequestResult(GridRestRequest req,
IgniteInternalFuture fut) {
+if (log == null || !log.isInfoEnabled())
+return;
+
+GridRestResponse resp = null;
+
+IgniteCheckedException reqProcErr = null;
+
+try {
+resp = fut.get();
+}
+catch (IgniteCheckedException e) {
+reqProcErr = e;
+}
+
+log.info(String.format("REST request handled [req=%s, resp=%s,
err=%s].", req, resp, reqProcErr));
Review comment:
Why do we need `info` level here? I think every parameter of every request
should be on `debug` or even `trace` level.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] nizhikov commented on a change in pull request #6928: IGNITE-12250 Adds rest requests processing logging.
nizhikov commented on a change in pull request #6928: IGNITE-12250 Adds rest
requests processing logging.
URL: https://github.com/apache/ignite/pull/6928#discussion_r330046163
##
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/rest/GridRestProcessor.java
##
@@ -150,7 +150,11 @@
}
@Override public IgniteInternalFuture
handleAsync(GridRestRequest req) {
-return handleAsync0(req);
+IgniteInternalFuture res = handleAsync0(req);
+
+res.listen(fut -> logRestRequestResult(req, fut));
Review comment:
Can we use closure here?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] nizhikov commented on issue #6907: IGNITE-11723: IgniteSpark integration should support skipStore option for internal dataStreamer (IgniteRdd and Ignite DataFrame)
nizhikov commented on issue #6907: IGNITE-11723: IgniteSpark integration should support skipStore option for internal dataStreamer (IgniteRdd and Ignite DataFrame) URL: https://github.com/apache/ignite/pull/6907#issuecomment-537004319 @zaleslaw LGTM, except for a couple of nits I mentioned in comments. We should run at least `Spark RDD` and `Examples` suites to test this patch. Please, check suites still succeed before the merge. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] nizhikov commented on a change in pull request #6907: IGNITE-11723: IgniteSpark integration should support skipStore option for internal dataStreamer (IgniteRdd and Ignite DataFrame)
nizhikov commented on a change in pull request #6907: IGNITE-11723: IgniteSpark integration should support skipStore option for internal dataStreamer (IgniteRdd and Ignite DataFrame) URL: https://github.com/apache/ignite/pull/6907#discussion_r330017134 ## File path: modules/spark/src/test/java/org/apache/ignite/spark/JavaEmbeddedIgniteRDDSelfTest.java ## @@ -335,4 +412,25 @@ private static IgniteConfiguration getConfiguration(String igniteInstanceName, b return t._2(); } } + +/** + * Review comment: Nit: We should write a javadoc here or replace it with the 1 line stub `/** */` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] nizhikov commented on a change in pull request #6907: IGNITE-11723: IgniteSpark integration should support skipStore option for internal dataStreamer (IgniteRdd and Ignite DataFrame)
nizhikov commented on a change in pull request #6907: IGNITE-11723: IgniteSpark
integration should support skipStore option for internal dataStreamer
(IgniteRdd and Ignite DataFrame)
URL: https://github.com/apache/ignite/pull/6907#discussion_r330016627
##
File path:
modules/spark/src/test/java/org/apache/ignite/spark/JavaEmbeddedIgniteRDDSelfTest.java
##
@@ -150,6 +169,59 @@ public void testStoreDataToIgnite() throws Exception {
}
}
+/**
+ * @throws Exception If failed.
+ */
+@Test
+public void testStoreDataToIgniteWithEnabledOptionSkipStore() throws
Exception {
+storeMap = new ConcurrentHashMap<>();
+store = new TestStore();
+
+JavaSparkContext sc = createContext();
+
+JavaIgniteContext ic = null;
+
+try {
+ic = new JavaIgniteContext<>(sc, new IgniteConfigProvider(),
false);
+
+Ignite ignite = ic.ignite();
+
+IgniteCache cache =
ignite.cache(PARTITIONED_CACHE_NAME);
+
+// 1000 entries in store; 1000 entries in cache
+for (int i = 0; i < 1000; i++)
+storeMap.put(i, i);
+
+// 1000 entries in store and cache; 1000 another entries in cache
writing to store
+ic.fromCache(PARTITIONED_CACHE_NAME)
+.savePairs(sc.parallelize(F.range(1000, 2000),
GRID_CNT).mapToPair(SIMPLE_FUNCTION), true, false);
+
+// check 2000 entries in store
+for (int i = 0; i < 2000; i++)
+assertEquals(i, storeMap.get(i));
+
+// add 1000 entries to cache but skip store
Review comment:
Nit: The sentence should start with the capital letter and ends with the dot.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] nizhikov commented on a change in pull request #6907: IGNITE-11723: IgniteSpark integration should support skipStore option for internal dataStreamer (IgniteRdd and Ignite DataFrame)
nizhikov commented on a change in pull request #6907: IGNITE-11723: IgniteSpark
integration should support skipStore option for internal dataStreamer
(IgniteRdd and Ignite DataFrame)
URL: https://github.com/apache/ignite/pull/6907#discussion_r330016504
##
File path:
modules/spark/src/test/java/org/apache/ignite/spark/JavaEmbeddedIgniteRDDSelfTest.java
##
@@ -150,6 +169,59 @@ public void testStoreDataToIgnite() throws Exception {
}
}
+/**
+ * @throws Exception If failed.
+ */
+@Test
+public void testStoreDataToIgniteWithEnabledOptionSkipStore() throws
Exception {
+storeMap = new ConcurrentHashMap<>();
+store = new TestStore();
+
+JavaSparkContext sc = createContext();
+
+JavaIgniteContext ic = null;
+
+try {
+ic = new JavaIgniteContext<>(sc, new IgniteConfigProvider(),
false);
+
+Ignite ignite = ic.ignite();
+
+IgniteCache cache =
ignite.cache(PARTITIONED_CACHE_NAME);
+
+// 1000 entries in store; 1000 entries in cache
+for (int i = 0; i < 1000; i++)
+storeMap.put(i, i);
+
+// 1000 entries in store and cache; 1000 another entries in cache
writing to store
Review comment:
Nit: The sentence should start with the capital letter and ends with the dot.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] nizhikov commented on a change in pull request #6907: IGNITE-11723: IgniteSpark integration should support skipStore option for internal dataStreamer (IgniteRdd and Ignite DataFrame)
nizhikov commented on a change in pull request #6907: IGNITE-11723: IgniteSpark
integration should support skipStore option for internal dataStreamer
(IgniteRdd and Ignite DataFrame)
URL: https://github.com/apache/ignite/pull/6907#discussion_r330016470
##
File path:
modules/spark/src/test/java/org/apache/ignite/spark/JavaEmbeddedIgniteRDDSelfTest.java
##
@@ -150,6 +169,59 @@ public void testStoreDataToIgnite() throws Exception {
}
}
+/**
+ * @throws Exception If failed.
+ */
+@Test
+public void testStoreDataToIgniteWithEnabledOptionSkipStore() throws
Exception {
+storeMap = new ConcurrentHashMap<>();
+store = new TestStore();
+
+JavaSparkContext sc = createContext();
+
+JavaIgniteContext ic = null;
+
+try {
+ic = new JavaIgniteContext<>(sc, new IgniteConfigProvider(),
false);
+
+Ignite ignite = ic.ignite();
+
+IgniteCache cache =
ignite.cache(PARTITIONED_CACHE_NAME);
+
+// 1000 entries in store; 1000 entries in cache
+for (int i = 0; i < 1000; i++)
+storeMap.put(i, i);
+
+// 1000 entries in store and cache; 1000 another entries in cache
writing to store
+ic.fromCache(PARTITIONED_CACHE_NAME)
+.savePairs(sc.parallelize(F.range(1000, 2000),
GRID_CNT).mapToPair(SIMPLE_FUNCTION), true, false);
+
+// check 2000 entries in store
Review comment:
Nit: The sentence should start with the capital letter and ends with the dot.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] nizhikov commented on a change in pull request #6907: IGNITE-11723: IgniteSpark integration should support skipStore option for internal dataStreamer (IgniteRdd and Ignite DataFrame)
nizhikov commented on a change in pull request #6907: IGNITE-11723: IgniteSpark
integration should support skipStore option for internal dataStreamer
(IgniteRdd and Ignite DataFrame)
URL: https://github.com/apache/ignite/pull/6907#discussion_r330016533
##
File path:
modules/spark/src/test/java/org/apache/ignite/spark/JavaEmbeddedIgniteRDDSelfTest.java
##
@@ -150,6 +169,59 @@ public void testStoreDataToIgnite() throws Exception {
}
}
+/**
+ * @throws Exception If failed.
+ */
+@Test
+public void testStoreDataToIgniteWithEnabledOptionSkipStore() throws
Exception {
+storeMap = new ConcurrentHashMap<>();
+store = new TestStore();
+
+JavaSparkContext sc = createContext();
+
+JavaIgniteContext ic = null;
+
+try {
+ic = new JavaIgniteContext<>(sc, new IgniteConfigProvider(),
false);
+
+Ignite ignite = ic.ignite();
+
+IgniteCache cache =
ignite.cache(PARTITIONED_CACHE_NAME);
+
+// 1000 entries in store; 1000 entries in cache
Review comment:
Nit: The sentence should start with the capital letter and ends with the dot.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] tledkov-gridgain closed pull request #6924: Gg 24457
tledkov-gridgain closed pull request #6924: Gg 24457 URL: https://github.com/apache/ignite/pull/6924 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] ololo3000 opened a new pull request #6928: IGNITE-12250 Adds rest requests processing logging.
ololo3000 opened a new pull request #6928: IGNITE-12250 Adds rest requests processing logging. URL: https://github.com/apache/ignite/pull/6928 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] nizhikov closed pull request #6790: IGNITE-11905: Monitoring lists.
nizhikov closed pull request #6790: IGNITE-11905: Monitoring lists. URL: https://github.com/apache/ignite/pull/6790 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] nizhikov merged pull request #6896: IGNITE-12209: Transactions system view.
nizhikov merged pull request #6896: IGNITE-12209: Transactions system view. URL: https://github.com/apache/ignite/pull/6896 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
