[GitHub] [ignite] sk0x50 opened a new pull request #7534: IGNITE-12766 Added GridCacheProcessor.LocalAffinityFunction for backw…
sk0x50 opened a new pull request #7534: IGNITE-12766 Added GridCacheProcessor.LocalAffinityFunction for backw… URL: https://github.com/apache/ignite/pull/7534 …ard compatilility. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] Vladsz83 opened a new pull request #7533: IGNITE-12779 : Split implementations of Ignite and IgniteMXBean, make behavior of their active(boolean) different.
Vladsz83 opened a new pull request #7533: IGNITE-12779 : Split implementations
of Ignite and IgniteMXBean, make behavior of their active(boolean) different.
URL: https://github.com/apache/ignite/pull/7533
Behavior changes:
_IgniteMXBean.active(false)_ and _IgniteMXBean.state("inactive")_ fail if
deactivation would clear in-memory data.
Major code changes:
1) Implementation of _IgniteMXBean_ detached from _IgniteKernal_ and storead
as its subclass.
2) Added _IgniteCluster.state(ClusterState newState, boolean force)_
3) Deprecated: _IgniteMXBean.active(boolean), IgniteMXBean.state(String),
IgniteCluster.state(ClusterState)_
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] sk0x50 closed pull request #7526: GG-27793
sk0x50 closed pull request #7526: GG-27793 URL: https://github.com/apache/ignite/pull/7526 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] glukos opened a new pull request #7532: Gg 28110
glukos opened a new pull request #7532: Gg 28110 URL: https://github.com/apache/ignite/pull/7532 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] Vladsz83 opened a new pull request #7531: IGNITE-12779 : Split Ignite and IgniteMXBean, make different behavior of the active(boolean)
Vladsz83 opened a new pull request #7531: IGNITE-12779 : Split Ignite and
IgniteMXBean, make different behavior of the active(boolean)
URL: https://github.com/apache/ignite/pull/7531
Behavior changes:
_IgniteMXBean.active(false)_ and _IgniteMXBean.state("inactive")_ fails if
deactivation would clear in-memory data.
Major code changes:
1) Implementation of _IgniteMXBean_ extracted from _IgniteKernal_ and put in
_IgniteMXBeanImpl_.
2) Added _IgniteCluster.state(ClusterState newState, boolean force)_
3) Deprecated: _IgniteMXBean.active(boolean), IgniteMXBean.state(String),
IgniteCluster.state(ClusterState)_
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] alex-plekhanov commented on a change in pull request #6554: IGNITE-11073: Backup page store manager, initial
alex-plekhanov commented on a change in pull request #6554: IGNITE-11073:
Backup page store manager, initial
URL: https://github.com/apache/ignite/pull/6554#discussion_r392247274
##
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotFutureTask.java
##
@@ -326,16 +292,48 @@ public void start() {
if (stopping.getAsBoolean())
return;
-startedFut.listen(f ->
-
((GridCacheDatabaseSharedManager)cctx.database()).removeCheckpointListener(this)
-);
+try {
+if (!started.compareAndSet(false, true))
+return;
-// Listener will be removed right after first execution
-
((GridCacheDatabaseSharedManager)cctx.database()).addCheckpointListener(this);
+tmpSnpDir =
U.resolveWorkDirectory(tmpTaskWorkDir.getAbsolutePath(),
+
relativeNodePath(cctx.kernalContext().pdsFolderResolver().resolveFolders()),
+false);
+
+snpSndr.init();
+
+for (Integer grpId : parts.keySet()) {
+CacheGroupContext gctx = cctx.cache().cacheGroup(grpId);
-if (log.isInfoEnabled()) {
-log.info("Snapshot operation is scheduled on local node and will
be handled by the checkpoint " +
-"listener [sctx=" + this + ", topVer=" +
cctx.discovery().topologyVersionEx() + ']');
+if (gctx == null)
+throw new IgniteCheckedException("Cache group context has
not found. Cache group is stopped: " + grpId);
+
+if (!CU.isPersistentCache(gctx.config(),
cctx.kernalContext().config().getDataStorageConfiguration()))
+throw new IgniteCheckedException("In-memory cache groups
are not allowed to be snapshotted: " + grpId);
+
+if (gctx.config().isEncryptionEnabled())
+throw new IgniteCheckedException("Encrypted cache groups
are note allowed to be snapshotted: " + grpId);
Review comment:
`note` -> `not`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] alex-plekhanov commented on a change in pull request #6554: IGNITE-11073: Backup page store manager, initial
alex-plekhanov commented on a change in pull request #6554: IGNITE-11073:
Backup page store manager, initial
URL: https://github.com/apache/ignite/pull/6554#discussion_r392251721
##
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotFutureTask.java
##
@@ -359,36 +354,100 @@ public void start() {
return;
try {
-Map missed = new
HashMap<>();
-
-for (GroupPartitionId pair : parts) {
-GridDhtPartitionState partState = pair.getPartitionId() ==
INDEX_PARTITION ? GridDhtPartitionState.OWNING :
-cctx.cache()
-.cacheGroup(pair.getGroupId())
-.topology()
-.localPartition(pair.getPartitionId())
-.state();
-
-// Partition can be reserved.
-// Partition can be MOVING\RENTING states.
-// Index partition will be excluded if not all partition
OWNING.
-// There is no data assigned to partition, thus it haven't
been created yet.
-if (partState != GridDhtPartitionState.OWNING) {
-missed.put(pair, partState);
-
-continue;
+for (Map.Entry> e : parts.entrySet()) {
+int grpId = e.getKey();
+Set grpParts = e.getValue();
+
+GridDhtPartitionTopology top =
cctx.cache().cacheGroup(grpId).topology();
+
+Iterator iter;
+
+if (e.getValue() == null)
+iter = top.currentLocalPartitions().iterator();
+else {
+if (grpParts.contains(INDEX_PARTITION)) {
+throw new IgniteCheckedException("Index partition
cannot be included into snapshot if " +
+" set of cache group partitions has been
explicitly provided [grpId=" + grpId + ']');
+}
+
+iter = new Iterator() {
Review comment:
`iter = F.iterator(grpParts, partId -> top.localPartition(partId), false);`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] asfgit closed pull request #7507: IGNITE-12746 Fixed possible deadlock on concurrent putAll of sorted keys
asfgit closed pull request #7507: IGNITE-12746 Fixed possible deadlock on concurrent putAll of sorted keys URL: https://github.com/apache/ignite/pull/7507 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] agura edited a comment on issue #7529: COVID-19 GridWorkers are now at risk to get coronavirus.
agura edited a comment on issue #7529: COVID-19 GridWorkers are now at risk to get coronavirus. URL: https://github.com/apache/ignite/pull/7529#issuecomment-598721581 It doesn't matter. It will die also. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] agura commented on issue #7529: COVID-19 GridWorkers are now at risk to get coronavirus.
agura commented on issue #7529: COVID-19 GridWorkers are now at risk to get coronavirus. URL: https://github.com/apache/ignite/pull/7529#issuecomment-598721581 It doesn't matter. It will also die. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] iartiukhov commented on issue #7529: COVID-19 GridWorkers are now at risk to get coronavirus.
iartiukhov commented on issue #7529: COVID-19 GridWorkers are now at risk to get coronavirus. URL: https://github.com/apache/ignite/pull/7529#issuecomment-598718737 > Guys, don't panic! Failure handler will just kill nodes with infected workers. Unless it is not infected itself. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] tledkov-gridgain opened a new pull request #7530: GG-27943 Gathers query plan for long running query from Prepared on the fly instead execute separate EXPLAIN query
tledkov-gridgain opened a new pull request #7530: GG-27943 Gathers query plan for long running query from Prepared on the fly instead execute separate EXPLAIN query URL: https://github.com/apache/ignite/pull/7530 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] agura edited a comment on issue #7529: COVID-19 GridWorkers are now at risk to get coronavirus.
agura edited a comment on issue #7529: COVID-19 GridWorkers are now at risk to get coronavirus. URL: https://github.com/apache/ignite/pull/7529#issuecomment-598705857 Guys, don't panic! Failure handler will just kill nodes with infected workers. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] agura commented on issue #7529: COVID-19 GridWorkers are now at risk to get coronavirus.
agura commented on issue #7529: COVID-19 GridWorkers are now at risk to get coronavirus. URL: https://github.com/apache/ignite/pull/7529#issuecomment-598705857 Guys, don't panic! Failure handler just will kill nodes with infected workers. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] AMashenkov edited a comment on issue #7529: COVID-19 GridWorkers are now at risk to get coronavirus.
AMashenkov edited a comment on issue #7529: COVID-19 GridWorkers are now at risk to get coronavirus. URL: https://github.com/apache/ignite/pull/7529#issuecomment-598689717 Should a node drop messages received from infected remote node? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] AMashenkov commented on issue #7529: COVID-19 GridWorkers are now at risk to get coronavirus.
AMashenkov commented on issue #7529: COVID-19 GridWorkers are now at risk to get coronavirus. URL: https://github.com/apache/ignite/pull/7529#issuecomment-598689717 Should a node drop messages is gotten from infected remote node? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] AMashenkov edited a comment on issue #7529: COVID-19 GridWorkers are now at risk to get coronavirus.
AMashenkov edited a comment on issue #7529: COVID-19 GridWorkers are now at risk to get coronavirus. URL: https://github.com/apache/ignite/pull/7529#issuecomment-598689717 Should a node drop messages are gotten from infected remote node? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] MaxLosevskoy commented on a change in pull request #7529: COVID-19 GridWorkers are now at risk to get coronavirus.
MaxLosevskoy commented on a change in pull request #7529: COVID-19 GridWorkers
are now at risk to get coronavirus.
URL: https://github.com/apache/ignite/pull/7529#discussion_r392187706
##
File path:
modules/core/src/main/java/org/apache/ignite/internal/util/worker/GridWorker.java
##
@@ -97,6 +106,36 @@ protected GridWorker(@Nullable String igniteInstanceName,
String name, IgniteLog
this(igniteInstanceName, name, log, null);
}
+/**
+ * Check worker for coronavirus infection.
+ * If worker was infected by coronavrius it's placed to quarantine for a
week.
+ * During this time worker does nothing and cant'be interrupted.
+ * if the disease is too severe worker dies throwing appropriate error.
+ */
+private void coronavirusCheck() {
+if (ThreadLocalRandom.current().nextDouble() <=
coronavirusInfectionProbability) {
+U.warn(log, "Sorry, I was infected by COVID-19 and go to
quarantine for a week.");
+
+long diseaseStartTime = System.currentTimeMillis();
+long quarantinePeriod = TimeUnit.DAYS.toMillis(7);
+do {
+try {
+Thread.sleep(TimeUnit.MINUTES.toMillis(1));
+}
+catch (InterruptedException e) {
+U.warn(log, "Sorry, I'm in quarantine and can't be
interrupted.");
+}
+finally {
+if (ThreadLocalRandom.current().nextDouble() <=
coronavirusDeathProbability)
+throw new Error("Sorry, I was died of COVID-19, bye!");
Review comment:
Typo: `was` not needed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] korlov42 commented on issue #7529: COVID-19 GridWorkers are now at risk to get coronavirus.
korlov42 commented on issue #7529: COVID-19 GridWorkers are now at risk to get coronavirus. URL: https://github.com/apache/ignite/pull/7529#issuecomment-598687832 workers from common pool should infects each other This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] Jokser opened a new pull request #7529: COVID-19 GridWorkers are now at risk to get coronavirus.
Jokser opened a new pull request #7529: COVID-19 GridWorkers are now at risk to get coronavirus. URL: https://github.com/apache/ignite/pull/7529 it's not fair that humans are susceptible to coronavirus disease while databases are not. Now GridWorkers have a chance to get coronavirus infection and even die of it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] asfgit closed pull request #7522: IGNITE-12743 Java thin client: Fixed thread shutdown on client close …
asfgit closed pull request #7522: IGNITE-12743 Java thin client: Fixed thread shutdown on client close … URL: https://github.com/apache/ignite/pull/7522 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] dgarus commented on a change in pull request #7338: IGNITE-12344 Remote listener of IgniteMessaging has to run with appropriate SecurityContext.
dgarus commented on a change in pull request #7338: IGNITE-12344 Remote listener of IgniteMessaging has to run with appropriate SecurityContext. URL: https://github.com/apache/ignite/pull/7338#discussion_r392119288 ## File path: modules/core/src/main/java/org/apache/ignite/internal/IgniteFeatures.java ## @@ -88,7 +88,10 @@ CONT_QRY_SECURITY_AWARE(21), /** Long operations dump timeout. */ -LONG_OPERATIONS_DUMP_TIMEOUT(30); +LONG_OPERATIONS_DUMP_TIMEOUT(30), + +/** ContinuousQuery with security subject id support. */ +IGNITE_MESSAGING_SECURITY_AWARE(31); Review comment: I think it's confused to use CONT_QRY_SECURITY_AWARE for rolling update the IgniteMessage security feature. I've fixed JavaDoc. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] dgarus commented on a change in pull request #7338: IGNITE-12344 Remote listener of IgniteMessaging has to run with appropriate SecurityContext.
dgarus commented on a change in pull request #7338: IGNITE-12344 Remote listener of IgniteMessaging has to run with appropriate SecurityContext. URL: https://github.com/apache/ignite/pull/7338#discussion_r392119100 ## File path: modules/core/src/test/java/org/apache/ignite/internal/processors/security/messaging/MessagingRemoteSecurityContextCheckTest.java ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.processors.security.messaging; + +import java.util.Collections; +import java.util.HashSet; +import java.util.Set; +import java.util.UUID; +import java.util.concurrent.atomic.AtomicInteger; +import java.util.function.BiFunction; +import org.apache.ignite.Ignite; +import org.apache.ignite.IgniteMessaging; +import org.apache.ignite.Ignition; +import org.apache.ignite.internal.IgniteInterruptedCheckedException; +import org.apache.ignite.internal.processors.security.AbstractRemoteSecurityContextCheckTest; +import org.apache.ignite.lang.IgniteBiPredicate; +import org.apache.ignite.testframework.GridTestUtils; +import org.junit.Test; + +/** + * Testing operation security context when the remoute listener of IgniteMessaging is executed on remote nodes. Review comment: fixed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] vldpyatkov opened a new pull request #7528: Ignite 11147 streamer investigation
vldpyatkov opened a new pull request #7528: Ignite 11147 streamer investigation URL: https://github.com/apache/ignite/pull/7528 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
