from:"via GitHub"

Re: [PR] IGNITE-22420 Fix expiryPolicy handling for thin client replication [ignite]

2024-06-13 Thread via GitHub



timoninmaxim merged PR #11376:
URL: https://github.com/apache/ignite/pull/11376


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [I] Transaction is being rolled back automatically by some process on Ignite 2.15 and 2.16 [ignite]

2024-06-12 Thread via GitHub



ptupitsyn commented on issue #11390:
URL: https://github.com/apache/ignite/issues/11390#issuecomment-2164393712

   Could it be rolled back due to a timeout?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] IGNITE-22451: Sql. An insert may cause specific later updates to fail Affects only char/varchar [ignite-3]

2024-06-12 Thread via GitHub



lowka opened a new pull request, #3912:
URL: https://github.com/apache/ignite-3/pull/3912

   Fixes a bug in TypeUtils that incorrectly skips `NULL` values.
   
   https://issues.apache.org/jira/browse/IGNITE-22451
   
   ---
   
   Thank you for submitting the pull request.
   
   To streamline the review process of the patch and ensure better code quality
   we ask both an author and a reviewer to verify the following:
   
   ### The Review Checklist
   - [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. 
Also make sure to complete the following:  
   \- There is a single JIRA ticket related to the pull request.  
   \- The web-link to the pull request is attached to the JIRA ticket.  
   \- The JIRA ticket has the Patch Available state.  
   \- The description of the JIRA ticket explains WHAT was made, WHY and HOW.  
   \- The pull request title is treated as the final commit message. The 
following pattern must be used: IGNITE- Change summary where  - number 
of JIRA issue.
   - [ ] **Design:** new code conforms with the design principles of the 
components it is added to.
   - [ ] **Patch quality:** patch cannot be split into smaller pieces, its size 
must be reasonable.
   - [ ] **Code quality:** code is clean and readable, necessary developer 
documentation is added if needed.
   - [ ] **Tests code quality:** test set covers positive/negative scenarios, 
happy/edge cases. Tests are effective in terms of execution time and resources.
   
   ### Notes
   - [Apache Ignite Coding 
Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[I] Transaction is being rolled back automatically by some process on Ignite 2.15 and 2.16 [ignite]

2024-06-12 Thread via GitHub

adiaz-dev opened a new issue, #11390:
URL: https://github.com/apache/ignite/issues/11390

Hi community,

Recently when trying to migrate from Ignite 2.14 to 2.15 or 2.16, I started
to see that our puts were being rollback automatically by some internal process
on Ignite, specifically we are getting the following exception:

`org.apache.ignite.internal.transactions.IgniteTxRollbackCheckedException:
Failed to finish transaction because it has been rolled back [timeout=6,
tx=GridDhtTxLocal[xid=2e9746e0091--13a
6-dc0d--0001,..`

Please see
[ignite_trasaction_rollback-log.txt](https://github.com/user-attachments/files/15812031/ignite_trasaction_rollback-log.txt)
for a complete stack trace.

This is my configuration:
1. Number of threads: 10 (putting records into caches).
2. Transaction Concurrency: PESSIMISTIC
3. Transaction Isolation: REPEATABLE_READ
4. Transaction timeout: 60 seconds
5. Cache Atomicity Mode: TRANSACTIONAL

My exact same code works on prior to these new 2 versions, so something new
was added that now it is causing a problem about transactions. Could you please
help to determine what could be the reason of the problem?

Thanks in advance and regards,

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] IGNITE-22198 Support multiple precision arithmetic operations in native code [ignite-3]

2024-06-12 Thread via GitHub



arcolight opened a new pull request, #3911:
URL: https://github.com/apache/ignite-3/pull/3911

   https://issues.apache.org/jira/browse/IGNITE-22198
   
   Thank you for submitting the pull request.
   
   To streamline the review process of the patch and ensure better code quality
   we ask both an author and a reviewer to verify the following:
   
   ### The Review Checklist
   - [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. 
Also make sure to complete the following:  
   \- There is a single JIRA ticket related to the pull request.  
   \- The web-link to the pull request is attached to the JIRA ticket.  
   \- The JIRA ticket has the Patch Available state.  
   \- The description of the JIRA ticket explains WHAT was made, WHY and HOW.  
   \- The pull request title is treated as the final commit message. The 
following pattern must be used: IGNITE- Change summary where  - number 
of JIRA issue.
   - [ ] **Design:** new code conforms with the design principles of the 
components it is added to.
   - [ ] **Patch quality:** patch cannot be split into smaller pieces, its size 
must be reasonable.
   - [ ] **Code quality:** code is clean and readable, necessary developer 
documentation is added if needed.
   - [ ] **Tests code quality:** test set covers positive/negative scenarios, 
happy/edge cases. Tests are effective in terms of execution time and resources.
   
   ### Notes
   - [Apache Ignite Coding 
Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] IGNITE-21974: Extend test coverage for SQL F221(Explicit defaults) [ignite-3]

2024-06-12 Thread via GitHub



ygerzhedovich merged PR #3910:
URL: https://github.com/apache/ignite-3/pull/3910


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] IGNITE-21974: Extend test coverage for SQL F221(Explicit defaults) [ignite-3]

2024-06-12 Thread via GitHub



lowka commented on code in PR #3910:
URL: https://github.com/apache/ignite-3/pull/3910#discussion_r1636446977


##
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDmlTest.java:
##
@@ -596,12 +598,55 @@ private void checkDefaultValue(List 
args) {
 
 @Test
 public void testCheckNullValueErrorMessageForColumnWithDefaultValue() {
+// F221: Explicit defaults
 sql("CREATE TABLE tbl(key int DEFAULT 9 primary key, val varchar)");
 
 var expectedMessage = "Column 'KEY' does not allow NULLs";
 
 assertThrowsSqlException(Sql.CONSTRAINT_VIOLATION_ERR, 
expectedMessage, () -> sql("INSERT INTO tbl (key, val) VALUES (NULL,'AA')"));
 }
+
+// UPDATE set x = DEFAULT is not supported in parser
+@Disabled("https://issues.apache.org/jira/browse/IGNITE-21462;)
+@Test
+public void testUpdateAllowsDefault() {
+// F221: Explicit defaults
+for (var arg : defaultValueArgs().collect(Collectors.toList())) {
+try {
+sql(format("CREATE TABLE test (id INT PRIMARY KEY, val %s 
DEFAULT %s)", arg.sqlType, arg.sqlVal));
+sql("INSERT INTO test (id, val) VALUES (1, NULL)");
+
+sql("UPDATE test SET val = DEFAULT WHERE id = 1");
+assertQuery("SELECT val FROM test WHERE id = 
1").returns(arg.expectedVal).check();
+} finally {
+sql("DROP TABLE IF EXISTS test");
+}
+}
+}
+
+@Test
+public void testDropDefault() {
+// F221: Explicit defaults
+for (var arg : defaultValueArgs().collect(Collectors.toList())) {

Review Comment:
   All types have a NOT NULL variant.



##
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDmlTest.java:
##
@@ -596,12 +598,55 @@ private void checkDefaultValue(List 
args) {
 
 @Test
 public void testCheckNullValueErrorMessageForColumnWithDefaultValue() {
+// F221: Explicit defaults
 sql("CREATE TABLE tbl(key int DEFAULT 9 primary key, val varchar)");
 
 var expectedMessage = "Column 'KEY' does not allow NULLs";
 
 assertThrowsSqlException(Sql.CONSTRAINT_VIOLATION_ERR, 
expectedMessage, () -> sql("INSERT INTO tbl (key, val) VALUES (NULL,'AA')"));
 }
+
+// UPDATE set x = DEFAULT is not supported in parser
+@Disabled("https://issues.apache.org/jira/browse/IGNITE-21462;)
+@Test
+public void testUpdateAllowsDefault() {
+// F221: Explicit defaults
+for (var arg : defaultValueArgs().collect(Collectors.toList())) {

Review Comment:
   Fixed.



##
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDmlTest.java:
##
@@ -596,12 +598,55 @@ private void checkDefaultValue(List 
args) {
 
 @Test
 public void testCheckNullValueErrorMessageForColumnWithDefaultValue() {
+// F221: Explicit defaults

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] IGNITE-22423 Don't use kill -9 for ignite3db [ignite-3]

2024-06-12 Thread via GitHub



Pochatkin merged PR #3894:
URL: https://github.com/apache/ignite-3/pull/3894


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] IGNITE-21974: Extend test coverage for SQL F221(Explicit defaults) [ignite-3]

2024-06-12 Thread via GitHub



ygerzhedovich commented on code in PR #3910:
URL: https://github.com/apache/ignite-3/pull/3910#discussion_r1636409671


##
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDmlTest.java:
##
@@ -596,12 +598,55 @@ private void checkDefaultValue(List 
args) {
 
 @Test
 public void testCheckNullValueErrorMessageForColumnWithDefaultValue() {
+// F221: Explicit defaults
 sql("CREATE TABLE tbl(key int DEFAULT 9 primary key, val varchar)");
 
 var expectedMessage = "Column 'KEY' does not allow NULLs";
 
 assertThrowsSqlException(Sql.CONSTRAINT_VIOLATION_ERR, 
expectedMessage, () -> sql("INSERT INTO tbl (key, val) VALUES (NULL,'AA')"));
 }
+
+// UPDATE set x = DEFAULT is not supported in parser
+@Disabled("https://issues.apache.org/jira/browse/IGNITE-21462;)
+@Test
+public void testUpdateAllowsDefault() {
+// F221: Explicit defaults
+for (var arg : defaultValueArgs().collect(Collectors.toList())) {
+try {
+sql(format("CREATE TABLE test (id INT PRIMARY KEY, val %s 
DEFAULT %s)", arg.sqlType, arg.sqlVal));
+sql("INSERT INTO test (id, val) VALUES (1, NULL)");
+
+sql("UPDATE test SET val = DEFAULT WHERE id = 1");
+assertQuery("SELECT val FROM test WHERE id = 
1").returns(arg.expectedVal).check();
+} finally {
+sql("DROP TABLE IF EXISTS test");
+}
+}
+}
+
+@Test
+public void testDropDefault() {
+// F221: Explicit defaults
+for (var arg : defaultValueArgs().collect(Collectors.toList())) {

Review Comment:
   Seems need to extend type coverage



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] IGNITE-21974: Extend test coverage for SQL F221(Explicit defaults) [ignite-3]

2024-06-12 Thread via GitHub



ygerzhedovich commented on code in PR #3910:
URL: https://github.com/apache/ignite-3/pull/3910#discussion_r1636400885


##
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDmlTest.java:
##
@@ -596,12 +598,55 @@ private void checkDefaultValue(List 
args) {
 
 @Test
 public void testCheckNullValueErrorMessageForColumnWithDefaultValue() {
+// F221: Explicit defaults
 sql("CREATE TABLE tbl(key int DEFAULT 9 primary key, val varchar)");
 
 var expectedMessage = "Column 'KEY' does not allow NULLs";
 
 assertThrowsSqlException(Sql.CONSTRAINT_VIOLATION_ERR, 
expectedMessage, () -> sql("INSERT INTO tbl (key, val) VALUES (NULL,'AA')"));
 }
+
+// UPDATE set x = DEFAULT is not supported in parser
+@Disabled("https://issues.apache.org/jira/browse/IGNITE-21462;)
+@Test
+public void testUpdateAllowsDefault() {
+// F221: Explicit defaults
+for (var arg : defaultValueArgs().collect(Collectors.toList())) {

Review Comment:
   var is forbidden in such context



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] IGNITE-21974: Extend test coverage for SQL F221(Explicit defaults) [ignite-3]

2024-06-12 Thread via GitHub



ygerzhedovich commented on code in PR #3910:
URL: https://github.com/apache/ignite-3/pull/3910#discussion_r1636396957


##
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDmlTest.java:
##
@@ -596,12 +598,55 @@ private void checkDefaultValue(List 
args) {
 
 @Test
 public void testCheckNullValueErrorMessageForColumnWithDefaultValue() {
+// F221: Explicit defaults

Review Comment:
   Let's say more explicitly, like a SQL Standard 2016 feature F221 - Explicit 
defaults



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] IGNITE-21974: Extend test coverage for SQL F221(Explicit defaults) [ignite-3]

2024-06-12 Thread via GitHub



ygerzhedovich commented on code in PR #3910:
URL: https://github.com/apache/ignite-3/pull/3910#discussion_r1636396957


##
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDmlTest.java:
##
@@ -596,12 +598,55 @@ private void checkDefaultValue(List 
args) {
 
 @Test
 public void testCheckNullValueErrorMessageForColumnWithDefaultValue() {
+// F221: Explicit defaults

Review Comment:
   Let's say more explicitly, like a SQL Standard 2016 feature F221



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] IGNITE-22052: Fix authentication tests [ignite-3]

2024-06-12 Thread via GitHub



isapego commented on code in PR #3903:
URL: https://github.com/apache/ignite-3/pull/3903#discussion_r1636223753


##
modules/platforms/cpp/tests/client-test/basic_authenticator_test.cpp:
##
@@ -22,20 +22,32 @@
 
 using namespace ignite;
 
-struct DISABLED_basic_authenticator_test : public basic_auth_test_suite {
+struct basic_authenticator_test : public basic_auth_test_suite {
+/**
+ * Set up.
+ */
+static void SetUpTestSuite() {
+// Make sure that

Review Comment:
   This whole function is actually unneeded. Thanks for bringing it to my 
attention.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] IGNITE-21974: Extend test coverage for SQL F221(Explicit defaults) [ignite-3]

2024-06-12 Thread via GitHub



lowka opened a new pull request, #3910:
URL: https://github.com/apache/ignite-3/pull/3910

   Adds java tests for DROP default.
   
   https://issues.apache.org/jira/browse/IGNITE-21974
   
   --- 
   Thank you for submitting the pull request.
   
   To streamline the review process of the patch and ensure better code quality
   we ask both an author and a reviewer to verify the following:
   
   ### The Review Checklist
   - [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. 
Also make sure to complete the following:  
   \- There is a single JIRA ticket related to the pull request.  
   \- The web-link to the pull request is attached to the JIRA ticket.  
   \- The JIRA ticket has the Patch Available state.  
   \- The description of the JIRA ticket explains WHAT was made, WHY and HOW.  
   \- The pull request title is treated as the final commit message. The 
following pattern must be used: IGNITE- Change summary where  - number 
of JIRA issue.
   - [ ] **Design:** new code conforms with the design principles of the 
components it is added to.
   - [ ] **Patch quality:** patch cannot be split into smaller pieces, its size 
must be reasonable.
   - [ ] **Code quality:** code is clean and readable, necessary developer 
documentation is added if needed.
   - [ ] **Tests code quality:** test set covers positive/negative scenarios, 
happy/edge cases. Tests are effective in terms of execution time and resources.
   
   ### Notes
   - [Apache Ignite Coding 
Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] IGNITE-22052: Fix authentication tests [ignite-3]

2024-06-12 Thread via GitHub



ptupitsyn commented on code in PR #3903:
URL: https://github.com/apache/ignite-3/pull/3903#discussion_r1636201090


##
modules/platforms/cpp/tests/client-test/basic_authenticator_test.cpp:
##
@@ -22,20 +22,32 @@
 
 using namespace ignite;
 
-struct DISABLED_basic_authenticator_test : public basic_auth_test_suite {
+struct basic_authenticator_test : public basic_auth_test_suite {
+/**
+ * Set up.
+ */
+static void SetUpTestSuite() {
+// Make sure that

Review Comment:
   Unfinished comment?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] Replaces a cast to CHAR(n) with a VARCHAR(n) [ignite-3]

2024-06-12 Thread via GitHub



lowka opened a new pull request, #3909:
URL: https://github.com/apache/ignite-3/pull/3909

   Thank you for submitting the pull request.
   
   To streamline the review process of the patch and ensure better code quality
   we ask both an author and a reviewer to verify the following:
   
   ### The Review Checklist
   - [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. 
Also make sure to complete the following:  
   \- There is a single JIRA ticket related to the pull request.  
   \- The web-link to the pull request is attached to the JIRA ticket.  
   \- The JIRA ticket has the Patch Available state.  
   \- The description of the JIRA ticket explains WHAT was made, WHY and HOW.  
   \- The pull request title is treated as the final commit message. The 
following pattern must be used: IGNITE- Change summary where  - number 
of JIRA issue.
   - [ ] **Design:** new code conforms with the design principles of the 
components it is added to.
   - [ ] **Patch quality:** patch cannot be split into smaller pieces, its size 
must be reasonable.
   - [ ] **Code quality:** code is clean and readable, necessary developer 
documentation is added if needed.
   - [ ] **Tests code quality:** test set covers positive/negative scenarios, 
happy/edge cases. Tests are effective in terms of execution time and resources.
   
   ### Notes
   - [Apache Ignite Coding 
Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] IGNITE-22224 Rework embedded mode API [ignite-3]

2024-06-12 Thread via GitHub



valepakh opened a new pull request, #3908:
URL: https://github.com/apache/ignite-3/pull/3908

   https://issues.apache.org/jira/browse/IGNITE-4


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] IGNITE-21959: Extend test coverage for SQL E021-12(Character comparison) [ignite-3]

2024-06-12 Thread via GitHub



lowka opened a new pull request, #3907:
URL: https://github.com/apache/ignite-3/pull/3907

   Adds test cases for character comparison operator for CHAR/CHAR, and 
VARCHAR/VARCHAR.
   
   https://issues.apache.org/jira/browse/IGNITE-21959
   
   ---
   
   Thank you for submitting the pull request.
   
   To streamline the review process of the patch and ensure better code quality
   we ask both an author and a reviewer to verify the following:
   
   ### The Review Checklist
   - [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. 
Also make sure to complete the following:  
   \- There is a single JIRA ticket related to the pull request.  
   \- The web-link to the pull request is attached to the JIRA ticket.  
   \- The JIRA ticket has the Patch Available state.  
   \- The description of the JIRA ticket explains WHAT was made, WHY and HOW.  
   \- The pull request title is treated as the final commit message. The 
following pattern must be used: IGNITE- Change summary where  - number 
of JIRA issue.
   - [ ] **Design:** new code conforms with the design principles of the 
components it is added to.
   - [ ] **Patch quality:** patch cannot be split into smaller pieces, its size 
must be reasonable.
   - [ ] **Code quality:** code is clean and readable, necessary developer 
documentation is added if needed.
   - [ ] **Tests code quality:** test set covers positive/negative scenarios, 
happy/edge cases. Tests are effective in terms of execution time and resources.
   
   ### Notes
   - [Apache Ignite Coding 
Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] IGNITE-22193 Move IgniteJdbcDriver to non internal package [ignite-3]

2024-06-12 Thread via GitHub



ygerzhedovich commented on code in PR #3871:
URL: https://github.com/apache/ignite-3/pull/3871#discussion_r1635943851


##
modules/jdbc/src/main/java/org/apache/ignite/jdbc/IgniteJdbcDriver.java:
##
@@ -29,11 +29,104 @@
 import java.util.Properties;
 import java.util.logging.Logger;
 import org.apache.ignite.internal.client.proto.ProtocolVersion;
+import org.apache.ignite.internal.jdbc.ConnectionPropertiesImpl;
+import org.apache.ignite.internal.jdbc.JdbcConnection;
 
 /**
- * JDBC driver thin implementation for Apache Ignite 3.x.
+ * JDBC driver implementation for Apache Ignite 3.x.
  *
- * Driver allows to get distributed data from Ignite Data Storage using 
standard SQL queries and standard JDBC API.
+ * Driver allows to get distributed data from Ignite 3 Data Storage using 
standard SQL queries and standard JDBC API.
+ * Register the JDBC drivers
+ * 
+ * The JDBC driver registration is automatically done via the Java Standard 
Edition Service Provider mechanism.
+ * Ignite JDBC driver implements this feature and it is automatically 
registered for case the JDBC driver jar presents in classpath.
+ * 

Review Comment:
   fixed



##
modules/jdbc/src/main/java/org/apache/ignite/jdbc/IgniteJdbcDriver.java:
##
@@ -29,11 +29,104 @@
 import java.util.Properties;
 import java.util.logging.Logger;
 import org.apache.ignite.internal.client.proto.ProtocolVersion;
+import org.apache.ignite.internal.jdbc.ConnectionPropertiesImpl;
+import org.apache.ignite.internal.jdbc.JdbcConnection;
 
 /**
- * JDBC driver thin implementation for Apache Ignite 3.x.
+ * JDBC driver implementation for Apache Ignite 3.x.
  *
- * Driver allows to get distributed data from Ignite Data Storage using 
standard SQL queries and standard JDBC API.
+ * Driver allows to get distributed data from Ignite 3 Data Storage using 
standard SQL queries and standard JDBC API.
+ * Register the JDBC drivers
+ * 
+ * The JDBC driver registration is automatically done via the Java Standard 
Edition Service Provider mechanism.
+ * Ignite JDBC driver implements this feature and it is automatically 
registered for case the JDBC driver jar presents in classpath.
+ * 
+ * URL Format
+ * 
+ * The JDBC Driver supports the following URL formats to establish a 
connection with an Ignite 3 Database.
+ * 
+ * 
jdbc:ignite:thin://host[:port][,host[:port][/schema][[?parameter1=value1][parameter2=value2],...]]
+ *  or 
+ * 
jdbc:ignite:thin://host[:port][,host[:port][/schema][[?parameter1=value1][;parameter2=value2],...]]
+ * 
+ * URL can have an optional list of name-value pairs as parameters after the 
'?' delimiter.
+ * Name and value are separated by an '=' and multiple properties are 
separated either by an '' or a ';'.
+ * Separate sign can't be mixed and should be either semicolon or ampersand 
sign.
+ * 
+ *   
+ * 
+ * The list of supported name value pairs:
+ *   
+ *  Parameter Name
+ *  Description
+ *   
+ *   
+ *  schema
+ *  Specifies default schema name.
+ *   
+ *   
+ *  queryTimeout
+ *  Number of seconds the driver will wait for a 
Statement object to execute. Zero means there is no limits.
+ *   
+ *   
+ *  connectionTimeout
+ *  Number of milliseconds JDBC client will waits for server to 
response. Zero means there is no limits."
+ *   
+ *   
+ *  reconnectThrottlingPeriod
+ *  Sets the reconnect throttling period, in milliseconds. Zero means 
there is no limits.
+ *   
+ *   
+ *  reconnectThrottlingRetries
+ *  Sets the reconnect throttling retries. Zero means there is no 
limits.
+ *   
+ *   
+ *  trustStorePath
+ *  Path to trust store.
+ *   
+ *   
+ *  trustStorePassword
+ *  Trust store password.
+ *   
+ *   
+ *  keyStorePath
+ *  Path to key store.
+ *   
+ *   
+ *  keyStorePassword
+ *  Key store password.
+ *   
+ *   
+ *  clientAuth
+ *  SSL client authentication.
+ *   
+ *   
+ *  ciphers
+ *  SSL ciphers.
+ *   
+ *   
+ *  sslEnabled
+ *  Enable ssl.
+ *   
+ *   
+ *  username
+ *  Username.
+ *   
+ *   
+ *  password
+ *  Password.

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] IGNITE-22193 Move IgniteJdbcDriver to non internal package [ignite-3]

2024-06-12 Thread via GitHub



ygerzhedovich commented on code in PR #3871:
URL: https://github.com/apache/ignite-3/pull/3871#discussion_r1635944614


##
modules/jdbc/src/main/java/org/apache/ignite/jdbc/IgniteJdbcDriver.java:
##
@@ -29,11 +29,104 @@
 import java.util.Properties;
 import java.util.logging.Logger;
 import org.apache.ignite.internal.client.proto.ProtocolVersion;
+import org.apache.ignite.internal.jdbc.ConnectionPropertiesImpl;
+import org.apache.ignite.internal.jdbc.JdbcConnection;
 
 /**
- * JDBC driver thin implementation for Apache Ignite 3.x.
+ * JDBC driver implementation for Apache Ignite 3.x.
  *
- * Driver allows to get distributed data from Ignite Data Storage using 
standard SQL queries and standard JDBC API.
+ * Driver allows to get distributed data from Ignite 3 Data Storage using 
standard SQL queries and standard JDBC API.
+ * Register the JDBC drivers
+ * 
+ * The JDBC driver registration is automatically done via the Java Standard 
Edition Service Provider mechanism.
+ * Ignite JDBC driver implements this feature and it is automatically 
registered for case the JDBC driver jar presents in classpath.
+ * 
+ * URL Format
+ * 
+ * The JDBC Driver supports the following URL formats to establish a 
connection with an Ignite 3 Database.
+ * 
+ * 
jdbc:ignite:thin://host[:port][,host[:port][/schema][[?parameter1=value1][parameter2=value2],...]]
+ *  or 
+ * 
jdbc:ignite:thin://host[:port][,host[:port][/schema][[?parameter1=value1][;parameter2=value2],...]]
+ * 
+ * URL can have an optional list of name-value pairs as parameters after the 
'?' delimiter.
+ * Name and value are separated by an '=' and multiple properties are 
separated either by an '' or a ';'.
+ * Separate sign can't be mixed and should be either semicolon or ampersand 
sign.
+ * 
+ *   
+ * 
+ * The list of supported name value pairs:
+ *   
+ *  Parameter Name
+ *  Description
+ *   
+ *   
+ *  schema
+ *  Specifies default schema name.
+ *   
+ *   
+ *  queryTimeout
+ *  Number of seconds the driver will wait for a 
Statement object to execute. Zero means there is no limits.
+ *   
+ *   
+ *  connectionTimeout
+ *  Number of milliseconds JDBC client will waits for server to 
response. Zero means there is no limits."
+ *   
+ *   
+ *  reconnectThrottlingPeriod
+ *  Sets the reconnect throttling period, in milliseconds. Zero means 
there is no limits.
+ *   
+ *   
+ *  reconnectThrottlingRetries
+ *  Sets the reconnect throttling retries. Zero means there is no 
limits.
+ *   
+ *   
+ *  trustStorePath
+ *  Path to trust store.
+ *   
+ *   
+ *  trustStorePassword
+ *  Trust store password.
+ *   
+ *   
+ *  keyStorePath
+ *  Path to key store.
+ *   
+ *   
+ *  keyStorePassword
+ *  Key store password.
+ *   
+ *   
+ *  clientAuth
+ *  SSL client authentication.

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] IGNITE-22193 Move IgniteJdbcDriver to non internal package [ignite-3]

2024-06-12 Thread via GitHub



ygerzhedovich commented on code in PR #3871:
URL: https://github.com/apache/ignite-3/pull/3871#discussion_r1635944381


##
modules/jdbc/src/main/java/org/apache/ignite/jdbc/IgniteJdbcDriver.java:
##
@@ -29,11 +29,104 @@
 import java.util.Properties;
 import java.util.logging.Logger;
 import org.apache.ignite.internal.client.proto.ProtocolVersion;
+import org.apache.ignite.internal.jdbc.ConnectionPropertiesImpl;
+import org.apache.ignite.internal.jdbc.JdbcConnection;
 
 /**
- * JDBC driver thin implementation for Apache Ignite 3.x.
+ * JDBC driver implementation for Apache Ignite 3.x.
  *
- * Driver allows to get distributed data from Ignite Data Storage using 
standard SQL queries and standard JDBC API.
+ * Driver allows to get distributed data from Ignite 3 Data Storage using 
standard SQL queries and standard JDBC API.
+ * Register the JDBC drivers
+ * 
+ * The JDBC driver registration is automatically done via the Java Standard 
Edition Service Provider mechanism.
+ * Ignite JDBC driver implements this feature and it is automatically 
registered for case the JDBC driver jar presents in classpath.
+ * 
+ * URL Format
+ * 
+ * The JDBC Driver supports the following URL formats to establish a 
connection with an Ignite 3 Database.
+ * 
+ * 
jdbc:ignite:thin://host[:port][,host[:port][/schema][[?parameter1=value1][parameter2=value2],...]]
+ *  or 
+ * 
jdbc:ignite:thin://host[:port][,host[:port][/schema][[?parameter1=value1][;parameter2=value2],...]]
+ * 
+ * URL can have an optional list of name-value pairs as parameters after the 
'?' delimiter.
+ * Name and value are separated by an '=' and multiple properties are 
separated either by an '' or a ';'.
+ * Separate sign can't be mixed and should be either semicolon or ampersand 
sign.
+ * 
+ *   
+ * 
+ * The list of supported name value pairs:
+ *   
+ *  Parameter Name
+ *  Description
+ *   
+ *   
+ *  schema
+ *  Specifies default schema name.
+ *   
+ *   
+ *  queryTimeout
+ *  Number of seconds the driver will wait for a 
Statement object to execute. Zero means there is no limits.
+ *   
+ *   
+ *  connectionTimeout
+ *  Number of milliseconds JDBC client will waits for server to 
response. Zero means there is no limits."
+ *   
+ *   
+ *  reconnectThrottlingPeriod
+ *  Sets the reconnect throttling period, in milliseconds. Zero means 
there is no limits.
+ *   
+ *   
+ *  reconnectThrottlingRetries
+ *  Sets the reconnect throttling retries. Zero means there is no 
limits.
+ *   
+ *   
+ *  trustStorePath
+ *  Path to trust store.
+ *   
+ *   
+ *  trustStorePassword
+ *  Trust store password.
+ *   
+ *   
+ *  keyStorePath
+ *  Path to key store.
+ *   
+ *   
+ *  keyStorePassword
+ *  Key store password.
+ *   
+ *   
+ *  clientAuth
+ *  SSL client authentication.
+ *   
+ *   
+ *  ciphers
+ *  SSL ciphers.
+ *   
+ *   
+ *  sslEnabled
+ *  Enable ssl.

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] IGNITE-22399 Improve handling of small network messages on send [ignite-3]

2024-06-12 Thread via GitHub



rpuch commented on code in PR #3865:
URL: https://github.com/apache/ignite-3/pull/3865#discussion_r1635925045


##
modules/network/src/main/java/org/apache/ignite/internal/network/netty/PipelineUtils.java:
##
@@ -57,6 +58,9 @@ public static void setup(ChannelPipeline pipeline, 
PerSessionSerializationServic
  */
 public static void setup(ChannelPipeline pipeline, 
PerSessionSerializationService serializationService,
 HandshakeManager handshakeManager, Consumer 
messageListener) {
+// Consolidate flushes to bigger ones (improves throughput with 
smaller messages at the price of the latency).

Review Comment:
   Big messages are split to fragments up to 16kb each, and those fragments 
will be collected to batches along with small messages. Batch size is 256 at 
max, so this will take up to 4Mb per event loop (and number of event loops is 
cpus*2).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] IGNITE-22399 Improve handling of small network messages on send [ignite-3]

2024-06-12 Thread via GitHub



rpuch merged PR #3865:
URL: https://github.com/apache/ignite-3/pull/3865


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] IGNITE-22437 Memory leak in MapNodeResults [ignite]

2024-06-11 Thread via GitHub



liyuj opened a new pull request, #11389:
URL: https://github.com/apache/ignite/pull/11389

   Thank you for submitting the pull request to the Apache Ignite.
   
   In order to streamline the review of the contribution 
   we ask you to ensure the following steps have been taken:
   
   ### The Contribution Checklist
   - [x ] There is a single JIRA ticket related to the pull request. 
   - [x ] The web-link to the pull request is attached to the JIRA ticket.
   - [x ] The JIRA ticket has the _Patch Available_ state.
   - [ ] The pull request body describes changes that have been made. 
   The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
   - [ ] The pull request title is treated as the final commit message. 
   The following pattern must be used: `IGNITE- Change summary` where 
`` - number of JIRA issue.
   - [ ] A reviewer has been mentioned through the JIRA comments 
   (see [the Maintainers 
list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
 
   - [ ] The pull request has been checked by the Teamcity Bot and 
   the `green visa` attached to the JIRA ticket (see [TC.Bot: Check 
PR](https://mtcga.gridgain.com/prs.html))
   
   ### Notes
   - [How to 
Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
   - [Coding abbreviation 
rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
   - [Coding 
Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
   - [Apache Ignite Teamcity 
Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
   
   If you need any help, please email d...@ignite.apache.org or ask anу advice 
on http://asf.slack.com _#ignite_ channel.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [I] Apache Ignite 2.15.0 startup failure using OpenJDK 17 version [ignite]

2024-06-11 Thread via GitHub



Litvinovis commented on issue #10747:
URL: https://github.com/apache/ignite/issues/10747#issuecomment-2161414393

   So i faced the same problem when i start Ignite on windows 10, this solved 
in my case:
   1) switch to ignite 2.16
   2) added VM option:
   --add-opens=java.base/jdk.internal.misc=ALL-UNNAMED
   --add-opens=java.base/sun.nio.ch=ALL-UNNAMED
   --add-opens=java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED
   --add-opens=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED
   --add-opens=java.base/sun.reflect.generics.reflectiveObjects=ALL-UNNAMED
   --add-opens=jdk.management/com.sun.management.internal=ALL-UNNAMED
   --add-opens=java.base/java.io=ALL-UNNAMED
   --add-opens=java.base/java.nio=ALL-UNNAMED
   --add-opens=java.base/java.util=ALL-UNNAMED
   --add-opens=java.base/java.lang=ALL-UNNAMED
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] Bump netty from 4.1.110.Final to 4.1.111.Final [ignite-3]

2024-06-11 Thread via GitHub



dependabot[bot] opened a new pull request, #3906:
URL: https://github.com/apache/ignite-3/pull/3906

   Bumps `netty` from 4.1.110.Final to 4.1.111.Final.
   Updates `io.netty:netty-common` from 4.1.110.Final to 4.1.111.Final
   
   Commits
   
   https://github.com/netty/netty/commit/90c5fd78c12ffe4698795e44fc6d865d3622c116;>90c5fd7
 [maven-release-plugin] prepare release netty-4.1.111.Final
   https://github.com/netty/netty/commit/4b825d3528bac7ff5f1af22a56b5c58581d25b89;>4b825d3
 Delete class which was committed by mistake
   https://github.com/netty/netty/commit/176bfbfd7d42ac3e1fee85ca86e46712e9a2b625;>176bfbf
 Add missing NULL checks in native code (https://redirect.github.com/netty/netty/issues/14100;>#14100)
   https://github.com/netty/netty/commit/03b5520f3dd196f6381d71af0dbe3b42d187d48b;>03b5520
 Revert Rewrite ZstdDecoder to remove the need of allocate a huge byte[] 
inte...
   https://github.com/netty/netty/commit/30d1b5cce5285ab8696ce892ca51685cd73b0576;>30d1b5c
 Fix AdaptiveByteBufAllocator class loading on Java 6/7 (https://redirect.github.com/netty/netty/issues/14101;>#14101)
   https://github.com/netty/netty/commit/23c19b2b764d49437c49653121c8185130814033;>23c19b2
 Prepare for unsafe memory access deprecated for removal (https://redirect.github.com/netty/netty/issues/14090;>#14090)
   https://github.com/netty/netty/commit/20a11b32f00a3d119bd2840e0963c3e9688b73a7;>20a11b3
 Optimize wrap buffer cumulation in SslHandler and don't mutate input buffers 
...
   https://github.com/netty/netty/commit/e9caa97d5968abb92ba02c1af8fb4c134801f1ce;>e9caa97
 Duplicate of slice should have the same capacity as the original slice so 
tha...
   https://github.com/netty/netty/commit/98cc2b1db47ef3a71c949199c9780f177bf9a743;>98cc2b1
 Upgrade to jctools from 3.1.0 to 4.0.5 (https://redirect.github.com/netty/netty/issues/14096;>#14096)
   https://github.com/netty/netty/commit/4f19ecfbb4f14c092fc74643d38152f2d034cf43;>4f19ecf
 Revert Rewrite ZstdDecoder to remove the need of allocate a huge byt… 
(https://redirect.github.com/netty/netty/issues/14084;>#14084)
   Additional commits viewable in https://github.com/netty/netty/compare/netty-4.1.110.Final...netty-4.1.111.Final;>compare
 view
   
   
   
   
   Updates `io.netty:netty-buffer` from 4.1.110.Final to 4.1.111.Final
   
   Commits
   
   https://github.com/netty/netty/commit/90c5fd78c12ffe4698795e44fc6d865d3622c116;>90c5fd7
 [maven-release-plugin] prepare release netty-4.1.111.Final
   https://github.com/netty/netty/commit/4b825d3528bac7ff5f1af22a56b5c58581d25b89;>4b825d3
 Delete class which was committed by mistake
   https://github.com/netty/netty/commit/176bfbfd7d42ac3e1fee85ca86e46712e9a2b625;>176bfbf
 Add missing NULL checks in native code (https://redirect.github.com/netty/netty/issues/14100;>#14100)
   https://github.com/netty/netty/commit/03b5520f3dd196f6381d71af0dbe3b42d187d48b;>03b5520
 Revert Rewrite ZstdDecoder to remove the need of allocate a huge byte[] 
inte...
   https://github.com/netty/netty/commit/30d1b5cce5285ab8696ce892ca51685cd73b0576;>30d1b5c
 Fix AdaptiveByteBufAllocator class loading on Java 6/7 (https://redirect.github.com/netty/netty/issues/14101;>#14101)
   https://github.com/netty/netty/commit/23c19b2b764d49437c49653121c8185130814033;>23c19b2
 Prepare for unsafe memory access deprecated for removal (https://redirect.github.com/netty/netty/issues/14090;>#14090)
   https://github.com/netty/netty/commit/20a11b32f00a3d119bd2840e0963c3e9688b73a7;>20a11b3
 Optimize wrap buffer cumulation in SslHandler and don't mutate input buffers 
...
   https://github.com/netty/netty/commit/e9caa97d5968abb92ba02c1af8fb4c134801f1ce;>e9caa97
 Duplicate of slice should have the same capacity as the original slice so 
tha...
   https://github.com/netty/netty/commit/98cc2b1db47ef3a71c949199c9780f177bf9a743;>98cc2b1
 Upgrade to jctools from 3.1.0 to 4.0.5 (https://redirect.github.com/netty/netty/issues/14096;>#14096)
   https://github.com/netty/netty/commit/4f19ecfbb4f14c092fc74643d38152f2d034cf43;>4f19ecf
 Revert Rewrite ZstdDecoder to remove the need of allocate a huge byt… 
(https://redirect.github.com/netty/netty/issues/14084;>#14084)
   Additional commits viewable in https://github.com/netty/netty/compare/netty-4.1.110.Final...netty-4.1.111.Final;>compare
 view
   
   
   
   
   Updates `io.netty:netty-codec` from 4.1.110.Final to 4.1.111.Final
   
   Commits
   
   https://github.com/netty/netty/commit/90c5fd78c12ffe4698795e44fc6d865d3622c116;>90c5fd7
 [maven-release-plugin] prepare release netty-4.1.111.Final
   https://github.com/netty/netty/commit/4b825d3528bac7ff5f1af22a56b5c58581d25b89;>4b825d3
 Delete class which was committed by mistake
   https://github.com/netty/netty/commit/176bfbfd7d42ac3e1fee85ca86e46712e9a2b625;>176bfbf
 Add missing NULL checks in native code (https://redirect.github.com/netty/netty/issues/14100;>#14100)
   https://github.com/netty/netty/commit/03b5520f3dd196f6381d71af0dbe3b42d187d48b;>03b5520
 Revert Rewrite

[PR] Bump com.github.spotbugs from 6.0.15 to 6.0.16 [ignite-3]

2024-06-11 Thread via GitHub



dependabot[bot] opened a new pull request, #3905:
URL: https://github.com/apache/ignite-3/pull/3905

   Bumps com.github.spotbugs from 6.0.15 to 6.0.16.
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.github.spotbugs=gradle=6.0.15=6.0.16)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot show  ignore conditions` will show all of 
the ignore conditions of the specified dependency
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] IGNITE-18372 metrics for k2i consumer [ignite-extensions]

2024-06-11 Thread via GitHub



maksaska opened a new pull request, #277:
URL: https://github.com/apache/ignite-extensions/pull/277

   ### Metrics for CDC with Kafka 
   **CDC with Kafka** doesn't have metrics for 'Kafka To Ignite' consumer. The 
improvement in this pull request contains the neccessary updates to fix this 
issue.
   
   ***What is new***:
   - Count of messages applied to destination cluster
   - Timestamp of last applied event
   
   To achieve the proposed goals, I've used `StandaloneGridKernalContext` dummy 
context to get the manager for the metrics SPI. With 
`KafkaToIgniteCdcStreamerConfiguration` configured to supply the CDC toolkit 
with Metrics SPIs, we are now able to register metrics exporter. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] IGNITE-21973: Extend test coverage for SQL F201(CAST function) [ignite-3]

2024-06-11 Thread via GitHub



lowka opened a new pull request, #3904:
URL: https://github.com/apache/ignite-3/pull/3904

   Adds sqllogic tests for CAST function.
   
   https://issues.apache.org/jira/browse/IGNITE-21973
   
   ---
   
   Thank you for submitting the pull request.
   
   To streamline the review process of the patch and ensure better code quality
   we ask both an author and a reviewer to verify the following:
   
   ### The Review Checklist
   - [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. 
Also make sure to complete the following:  
   \- There is a single JIRA ticket related to the pull request.  
   \- The web-link to the pull request is attached to the JIRA ticket.  
   \- The JIRA ticket has the Patch Available state.  
   \- The description of the JIRA ticket explains WHAT was made, WHY and HOW.  
   \- The pull request title is treated as the final commit message. The 
following pattern must be used: IGNITE- Change summary where  - number 
of JIRA issue.
   - [ ] **Design:** new code conforms with the design principles of the 
components it is added to.
   - [ ] **Patch quality:** patch cannot be split into smaller pieces, its size 
must be reasonable.
   - [ ] **Code quality:** code is clean and readable, necessary developer 
documentation is added if needed.
   - [ ] **Tests code quality:** test set covers positive/negative scenarios, 
happy/edge cases. Tests are effective in terms of execution time and resources.
   
   ### Notes
   - [Apache Ignite Coding 
Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] IGNITE-22396 Update xstream to 1.4.20 [ignite]

2024-06-11 Thread via GitHub



lordgarrish opened a new pull request, #11388:
URL: https://github.com/apache/ignite/pull/11388

   Thank you for submitting the pull request to the Apache Ignite.
   
   In order to streamline the review of the contribution 
   we ask you to ensure the following steps have been taken:
   
   ### The Contribution Checklist
   - [ ] There is a single JIRA ticket related to the pull request. 
   - [ ] The web-link to the pull request is attached to the JIRA ticket.
   - [ ] The JIRA ticket has the _Patch Available_ state.
   - [ ] The pull request body describes changes that have been made. 
   The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
   - [ ] The pull request title is treated as the final commit message. 
   The following pattern must be used: `IGNITE- Change summary` where 
`` - number of JIRA issue.
   - [ ] A reviewer has been mentioned through the JIRA comments 
   (see [the Maintainers 
list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
 
   - [ ] The pull request has been checked by the Teamcity Bot and 
   the `green visa` attached to the JIRA ticket (see [TC.Bot: Check 
PR](https://mtcga.gridgain.com/prs.html))
   
   ### Notes
   - [How to 
Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
   - [Coding abbreviation 
rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
   - [Coding 
Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
   - [Apache Ignite Teamcity 
Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
   
   If you need any help, please email d...@ignite.apache.org or ask anу advice 
on http://asf.slack.com _#ignite_ channel.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] IGNITE-22302 Add resultSubscriber support to Data Streamer [ignite-3]

2024-06-11 Thread via GitHub



ptupitsyn merged PR #3900:
URL: https://github.com/apache/ignite-3/pull/3900


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] IGNITE-22052: Fix authentication tests [ignite-3]

2024-06-11 Thread via GitHub



isapego opened a new pull request, #3903:
URL: https://github.com/apache/ignite-3/pull/3903

   https://issues.apache.org/jira/browse/IGNITE-22052


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] IGNITE-22443 Fix sporadic configuration tests failures [ignite-3]

2024-06-11 Thread via GitHub



ibessonov merged PR #3895:
URL: https://github.com/apache/ignite-3/pull/3895


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] IGNITE-22449 Cache View documentation update [ignite]

2024-06-11 Thread via GitHub



alex-plekhanov merged PR #11385:
URL: https://github.com/apache/ignite/pull/11385


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] IGNITE-22464 Java thin client: Add events for client start and stop [ignite]

2024-06-11 Thread via GitHub



alex-plekhanov opened a new pull request, #11387:
URL: https://github.com/apache/ignite/pull/11387

   Thank you for submitting the pull request to the Apache Ignite.
   
   In order to streamline the review of the contribution 
   we ask you to ensure the following steps have been taken:
   
   ### The Contribution Checklist
   - [ ] There is a single JIRA ticket related to the pull request. 
   - [ ] The web-link to the pull request is attached to the JIRA ticket.
   - [ ] The JIRA ticket has the _Patch Available_ state.
   - [ ] The pull request body describes changes that have been made. 
   The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
   - [ ] The pull request title is treated as the final commit message. 
   The following pattern must be used: `IGNITE- Change summary` where 
`` - number of JIRA issue.
   - [ ] A reviewer has been mentioned through the JIRA comments 
   (see [the Maintainers 
list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
 
   - [ ] The pull request has been checked by the Teamcity Bot and 
   the `green visa` attached to the JIRA ticket (see [TC.Bot: Check 
PR](https://mtcga.gridgain.com/prs.html))
   
   ### Notes
   - [How to 
Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
   - [Coding abbreviation 
rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
   - [Coding 
Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
   - [Apache Ignite Teamcity 
Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
   
   If you need any help, please email d...@ignite.apache.org or ask anу advice 
on http://asf.slack.com _#ignite_ channel.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] IGNITE-22399 Improve handling of small network messages on send [ignite-3]

2024-06-11 Thread via GitHub



tkalkirill commented on code in PR #3865:
URL: https://github.com/apache/ignite-3/pull/3865#discussion_r1634814772


##
modules/network/src/main/java/org/apache/ignite/internal/network/netty/PipelineUtils.java:
##
@@ -57,6 +58,9 @@ public static void setup(ChannelPipeline pipeline, 
PerSessionSerializationServic
  */
 public static void setup(ChannelPipeline pipeline, 
PerSessionSerializationService serializationService,
 HandshakeManager handshakeManager, Consumer 
messageListener) {
+// Consolidate flushes to bigger ones (improves throughput with 
smaller messages at the price of the latency).

Review Comment:
   And if there are big messages and small ones, will they also be collected in 
batch or will there be a flush immediately if there are big ones?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] IGNITE-21243 Bump calcite version to 1.37 [ignite-3]

2024-06-11 Thread via GitHub



ygerzhedovich merged PR #3878:
URL: https://github.com/apache/ignite-3/pull/3878


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] IGNITE-22438 Enable ItFileTransferTest [ignite-3]

2024-06-11 Thread via GitHub



Pochatkin merged PR #3901:
URL: https://github.com/apache/ignite-3/pull/3901


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] IGNITE-22204: Sql. Set operation. Incorrect query transformation for a query with limit / offset and sort [ignite-3]

2024-06-11 Thread via GitHub



korlov42 merged PR #3857:
URL: https://github.com/apache/ignite-3/pull/3857


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] IGNITE-21957 Sql. Extend test coverage for SQL E021-10 (Character string types. Implicit casting among the character string types) [ignite-3]

2024-06-11 Thread via GitHub



AMashenkov merged PR #3896:
URL: https://github.com/apache/ignite-3/pull/3896


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] IGNITE-22440 Add Maven command for building .zip files of Ignite extensions [ignite-extensions]

2024-06-11 Thread via GitHub



NSAmelchev merged PR #274:
URL: https://github.com/apache/ignite-extensions/pull/274


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [I] Unable to connect to ignite with persistence enabled [ignite]

2024-06-11 Thread via GitHub



siddharth-u commented on issue #11386:
URL: https://github.com/apache/ignite/issues/11386#issuecomment-2160074235

   To summarise:
   
   Ignite version < 2.16 - works with persistence enabled
   Ignite version 2.16 - fails with above error for persistence enabled
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[I] Unable to connect to ignite with persistence enabled [ignite]

2024-06-11 Thread via GitHub



siddharth-u opened a new issue, #11386:
URL: https://github.com/apache/ignite/issues/11386

   Hi
   I am trying to run ignite in a cluster on kubernetes. My service tries to 
connect to the running ignite pod. But with ignite 2.16, the connection fails 
when persistence is enabled. The same operation works with persistence disabled 
with version 2.16 and also works with the previous versions irrespective of 
whether persistence is enabled or disabled. 
   I use thinClient to connect to ignite from my service
   
   logsof my service -
   
   org.apache.ignite.client.ClientException: Ignite failed to process request 
[24]: 5: Failed to execute map query on remote node 
[nodeId=514c2e13-805e-4b75-8811-9b2e8343b44b, errMsg=General error: "class 
org.apache.ignite.binary.BinaryObjectException: Cannot find metadata for object 
with compact footer (Ignite work directory might have been cleared after 
restart. Make sure that IGNITE_HOME does not point to a temp folder or any 
other folder that is destroyed/cleared on restarts) [typeId=396738638, 
IGNITE_HOME='/opt/ignite/apache-ignite']"; SQL statement:
   SELECT
   PUBLIC.__Z0._KEY __C0_0,
   PUBLIC.__Z0._VAL __C0_1,
   __Z0.LASTUPDATED __C0_2
   FROM PUBLIC.ABC __Z0
   WHERE __Z0.ABCDEF = ?1
   ORDER BY 3 LIMIT ?2 [5-197]] (server status code [1])
at 
org.apache.ignite.internal.client.thin.TcpClientChannel.convertException(TcpClientChannel.java:475)
 ~[ignite-core-2.16.0.jar!/:2.16.0]
at 
org.apache.ignite.internal.client.thin.TcpClientChannel.receive(TcpClientChannel.java:421)
 ~[ignite-core-2.16.0.jar!/:2.16.0]
at 
org.apache.ignite.internal.client.thin.TcpClientChannel.service(TcpClientChannel.java:311)
 ~[ignite-core-2.16.0.jar!/:2.16.0]
at 
org.apache.ignite.internal.client.thin.ReliableChannel.lambda$service$0(ReliableChannel.java:205)
 ~[ignite-core-2.16.0.jar!/:2.16.0]
at 
org.apache.ignite.internal.client.thin.ReliableChannel.applyOnDefaultChannel(ReliableChannel.java:835)
 ~[ignite-core-2.16.0.jar!/:2.16.0]
at 
org.apache.ignite.internal.client.thin.ReliableChannel.applyOnDefaultChannel(ReliableChannel.java:788)
 ~[ignite-core-2.16.0.jar!/:2.16.0]
at 
org.apache.ignite.internal.client.thin.ReliableChannel.service(ReliableChannel.java:205)
 ~[ignite-core-2.16.0.jar!/:2.16.0]
at 
org.apache.ignite.internal.client.thin.ReliableChannel.service(ReliableChannel.java:186)
 ~[ignite-core-2.16.0.jar!/:2.16.0]
at 
org.apache.ignite.internal.client.thin.GenericQueryPager.next(GenericQueryPager.java:93)
 ~[ignite-core-2.16.0.jar!/:2.16.0]
at 
org.apache.ignite.internal.client.thin.ClientQueryCursor$1.nextPage(ClientQueryCursor.java:93)
 ~[ignite-core-2.16.0.jar!/:2.16.0]
at 
org.apache.ignite.internal.client.thin.ClientQueryCursor$1.hasNext(ClientQueryCursor.java:76)
 ~[ignite-core-2.16.0.jar!/:2.16.0]
at java.base/java.lang.Iterable.forEach(Unknown Source) ~[na:na]
at 
org.apache.ignite.springdata.repository.query.IgniteRepositoryQuery$QueryCursorWrapper.getAll(IgniteRepositoryQuery.java:963)
 ~[ignite-spring-data-ext-2.0.0.jar!/:2.0.0]
at 
org.apache.ignite.springdata.repository.query.IgniteRepositoryQuery.transformQueryCursor(IgniteRepositoryQuery.java:616)
 ~[ignite-spring-data-ext-2.0.0.jar!/:2.0.0]
at 
org.apache.ignite.springdata.repository.query.IgniteRepositoryQuery.execute(IgniteRepositoryQuery.java:360)
 ~[ignite-spring-data-ext-2.0.0.jar!/:2.0.0]
at 
org.springframework.data.repository.core.support.RepositoryMethodInvoker.doInvoke(RepositoryMethodInvoker.java:136)
 ~[spring-data-commons-3.0.5.jar!/:3.0.5]
at 
org.springframework.data.repository.core.support.RepositoryMethodInvoker.invoke(RepositoryMethodInvoker.java:120)
 ~[spring-data-commons-3.0.5.jar!/:3.0.5]
at 
org.springframework.data.repository.core.support.QueryExecutorMethodInterceptor.doInvoke(QueryExecutorMethodInterceptor.java:164)
 ~[spring-data-commons-3.0.5.jar!/:3.0.5]
at 
org.springframework.data.repository.core.support.QueryExecutorMethodInterceptor.invoke(QueryExecutorMethodInterceptor.java:143)
 ~[spring-data-commons-3.0.5.jar!/:3.0.5]
at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:184)
 ~[spring-aop-6.0.11.jar!/:6.0.11]
at 
org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
 ~[spring-aop-6.0.11.jar!/:6.0.11]
at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:184)
 ~[spring-aop-6.0.11.jar!/:6.0.11]
at 
org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:244)
 ~[spring-aop-6.0.11.jar!/:6.0.11]
at jdk.proxy2/jdk.proxy2.$Proxy129.getGoodABCs(Unknown Source) ~[na:na]
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
~[na:na]
at

Re: [PR] IGNITE-22319 Fixed node crashing if a snapshot restore cancelled due to network issues [ignite]

2024-06-11 Thread via GitHub



NSAmelchev commented on code in PR #11361:
URL: https://github.com/apache/ignite/pull/11361#discussion_r1634399429


##
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotRestoreProcess.java:
##
@@ -1200,8 +1200,7 @@ private IgniteInternalFuture preload(UUID reqId) 
{
 }
 catch (Exception ex) {
 opCtx0.errHnd.accept(ex);
-

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] IGNITE-20650 Fix case-sensitive field names resolution [ignite-3]

2024-06-11 Thread via GitHub



AMashenkov merged PR #3850:
URL: https://github.com/apache/ignite-3/pull/3850


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] IGNITE-21966: Extend test coverage for SQL E091-01(Set functions. AVG) [ignite-3]

2024-06-11 Thread via GitHub



ygerzhedovich merged PR #3898:
URL: https://github.com/apache/ignite-3/pull/3898


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

1 2 3 4 5 6 7 8 9 10 >

1 - 100 of 20677 matches

Mail list logo