[GitHub] [ignite] Mmuzaf commented on a change in pull request #7486: IGNITE-12733: TransmissionHandler can now notify user listeners when it ends

2020-03-04 Thread GitBox
Mmuzaf commented on a change in pull request #7486: IGNITE-12733: 
TransmissionHandler can now notify user listeners when it ends
URL: https://github.com/apache/ignite/pull/7486#discussion_r387846357
 
 

 ##
 File path: 
modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoManager.java
 ##
 @@ -2835,7 +2835,11 @@ private void receiveFromChannel(
 boolean exit = in.readBoolean();
 
 if (exit) {
-rcvCtxs.remove(topic);
+ReceiverContext rcv0 = rcvCtxs.remove(topic);
 
 Review comment:
   fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [ignite] Mmuzaf commented on a change in pull request #7486: IGNITE-12733: TransmissionHandler can now notify user listeners when it ends

2020-03-04 Thread GitBox
Mmuzaf commented on a change in pull request #7486: IGNITE-12733: 
TransmissionHandler can now notify user listeners when it ends
URL: https://github.com/apache/ignite/pull/7486#discussion_r387846291
 
 

 ##
 File path: 
modules/core/src/main/java/org/apache/ignite/internal/managers/communication/TransmissionHandler.java
 ##
 @@ -40,6 +40,15 @@
  * {@link TransmissionPolicy#CHUNK} the #chunkHandler() will be 
picked up.
  */
 public interface TransmissionHandler {
+/**
+ * The end of the handled transmission. This means that all resources 
associated with previously opened
+ * session are freed and can be reused. Generally, it means that 
transmission topic from now can
 
 Review comment:
   fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services