[GitHub] [ignite] gvvinblade commented on a change in pull request #7489: IGNITE-12708: Calcite integration. Expressions factory base implementation.
gvvinblade commented on a change in pull request #7489: IGNITE-12708: Calcite
integration. Expressions factory base implementation.
URL: https://github.com/apache/ignite/pull/7489#discussion_r387865444
##
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/Upstream.java
##
@@ -15,25 +15,26 @@
* limitations under the License.
*/
-package org.apache.ignite.internal.processors.query.calcite.exec;
+package org.apache.ignite.internal.processors.query.calcite.exec.rel;
/**
* Represents an abstract data consumer.
*
- * Note: except several cases (like consumer node and mailboxes),
{@link Node#request()}, {@link Node#cancel()},
- * {@link Node#reset()}, {@link Sink#push(Object)} and {@link Sink#end()}
methods should be used from one single thread.
+ * Note: except several cases (like consumer node and mailboxes),
{@link Node#request(int)}, {@link Node#cancel()},
+ * {@link Upstream#push(Object)} and {@link Upstream#end()} methods should be
used from one single thread.
*/
-public interface Sink {
+public interface Upstream {
Review comment:
Yes, you're right, it's my mistake, of course "downstream" should be used.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] gvvinblade commented on a change in pull request #7489: IGNITE-12708: Calcite integration. Expressions factory base implementation.
gvvinblade commented on a change in pull request #7489: IGNITE-12708: Calcite
integration. Expressions factory base implementation.
URL: https://github.com/apache/ignite/pull/7489#discussion_r387864129
##
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/FilterNode.java
##
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.calcite.exec.rel;
+
+import java.util.ArrayDeque;
+import java.util.Deque;
+import java.util.function.Predicate;
+import
org.apache.ignite.internal.processors.query.calcite.exec.ExecutionContext;
+import org.apache.ignite.internal.util.typedef.F;
+
+/**
+ *
+ */
+public class FilterNode extends AbstractNode implements
SingleNode, Upstream {
+/** */
+private final Predicate predicate;
+
+/** */
+private Deque inBuffer = new ArrayDeque<>(IN_BUFFER_SIZE);
Review comment:
A filter node requests more rows than its consumer requests from the filter
because the filter filters some of them) a small buffer is used to hold the
difference till a next portion of rows is requested. The same is true for other
nodes, where a node requests from its input more rows than it's requested from
the node itself.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] gvvinblade commented on a change in pull request #7489: IGNITE-12708: Calcite integration. Expressions factory base implementation.
gvvinblade commented on a change in pull request #7489: IGNITE-12708: Calcite
integration. Expressions factory base implementation.
URL: https://github.com/apache/ignite/pull/7489#discussion_r387864129
##
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/FilterNode.java
##
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.calcite.exec.rel;
+
+import java.util.ArrayDeque;
+import java.util.Deque;
+import java.util.function.Predicate;
+import
org.apache.ignite.internal.processors.query.calcite.exec.ExecutionContext;
+import org.apache.ignite.internal.util.typedef.F;
+
+/**
+ *
+ */
+public class FilterNode extends AbstractNode implements
SingleNode, Upstream {
+/** */
+private final Predicate predicate;
+
+/** */
+private Deque inBuffer = new ArrayDeque<>(IN_BUFFER_SIZE);
Review comment:
A filter node requests more rows than its consumer requests from the filter
because the filter filters some of them) a small buffer is used to hold the
difference till a next portion of rows is requested. The same is true for other
nodes, where you may request from a node input more rows than it's requested
from the node itself.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] gvvinblade commented on a change in pull request #7489: IGNITE-12708: Calcite integration. Expressions factory base implementation.
gvvinblade commented on a change in pull request #7489: IGNITE-12708: Calcite
integration. Expressions factory base implementation.
URL: https://github.com/apache/ignite/pull/7489#discussion_r387865444
##
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/Upstream.java
##
@@ -15,25 +15,26 @@
* limitations under the License.
*/
-package org.apache.ignite.internal.processors.query.calcite.exec;
+package org.apache.ignite.internal.processors.query.calcite.exec.rel;
/**
* Represents an abstract data consumer.
*
- * Note: except several cases (like consumer node and mailboxes),
{@link Node#request()}, {@link Node#cancel()},
- * {@link Node#reset()}, {@link Sink#push(Object)} and {@link Sink#end()}
methods should be used from one single thread.
+ * Note: except several cases (like consumer node and mailboxes),
{@link Node#request(int)}, {@link Node#cancel()},
+ * {@link Upstream#push(Object)} and {@link Upstream#end()} methods should be
used from one single thread.
*/
-public interface Sink {
+public interface Upstream {
Review comment:
Yes, you right, it's my mistake, of course "downstream" should be used.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] gvvinblade commented on a change in pull request #7489: IGNITE-12708: Calcite integration. Expressions factory base implementation.
gvvinblade commented on a change in pull request #7489: IGNITE-12708: Calcite
integration. Expressions factory base implementation.
URL: https://github.com/apache/ignite/pull/7489#discussion_r387864129
##
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/FilterNode.java
##
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.calcite.exec.rel;
+
+import java.util.ArrayDeque;
+import java.util.Deque;
+import java.util.function.Predicate;
+import
org.apache.ignite.internal.processors.query.calcite.exec.ExecutionContext;
+import org.apache.ignite.internal.util.typedef.F;
+
+/**
+ *
+ */
+public class FilterNode extends AbstractNode implements
SingleNode, Upstream {
+/** */
+private final Predicate predicate;
+
+/** */
+private Deque inBuffer = new ArrayDeque<>(IN_BUFFER_SIZE);
Review comment:
A filter node requests more rows than its consumer requests from the filter
because the filter filters some of them) a small buffer is used to hold the
difference till a next portion of rows is requested. The same is true for other
nodes, where you may request from a node input more rows then requested from
the node itself.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
