[GitHub] [ignite] nizhikov commented on a change in pull request #7520: IGNITE-12632: Support of cancel command for resource-consuming entities.
nizhikov commented on a change in pull request #7520: IGNITE-12632: Support of
cancel command for resource-consuming entities.
URL: https://github.com/apache/ignite/pull/7520#discussion_r394374809
##
File path:
modules/core/src/main/java/org/apache/ignite/internal/QueryMXBeanImpl.java
##
@@ -0,0 +1,168 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal;
+
+import java.util.UUID;
+import org.apache.ignite.IgniteCompute;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.internal.cluster.IgniteClusterImpl;
+import org.apache.ignite.internal.util.typedef.T2;
+import org.apache.ignite.internal.util.typedef.internal.A;
+import org.apache.ignite.internal.util.typedef.internal.U;
+import org.apache.ignite.internal.visor.VisorTaskArgument;
+import org.apache.ignite.internal.visor.query.VisorContinuousQueryCancelTask;
+import
org.apache.ignite.internal.visor.query.VisorContinuousQueryCancelTaskArg;
+import org.apache.ignite.internal.visor.query.VisorQueryCancelTask;
+import org.apache.ignite.internal.visor.query.VisorQueryCancelTaskArg;
+import org.apache.ignite.internal.visor.query.VisorScanQueryCancelTask;
+import org.apache.ignite.internal.visor.query.VisorScanQueryCancelTaskArg;
+import org.apache.ignite.mxbean.QueryMXBean;
+
+import static
org.apache.ignite.internal.sql.command.SqlKillQueryCommand.parseGlobalQueryId;
+
+/**
+ * QueryMXBean implementation.
+ */
+public class QueryMXBeanImpl implements QueryMXBean {
+/** */
+public static final String EXPECTED_GLOBAL_QRY_ID_FORMAT = "Global query
id should have format " +
+"'{node_id}_{query_id}', e.g.
'6fa749ee-7cf8-4635-be10-36a1c75267a7_54321'";
+
+/** */
+private final GridKernalContext ctx;
+
+/** */
+private final IgniteLogger log;
+
+/**
+ * @param ctx Context.
+ */
+public QueryMXBeanImpl(GridKernalContext ctx) {
+this.ctx = ctx;
+this.log = ctx.log(QueryMXBeanImpl.class);
+}
+
+/** {@inheritDoc} */
+@Override public void cancelContinuous(String routineId) {
+A.notNull(routineId, "routineId");
+
+cancelContinuous(UUID.fromString(routineId));
+}
+
+/** {@inheritDoc} */
+@Override public void cancelSQL(String id) {
+A.notNull(id, "id");
+
+if (log.isInfoEnabled())
+log.info("Killing sql query[id=" + id + ']');
+
+boolean res;
+
+try {
+IgniteClusterImpl cluster = ctx.cluster().get();
+
+T2 ids = parseGlobalQueryId(id);
+
+if (ids == null)
+throw new IllegalArgumentException("Expected global query id.
" + EXPECTED_GLOBAL_QRY_ID_FORMAT);
+
+res = cluster.compute().execute(new VisorQueryCancelTask(),
+new VisorTaskArgument<>(ids.get1(), new
VisorQueryCancelTaskArg(ids.get1(), ids.get2()), false));
+}
+catch (Exception e) {
+throw new RuntimeException(e);
+}
+
+if (!res)
+throw new RuntimeException("Query not found[id=" + id + ']');
+}
+
+/** {@inheritDoc} */
+@Override public void cancelScan(String originNodeId, String cacheName,
Long id) {
+A.notNullOrEmpty(originNodeId, "originNodeId");
+A.notNullOrEmpty(cacheName, "cacheName");
+A.notNull(id, "id");
+
+if (log.isInfoEnabled())
+log.info("Killing scan query[id=" + id + ",originNodeId=" +
originNodeId + ']');
+
+cancelScan(UUID.fromString(originNodeId), cacheName, id);
+}
+
+/**
+ * Kills scan query by the identifiers.
+ *
+ * @param originNodeId Originating node id.
+ * @param cacheName Cache name.
+ * @param id Scan query id.
+ */
+public void cancelScan(UUID originNodeId, String cacheName, long id) {
+boolean res;
+
+try {
+IgniteClusterImpl cluster = ctx.cluster().get();
+
+ClusterNode srv = U.randomServerNode(ctx);
Review comment:
> Every node in the cluster can be overloaded, even the one where we are
going to send the kill task from.
> This is not an issue.
This is the issue I'm
[GitHub] [ignite] nizhikov commented on a change in pull request #7520: IGNITE-12632: Support of cancel command for resource-consuming entities.
nizhikov commented on a change in pull request #7520: IGNITE-12632: Support of
cancel command for resource-consuming entities.
URL: https://github.com/apache/ignite/pull/7520#discussion_r393772907
##
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/continuous/StopRoutineDiscoveryMessage.java
##
@@ -29,11 +29,24 @@
/** */
private static final long serialVersionUID = 0L;
+/** {@code True} if stop should be forced. */
+private boolean force;
Review comment:
fixed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] nizhikov commented on a change in pull request #7520: IGNITE-12632: Support of cancel command for resource-consuming entities.
nizhikov commented on a change in pull request #7520: IGNITE-12632: Support of
cancel command for resource-consuming entities.
URL: https://github.com/apache/ignite/pull/7520#discussion_r393748169
##
File path:
modules/core/src/main/java/org/apache/ignite/internal/visor/query/VisorContinuousQueryCancelTaskArg.java
##
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.visor.query;
+
+import java.io.IOException;
+import java.io.ObjectInput;
+import java.io.ObjectOutput;
+import java.util.UUID;
+import org.apache.ignite.internal.processors.task.GridInternal;
+import org.apache.ignite.internal.util.typedef.internal.S;
+import org.apache.ignite.internal.util.typedef.internal.U;
+import org.apache.ignite.internal.visor.VisorDataTransferObject;
+
+/**
+ * Arguments of task for cancel CONTINUOUS query.
+ */
+@GridInternal
+public class VisorContinuousQueryCancelTaskArg extends VisorDataTransferObject
{
Review comment:
fixed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] nizhikov commented on a change in pull request #7520: IGNITE-12632: Support of cancel command for resource-consuming entities.
nizhikov commented on a change in pull request #7520: IGNITE-12632: Support of
cancel command for resource-consuming entities.
URL: https://github.com/apache/ignite/pull/7520#discussion_r393747647
##
File path:
modules/core/src/main/java/org/apache/ignite/internal/ServiceMXBeanImpl.java
##
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal;
+
+import java.util.UUID;
+import org.apache.ignite.IgniteCompute;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.internal.cluster.IgniteClusterImpl;
+import org.apache.ignite.internal.util.typedef.internal.A;
+import org.apache.ignite.internal.util.typedef.internal.U;
+import org.apache.ignite.internal.visor.VisorTaskArgument;
+import org.apache.ignite.internal.visor.service.VisorCancelServiceTask;
+import org.apache.ignite.internal.visor.service.VisorCancelServiceTaskArg;
+import org.apache.ignite.mxbean.ServiceMXBean;
+
+/**
+ * ServiceMXBean implementation.
+ */
+public class ServiceMXBeanImpl implements ServiceMXBean {
+/** */
+private final GridKernalContext ctx;
+
+/** */
+private final IgniteLogger log;
+
+/**
+ * @param ctx Context.
+ */
+public ServiceMXBeanImpl(GridKernalContext ctx) {
+this.ctx = ctx;
+this.log = ctx.log(ServiceMXBeanImpl.class);
+}
+
+/** {@inheritDoc} */
+@Override public void cancel(String name) {
+A.notNull(name, "name");
+
+if (log.isInfoEnabled())
+log.info("Canceling service[name=" + name + ']');
+
+boolean res;
+
+try {
+IgniteClusterImpl cluster = ctx.cluster().get();
+
+IgniteCompute compute = cluster.compute();
+
+ClusterNode srv = U.randomServerNode(ctx);
+
+res = compute.execute(new VisorCancelServiceTask(),
Review comment:
Yes, we can.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] nizhikov commented on a change in pull request #7520: IGNITE-12632: Support of cancel command for resource-consuming entities.
nizhikov commented on a change in pull request #7520: IGNITE-12632: Support of
cancel command for resource-consuming entities.
URL: https://github.com/apache/ignite/pull/7520#discussion_r393747287
##
File path:
modules/core/src/main/java/org/apache/ignite/internal/QueryMXBeanImpl.java
##
@@ -0,0 +1,168 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal;
+
+import java.util.UUID;
+import org.apache.ignite.IgniteCompute;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.internal.cluster.IgniteClusterImpl;
+import org.apache.ignite.internal.util.typedef.T2;
+import org.apache.ignite.internal.util.typedef.internal.A;
+import org.apache.ignite.internal.util.typedef.internal.U;
+import org.apache.ignite.internal.visor.VisorTaskArgument;
+import org.apache.ignite.internal.visor.query.VisorContinuousQueryCancelTask;
+import
org.apache.ignite.internal.visor.query.VisorContinuousQueryCancelTaskArg;
+import org.apache.ignite.internal.visor.query.VisorQueryCancelTask;
+import org.apache.ignite.internal.visor.query.VisorQueryCancelTaskArg;
+import org.apache.ignite.internal.visor.query.VisorScanQueryCancelTask;
+import org.apache.ignite.internal.visor.query.VisorScanQueryCancelTaskArg;
+import org.apache.ignite.mxbean.QueryMXBean;
+
+import static
org.apache.ignite.internal.sql.command.SqlKillQueryCommand.parseGlobalQueryId;
+
+/**
+ * QueryMXBean implementation.
+ */
+public class QueryMXBeanImpl implements QueryMXBean {
+/** */
+public static final String EXPECTED_GLOBAL_QRY_ID_FORMAT = "Global query
id should have format " +
+"'{node_id}_{query_id}', e.g.
'6fa749ee-7cf8-4635-be10-36a1c75267a7_54321'";
+
+/** */
+private final GridKernalContext ctx;
+
+/** */
+private final IgniteLogger log;
+
+/**
+ * @param ctx Context.
+ */
+public QueryMXBeanImpl(GridKernalContext ctx) {
+this.ctx = ctx;
+this.log = ctx.log(QueryMXBeanImpl.class);
+}
+
+/** {@inheritDoc} */
+@Override public void cancelContinuous(String routineId) {
+A.notNull(routineId, "routineId");
+
+cancelContinuous(UUID.fromString(routineId));
+}
+
+/** {@inheritDoc} */
+@Override public void cancelSQL(String id) {
+A.notNull(id, "id");
+
+if (log.isInfoEnabled())
+log.info("Killing sql query[id=" + id + ']');
+
+boolean res;
+
+try {
+IgniteClusterImpl cluster = ctx.cluster().get();
+
+T2 ids = parseGlobalQueryId(id);
+
+if (ids == null)
+throw new IllegalArgumentException("Expected global query id.
" + EXPECTED_GLOBAL_QRY_ID_FORMAT);
+
+res = cluster.compute().execute(new VisorQueryCancelTask(),
+new VisorTaskArgument<>(ids.get1(), new
VisorQueryCancelTaskArg(ids.get1(), ids.get2()), false));
+}
+catch (Exception e) {
+throw new RuntimeException(e);
+}
+
+if (!res)
+throw new RuntimeException("Query not found[id=" + id + ']');
+}
+
+/** {@inheritDoc} */
+@Override public void cancelScan(String originNodeId, String cacheName,
Long id) {
+A.notNullOrEmpty(originNodeId, "originNodeId");
+A.notNullOrEmpty(cacheName, "cacheName");
+A.notNull(id, "id");
+
+if (log.isInfoEnabled())
+log.info("Killing scan query[id=" + id + ",originNodeId=" +
originNodeId + ']');
+
+cancelScan(UUID.fromString(originNodeId), cacheName, id);
+}
+
+/**
+ * Kills scan query by the identifiers.
+ *
+ * @param originNodeId Originating node id.
+ * @param cacheName Cache name.
+ * @param id Scan query id.
+ */
+public void cancelScan(UUID originNodeId, String cacheName, long id) {
+boolean res;
+
+try {
+IgniteClusterImpl cluster = ctx.cluster().get();
+
+ClusterNode srv = U.randomServerNode(ctx);
Review comment:
Same of previous:
> Why it's not a good idea to send cancel message to the initiator
My opinion - canceling of the query is the "last line of
[GitHub] [ignite] nizhikov commented on a change in pull request #7520: IGNITE-12632: Support of cancel command for resource-consuming entities.
nizhikov commented on a change in pull request #7520: IGNITE-12632: Support of
cancel command for resource-consuming entities.
URL: https://github.com/apache/ignite/pull/7520#discussion_r393742993
##
File path:
modules/core/src/main/java/org/apache/ignite/internal/QueryMXBeanImpl.java
##
@@ -0,0 +1,168 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal;
+
+import java.util.UUID;
+import org.apache.ignite.IgniteCompute;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.internal.cluster.IgniteClusterImpl;
+import org.apache.ignite.internal.util.typedef.T2;
+import org.apache.ignite.internal.util.typedef.internal.A;
+import org.apache.ignite.internal.util.typedef.internal.U;
+import org.apache.ignite.internal.visor.VisorTaskArgument;
+import org.apache.ignite.internal.visor.query.VisorContinuousQueryCancelTask;
+import
org.apache.ignite.internal.visor.query.VisorContinuousQueryCancelTaskArg;
+import org.apache.ignite.internal.visor.query.VisorQueryCancelTask;
+import org.apache.ignite.internal.visor.query.VisorQueryCancelTaskArg;
+import org.apache.ignite.internal.visor.query.VisorScanQueryCancelTask;
+import org.apache.ignite.internal.visor.query.VisorScanQueryCancelTaskArg;
+import org.apache.ignite.mxbean.QueryMXBean;
+
+import static
org.apache.ignite.internal.sql.command.SqlKillQueryCommand.parseGlobalQueryId;
+
+/**
+ * QueryMXBean implementation.
+ */
+public class QueryMXBeanImpl implements QueryMXBean {
+/** */
+public static final String EXPECTED_GLOBAL_QRY_ID_FORMAT = "Global query
id should have format " +
+"'{node_id}_{query_id}', e.g.
'6fa749ee-7cf8-4635-be10-36a1c75267a7_54321'";
+
+/** */
+private final GridKernalContext ctx;
+
+/** */
+private final IgniteLogger log;
+
+/**
+ * @param ctx Context.
+ */
+public QueryMXBeanImpl(GridKernalContext ctx) {
+this.ctx = ctx;
+this.log = ctx.log(QueryMXBeanImpl.class);
+}
+
+/** {@inheritDoc} */
+@Override public void cancelContinuous(String routineId) {
+A.notNull(routineId, "routineId");
+
+cancelContinuous(UUID.fromString(routineId));
+}
+
+/** {@inheritDoc} */
+@Override public void cancelSQL(String id) {
+A.notNull(id, "id");
+
+if (log.isInfoEnabled())
+log.info("Killing sql query[id=" + id + ']');
+
+boolean res;
+
+try {
+IgniteClusterImpl cluster = ctx.cluster().get();
+
+T2 ids = parseGlobalQueryId(id);
+
+if (ids == null)
+throw new IllegalArgumentException("Expected global query id.
" + EXPECTED_GLOBAL_QRY_ID_FORMAT);
+
+res = cluster.compute().execute(new VisorQueryCancelTask(),
+new VisorTaskArgument<>(ids.get1(), new
VisorQueryCancelTaskArg(ids.get1(), ids.get2()), false));
+}
+catch (Exception e) {
+throw new RuntimeException(e);
+}
+
+if (!res)
+throw new RuntimeException("Query not found[id=" + id + ']');
+}
+
+/** {@inheritDoc} */
+@Override public void cancelScan(String originNodeId, String cacheName,
Long id) {
+A.notNullOrEmpty(originNodeId, "originNodeId");
+A.notNullOrEmpty(cacheName, "cacheName");
+A.notNull(id, "id");
+
+if (log.isInfoEnabled())
+log.info("Killing scan query[id=" + id + ",originNodeId=" +
originNodeId + ']');
+
+cancelScan(UUID.fromString(originNodeId), cacheName, id);
+}
+
+/**
+ * Kills scan query by the identifiers.
+ *
+ * @param originNodeId Originating node id.
+ * @param cacheName Cache name.
+ * @param id Scan query id.
+ */
+public void cancelScan(UUID originNodeId, String cacheName, long id) {
+boolean res;
+
+try {
+IgniteClusterImpl cluster = ctx.cluster().get();
+
+ClusterNode srv = U.randomServerNode(ctx);
+
+IgniteCompute compute = cluster.compute();
+
+res = compute.execute(new VisorScanQueryCancelTask(),
+new VisorTaskArgument<>(srv.id(),
+
[GitHub] [ignite] nizhikov commented on a change in pull request #7520: IGNITE-12632: Support of cancel command for resource-consuming entities.
nizhikov commented on a change in pull request #7520: IGNITE-12632: Support of
cancel command for resource-consuming entities.
URL: https://github.com/apache/ignite/pull/7520#discussion_r393731396
##
File path:
modules/core/src/main/java/org/apache/ignite/internal/visor/query/VisorQueryCancelTask.java
##
@@ -17,22 +17,25 @@
package org.apache.ignite.internal.visor.query;
+import java.util.Collection;
Review comment:
it used in the method `jobNodes`:
```
@Override protected Collection
jobNodes(VisorTaskArgument arg) {
return Collections.singleton(arg.getArgument().getNodeId());
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] nizhikov commented on a change in pull request #7520: IGNITE-12632: Support of cancel command for resource-consuming entities.
nizhikov commented on a change in pull request #7520: IGNITE-12632: Support of
cancel command for resource-consuming entities.
URL: https://github.com/apache/ignite/pull/7520#discussion_r393729454
##
File path:
modules/core/src/main/java/org/apache/ignite/internal/visor/query/VisorScanQueryCancelTaskArg.java
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.visor.query;
+
+import java.io.IOException;
+import java.io.ObjectInput;
+import java.io.ObjectOutput;
+import java.util.UUID;
+import org.apache.ignite.internal.processors.task.GridInternal;
+import org.apache.ignite.internal.util.typedef.internal.S;
+import org.apache.ignite.internal.util.typedef.internal.U;
+import org.apache.ignite.internal.visor.VisorDataTransferObject;
+
+/**
+ * Arguments of task for cancel SCAN query.
+ */
+@GridInternal
+public class VisorScanQueryCancelTaskArg extends VisorDataTransferObject {
Review comment:
Fixed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] nizhikov commented on a change in pull request #7520: IGNITE-12632: Support of cancel command for resource-consuming entities.
nizhikov commented on a change in pull request #7520: IGNITE-12632: Support of cancel command for resource-consuming entities. URL: https://github.com/apache/ignite/pull/7520#discussion_r393717443 ## File path: modules/core/src/main/java/org/apache/ignite/internal/visor/query/VisorQueryCancelTask.java ## @@ -17,22 +17,25 @@ package org.apache.ignite.internal.visor.query; +import java.util.Collection; Review comment: What's wrong with it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [ignite] nizhikov commented on a change in pull request #7520: IGNITE-12632: Support of cancel command for resource-consuming entities.
nizhikov commented on a change in pull request #7520: IGNITE-12632: Support of
cancel command for resource-consuming entities.
URL: https://github.com/apache/ignite/pull/7520#discussion_r393716433
##
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryManager.java
##
@@ -1962,6 +1962,21 @@ public String cacheName() {
return cacheName;
}
+/**
+ * Cancel scan query.
+ *
+ * @param origNodeId Originating node id.
+ * @param qryId Query id.
+ */
+public boolean cancelScanQuery(UUID origNodeId, long qryId) {
Review comment:
Fixed. Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
