[GitHub] nva commented on a change in pull request #6185: IGNITE-11386 Actualized configuration of local event listeners.
nva commented on a change in pull request #6185: IGNITE-11386 Actualized
configuration of local event listeners.
URL: https://github.com/apache/ignite/pull/6185#discussion_r260618871
##
File path:
modules/web-console/frontend/app/configuration/generator/generator/JavaTransformer.service.js
##
@@ -837,6 +847,18 @@ export default class IgniteJavaTransformer extends
AbstractTransformer {
imports.push(`${grp.class}.${grp.value}`);
});
+break;
+
+case 'MAP':
+if (prop.valClsNameShow === 'ARRAY_EVENTS') {
+_.forEach(prop.entries, (lnr) => {
+_.forEach(lnr.eventTypes, (type) => {
+console.log(type);
Review comment:
console.log should be removed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] nva commented on a change in pull request #6185: IGNITE-11386 Actualized configuration of local event listeners.
nva commented on a change in pull request #6185: IGNITE-11386 Actualized
configuration of local event listeners.
URL: https://github.com/apache/ignite/pull/6185#discussion_r260619041
##
File path:
modules/web-console/frontend/app/configuration/generator/generator/JavaTransformer.service.js
##
@@ -383,6 +383,12 @@ export default class IgniteJavaTransformer extends
AbstractTransformer {
static _toObject(clsName, val) {
const items = _.isArray(val) ? val : [val];
+if (clsName === 'ARRAY_EVENTS') {
Review comment:
Please rename to EVENTS
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] nva commented on a change in pull request #6185: IGNITE-11386 Actualized configuration of local event listeners.
nva commented on a change in pull request #6185: IGNITE-11386 Actualized
configuration of local event listeners.
URL: https://github.com/apache/ignite/pull/6185#discussion_r260622589
##
File path:
modules/web-console/frontend/app/configuration/generator/generator/Beans.js
##
@@ -367,8 +367,11 @@ export class Bean extends EmptyBean {
keyClsName: dflt.keyClsName,
keyField: dflt.keyField || 'name',
valClsName: dflt.valClsName,
+valClsNameShow: dflt.valClsNameShow,
valField: dflt.valField || 'value',
-entries
+entries,
+keyClsGenericName: dflt.keyClsGenericName,
+keyClsGenericExtends: dflt.keyClsGenericExtends
Review comment:
```suggestion
isKeyClsGenericTypeExtended: dflt.isKeyClsGenericTypeExtended
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] nva commented on a change in pull request #6185: IGNITE-11386 Actualized configuration of local event listeners.
nva commented on a change in pull request #6185: IGNITE-11386 Actualized
configuration of local event listeners.
URL: https://github.com/apache/ignite/pull/6185#discussion_r260626890
##
File path:
modules/web-console/frontend/app/configuration/generator/generator/JavaTransformer.service.js
##
@@ -514,11 +520,12 @@ export default class IgniteJavaTransformer extends
AbstractTransformer {
static _constructMap(sb, map, vars = []) {
const keyClsName = this.javaTypes.shortClassName(map.keyClsName);
+const keyClsGeneric = map.keyClsGenericName ?
`<${map.keyClsGenericExtends ? '? extends ' :
''}${this.javaTypes.shortClassName(map.keyClsGenericName)}>` : '';
Review comment:
Please try to simplify this expression, may be will be better to separate
for two lines or add braces.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] nva commented on a change in pull request #6185: IGNITE-11386 Actualized configuration of local event listeners.
nva commented on a change in pull request #6185: IGNITE-11386 Actualized
configuration of local event listeners.
URL: https://github.com/apache/ignite/pull/6185#discussion_r260622443
##
File path:
modules/web-console/frontend/app/configuration/generator/generator/Beans.js
##
@@ -367,8 +367,11 @@ export class Bean extends EmptyBean {
keyClsName: dflt.keyClsName,
keyField: dflt.keyField || 'name',
valClsName: dflt.valClsName,
+valClsNameShow: dflt.valClsNameShow,
valField: dflt.valField || 'value',
-entries
+entries,
+keyClsGenericName: dflt.keyClsGenericName,
Review comment:
```suggestion
keyClsGenericType: dflt.keyClsGenericType,
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
