[BUILD-STABLE]: Job 'IoTDB/IoTDB-pip-new/master [master] [562]'
BUILD-STABLE: Job 'IoTDB/IoTDB-pip-new/master [master] [562]': Is back to normal.
Re: [PR] Remove useless setting for IT [iotdb-client-go]
HTHou merged PR #99: URL: https://github.com/apache/iotdb-client-go/pull/99 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Merge config files to iotdb-system.properties [iotdb-client-go]
HTHou commented on code in PR #99: URL: https://github.com/apache/iotdb-client-go/pull/99#discussion_r1609497471 ## test/e2e/Dockerfile.iotdb-server: ## @@ -24,8 +24,8 @@ RUN apt update \ ADD target /usr/local ADD test/e2e/start-1c1d.sh / WORKDIR /usr/local/iotdb -RUN sed -i 's/dn_rpc_address=127.0.0.1/dn_rpc_address=0.0.0.0/g' conf/iotdb-datanode.properties \ - && sed -i 's/dn_internal_address=127.0.0.1/dn_internal_address=0.0.0.0/g' conf/iotdb-datanode.properties \ - && sed -i 's/cn_internal_address=127.0.0.1/cn_internal_address=0.0.0.0/g' conf/iotdb-confignode.properties +RUN sed -i 's/dn_rpc_address=127.0.0.1/dn_rpc_address=0.0.0.0/g' conf/iotdb-system.properties \ + && sed -i 's/dn_internal_address=127.0.0.1/dn_internal_address=0.0.0.0/g' conf/iotdb-system.properties \ + && sed -i 's/cn_internal_address=127.0.0.1/cn_internal_address=0.0.0.0/g' conf/iotdb-system.properties Review Comment: Removing these lines is better? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Merge config files to iotdb-system.properties [iotdb-client-go]
HTHou commented on code in PR #99: URL: https://github.com/apache/iotdb-client-go/pull/99#discussion_r1609497471 ## test/e2e/Dockerfile.iotdb-server: ## @@ -24,8 +24,8 @@ RUN apt update \ ADD target /usr/local ADD test/e2e/start-1c1d.sh / WORKDIR /usr/local/iotdb -RUN sed -i 's/dn_rpc_address=127.0.0.1/dn_rpc_address=0.0.0.0/g' conf/iotdb-datanode.properties \ - && sed -i 's/dn_internal_address=127.0.0.1/dn_internal_address=0.0.0.0/g' conf/iotdb-datanode.properties \ - && sed -i 's/cn_internal_address=127.0.0.1/cn_internal_address=0.0.0.0/g' conf/iotdb-confignode.properties +RUN sed -i 's/dn_rpc_address=127.0.0.1/dn_rpc_address=0.0.0.0/g' conf/iotdb-system.properties \ + && sed -i 's/dn_internal_address=127.0.0.1/dn_internal_address=0.0.0.0/g' conf/iotdb-system.properties \ + && sed -i 's/cn_internal_address=127.0.0.1/cn_internal_address=0.0.0.0/g' conf/iotdb-system.properties Review Comment: Removing these lines is better? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Merge config files to iotdb-system.properties [iotdb-client-go]
HTHou commented on code in PR #99: URL: https://github.com/apache/iotdb-client-go/pull/99#discussion_r1609491797 ## test/e2e/Dockerfile.iotdb-server: ## @@ -24,8 +24,8 @@ RUN apt update \ ADD target /usr/local ADD test/e2e/start-1c1d.sh / WORKDIR /usr/local/iotdb -RUN sed -i 's/dn_rpc_address=127.0.0.1/dn_rpc_address=0.0.0.0/g' conf/iotdb-datanode.properties \ - && sed -i 's/dn_internal_address=127.0.0.1/dn_internal_address=0.0.0.0/g' conf/iotdb-datanode.properties \ - && sed -i 's/cn_internal_address=127.0.0.1/cn_internal_address=0.0.0.0/g' conf/iotdb-confignode.properties +RUN sed -i 's/dn_rpc_address=127.0.0.1/dn_rpc_address=0.0.0.0/g' conf/iotdb-system.properties \ + && sed -i 's/dn_internal_address=127.0.0.1/dn_internal_address=0.0.0.0/g' conf/iotdb-system.properties \ + && sed -i 's/cn_internal_address=127.0.0.1/cn_internal_address=0.0.0.0/g' conf/iotdb-system.properties Review Comment: Removing these lines is better? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
