[jira] [Updated] (JCLOUDS-504) search for group name in tags

2014-03-20 Thread Izek Greenfield (JIRA)

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Izek Greenfield updated JCLOUDS-504:


Description: By now aws-ec2 search for group in the securityGroup name and 
keyPair. it will be great to add search in tags for tag called jclouds#group  
 (was: By now aws-ec2 search for group in the securityGroup name and keyPair. 
it will be grate to add search in tags for tag called jclouds#group )

 search for group name in tags
 -

 Key: JCLOUDS-504
 URL: https://issues.apache.org/jira/browse/JCLOUDS-504
 Project: jclouds
  Issue Type: Improvement
  Components: jclouds-compute
Affects Versions: 1.8.0
Reporter: Izek Greenfield
  Labels: aws, compute, ec2

 By now aws-ec2 search for group in the securityGroup name and keyPair. it 
 will be great to add search in tags for tag called jclouds#group 



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (JCLOUDS-180) Audit MD5 enforcement via new live tests

2014-03-20 Thread Bhathiya Supun (JIRA)

[ 
https://issues.apache.org/jira/browse/JCLOUDS-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941719#comment-13941719
 ] 

Bhathiya Supun commented on JCLOUDS-180:


 I like to work on this issue,Where it stands now?(I am asking because issue is 
created 8 months back and things may have change).

 Audit MD5 enforcement via new live tests
 

 Key: JCLOUDS-180
 URL: https://issues.apache.org/jira/browse/JCLOUDS-180
 Project: jclouds
  Issue Type: Improvement
  Components: jclouds-blobstore
Reporter: Andrew Gaul
Assignee: Andrew Gaul

 We should audit MD5 enforcement via new live tests.  These tests shoud upload 
 a blob with missing MD5, an incorrect MD5, and a correct MD5, for both 
 authenticated putBlob and signed URL PUT.  Previously we encountered 
 situations where providers like Atmos and Swift used different headers than 
 Content-MD5 and did not benefit from this data integrity check.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (JCLOUDS-180) Audit MD5 enforcement via new live tests

2014-03-20 Thread Andrew Gaul (JIRA)

[ 
https://issues.apache.org/jira/browse/JCLOUDS-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941892#comment-13941892
 ] 

Andrew Gaul commented on JCLOUDS-180:
-

[~Bhash90] Presently all (known) providers enforce MD5 with jclouds.  However 
we should add a test to BaseBlobIntegrationTest to prove this.  Would you like 
to add this test?  It will help with your GSoC project.

 Audit MD5 enforcement via new live tests
 

 Key: JCLOUDS-180
 URL: https://issues.apache.org/jira/browse/JCLOUDS-180
 Project: jclouds
  Issue Type: Improvement
  Components: jclouds-blobstore
Reporter: Andrew Gaul
Assignee: Andrew Gaul

 We should audit MD5 enforcement via new live tests.  These tests shoud upload 
 a blob with missing MD5, an incorrect MD5, and a correct MD5, for both 
 authenticated putBlob and signed URL PUT.  Previously we encountered 
 situations where providers like Atmos and Swift used different headers than 
 Content-MD5 and did not benefit from this data integrity check.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


Re: [jclouds-examples] Remove RestContext from Rackspace examples (#35)

2014-03-20 Thread Ignasi Barrera
Closed #35.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/35

Re: [jclouds-examples] Remove RestContext from Rackspace examples (#35)

2014-03-20 Thread Ignasi Barrera
[Merged](https://git-wip-us.apache.org/repos/asf?p=jclouds-examples.git;a=commit;h=40da9b47850f6794381f9cd7557ab034300aa375).
 Thanks!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/35#issuecomment-38190676

Jenkins build became unstable: jclouds » jclouds #928

2014-03-20 Thread BuildHive
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds/928/changes



Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

2014-03-20 Thread BuildHive
[jclouds » jclouds 
#928](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/928/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/312#issuecomment-38205060

[jira] [Created] (JCLOUDS-505) Deprecate and remove org.jclouds.blobstore.functions.ObjectMD5

2014-03-20 Thread Andrew Gaul (JIRA)
Andrew Gaul created JCLOUDS-505:
---

 Summary: Deprecate and remove 
org.jclouds.blobstore.functions.ObjectMD5
 Key: JCLOUDS-505
 URL: https://issues.apache.org/jira/browse/JCLOUDS-505
 Project: jclouds
  Issue Type: Improvement
  Components: jclouds-blobstore
Affects Versions: 1.8.0, 1.7.2
Reporter: Andrew Gaul


Callers should prefer Guava Hashing instead.  We should deprecate this in 1.7.2 
and remove it in 1.8.0.  Thanks [~Bhash90] for bringing this to my attention!



--
This message was sent by Atlassian JIRA
(v6.2#6252)


Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

2014-03-20 Thread CloudBees pull request builder plugin
[jclouds-pull-requests 
#673](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/673/) UNSTABLE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/312#issuecomment-38206878

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

2014-03-20 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests 
#1143](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1143/) 
SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/312#issuecomment-38207968

[jclouds] JCLOUDS-505: Remove unused ObjectMD5 (#321)

2014-03-20 Thread Andrew Gaul
The only users of this seem to be
org.jclouds.atmos.blobstore.strategy.FindMD5InUserMetadata and
org.jclouds.azureblob.blobstore.strategy.FindMD5InBlobProperties which
are themselves unused.
You can merge this Pull Request by running:

  git pull https://github.com/maginatics/jclouds remove-object-md5

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds/pull/321

-- Commit Summary --

  * JCLOUDS-505: Remove unused ObjectMD5

-- File Changes --

M 
apis/atmos/src/main/java/org/jclouds/atmos/blobstore/config/AtmosBlobStoreContextModule.java
 (3)
D 
apis/atmos/src/main/java/org/jclouds/atmos/blobstore/strategy/FindMD5InUserMetadata.java
 (130)
D 
apis/atmos/src/test/java/org/jclouds/atmos/blobstore/config/AtmosBlobStoreModuleTest.java
 (62)
D blobstore/src/main/java/org/jclouds/blobstore/functions/ObjectMD5.java 
(56)
D 
blobstore/src/main/java/org/jclouds/blobstore/strategy/ContainsValueInListStrategy.java
 (34)
D 
blobstore/src/main/java/org/jclouds/blobstore/strategy/internal/FindMD5InList.java
 (66)
D 
blobstore/src/test/java/org/jclouds/blobstore/functions/ObjectMD5Test.java (62)
M 
providers/azureblob/src/main/java/org/jclouds/azureblob/blobstore/config/AzureBlobStoreContextModule.java
 (3)
D 
providers/azureblob/src/main/java/org/jclouds/azureblob/blobstore/strategy/FindMD5InBlobProperties.java
 (72)
D 
providers/azureblob/src/test/java/org/jclouds/azureblob/blobstore/config/AzureBlobStoreModuleTest.java
 (45)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/321.patch
https://github.com/jclouds/jclouds/pull/321.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/321


Re: [jclouds] JCLOUDS-505: Remove unused ObjectMD5 (#321)

2014-03-20 Thread Andrew Phillips
Pending PR builders, definitely +1, good to go for me - thanks for the cleanup, 
@andrewgaul! Do we know if e.g. this is maybe used in labs?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/321#issuecomment-38211729

Re: [jclouds] JCLOUDS-505: Remove unused ObjectMD5 (#321)

2014-03-20 Thread BuildHive
[jclouds » jclouds 
#929](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/929/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/321#issuecomment-38216413

Re: [jclouds] JCLOUDS-505: Deprecate unused ObjectMD5 (#322)

2014-03-20 Thread Andrew Phillips
Add a will be removed in 1.8.0 warning? Otherwise, good to go for me, +1 
(pending PR builders, obviously). Thanks, @andrewgaul!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/322#issuecomment-38216555

Re: [jclouds] JCLOUDS-505: Remove unused ObjectMD5 (#321)

2014-03-20 Thread CloudBees pull request builder plugin
[jclouds-pull-requests 
#674](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/674/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/321#issuecomment-38217431

Jenkins build is still unstable: jclouds » jclouds-labs-openstack #934

2014-03-20 Thread BuildHive
See 
https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/934/



Re: [jclouds] JCLOUDS-505: Deprecate unused ObjectMD5 (#322)

2014-03-20 Thread CloudBees pull request builder plugin
[jclouds-pull-requests 
#675](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/675/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/322#issuecomment-38217492

Re: [jclouds] JCLOUDS-505: Remove unused ObjectMD5 (#321)

2014-03-20 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests 
#1144](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1144/) 
SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/321#issuecomment-38217877

Re: [jclouds] JCLOUDS-505: Deprecate unused ObjectMD5 (#322)

2014-03-20 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests 
#1145](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1145/) 
SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/322#issuecomment-38218321

Re: [jclouds] JCLOUDS-184: Improving AzureBlob unit tests for AzureBlobBlockUploadStrategyTest (#320)

2014-03-20 Thread CloudBees pull request builder plugin
[jclouds-pull-requests 
#676](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/676/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/320#issuecomment-38221041

Re: [jclouds] JCLOUDS-505: Deprecate unused ObjectMD5 (#322)

2014-03-20 Thread BuildHive
[jclouds » jclouds 
#930](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/930/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/322#issuecomment-38221733

Re: [jclouds-examples] Remove RestContext from Rackspace examples (#35)

2014-03-20 Thread Andrew Phillips
  .credentials(username, apiKey)
  .modules(modules)
 -.overrides(overrides)
 -.buildView(ComputeServiceContext.class);
 -  computeService = context.getComputeService();
 -  nova = context.unwrap();
 -  volumeAttachmentApi = 
 nova.getApi().getVolumeAttachmentExtensionForZone(ZONE).get();
 +.overrides(overrides);
 +
 +  computeService = 
 builder.buildView(ComputeServiceContext.class).getComputeService();
 +  nova = builder.buildApi(NovaApi.class);

Hm...do we recommend building _two separate_ things here? Isn't that 
effectively creating two contexts, which is quite expensive? In this case, I'd 
say the old approach (building one context, then getting the compute service 
and unwrapping the context) is preferable?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/35/files#r10816650

Re: [jclouds-examples] Remove RestContext from Rackspace examples (#35)

2014-03-20 Thread Andrew Phillips
  .credentials(username, apiKey)
 -.modules(modules)
 -.buildView(ComputeServiceContext.class);
 -  computeService = context.getComputeService();
 -  nova = context.unwrap();
 -  serverApi = nova.getApi().getServerApiForZone(ZONE);
 -  volumeAttachmentApi = 
 nova.getApi().getVolumeAttachmentExtensionForZone(ZONE).get();
 +.modules(modules);
 +  computeService = 
 builder.buildView(ComputeServiceContext.class).getComputeService();
 +  nova = builder.buildApi(NovaApi.class);

Same comment as above. Stick to building one context?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/35/files#r10816697

Re: [jclouds-examples] Remove RestContext from Rackspace examples (#35)

2014-03-20 Thread Andrew Phillips
 @@ -212,6 +215,7 @@ private void mountVolume(NodeMetadata node) {
  */
 public void close() throws IOException {
Closeables.close(cinderApi, true);
 +  Closeables.close(nova, true);

If we stick with one context, we wouldn't need this, I guess?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/35/files#r10816673

Re: [jclouds] JCLOUDS-184: Improving AzureBlob unit tests for AzureBlobBlockUploadStrategyTest (#320)

2014-03-20 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests 
#1146](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1146/) 
UNSTABLE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/320#issuecomment-38221925

Re: [jclouds-examples] Remove RestContext from Rackspace examples (#35)

2014-03-20 Thread Andrew Phillips
 @@ -22,12 +22,13 @@
   * Constants used by the Rackspace Examples.
   * 
   * @author Everett Toews
 + * @authot Jeremy Daggett

[minor] author

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/35/files#r10816711

Re: [jclouds-examples] Remove RestContext from Rackspace examples (#35)

2014-03-20 Thread Andrew Phillips
 @@ -77,12 +81,10 @@ public static void main(String[] args) throws IOException 
 {
 }
  
 public UploadDirectoryToCDN(String username, String apiKey) {
 -  BlobStoreContext context = ContextBuilder.newBuilder(PROVIDER)
 -.credentials(username, apiKey)
 -.buildView(BlobStoreContext.class);
 -  blobStore = context.getBlobStore();
 -  // can use context.unwrapApi(CloudFilesClient.class) in jclouds 1.7
 -  cloudFilesClient = 
 context.unwrap(CloudFilesApiMetadata.CONTEXT_TOKEN).getApi();
 +  ContextBuilder builder = ContextBuilder.newBuilder(PROVIDER)
 +.credentials(username, apiKey);
 +  blobStore = builder.buildView(BlobStoreContext.class).getBlobStore();
 +  cloudFilesClient = builder.buildApi(CloudFilesClient.class);

Same as above, again - two contexts created here.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/35/files#r10816761

Re: [jclouds-examples] Remove RestContext from Rackspace examples (#35)

2014-03-20 Thread Andrew Phillips
 @@ -67,11 +71,10 @@ public static void main(String[] args) throws IOException 
 {
 }
  
 public UploadObjects(String username, String apiKey) {
 -  BlobStoreContext context = ContextBuilder.newBuilder(PROVIDER)
 -.credentials(username, apiKey)
 -.buildView(BlobStoreContext.class);
 -  blobStore = context.getBlobStore();
 -  swift = context.unwrap();
 +  ContextBuilder builder = ContextBuilder.newBuilder(PROVIDER)
 +  .credentials(username, apiKey);
 +  blobStore = builder.buildView(BlobStoreContext.class).getBlobStore();
 +  swift = builder.buildApi(CloudFilesClient.class);

And again here.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/35/files#r10816767

Re: [jclouds-examples] Remove RestContext from Rackspace examples (#35)

2014-03-20 Thread Andrew Phillips
  .credentials(username, apiKey)
  .overrides(overrides)
 -.modules(modules)
 -.buildView(ComputeServiceContext.class);
 -
 -  computeService = context.getComputeService();
 -  novaContext = context.unwrap();
 +.modules(modules);
 +  computeService = 
 builder.buildView(ComputeServiceContext.class).getComputeService();
 +  nova = builder.buildApi(NovaApi.class);

And here ;-)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/35/files#r10816775

Re: [jclouds-examples] Remove RestContext from Rackspace examples (#35)

2014-03-20 Thread Andrew Phillips
Most of the cleanup is great, thanks @jdaggett! Just a comment about those 
examples where we use both the ComputeService view and the API. This 
refactoring now ends up creating _two_ contexts in those cases, which I'm not 
sure is a good thing to be recommending?

@everett-toews @zack-shoylev What do you think..?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/35#issuecomment-38222173

Re: [jclouds] JCLOUDS-184: Improving AzureBlob unit tests for AzureBlobBlockUploadStrategyTest (#320)

2014-03-20 Thread Andrew Phillips
 jclouds-java-7-pull-requests #1146 UNSTABLE

Spurious [test 
failure](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/org.apache.jclouds$jclouds-compute/1146/testReport/junit/org.jclouds.compute.util/ConcurrentOpenSocketFinderTest/testChecksSocketsConcurrently/)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/320#issuecomment-3846

Re: [jclouds-examples] Remove RestContext from Rackspace examples (#35)

2014-03-20 Thread Jeremy Daggett
@demobox Thanks for the feedback! Removal of RestContext was the first step in 
a bunch of example changes coming. I can update with your suggestions in the 
next PR which is underway now. WDYT?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/35#issuecomment-38222858

Jenkins build is still unstable: jclouds » jclouds-labs-openstack #935

2014-03-20 Thread BuildHive
See 
https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/935/



Re: [jclouds-examples] Remove RestContext from Rackspace examples (#35)

2014-03-20 Thread Ignasi Barrera
Didn't notice that when going through the PR. and agree. Examples should be 
creating only one context!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/35#issuecomment-38228840

[jira] [Commented] (JCLOUDS-458) Google Cloud Storage support

2014-03-20 Thread Roney Thomas (JIRA)

[ 
https://issues.apache.org/jira/browse/JCLOUDS-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13942722#comment-13942722
 ] 

Roney Thomas commented on JCLOUDS-458:
--

Deliverables : Google Cloud Storage Support 
Time Schedule : The time frame for this project is from May 19 to August 18 and 
there is 13 weeks to work on. 
(Up Until May 18) : Community bonding, Learn about the state of jcloud. Learn 
how other cloud storage services are supported in jcloud. Learn about the apis 
in Google cloud storage. 
3 Weeks : Add support for Google cloud storage and a test suit 
1 Week : Fix any bugs related to Google cloud storage and add documentation
3 Weeks : Fix any other issues/bugs related to jcloud
3 Weeks : Examine any other possible to way to enhance jcloud. Which includes 
improving any existing apis and adding support to more cloud service providers.
3 Weeks : Fix any bugs/issues related to any new api’s added by me other than 
Google Cloud storage.
Reason for choosing : I volunteer at a non-profit organization that uses a lot 
of Google Cloud service. Mainly App Engine and Google Cloud Storage. Last 
summer I made a photo sharing website with App Engine and Google Cloud Storage. 
So I am really familiar with Google Cloud Storage api’s.

During the first week of June I have my finals and after that I am free.

 Google Cloud Storage support
 

 Key: JCLOUDS-458
 URL: https://issues.apache.org/jira/browse/JCLOUDS-458
 Project: jclouds
  Issue Type: New Feature
  Components: jclouds-blobstore
Reporter: Andrew Gaul
  Labels: gsoc2014

 Presently users can access Google Cloud Storage via the S3-compatible API, 
 although native support would give access to durable reduced availability, 
 better region support, and resumable uploads.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


Re: [jclouds] JCLOUDS-486 This will allow booting up nova servers with fixed IPs and p... (#313)

2014-03-20 Thread Andrew Phillips
 @@ -537,7 +558,8 @@ public NovaTemplateOptions nodeNames(IterableString 
 nodeNames) {
 }
  
 /**
 -* {@inheritDoc}
 +* brEnsures NovaTemplateOptions can work with networks specified as 
 Strings.

What's the `br` for here?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/313/files#r10826214

Re: [jclouds] JCLOUDS-486 This will allow booting up nova servers with fixed IPs and p... (#313)

2014-03-20 Thread Andrew Phillips
 @@ -545,6 +567,15 @@ public NovaTemplateOptions networks(IterableString 
 networks) {
 }
  
 /**
 +* brEnsures NovaTemplateOptions can work with networks specified as 
 Strings.

What's the `br` for here?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/313/files#r10826218

Re: [jclouds] JCLOUDS-486 This will allow booting up nova servers with fixed IPs and p... (#313)

2014-03-20 Thread Andrew Phillips
 + */
 +package org.jclouds.openstack.nova.v2_0.domain;
 +
 +import java.beans.ConstructorProperties;
 +
 +import com.google.common.base.Objects;
 +import com.google.common.base.Objects.ToStringHelper;
 +
 +import static com.google.common.base.Preconditions.checkArgument;
 +
 +/**
 + * Nova (or Neutron) network definition
 + * Used to provide support for network, port, and fixed_ip when booting Nova 
 servers.
 + * OpenStack will support either a Nova Network or Neutron, but not both at 
 the same time.
 + * Specifying a port is only possible with Neutron.
 + * @author Zack Shoylev

[minor] Blank line before `@author`?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/313/files#r10826266

Re: [jclouds] JCLOUDS-486 This will allow booting up nova servers with fixed IPs and p... (#313)

2014-03-20 Thread Andrew Phillips
 + * See the License for the specific language governing permissions and
 + * limitations under the License.
 + */
 +package org.jclouds.openstack.nova.v2_0.domain;
 +
 +import java.beans.ConstructorProperties;
 +
 +import com.google.common.base.Objects;
 +import com.google.common.base.Objects.ToStringHelper;
 +
 +import static com.google.common.base.Preconditions.checkArgument;
 +
 +/**
 + * Nova (or Neutron) network definition
 + * Used to provide support for network, port, and fixed_ip when booting Nova 
 servers.
 + * OpenStack will support either a Nova Network or Neutron, but not both at 
 the same time.

[minor] Is this network?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/313/files#r10826287

[jira] [Comment Edited] (JCLOUDS-458) Google Cloud Storage support

2014-03-20 Thread Roney Thomas (JIRA)

[ 
https://issues.apache.org/jira/browse/JCLOUDS-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13942722#comment-13942722
 ] 

Roney Thomas edited comment on JCLOUDS-458 at 3/21/14 3:40 AM:
---

Deliverables : Google Cloud Storage Support 
Time Schedule : The time frame for this project is from May 19 to August 18 and 
there is 13 weeks to work on. 
(Up Until May 18) : Community bonding, Learn about the state of jcloud. Learn 
how other cloud storage services are supported in jcloud. Learn about the apis 
in Google cloud storage. 
3 Weeks : Add support for Google cloud storage and a test suit 
1 Week : Fix any bugs related to Google cloud storage and add documentation
3 Weeks : Fix any other issues/bugs related to jcloud
3 Weeks : Examine any other possible to way to enhance jcloud. Which includes 
improving any existing apis and adding support to more cloud service providers.
3 Weeks : Fix any bugs/issues related to any new api’s added by me other than 
Google Cloud storage.
Reason for choosing : I volunteer at a non-profit organization that uses a lot 
of Google Cloud service. Mainly App Engine and Google Cloud Storage. Last 
summer I made a photo sharing website with App Engine and Google Cloud Storage. 
So I am really familiar with Google Cloud Storage api’s.

Other activities during GsOC period : During the first week of June I have my 
finals and after that I am free.


was (Author: roneythomas):
Deliverables : Google Cloud Storage Support 
Time Schedule : The time frame for this project is from May 19 to August 18 and 
there is 13 weeks to work on. 
(Up Until May 18) : Community bonding, Learn about the state of jcloud. Learn 
how other cloud storage services are supported in jcloud. Learn about the apis 
in Google cloud storage. 
3 Weeks : Add support for Google cloud storage and a test suit 
1 Week : Fix any bugs related to Google cloud storage and add documentation
3 Weeks : Fix any other issues/bugs related to jcloud
3 Weeks : Examine any other possible to way to enhance jcloud. Which includes 
improving any existing apis and adding support to more cloud service providers.
3 Weeks : Fix any bugs/issues related to any new api’s added by me other than 
Google Cloud storage.
Reason for choosing : I volunteer at a non-profit organization that uses a lot 
of Google Cloud service. Mainly App Engine and Google Cloud Storage. Last 
summer I made a photo sharing website with App Engine and Google Cloud Storage. 
So I am really familiar with Google Cloud Storage api’s.

During the first week of June I have my finals and after that I am free.

 Google Cloud Storage support
 

 Key: JCLOUDS-458
 URL: https://issues.apache.org/jira/browse/JCLOUDS-458
 Project: jclouds
  Issue Type: New Feature
  Components: jclouds-blobstore
Reporter: Andrew Gaul
  Labels: gsoc2014

 Presently users can access Google Cloud Storage via the S3-compatible API, 
 although native support would give access to durable reduced availability, 
 better region support, and resumable uploads.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


Re: [jclouds] JCLOUDS-486 This will allow booting up nova servers with fixed IPs and p... (#313)

2014-03-20 Thread Andrew Phillips
 @@ -364,6 +386,16 @@ public CreateServerOptions availabilityZone(String 
 availabilityZone) {
 public SetString getNetworks() {
return networks;
 }
 +   
 +   /**
 +* Get custom networks specified for the server.

[minor] Gets

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/313/files#r10826455

Re: [jclouds] JCLOUDS-486 This will allow booting up nova servers with fixed IPs and p... (#313)

2014-03-20 Thread Andrew Phillips
 -  }
 -   }
 -}
 -
 -@Test
 -public void testCreateInAvailabilityZone() {
 -String serverId = null;
 -for (String zoneId : zones) {
 -ServerApi serverApi = api.getServerApiForZone(zoneId);
 -try {
 -serverId = createServer(zoneId, nova, 
 Server.Status.ACTIVE).getId();
 -Server server = serverApi.get(serverId);
 -assertEquals(server.getStatus(), Server.Status.ACTIVE);
 -} finally {
 -serverApi.delete(serverId);
 +   @Test(description = GET /v${apiVersion}/{tenantId}/servers)

I like this (the description), but is it something we do anywhere else..?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/313/files#r10826467

Re: [jclouds] JCLOUDS-486 This will allow booting up nova servers with fixed IPs and p... (#313)

2014-03-20 Thread Andrew Phillips
 +serverId = createServer(zoneId, nova, 
 Server.Status.ACTIVE).getId();
 +Server server = serverApi.get(serverId);
 +assertEquals(server.getStatus(), Server.Status.ACTIVE);
 + } finally {
 +serverApi.delete(serverId);
 + }
 +  }
 +   }
 +
 +   /**
 +* This needs to be supported by the provider, and is usually not 
 supported.
 +* However this can be tested on devstack:
 +* In apis/openstack-nova:
 +* mvn -Plive clean install 
 -Dtest.openstack-nova.endpoint=http://localhost:5000/v2.0; 
 -Dtest.openstack-nova.identity=demo:demo 
 -Dtest.openstack-nova.credential=devstack 
 -Dtest=org.jclouds.openstack.nova.v2_0.features.ServerApiLiveTest#testCreateWithNetworkOptions
 +*/
 +   @Test(enabled = false)

Hm...is there some way we can programmatically test whether to run this test or 
not, rather than adding a disabled test to the code base, that is liable to rot?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/313/files#r10826500

Re: [jclouds] JCLOUDS-486 This will allow booting up nova servers with fixed IPs and p... (#313)

2014-03-20 Thread Andrew Phillips
 +  withImage(server.getImage().getId()).
 +  name(newName).
 +  adminPass(password).
 +  ipv4Address(1.1.1.1).
 +  ipv6Address(fe80::100);
 +
 +serverApi.rebuild(serverId, options);
 +
 +Server rebuiltServer = serverApi.get(serverId);
 +
 +assertEquals(newName, rebuiltServer.getName());
 +assertEquals(1.1.1.1, rebuiltServer.getAccessIPv4());
 +assertEquals(fe80::100, rebuiltServer.getAccessIPv6());
 +
 + } finally {
 +serverApi.delete(serverId);

What if serverId is still null at this point?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/313/files#r10826578

Re: [jclouds] JCLOUDS-486 This will allow booting up nova servers with fixed IPs and p... (#313)

2014-03-20 Thread Andrew Phillips
 -}
 + }
 +  }
 +   }
 +
 +   @Test
 +   public void testCreateInWrongAvailabilityZone() {
 +  String serverId = null;
 +  for (String zoneId : zones) {
 + ServerApi serverApi = api.getServerApiForZone(zoneId);
 + try {
 +serverId = createServer(zoneId, err, 
 Server.Status.ERROR).getId();
 +Server server = serverApi.get(serverId);
 +assertEquals(server.getStatus(), Server.Status.ERROR);
 + } finally {
 +serverApi.delete(serverId);

What if serverId is still null at this point?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/313/files#r10826577

Re: [jclouds] JCLOUDS-486 This will allow booting up nova servers with fixed IPs and p... (#313)

2014-03-20 Thread Andrew Phillips
 +serverApi.delete(serverId);
 + }
 +  }
 +   }
 +
 +   private Server createServer(String regionId, Server.Status serverStatus) {
 +  ServerApi serverApi = api.getServerApiForZone(regionId);
 +  CreateServerOptions options = new CreateServerOptions();
 +  ServerCreated server = serverApi.create(hostName, 
 imageIdForZone(regionId), flavorRefForZone(regionId), options);
 +
 +  blockUntilServerInState(server.getId(), serverApi, serverStatus);
 +
 +  return serverApi.get(server.getId());
 +   }
 +
 +   private Server createServer(String regionId, String availabilityZoneId, 
 Server.Status serverStatus) {

[minor] Rather than duplicate almost the whole method, add a null switch for 
availabilityZone?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/313/files#r10826604