[jira] [Commented] (JCLOUDS-1125) list multipart uploads

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/JCLOUDS-1125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347694#comment-15347694
 ] 

ASF subversion and git services commented on JCLOUDS-1125:
--

Commit 6df0472ab5f70b96ea55ee6f75abd45d218f64ee in jclouds's branch 
refs/heads/master from [~gaul]
[ https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=6df0472 ]

JCLOUDS-1125: local blobstore list MPUs


> list multipart uploads
> --
>
> Key: JCLOUDS-1125
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1125
> Project: jclouds
>  Issue Type: New Feature
>  Components: jclouds-blobstore
>Affects Versions: 2.0.0
>Reporter: Andrew Gaul
>Assignee: Andrew Gaul
> Fix For: 2.0.0
>
>
> jclouds provides support for multipart uploads on most providers but lacks a 
> list multipart upload feature in both the providers and portable abstraction. 
>  Clients use this operation when they want to abort a MPU but does not have 
> the original upload id, e.g., {{BlobStore.clearContainer}}.  We should 
> support listing on providers with native support and emulate it on others.  
> Compatibility matrix:
> * Atmos: not supported
> * Azure: https://msdn.microsoft.com/en-us/library/azure/dd135734.aspx
> * B2: https://www.backblaze.com/b2/docs/b2_list_unfinished_large_files.html
> * GCS: not supported
> * S3: 
> https://docs.aws.amazon.com/AmazonS3/latest/API/mpUploadListMPUpload.html
> * Swift: not supported



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [jclouds/jclouds] JCLOUDS-1125: local blobstore list MPUs (#976)

[Andrew Gaul]

> @@ -100,6 +100,7 @@
>  
>  @Singleton
>  public final class LocalBlobStore implements BlobStore {
> +   private static final String MULTIPART_PREFIX = ".mpus-";

I don't think so; it might be nice to configure MPUs to go into another 
directory or similar but I don't see much need to change the prefix.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/976/files/c17ea1f76c90433f3c752099b65aef93d201becb#r68353223

Re: [jclouds/jclouds] JCLOUDS-1125: local blobstore list MPUs (#976)

[Andrew Gaul]

> @@ -783,24 +784,29 @@ public boolean createContainerInLocation(Location 
> location, String container, Cr
>  
> @Override
> public MultipartUpload initiateMultipartUpload(String container, 
> BlobMetadata blobMetadata, PutOptions options) {
> -  return MultipartUpload.create(container, blobMetadata.getName(), 
> UUID.randomUUID().toString(),
> +  String uploadId = UUID.randomUUID().toString();
> +  // create a stub blob
> +  Blob blob = blobBuilder(MULTIPART_PREFIX + uploadId + "-" + 
> blobMetadata.getName() + "-0").payload(ByteSource.empty()).build();

Done.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/976/files/c17ea1f76c90433f3c752099b65aef93d201becb#r68353086

[jira] [Commented] (JCLOUDS-1005) Backblaze B2 Cloud Storage

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/JCLOUDS-1005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347637#comment-15347637
 ] 

ASF subversion and git services commented on JCLOUDS-1005:
--

Commit 4a1997a5e4e061180d2ae6ab9b34c54fd227fc74 in jclouds-labs's branch 
refs/heads/master from [~gaul]
[ https://git-wip-us.apache.org/repos/asf?p=jclouds-labs.git;h=4a1997a ]

JCLOUDS-1005: Percent encode user metadata values


> Backblaze B2 Cloud Storage
> --
>
> Key: JCLOUDS-1005
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1005
> Project: jclouds
>  Issue Type: New Feature
>  Components: jclouds-blobstore
>Affects Versions: 1.9.1
>Reporter: Andrew Gaul
>Assignee: Andrew Gaul
>  Labels: b2
>
> Backblaze announced B2 which has its own object storage API:
> https://www.backblaze.com/b2/docs/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm image capture userdata keyvault (#291)

[Rita Zhang]

@ritazh pushed 1 commit.

1ec0035  Add TIMEOUT_IMAGE_AVAILABLE


---
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/291/files/dbef0dbf218695daf473447a9a2398eed2131ebf..1ec0035606e02ee62b7ac82a15789a012a7942b1

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm image capture userdata keyvault (#291)

[Rita Zhang]

@ritazh pushed 1 commit.

dbef0db  Add tests to mock and live tests


---
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/291/files/80226b08dae860fcad53a4906ea71fa2996abdbd..dbef0dbf218695daf473447a9a2398eed2131ebf

Re: [jclouds/jclouds] Changes the upload behavior to parallel, completing a TODO (#975)

[Andrew Gaul]

> @@ -87,6 +110,15 @@ public BlobAccess getBlobAccess() {
>return blobAccess;
> }
>  
> +   public ExecutorService getCustomExecutor() {
> +  return customExecutor;
> +   }
> +
> +   public PutOptions setCustomExecutor(ExecutorService customExecutor) {
> +  this.customExecutor = customExecutor;

Call `Preconditions.checkNotNull`.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/975/files/0b784d15fa6f35ceb82028e1823e85c31ccf513d#r68282022

Re: [jclouds/jclouds] Changes the upload behavior to parallel, completing a TODO (#975)

[Andrew Gaul]

> @@ -36,6 +38,7 @@
>  
> private BlobAccess blobAccess = BlobAccess.PRIVATE;
> private boolean multipart = false;
> +   private ExecutorService customExecutor = null;

Instead use `MoreExecutors.sameThreadExecutor` so all code can rely on this.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/975/files/0b784d15fa6f35ceb82028e1823e85c31ccf513d#r68281843

Re: [jclouds/jclouds] Changes the upload behavior to parallel, completing a TODO (#975)

[Andrew Gaul]

> @@ -44,6 +47,16 @@ public PutOptions(boolean multipart) {
>this.multipart = multipart;
> }
>  
> +   public PutOptions(boolean multipart, ExecutorService customExecutor) {

Do we need this variant?

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/975/files/0b784d15fa6f35ceb82028e1823e85c31ccf513d#r68281936

Re: [jclouds/jclouds] Changes the upload behavior to parallel, completing a TODO (#975)

[Andrew Gaul]

> @@ -44,6 +47,16 @@ public PutOptions(boolean multipart) {
>this.multipart = multipart;
> }
>  
> +   public PutOptions(boolean multipart, ExecutorService customExecutor) {
> +  this.multipart = multipart;
> +  this.customExecutor = customExecutor;
> +   }
> +
> +   public PutOptions(ExecutorService customExecutor) {
> +  this.multipart = true;
> +  this.customExecutor = customExecutor;

Call `Preconditions.checkNotNull`.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/975/files/0b784d15fa6f35ceb82028e1823e85c31ccf513d#r68281873

Re: [jclouds/jclouds] Changes the upload behavior to parallel, completing a TODO (#975)

[Andrew Gaul]

> @Beta
> protected String putMultipartBlob(String container, Blob blob, PutOptions 
> overrides) {
> -  List parts = Lists.newArrayList();
> +  if (overrides.getCustomExecutor() != null) {
> + return putMultipartBlob(container, blob, overrides, 
> overrides.getCustomExecutor());
> +  } else {
> + return putMultipartBlob(container, blob, overrides, 
> jcloudsBigBlobUploadTreadPool);
> +  }
> +   }
> +
> +   // copied from BaseBlobStore

We need similar code in `BaseBlobStore` for other providers now that we change 
`PutOptions`.  This will also resolve 
[JCLOUDS-227](https://issues.apache.org/jira/browse/JCLOUDS-227).

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/975/files/0b784d15fa6f35ceb82028e1823e85c31ccf513d#r68281631

Re: [jclouds/jclouds] Changes the upload behavior to parallel, completing a TODO (#975)

[Andrew Gaul]

> - ++partNumber;
> + BlobUploader b =
> +   new BlobUploader(mpu, partNumber++, payload);
> + parts.add(executor.submit(b));
> +  }
> +
> +  return completeMultipartUpload(mpu, 
> Lists.newArrayList(Iterables.transform(parts, new 
> Function() {
> + @Override
> + public MultipartPart apply(Future input) {
> +try {
> +   return input.get();
> +} catch (InterruptedException e) {
> +   e.printStackTrace();
> +   throw new RuntimeException(e);
> +} catch (ExecutionException e) {
> +   e.printStackTrace();

Don't `printStackTrace`.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/975/files/0b784d15fa6f35ceb82028e1823e85c31ccf513d#r68281268

Re: [jclouds/jclouds] Changes the upload behavior to parallel, completing a TODO (#975)

[Andrew Gaul]

>for (Payload payload : slicer.slice(blob.getPayload(), partSize)) {
> - MultipartPart part = uploadMultipartPart(mpu, partNumber, payload);
> - parts.add(part);
> - ++partNumber;
> + BlobUploader b =
> +   new BlobUploader(mpu, partNumber++, payload);
> + parts.add(executor.submit(b));
> +  }
> +
> +  return completeMultipartUpload(mpu, 
> Lists.newArrayList(Iterables.transform(parts, new 
> Function() {
> + @Override
> + public MultipartPart apply(Future input) {

Call `Futures.allAsList().get()` instead.  Possibly with `Futures.getUnchecked` 
to handle exceptions.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/975/files/0b784d15fa6f35ceb82028e1823e85c31ccf513d#r68281233

Re: [jclouds/jclouds] Changes the upload behavior to parallel, completing a TODO (#975)

[Andrew Gaul]

> +  })));
> +   }
> +
> +   private class BlobUploader implements Callable {
> +  private MultipartUpload mpu;
> +  private int partNumber;
> +  private Payload payload;
> +
> +  BlobUploader(MultipartUpload mpu, int partNumber, Payload payload) {
> + this.mpu = mpu;
> + this.partNumber = partNumber;
> + this.payload = payload;
> +  }
> +
> +  @Override
> +  public final MultipartPart call() {

Remove `final` here, add to class and fields.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/975/files/0b784d15fa6f35ceb82028e1823e85c31ccf513d#r68280327

Re: [jclouds/jclouds] Changes the upload behavior to parallel, completing a TODO (#975)

[Andrew Gaul]

> @@ -579,22 +590,79 @@ public long countBlobs(String containerName, 
> ListContainerOptions options) {
>throw new UnsupportedOperationException();
> }
>  
> -   // copied from BaseBlobStore
> +   // TODO: Move statics up to BaseBlobStore to reuse?
> +   @com.google.inject.Inject(optional = true)
> +   @Named("jclouds.mpu.parallel.degree")
> +   @VisibleForTesting
> +   private int numThreads = 16;
> +
> +   private ExecutorService jcloudsBigBlobUploadTreadPool = 
> MoreExecutors.getExitingExecutorService(

We should not add random `ExecutorService` to our code.  Either we reuse the 
deprecated `userExecutor` and `ioExecutor` or make a caller provide this via a 
parameter.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/975/files/0b784d15fa6f35ceb82028e1823e85c31ccf513d#r68280252

[jira] [Created] (JCLOUDS-1131) jclouds-2.0.0 not compatible with gson-2.7

[Olivier Voortman (JIRA)]

Olivier Voortman created JCLOUDS-1131:
-

 Summary: jclouds-2.0.0 not compatible with gson-2.7
 Key: JCLOUDS-1131
 URL: https://issues.apache.org/jira/browse/JCLOUDS-1131
 Project: jclouds
  Issue Type: Bug
Affects Versions: 2.0.0
Reporter: Olivier Voortman


It seems jclouds is using some of gson internal classes, which is wrong.

There is now an incompatibility in jclouds-core-2.0.0-SNAPSHOT.jar.
The class 
org.jclouds.json.internal.DeserializationConstructorAndReflectiveTypeAdapterFactory
 is importing com.google.gson.internal.bind.ReflectiveTypeAdapterFactory which 
is clearly marked as internal.

There is now a 4th parameter on the constructor since gson-2.7.

Is it something that you can fix, maybe by cloning that 
ReflectiveTypeAdapterFactory inside your packages ?

Thanks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Jenkins build is back to normal : jclouds-guava-guice-compat » 18.0,4.0,OpenJDK 7 (latest) #171

[jenkins-no-reply]

See 

Jenkins build is back to normal : jclouds-guava-guice-compat » 19.0-rc1,4.0,OpenJDK 7 (latest) #171

[jenkins-no-reply]

See 

Jenkins build is back to normal : jclouds-guava-guice-compat » 17.0,4.0,OpenJDK 7 (latest) #171

[jenkins-no-reply]

See 

[jira] [Commented] (JCLOUDS-1074) Compatibility with Guava 20

[Olivier Voortman (JIRA)]

[ 
https://issues.apache.org/jira/browse/JCLOUDS-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346446#comment-15346446
 ] 

Olivier Voortman commented on JCLOUDS-1074:
---

I think sticking with an outdated version of guava is not a good idea.

People will want to upgrade to the latest guava version.
I personally don't care, but some of my dependencies require a more recent 
version.

If it's not possible, maybe you could repackage the correct version inside your 
own jar files?

> Compatibility with Guava 20
> ---
>
> Key: JCLOUDS-1074
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1074
> Project: jclouds
>  Issue Type: Bug
>  Components: jclouds-core
>Affects Versions: 2.0.0
>Reporter: Olivier Voortman
>  Labels: guava
>
> Hello,
> It seems jclouds is still using some deprecated methods from the Guava 
> library, which are now removed from version 20.0-SNAPSHOT.
> For example :
> java.lang.NoSuchMethodError: 
> com.google.common.reflect.TypeToken.isAssignableFrom(Lcom/google/common/reflect/TypeToken;)Z
> Used here :
> org.jclouds.apis.Apis$1.apply(Apis.java:134)
> See removal of those methods from Guava here :
> https://github.com/google/guava/commit/f001be54c2e3676d39623942e96b97699d42467a
> This should be quite easy to fix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Jenkins build is back to normal : jclouds-guava-guice-compat » 17.0,3.0,OpenJDK 7 (latest) #171

[jenkins-no-reply]

See 

Jenkins build is back to normal : jclouds-guava-guice-compat » 19.0-rc1,3.0,OpenJDK 7 (latest) #171

[jenkins-no-reply]

See 

Build failed in Jenkins: jclouds-guava-guice-compat » 18.0,3.0,OpenJDK 7 (latest) #171

[jenkins-no-reply]

See 


Changes:

[Andrew Gaul] Create Payload per thread in testPutBlobParallel

--
[...truncated 20565 lines...]
Starting test 
testSerializedNameRequiredOnAllParameters(org.jclouds.json.internal.DeserializationConstructorAndReflectiveTypeAdapterFactoryTest)
Starting test 
testValidatedConstructor(org.jclouds.json.internal.DeserializationConstructorAndReflectiveTypeAdapterFactoryTest)
Starting test 
testSerializedNamesMustHaveCorrectCountOfNames(org.jclouds.json.internal.DeserializationConstructorAndReflectiveTypeAdapterFactoryTest)
[pool-84-thread-4] Test 
testRenamedFields(org.jclouds.json.internal.DeserializationConstructorAndReflectiveTypeAdapterFactoryTest)
 succeeded: 1ms
Test suite progress: tests succeeded: 820, failed: 2, skipped: 0.
[pool-84-thread-2] Test 
testSerializedNameRequiredOnAllParameters(org.jclouds.json.internal.DeserializationConstructorAndReflectiveTypeAdapterFactoryTest)
 succeeded: 1ms
Test suite progress: tests succeeded: 821, failed: 2, skipped: 0.
[pool-84-thread-5] Test 
testValidatedConstructor(org.jclouds.json.internal.DeserializationConstructorAndReflectiveTypeAdapterFactoryTest)
 succeeded: 1ms
Test suite progress: tests succeeded: 822, failed: 2, skipped: 0.
[pool-84-thread-3] Test 
testSerializedNamesMustHaveCorrectCountOfNames(org.jclouds.json.internal.DeserializationConstructorAndReflectiveTypeAdapterFactoryTest)
 succeeded: 2ms
Test suite progress: tests succeeded: 823, failed: 2, skipped: 0.
Starting test 
testCollection(org.jclouds.json.internal.NullFilteringTypeAdapterFactoriesTest)
Starting test 
testFluentIterable(org.jclouds.json.internal.NullFilteringTypeAdapterFactoriesTest)
Starting test 
testImmutableMap(org.jclouds.json.internal.NullFilteringTypeAdapterFactoriesTest)
Starting test 
testImmutableSet(org.jclouds.json.internal.NullFilteringTypeAdapterFactoriesTest)
Starting test 
testImmutableList(org.jclouds.json.internal.NullFilteringTypeAdapterFactoriesTest)
[pool-85-thread-1] Test 
testCollection(org.jclouds.json.internal.NullFilteringTypeAdapterFactoriesTest) 
succeeded: 18ms
Test suite progress: tests succeeded: 824, failed: 2, skipped: 0.
[pool-85-thread-2] Test 
testFluentIterable(org.jclouds.json.internal.NullFilteringTypeAdapterFactoriesTest)
 succeeded: 18ms
Test suite progress: tests succeeded: 825, failed: 2, skipped: 0.
[pool-85-thread-5] Test 
testImmutableSet(org.jclouds.json.internal.NullFilteringTypeAdapterFactoriesTest)
 succeeded: 18ms
Test suite progress: tests succeeded: 826, failed: 2, skipped: 0.
[pool-85-thread-3] Test 
testImmutableList(org.jclouds.json.internal.NullFilteringTypeAdapterFactoriesTest)
 succeeded: 1ms
Test suite progress: tests succeeded: 827, failed: 2, skipped: 0.
[pool-85-thread-4] Test 
testImmutableMap(org.jclouds.json.internal.NullFilteringTypeAdapterFactoriesTest)
 succeeded: 18ms
Test suite progress: tests succeeded: 828, failed: 2, skipped: 0.
Starting test 
testList(org.jclouds.json.internal.NullFilteringTypeAdapterFactoriesTest)
Starting test 
testListInMap(org.jclouds.json.internal.NullFilteringTypeAdapterFactoriesTest)
Starting test 
testIterable(org.jclouds.json.internal.NullFilteringTypeAdapterFactoriesTest)
Starting test 
testMap(org.jclouds.json.internal.NullFilteringTypeAdapterFactoriesTest)
Starting test 
testMultimap(org.jclouds.json.internal.NullFilteringTypeAdapterFactoriesTest)
[pool-85-thread-2] Test 
testList(org.jclouds.json.internal.NullFilteringTypeAdapterFactoriesTest) 
succeeded: 1ms
Test suite progress: tests succeeded: 829, failed: 2, skipped: 0.
[pool-85-thread-3] Test 
testMap(org.jclouds.json.internal.NullFilteringTypeAdapterFactoriesTest) 
succeeded: 1ms
Test suite progress: tests succeeded: 830, failed: 2, skipped: 0.
[pool-85-thread-5] Test 
testListInMap(org.jclouds.json.internal.NullFilteringTypeAdapterFactoriesTest) 
succeeded: 1ms
Test suite progress: tests succeeded: 831, failed: 2, skipped: 0.
[pool-85-thread-1] Test 
testIterable(org.jclouds.json.internal.NullFilteringTypeAdapterFactoriesTest) 
succeeded: 1ms
Starting test 
testSet(org.jclouds.json.internal.NullFilteringTypeAdapterFactoriesTest)
Test suite progress: tests succeeded: 832, failed: 2, skipped: 0.
Starting test 
testWildcardExtends(org.jclouds.json.internal.NullFilteringTypeAdapterFactoriesTest)
[pool-85-thread-4] Test 
testMultimap(org.jclouds.json.internal.NullFilteringTypeAdapterFactoriesTest) 
succeeded: 2ms
Test suite progress: tests succeeded: 833, failed: 2, skipped: 0.
[pool-85-thread-2] Test 
testSet(org.jclouds.json.internal.NullFilteringTypeAdapterFactoriesTest) 
succeeded: 1ms
Test suite progress: tests succeeded: 834, failed: 2, skipped: 0.
[pool-85-thread-3] Test 
testWildcardExtends(org.jclouds.json.internal.NullFilteringTypeAdapterFactoriesTest)
 succeeded: 2ms
Test suite progress: tests succeeded: 835, failed: 2, 

Re: [jclouds/jclouds-labs] Docker ImageId can be image name or id and will pull from hub (#290)

[Andrea Turli]

@nacx, @kwart do you like it as well?

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/290#issuecomment-228007485

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm image capture userdata keyvault (#291)

[Ignasi Barrera]

> +if (nsg != null) {
> +   uri = 
> api.getNetworkSecurityGroupApi(group).delete(id + "nsg");
> +   jobDone = resourceDeleted.apply(uri);
> +   if (jobDone) {
> +  nsgDeleteStatus = true;
> +
> +   }
> +}
> +else {
> +   nsgDeleteStatus = true;
> +}
> +
> +return deploymentDeleteStatus && 
> storageAcctDeleteStatus && ipDeleteStatus && nsgDeleteStatus;
> + } else {
> +return false;
> + }
>} else {
>   return false;

>Then we will add this create with tag and cleanup by tag feature in a 
>subsequent PR.

Yes, let's better do that in another PR.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/291/files/8a39037237f57d100bc58a9a82bdb89924b1#r68208905

Re: [jclouds/jclouds-labs] Docker ImageId can be image name or id and will pull from hub (#290)

[Andrea Turli]

Thanks @duncangrant 

I've tested it and looks fine to me
Please address my last comment, squash and push it again.

Thanks!

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/290#issuecomment-228007102

Re: [jclouds/jclouds-labs] Docker ImageId can be image name or id and will pull from hub (#290)

[Andrea Turli]

>   @Override
>   public boolean apply(Image input) {
> -return input.id().equals(imageId);
> +for (String tag : input.repoTags()) {
> +   checkNotNull(imageIdOrName);

I'd probably move this checkNotNull up to line 242

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/290/files/3e3400733d7902e2947a32e859d7966169bfd324#r68208798

Build failed in Jenkins: jclouds-guava-guice-compat » 17.0,4.0,OpenJDK 7 (latest) #170

[jenkins-no-reply]

See 


Changes:

[Andrew Gaul] Consistently name test container names

[Andrew Gaul] Use in-memory payload for testPutBlobParallel

--
[...truncated 12637 lines...]
at org.testng.SuiteRunner.runTest(SuiteRunner.java:348)
at org.testng.SuiteRunner.access$000(SuiteRunner.java:38)
at org.testng.SuiteRunner$SuiteWorker.run(SuiteRunner.java:382)
at org.testng.internal.thread.ThreadUtil$2.call(ThreadUtil.java:64)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)
[TestNG] Test 
testPutBlobParallel(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 failed.
Test suite progress: tests succeeded: 72, failed: 1, skipped: 4.
Starting test 
testPutByteSource(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutByteSource(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 succeeded: 6ms
Test suite progress: tests succeeded: 73, failed: 1, skipped: 4.
Starting test 
testPutCorrectContentMD5(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutCorrectContentMD5(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 succeeded: 2ms
Test suite progress: tests succeeded: 74, failed: 1, skipped: 4.
Starting test 
testPutIncorrectContentMD5(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutIncorrectContentMD5(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 succeeded: 1ms
Test suite progress: tests succeeded: 75, failed: 1, skipped: 4.
Starting test 
testPutInputStream(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutInputStream(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 succeeded: 4ms
Test suite progress: tests succeeded: 76, failed: 1, skipped: 4.
Starting test 
testPutMultipartByteSource(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutMultipartByteSource(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 skipped.
Test suite progress: tests succeeded: 76, failed: 1, skipped: 5.
Starting test 
testPutMultipartInputStream(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutMultipartInputStream(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 skipped.
Test suite progress: tests succeeded: 76, failed: 1, skipped: 6.
Starting test 
testPutObject(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutObject(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest) 
succeeded: 7ms
Test suite progress: tests succeeded: 77, failed: 1, skipped: 6.
Starting test 
testPutObject(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutObject(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest) 
succeeded: 5ms
Test suite progress: tests succeeded: 78, failed: 1, skipped: 6.
Starting test 
testPutObject(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutObject(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest) 
succeeded: 5ms
Test suite progress: tests succeeded: 79, failed: 1, skipped: 6.
Starting test 
testPutObjectStream(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutObjectStream(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 succeeded: 4ms
Test suite progress: tests succeeded: 80, failed: 1, skipped: 6.
[TestNG] Test 
checkContentMetadata(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 skipped.
Test suite progress: tests succeeded: 80, failed: 1, skipped: 7.
[TestNG] Test 
testCreateBlobWithExpiry(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 skipped.
Test suite progress: tests succeeded: 80, failed: 1, skipped: 8.
Starting test 
testListMultipartUploads(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testListMultipartUploads(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 skipped.
Test suite progress: tests succeeded: 80, failed: 1, skipped: 9.
Starting test 
testSetBlobAccess(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testSetBlobAccess(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 skipped.
Test suite progress: tests succeeded: 80, failed: 1, skipped: 10.
Starting test 
containerDoesntExist(org.jclouds.filesystem.integration.FilesystemServiceIntegrationTest)
[TestNG] Test 

Build failed in Jenkins: jclouds-guava-guice-compat » 18.0,4.0,OpenJDK 7 (latest) #170

[jenkins-no-reply]

See 


Changes:

[Andrew Gaul] Consistently name test container names

[Andrew Gaul] Use in-memory payload for testPutBlobParallel

--
[...truncated 12651 lines...]
at 
org.jclouds.concurrent.FutureIterables.awaitCompletion(FutureIterables.java:153)
at 
org.jclouds.blobstore.integration.internal.BaseBlobIntegrationTest.testPutBlobParallel(BaseBlobIntegrationTest.java:150)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:85)
at org.testng.internal.Invoker.invokeMethod(Invoker.java:696)
at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:882)
at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1189)
at 
org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:124)
at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:108)
at org.testng.TestRunner.privateRun(TestRunner.java:767)
at org.testng.TestRunner.run(TestRunner.java:617)
at org.testng.SuiteRunner.runTest(SuiteRunner.java:348)
at org.testng.SuiteRunner.access$000(SuiteRunner.java:38)
at org.testng.SuiteRunner$SuiteWorker.run(SuiteRunner.java:382)
at org.testng.internal.thread.ThreadUtil$2.call(ThreadUtil.java:64)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)
[TestNG] Test 
testPutBlobParallel(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 failed.
Test suite progress: tests succeeded: 75, failed: 1, skipped: 4.
Starting test 
testPutByteSource(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutByteSource(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 succeeded: 7ms
Test suite progress: tests succeeded: 76, failed: 1, skipped: 4.
Starting test 
testPutCorrectContentMD5(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutCorrectContentMD5(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 succeeded: 3ms
Test suite progress: tests succeeded: 77, failed: 1, skipped: 4.
Starting test 
testPutIncorrectContentMD5(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutIncorrectContentMD5(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 succeeded: 2ms
Test suite progress: tests succeeded: 78, failed: 1, skipped: 4.
Starting test 
testPutInputStream(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutInputStream(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 succeeded: 5ms
Test suite progress: tests succeeded: 79, failed: 1, skipped: 4.
Starting test 
testPutMultipartByteSource(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutMultipartByteSource(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 skipped.
Test suite progress: tests succeeded: 79, failed: 1, skipped: 5.
Starting test 
testPutMultipartInputStream(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutMultipartInputStream(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 skipped.
Test suite progress: tests succeeded: 79, failed: 1, skipped: 6.
Starting test 
testPutObject(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutObject(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest) 
succeeded: 8ms
Test suite progress: tests succeeded: 80, failed: 1, skipped: 6.
Starting test 
testPutObject(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutObject(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest) 
succeeded: 7ms
Test suite progress: tests succeeded: 81, failed: 1, skipped: 6.
Starting test 
testPutObject(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutObject(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest) 
succeeded: 7ms
Test suite progress: tests succeeded: 82, failed: 1, skipped: 6.
Starting test 
testPutObjectStream(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 

Build failed in Jenkins: jclouds-guava-guice-compat » 18.0,3.0,OpenJDK 7 (latest) #170

[jenkins-no-reply]

See 


Changes:

[Andrew Gaul] Consistently name test container names

[Andrew Gaul] Use in-memory payload for testPutBlobParallel

--
[...truncated 12445 lines...]
at org.testng.SuiteRunner.runTest(SuiteRunner.java:348)
at org.testng.SuiteRunner.access$000(SuiteRunner.java:38)
at org.testng.SuiteRunner$SuiteWorker.run(SuiteRunner.java:382)
at org.testng.internal.thread.ThreadUtil$2.call(ThreadUtil.java:64)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)
[TestNG] Test 
testPutBlobParallel(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 failed.
Test suite progress: tests succeeded: 72, failed: 1, skipped: 4.
Starting test 
testPutByteSource(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutByteSource(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 succeeded: 6ms
Test suite progress: tests succeeded: 73, failed: 1, skipped: 4.
Starting test 
testPutCorrectContentMD5(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutCorrectContentMD5(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 succeeded: 2ms
Test suite progress: tests succeeded: 74, failed: 1, skipped: 4.
Starting test 
testPutIncorrectContentMD5(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutIncorrectContentMD5(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 succeeded: 2ms
Test suite progress: tests succeeded: 75, failed: 1, skipped: 4.
Starting test 
testPutInputStream(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutInputStream(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 succeeded: 4ms
Test suite progress: tests succeeded: 76, failed: 1, skipped: 4.
Starting test 
testPutMultipartByteSource(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutMultipartByteSource(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 skipped.
Test suite progress: tests succeeded: 76, failed: 1, skipped: 5.
Starting test 
testPutMultipartInputStream(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutMultipartInputStream(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 skipped.
Test suite progress: tests succeeded: 76, failed: 1, skipped: 6.
Starting test 
testPutObject(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutObject(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest) 
succeeded: 7ms
Test suite progress: tests succeeded: 77, failed: 1, skipped: 6.
Starting test 
testPutObject(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutObject(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest) 
succeeded: 6ms
Test suite progress: tests succeeded: 78, failed: 1, skipped: 6.
Starting test 
testPutObject(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutObject(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest) 
succeeded: 5ms
Test suite progress: tests succeeded: 79, failed: 1, skipped: 6.
Starting test 
testPutObjectStream(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutObjectStream(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 succeeded: 5ms
Test suite progress: tests succeeded: 80, failed: 1, skipped: 6.
[TestNG] Test 
checkContentMetadata(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 skipped.
Test suite progress: tests succeeded: 80, failed: 1, skipped: 7.
[TestNG] Test 
testCreateBlobWithExpiry(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 skipped.
Test suite progress: tests succeeded: 80, failed: 1, skipped: 8.
Starting test 
testListMultipartUploads(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testListMultipartUploads(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 skipped.
Test suite progress: tests succeeded: 80, failed: 1, skipped: 9.
Starting test 
testSetBlobAccess(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testSetBlobAccess(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 skipped.
Test suite progress: tests succeeded: 80, failed: 1, skipped: 10.
Starting test 
containerDoesntExist(org.jclouds.filesystem.integration.FilesystemServiceIntegrationTest)
[TestNG] Test 

Build failed in Jenkins: jclouds-guava-guice-compat » 19.0-rc1,3.0,OpenJDK 7 (latest) #170

[jenkins-no-reply]

See 


Changes:

[Andrew Gaul] Consistently name test container names

[Andrew Gaul] Use in-memory payload for testPutBlobParallel

--
[...truncated 13062 lines...]
at 
org.jclouds.concurrent.FutureIterables.awaitCompletion(FutureIterables.java:153)
at 
org.jclouds.blobstore.integration.internal.BaseBlobIntegrationTest.testPutBlobParallel(BaseBlobIntegrationTest.java:150)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:85)
at org.testng.internal.Invoker.invokeMethod(Invoker.java:696)
at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:882)
at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1189)
at 
org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:124)
at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:108)
at org.testng.TestRunner.privateRun(TestRunner.java:767)
at org.testng.TestRunner.run(TestRunner.java:617)
at org.testng.SuiteRunner.runTest(SuiteRunner.java:348)
at org.testng.SuiteRunner.access$000(SuiteRunner.java:38)
at org.testng.SuiteRunner$SuiteWorker.run(SuiteRunner.java:382)
at org.testng.internal.thread.ThreadUtil$2.call(ThreadUtil.java:64)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)
[TestNG] Test 
testPutBlobParallel(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 failed.
Test suite progress: tests succeeded: 75, failed: 1, skipped: 4.
Starting test 
testPutByteSource(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutByteSource(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 succeeded: 5ms
Test suite progress: tests succeeded: 76, failed: 1, skipped: 4.
Starting test 
testPutCorrectContentMD5(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutCorrectContentMD5(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 succeeded: 2ms
Test suite progress: tests succeeded: 77, failed: 1, skipped: 4.
Starting test 
testPutIncorrectContentMD5(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutIncorrectContentMD5(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 succeeded: 2ms
Test suite progress: tests succeeded: 78, failed: 1, skipped: 4.
Starting test 
testPutInputStream(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutInputStream(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 succeeded: 4ms
Test suite progress: tests succeeded: 79, failed: 1, skipped: 4.
Starting test 
testPutMultipartByteSource(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutMultipartByteSource(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 skipped.
Test suite progress: tests succeeded: 79, failed: 1, skipped: 5.
Starting test 
testPutMultipartInputStream(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutMultipartInputStream(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 skipped.
Test suite progress: tests succeeded: 79, failed: 1, skipped: 6.
Starting test 
testPutObject(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutObject(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest) 
succeeded: 7ms
Test suite progress: tests succeeded: 80, failed: 1, skipped: 6.
Starting test 
testPutObject(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutObject(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest) 
succeeded: 6ms
Test suite progress: tests succeeded: 81, failed: 1, skipped: 6.
Starting test 
testPutObject(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutObject(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest) 
succeeded: 5ms
Test suite progress: tests succeeded: 82, failed: 1, skipped: 6.
Starting test 
testPutObjectStream(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 

Build failed in Jenkins: jclouds-guava-guice-compat » 19.0-rc1,4.0,OpenJDK 7 (latest) #170

[jenkins-no-reply]

See 


Changes:

[Andrew Gaul] Consistently name test container names

[Andrew Gaul] Use in-memory payload for testPutBlobParallel

--
[...truncated 23669 lines...]
[pool-25-thread-2] Test 
testAllProtocolCidrBound(org.jclouds.net.util.IpPermissionsTest) succeeded: 5ms
Test suite progress: tests succeeded: 272, failed: 1, skipped: 0.
[pool-25-thread-1] Test testAllProtocol(org.jclouds.net.util.IpPermissionsTest) 
succeeded: 5ms
Test suite progress: tests succeeded: 273, failed: 1, skipped: 0.
[pool-25-thread-3] Test 
testAllProtocolExclusionCidrBound(org.jclouds.net.util.IpPermissionsTest) 
succeeded: 4ms
Test suite progress: tests succeeded: 274, failed: 1, skipped: 0.
[pool-25-thread-4] Test 
testAllProtocolInvalidCidr(org.jclouds.net.util.IpPermissionsTest) succeeded: 
4ms
Starting test 
testAllProtocolInvalidExclusionCidr(org.jclouds.net.util.IpPermissionsTest)
Starting test testAnyProtocol(org.jclouds.net.util.IpPermissionsTest)
Starting test 
testAllProtocolInvalidExclusionCidrMultiple(org.jclouds.net.util.IpPermissionsTest)
Test suite progress: tests succeeded: 275, failed: 1, skipped: 0.
Starting test 
testAnyProtocolWithExcludedCidr(org.jclouds.net.util.IpPermissionsTest)
[pool-25-thread-5] Test 
testAllProtocolInvalidExclusionCidr(org.jclouds.net.util.IpPermissionsTest) 
succeeded: 0ms
Test suite progress: tests succeeded: 276, failed: 1, skipped: 0.
[pool-25-thread-3] Test 
testAnyProtocolWithExcludedCidr(org.jclouds.net.util.IpPermissionsTest) 
succeeded: 1ms
Test suite progress: tests succeeded: 277, failed: 1, skipped: 0.
[pool-25-thread-1] Test testAnyProtocol(org.jclouds.net.util.IpPermissionsTest) 
succeeded: 1ms
Test suite progress: tests succeeded: 278, failed: 1, skipped: 0.
Starting test testJustProtocolAndCidr(org.jclouds.net.util.IpPermissionsTest)
Starting test testMultipleCidrs(org.jclouds.net.util.IpPermissionsTest)
Starting test 
testJustProtocolAndExcludedCidr(org.jclouds.net.util.IpPermissionsTest)
[pool-25-thread-5] Test 
testJustProtocolAndCidr(org.jclouds.net.util.IpPermissionsTest) succeeded: 0ms
Starting test 
testMultipleCidrsExclusions(org.jclouds.net.util.IpPermissionsTest)
Test suite progress: tests succeeded: 279, failed: 1, skipped: 0.
[pool-25-thread-3] Test 
testMultipleCidrs(org.jclouds.net.util.IpPermissionsTest) succeeded: 0ms
Test suite progress: tests succeeded: 280, failed: 1, skipped: 0.
[pool-25-thread-4] Test 
testJustProtocolAndExcludedCidr(org.jclouds.net.util.IpPermissionsTest) 
succeeded: 0ms
Test suite progress: tests succeeded: 281, failed: 1, skipped: 0.
Starting test 
testProtocolFromAndToPortAndGroupIds(org.jclouds.net.util.IpPermissionsTest)
[pool-25-thread-2] Test 
testAllProtocolInvalidExclusionCidrMultiple(org.jclouds.net.util.IpPermissionsTest)
 succeeded: 1ms
Starting test 
testProtocolFromAndToPortAndUserGroups(org.jclouds.net.util.IpPermissionsTest)
Test suite progress: tests succeeded: 282, failed: 1, skipped: 0.
[pool-25-thread-1] Test 
testMultipleCidrsExclusions(org.jclouds.net.util.IpPermissionsTest) succeeded: 
1ms
Starting test testProtocolICMPAny(org.jclouds.net.util.IpPermissionsTest)
Test suite progress: tests succeeded: 283, failed: 1, skipped: 0.
Starting test 
testProtocolICMPTypeAnyCode(org.jclouds.net.util.IpPermissionsTest)
Starting test testProtocolICMPTypeCode(org.jclouds.net.util.IpPermissionsTest)
[pool-25-thread-5] Test 
testProtocolFromAndToPortAndGroupIds(org.jclouds.net.util.IpPermissionsTest) 
succeeded: 1ms
Test suite progress: tests succeeded: 284, failed: 1, skipped: 0.
[pool-25-thread-4] Test 
testProtocolICMPAny(org.jclouds.net.util.IpPermissionsTest) succeeded: 0ms
Test suite progress: tests succeeded: 285, failed: 1, skipped: 0.
[pool-25-thread-2] Test 
testProtocolICMPTypeAnyCode(org.jclouds.net.util.IpPermissionsTest) succeeded: 
1ms
Test suite progress: tests succeeded: 286, failed: 1, skipped: 0.
[pool-25-thread-1] Test 
testProtocolICMPTypeCode(org.jclouds.net.util.IpPermissionsTest) succeeded: 1ms
Test suite progress: tests succeeded: 287, failed: 1, skipped: 0.
[pool-25-thread-3] Test 
testProtocolFromAndToPortAndUserGroups(org.jclouds.net.util.IpPermissionsTest) 
succeeded: 4ms
Test suite progress: tests succeeded: 288, failed: 1, skipped: 0.
Starting test testApply(org.jclouds.ssh.config.RsaSshKeyPairGeneratorTest)
[pool-26-thread-1] Test 
testApply(org.jclouds.ssh.config.RsaSshKeyPairGeneratorTest) succeeded: 18ms
Test suite progress: tests succeeded: 289, failed: 1, skipped: 0.
Starting test testCanGenerate(org.jclouds.ssh.SshKeysTest)
[pool-27-thread-1] Test testCanGenerate(org.jclouds.ssh.SshKeysTest) succeeded: 
64ms
Test suite progress: tests succeeded: 290, failed: 1, skipped: 0.
Starting test 
testCanReadRsaAndCompareFingerprintOnPrivateRSAKey(org.jclouds.ssh.SshKeysTest)
[pool-27-thread-1] Test 

Build failed in Jenkins: jclouds-guava-guice-compat » 17.0,3.0,OpenJDK 7 (latest) #170

[jenkins-no-reply]

See 


Changes:

[Andrew Gaul] Consistently name test container names

[Andrew Gaul] Use in-memory payload for testPutBlobParallel

--
[...truncated 3480 lines...]
Starting test testList(org.jclouds.json.internal.NullHackJsonLiteralAdapterTest)
Starting test 
testObject(org.jclouds.json.internal.NullHackJsonLiteralAdapterTest)
Starting test 
testString(org.jclouds.json.internal.NullHackJsonLiteralAdapterTest)
Starting test 
testNumber(org.jclouds.json.internal.NullHackJsonLiteralAdapterTest)
[pool-87-thread-4] Test 
testObject(org.jclouds.json.internal.NullHackJsonLiteralAdapterTest) succeeded: 
1ms
Test suite progress: tests succeeded: 818, failed: 1, skipped: 0.
[pool-87-thread-1] Test 
testBoolean(org.jclouds.json.internal.NullHackJsonLiteralAdapterTest) 
succeeded: 1ms
Test suite progress: tests succeeded: 819, failed: 1, skipped: 0.
[pool-87-thread-3] Test 
testNumber(org.jclouds.json.internal.NullHackJsonLiteralAdapterTest) succeeded: 
1ms
Test suite progress: tests succeeded: 820, failed: 1, skipped: 0.
[pool-87-thread-2] Test 
testList(org.jclouds.json.internal.NullHackJsonLiteralAdapterTest) succeeded: 
1ms
Test suite progress: tests succeeded: 821, failed: 1, skipped: 0.
[pool-87-thread-5] Test 
testString(org.jclouds.json.internal.NullHackJsonLiteralAdapterTest) succeeded: 
1ms
Test suite progress: tests succeeded: 822, failed: 1, skipped: 0.
Starting test 
checkSimpleComposedObject(org.jclouds.json.internal.DeserializationConstructorAndReflectiveTypeAdapterFactoryTest)
Starting test 
testBuilderOnAbstractValueType(org.jclouds.json.internal.DeserializationConstructorAndReflectiveTypeAdapterFactoryTest)
Starting test 
testCanOverrideDefault(org.jclouds.json.internal.DeserializationConstructorAndReflectiveTypeAdapterFactoryTest)
Starting test 
testEmptyObjectIsNull(org.jclouds.json.internal.DeserializationConstructorAndReflectiveTypeAdapterFactoryTest)
Starting test 
testGenericParamsCopiedIn(org.jclouds.json.internal.DeserializationConstructorAndReflectiveTypeAdapterFactoryTest)
[pool-88-thread-1] Test 
checkSimpleComposedObject(org.jclouds.json.internal.DeserializationConstructorAndReflectiveTypeAdapterFactoryTest)
 succeeded: 2ms
Test suite progress: tests succeeded: 823, failed: 1, skipped: 0.
[pool-88-thread-3] Test 
testCanOverrideDefault(org.jclouds.json.internal.DeserializationConstructorAndReflectiveTypeAdapterFactoryTest)
 succeeded: 1ms
Test suite progress: tests succeeded: 824, failed: 1, skipped: 0.
[pool-88-thread-4] Test 
testEmptyObjectIsNull(org.jclouds.json.internal.DeserializationConstructorAndReflectiveTypeAdapterFactoryTest)
 succeeded: 1ms
Test suite progress: tests succeeded: 825, failed: 1, skipped: 0.
Starting test 
testNoDuplicateSerializedNamesRequiredOnAllParameters(org.jclouds.json.internal.DeserializationConstructorAndReflectiveTypeAdapterFactoryTest)
Starting test 
testNullWhenPrimitive(org.jclouds.json.internal.DeserializationConstructorAndReflectiveTypeAdapterFactoryTest)
Starting test 
testPartialObjectStillThrows(org.jclouds.json.internal.DeserializationConstructorAndReflectiveTypeAdapterFactoryTest)
[pool-88-thread-3] Test 
testNullWhenPrimitive(org.jclouds.json.internal.DeserializationConstructorAndReflectiveTypeAdapterFactoryTest)
 succeeded: 0ms
Test suite progress: tests succeeded: 826, failed: 1, skipped: 0.
Starting test 
testRejectsIfNoConstuctorMarked(org.jclouds.json.internal.DeserializationConstructorAndReflectiveTypeAdapterFactoryTest)
[pool-88-thread-3] Test 
testRejectsIfNoConstuctorMarked(org.jclouds.json.internal.DeserializationConstructorAndReflectiveTypeAdapterFactoryTest)
 succeeded: 0ms
Test suite progress: tests succeeded: 827, failed: 1, skipped: 0.
[pool-88-thread-4] Test 
testPartialObjectStillThrows(org.jclouds.json.internal.DeserializationConstructorAndReflectiveTypeAdapterFactoryTest)
 succeeded: 1ms
Starting test 
testRenamedFields(org.jclouds.json.internal.DeserializationConstructorAndReflectiveTypeAdapterFactoryTest)
Test suite progress: tests succeeded: 828, failed: 1, skipped: 0.
[pool-88-thread-1] Test 
testNoDuplicateSerializedNamesRequiredOnAllParameters(org.jclouds.json.internal.DeserializationConstructorAndReflectiveTypeAdapterFactoryTest)
 succeeded: 1ms
Test suite progress: tests succeeded: 829, failed: 1, skipped: 0.
[pool-88-thread-2] Test 
testBuilderOnAbstractValueType(org.jclouds.json.internal.DeserializationConstructorAndReflectiveTypeAdapterFactoryTest)
 succeeded: 3ms
Test suite progress: tests succeeded: 830, failed: 1, skipped: 0.
Starting test 
testSerializedNameRequiredOnAllParameters(org.jclouds.json.internal.DeserializationConstructorAndReflectiveTypeAdapterFactoryTest)
Starting test 
testSerializedNamesMustHaveCorrectCountOfNames(org.jclouds.json.internal.DeserializationConstructorAndReflectiveTypeAdapterFactoryTest)

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm image capture userdata keyvault (#291)

[Rita Zhang]

> +if (nsg != null) {
> +   uri = 
> api.getNetworkSecurityGroupApi(group).delete(id + "nsg");
> +   jobDone = resourceDeleted.apply(uri);
> +   if (jobDone) {
> +  nsgDeleteStatus = true;
> +
> +   }
> +}
> +else {
> +   nsgDeleteStatus = true;
> +}
> +
> +return deploymentDeleteStatus && 
> storageAcctDeleteStatus && ipDeleteStatus && nsgDeleteStatus;
> + } else {
> +return false;
> + }
>} else {
>   return false;

@nacx @andreaturli If you guys don't mind, let's get this PR done first. Then 
we will add this create with tag and cleanup by tag feature in a subsequent PR. 

As for adding a tag with the id of the VM, I recommend not because some of 
these resources are shared between nodes, for example vnet and subnet. 


---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/291/files/8a39037237f57d100bc58a9a82bdb89924b1#r68182085

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm image capture userdata keyvault (#291)

[Andrea Turli]

> +if (nsg != null) {
> +   uri = 
> api.getNetworkSecurityGroupApi(group).delete(id + "nsg");
> +   jobDone = resourceDeleted.apply(uri);
> +   if (jobDone) {
> +  nsgDeleteStatus = true;
> +
> +   }
> +}
> +else {
> +   nsgDeleteStatus = true;
> +}
> +
> +return deploymentDeleteStatus && 
> storageAcctDeleteStatus && ipDeleteStatus && nsgDeleteStatus;
> + } else {
> +return false;
> + }
>} else {
>   return false;

Grear idea! I'd suggest to tag them with the name or id of the vm: in this way 
jclouds knows exactly who owns each resource and can delete them when 
appropriate. Wdyt?

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/291/files/8a39037237f57d100bc58a9a82bdb89924b1#r68179672

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm image capture userdata keyvault (#291)

[Rita Zhang]

@ritazh pushed 1 commit.

80226b0  Fix PR issues


---
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/291/files/8a39037237f57d100bc58a9a82bdb89924b1..80226b08dae860fcad53a4906ea71fa2996abdbd