Re: [jclouds/jclouds-site] Minor text changes and small corrections (take 2) (#208)
demobox commented on this pull request. > * The `KeystoneAuthenticationModule` and the `AuthenticationApiModule` have > been refactored and generalised into: * `AuthenticationModule` - Providing authentication services to all OpenStack APIs and providers. * `ServiceCatalogModule` - Providing endpoint resolution to all OpenStack APIs and providers. + +Use `AuthenticationModule` and `ServiceCatalogModule` when developing OpenStack APIs. @nacx Updated in 1d801fc -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/208#pullrequestreview-88937519
Re: [jclouds/jclouds-site] Minor text changes and small corrections (take 2) (#208)
Go to http://5d36d0aba8c170e9a4c5-ce263ec4815b2c3b731b4bdd285b4574.r24.cf5.rackcdn.com/ to review your changes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/208#issuecomment-357794183
Re: [jclouds/jclouds-site] Minor text changes and small corrections (take 2) (#208)
nacx commented on this pull request. > * The `KeystoneAuthenticationModule` and the `AuthenticationApiModule` have > been refactored and generalised into: * `AuthenticationModule` - Providing authentication services to all OpenStack APIs and providers. * `ServiceCatalogModule` - Providing endpoint resolution to all OpenStack APIs and providers. + +Replace uses of `KeystoneAuthenticationModule` with `AuthenticationModule`, and uses of `AuthenticationApiModule` with `ServiceCatalogModule`. Yes, that's fine :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/208#discussion_r161614337
Re: [jclouds/jclouds-site] Minor text changes and small corrections (take 2) (#208)
demobox commented on this pull request. > * The `KeystoneAuthenticationModule` and the `AuthenticationApiModule` have > been refactored and generalised into: * `AuthenticationModule` - Providing authentication services to all OpenStack APIs and providers. * `ServiceCatalogModule` - Providing endpoint resolution to all OpenStack APIs and providers. + +Replace uses of `KeystoneAuthenticationModule` with `AuthenticationModule`, and uses of `AuthenticationApiModule` with `ServiceCatalogModule`. > Those modules are already included by all OpenStack APIs, so that info is > interesting only for those writing new APIs. So is the guidance something like "Use `AuthenticationModule` and `ServiceCatalogModule` when developing OpenStack APIs."? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/208#discussion_r161611424
[jira] [Commented] (JCLOUDS-114) Support OpenStack Keystone v3 API
[ https://issues.apache.org/jira/browse/JCLOUDS-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326355#comment-16326355 ] Ignasi Barrera commented on JCLOUDS-114: And we have finally the pull request! https://github.com/jclouds/jclouds/pull/1170 > Support OpenStack Keystone v3 API > - > > Key: JCLOUDS-114 > URL: https://issues.apache.org/jira/browse/JCLOUDS-114 > Project: jclouds > Issue Type: New Feature > Components: jclouds-blobstore, jclouds-compute, > jclouds-labs-openstack >Affects Versions: 1.7.0 >Reporter: Jeremy Daggett >Assignee: Ignasi Barrera >Priority: Critical > Labels: oak, openstack-keystone > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jclouds/jclouds] Add Keystone V3 support (#1170)
https://issues.apache.org/jira/browse/JCLOUDS-114 Adds support for OpenStack Keystone V3. This has been live tested against Fujitsu and DevStack, and also verified with the jclouds-cli. Once this is merged the OpenStack APIs in the labs repos need to be updated too. Kudos to @andreaturli too! You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1170 -- Commit Summary -- * Initial work towards Keystone V3 authentication * fix for keystone v3 liveTests (#1) * wip * wip * some minor fixes to keystone * Add support for scoped authentication * Response headers should be case-insensitive * Support domain and project scopes * Scope fixes * improve mocke tests * Fix nullable fields * wip - adding keystone v3 tests * Proper configuration for Mock and Live tests * Complete mock tests for the V3 AuthApi * Default to domain scoped authentication * Allow the Domain id as a scope * Minor fix * Default to unscoped authentication * Completed ProjectApi and live tests * Completed the RegionApi * Completed the UserApi * Fix Rackspace CloudIdentity * Properly default to unscoped authorization * Add support for project name in authorization scope * Include the domain info in project named based authentication * Properly scope a project name to the domain * Properly resolve the identity endpoint fro the service catalog * Add warning if there is no service catalog in the authenticated token * fix domain objects * Return project id not the domain id -- File Changes -- M apis/openstack-cinder/src/main/java/org/jclouds/openstack/cinder/v1/CinderApiMetadata.java (18) M apis/openstack-cinder/src/main/java/org/jclouds/openstack/cinder/v1/extensions/AvailabilityZoneApi.java (2) M apis/openstack-cinder/src/main/java/org/jclouds/openstack/cinder/v1/features/QuotaApi.java (2) M apis/openstack-cinder/src/main/java/org/jclouds/openstack/cinder/v1/features/SnapshotApi.java (2) M apis/openstack-cinder/src/main/java/org/jclouds/openstack/cinder/v1/features/VolumeApi.java (2) M apis/openstack-cinder/src/main/java/org/jclouds/openstack/cinder/v1/features/VolumeTypeApi.java (2) M apis/openstack-cinder/src/test/java/org/jclouds/openstack/cinder/v1/internal/BaseCinderApiLiveTest.java (2) M apis/openstack-keystone/pom.xml (85) R apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/auth/AuthHeaders.java (2) A apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/auth/AuthenticationApi.java (35) R apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/auth/config/Authentication.java (2) A apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/auth/config/AuthenticationModule.java (142) R apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/auth/config/CredentialType.java (3) R apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/auth/config/CredentialTypes.java (24) A apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/auth/domain/ApiAccessKeyCredentials.java (51) R apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/auth/domain/AuthInfo.java (10) A apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/auth/domain/PasswordCredentials.java (59) A apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/auth/domain/TenantOrDomainAndCredentials.java (52) R apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/auth/domain/TokenCredentials.java (39) R apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/auth/filters/AuthenticateRequest.java (8) A apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/auth/functions/AuthenticateApiAccessKeyCredentials.java (51) A apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/auth/functions/AuthenticatePasswordCredentials.java (50) A apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/auth/functions/AuthenticateTokenCredentials.java (50) R apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/auth/functions/BaseAuthenticator.java (57) R apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/auth/handlers/RetryOnRenew.java (10) A apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/catalog/ServiceEndpoint.java (74) R apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/catalog/config/InternalUrlModule.java (8) A apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/catalog/config/KeystoneAdminURLModule.java (72) A apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/catalog/config/ServiceCatalogModule.java (160) R
Re: [jclouds/jclouds-site] Minor text changes and small corrections (take 2) (#208)
nacx commented on this pull request. > * The `KeystoneAuthenticationModule` and the `AuthenticationApiModule` have > been refactored and generalised into: * `AuthenticationModule` - Providing authentication services to all OpenStack APIs and providers. * `ServiceCatalogModule` - Providing endpoint resolution to all OpenStack APIs and providers. + +Replace uses of `KeystoneAuthenticationModule` with `AuthenticationModule`, and uses of `AuthenticationApiModule` with `ServiceCatalogModule`. This is not strictly true, and that's why I wrote it that way. The KeystoneAuthModule contained both, the authentication configuration and the service catalog one, and the AuthenticationApiModule just bound the internal Authentication API. I've refactored it in a way that makes more sense, moving all config to the AuthenticationModule and the service catalog parsing to the Service Catalog module, but I don't think we need to mention that. Those modules are already included by all OpenStack APIs, so that info is interesting only for those writing new APIs. I wanted to mention the refactoring, but users won't need to replace anything when upgrading, so I'd just remove this last sentence. Apart from this, LGTM. Many thanks for reviewing! :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/208#pullrequestreview-88741843
