Re: [jclouds/jclouds-labs] [JCLOUDS-1430] Aliyun ECS (#443)

2018-08-19 Thread Andrea Turli 
andreaturli commented on this pull request.



>  public class BaseECSComputeServiceApiLiveTest extends 
> BaseApiLiveTest {
 
+   protected static final String TEST_REGION = Regions.EU_CENTRAL_1.getName();

ok done

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/443#discussion_r211107120

Re: [jclouds/jclouds-labs] [JCLOUDS-1430] Aliyun ECS (#443)

2018-08-19 Thread Andrea Turli 
andreaturli commented on this pull request.



> @@ -23,6 +23,10 @@
 @AutoValue
 public abstract class Tag {
 
+   public static final String DEFAULT_OWNER_KEY = "owner";
+   public static final String DEFAULT_OWNER_VALUE = "jclouds";
+   public static final String GROUP = "group";

not sure we need that, as I'm adding the vswitchId tag using this code
```
  Map tags = 
ComputeServiceUtils.metadataAndTagsAsValuesOfEmptyString(templateOptions);
  tags = new ImmutableMap.Builder()
  .putAll(tags)
  .put(vSwitchId, "")
  .build();
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/443#discussion_r211107039