[jira] [Comment Edited] (JCLOUDS-1339) Support launching an x1 EC2 instance

2018-08-21 Thread Markus Kuppe (JIRA)


[ 
https://issues.apache.org/jira/browse/JCLOUDS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587983#comment-16587983
 ] 

Markus Kuppe edited comment on JCLOUDS-1339 at 8/21/18 9:09 PM:


[https://github.com/jclouds/jclouds/pull/1235]

 

Please also consider including this feature in the next 2.1.x maintenance 
release.


was (Author: mkuppe):
https://github.com/jclouds/jclouds/pull/1235

> Support launching an x1 EC2 instance
> 
>
> Key: JCLOUDS-1339
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1339
> Project: jclouds
>  Issue Type: Improvement
>  Components: jclouds-compute
>Affects Versions: 2.0.2
>Reporter: Markus Kuppe
>Priority: Major
>  Labels: aws-ec2
>
> The current version of jclouds-compute does not support launching x1 
> (x1.32xlarge and x1.16xlarge) EC instances. x1 instances are memory optimized 
> instances with a high core count tailored to demanding workloads. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (JCLOUDS-1339) Support launching an x1 EC2 instance

2018-08-21 Thread Markus Kuppe (JIRA)


[ 
https://issues.apache.org/jira/browse/JCLOUDS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587983#comment-16587983
 ] 

Markus Kuppe commented on JCLOUDS-1339:
---

https://github.com/jclouds/jclouds/pull/1235

> Support launching an x1 EC2 instance
> 
>
> Key: JCLOUDS-1339
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1339
> Project: jclouds
>  Issue Type: Improvement
>  Components: jclouds-compute
>Affects Versions: 2.0.2
>Reporter: Markus Kuppe
>Priority: Major
>  Labels: aws-ec2
>
> The current version of jclouds-compute does not support launching x1 
> (x1.32xlarge and x1.16xlarge) EC instances. x1 instances are memory optimized 
> instances with a high core count tailored to demanding workloads. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jclouds/jclouds] JCLOUDS-1339: Support launching an x1 EC2 instance (#1235)

2018-08-21 Thread Markus Alexander Kuppe
https://issues.apache.org/jira/browse/JCLOUDS-1339

Please consider including in next 2.1.x release.
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1235

-- Commit Summary --

  * JCLOUDS-1339: Support launching an x1 EC2 instance

-- File Changes --

M 
apis/ec2/src/main/java/org/jclouds/ec2/compute/domain/EC2HardwareBuilder.java 
(38)
M apis/ec2/src/main/java/org/jclouds/ec2/domain/InstanceType.java (26)
M 
providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/compute/suppliers/AWSEC2HardwareSupplier.java
 (4)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1235.patch
https://github.com/jclouds/jclouds/pull/1235.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1235


Re: [jclouds/jclouds-labs] [JCLOUDS-1430] Aliyun ECS (#443)

2018-08-21 Thread Andrea Turli
@nacx it is a wip, so please don't bother to review it yet. I'll ping when I 
think it's ready for your review, ok?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/443#issuecomment-414683491

Re: [jclouds/jclouds-labs] [JCLOUDS-1430] Aliyun ECS (#443)

2018-08-21 Thread Andrea Turli
@andreaturli pushed 2 commits.

2d991e1  wip
88d83f3  more comments addressed


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/443/files/801266bac92ae8d6c54cdec540b1860b95f8cb94..88d83f336aefd7a8013dac58f79e5b9ea4ec27c9


Re: [jclouds/jclouds-labs] [JCLOUDS-1430] Aliyun ECS (#443)

2018-08-21 Thread Andrea Turli
andreaturli commented on this pull request.



> +// public String apply(Map.Entry input) {
+//return String.format(PORT_RANGE_FORMAT, input.getKey(), 
input.getValue());
+// }
+//  }));
+//
+//  for (SecurityGroup securityGroup : 
api.securityGroupApi().list(regionId).concat()) {
+// List permissions = api.securityGroupApi().get(regionId, 
securityGroup.id());
+// if (permissions.size() == portRangesAsString.size()) {
+//for (Permission permission : permissions) {
+//   if (permission.ipProtocol() == IpProtocol.TCP && 
permission.sourceCidrIp().equals(INTERNET)) {
+//  portRangesAsString.remove(permission.portRange());
+//   }
+//}
+//if (portRangesAsString.isEmpty()) return 
Optional.of(securityGroup);
+// }
+//  }

sorry removed

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/443#discussion_r211587632