[jira] [Commented] (JCLOUDS-114) Support OpenStack Keystone v3 API

2017-07-03 Thread Everett Toews (JIRA)

[ 
https://issues.apache.org/jira/browse/JCLOUDS-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16072604#comment-16072604
 ] 

Everett Toews commented on JCLOUDS-114:
---

Apologies but I won't be able to help out here. 

> Support OpenStack Keystone v3 API
> -
>
> Key: JCLOUDS-114
> URL: https://issues.apache.org/jira/browse/JCLOUDS-114
> Project: jclouds
>  Issue Type: New Feature
>  Components: jclouds-blobstore, jclouds-compute, 
> jclouds-labs-openstack
>Affects Versions: 1.7.0
>Reporter: Jeremy Daggett
>Priority: Critical
>  Labels: oak, openstack-keystone
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Re: [jclouds-labs-openstack] OS Ceilometer API support (#166)

2015-04-03 Thread Everett Toews
Closed #166.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/166#event-272752086

Re: [jclouds-site] add softlayer getting started (#134)

2015-04-03 Thread Everett Toews
@andreaturli The next release is out. ;) I'll leave this one up to you.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/134#issuecomment-89337328

Re: [jclouds-examples] Add layer 7 load balancer examples. (#61)

2015-04-03 Thread Everett Toews
Closed #61.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/61#event-272780705

Re: [jclouds-site] Update compute.md (#130)

2015-04-03 Thread Everett Toews
Closed #130.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/130#event-272779175

Re: [jclouds-labs-openstack] Adds service predicates and more tests (#186)

2015-04-03 Thread Everett Toews
:+1: after a check for naming consistency is done.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/186#issuecomment-89410171

Re: [jclouds-labs-openstack] Adds service predicates and more tests (#186)

2015-04-03 Thread Everett Toews
 +import static com.google.common.base.Preconditions.checkNotNull;
 +import static java.util.concurrent.TimeUnit.SECONDS;
 +import static org.jclouds.util.Predicates2.retry;
 +
 +import org.jclouds.openstack.poppy.v1.domain.Service;
 +import org.jclouds.openstack.poppy.v1.domain.ServiceStatus;
 +import org.jclouds.openstack.poppy.v1.features.ServiceApi;
 +import com.google.common.base.Predicate;
 +
 +public class ServicePredicates {
 +   public static PredicateService awaitDeployed(ServiceApi serviceApi) {
 +  StatusUpdatedPredicate statusPredicate = new 
 StatusUpdatedPredicate(serviceApi, ServiceStatus.DEPLOYED);
 +  return retry(statusPredicate, 1200, 15, 15, SECONDS);
 +   }
 +
 +   private static class StatusUpdatedPredicate implements PredicateService 
 {

Oops. I see that now. I think it was the name of the class that threw me. To me 
`StatusUpdatedPredicate` says it has to do with a 'Updated' status. Search the 
other predicates packages and see if this name is consistent with others. It 
should be inline with whatever is most consistent.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/186/files#r27753065

Re: [jclouds] JCLOUDS-599 ability to execute function locally before initScript runs. (#406)

2015-04-03 Thread Everett Toews
Closed #406.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/406#event-272756458

Re: [jclouds-labs-openstack] Adds service predicates and more tests (#186)

2015-04-03 Thread Everett Toews
 +import static com.google.common.base.Preconditions.checkNotNull;
 +import static java.util.concurrent.TimeUnit.SECONDS;
 +import static org.jclouds.util.Predicates2.retry;
 +
 +import org.jclouds.openstack.poppy.v1.domain.Service;
 +import org.jclouds.openstack.poppy.v1.domain.ServiceStatus;
 +import org.jclouds.openstack.poppy.v1.features.ServiceApi;
 +import com.google.common.base.Predicate;
 +
 +public class ServicePredicates {
 +   public static PredicateService awaitDeployed(ServiceApi serviceApi) {
 +  StatusUpdatedPredicate statusPredicate = new 
 StatusUpdatedPredicate(serviceApi, ServiceStatus.DEPLOYED);
 +  return retry(statusPredicate, 1200, 15, 15, SECONDS);
 +   }
 +
 +   private static class StatusUpdatedPredicate implements PredicateService 
 {

This should really be a more generalized status predicate like 
[ServerStatusPredicate](https://github.com/jclouds/jclouds/blob/master/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/predicates/ServerPredicates.java#L92).
 The convenience method `awaitDeployed` can then be built on that.

I know it's unlikely that anyone would ever want to await on any of the other 
`ServiceStatus` in this particular case but the general style should still be 
followed.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/186/files#r27735322

Re: [jclouds] JCLOUDS-670 Option force no password when launching images on providers (#486)

2015-04-03 Thread Everett Toews
Closed #486.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/486#event-272758128

Re: [jclouds] Throw sane error if one of security groups is null (#515)

2015-04-03 Thread Everett Toews
Closed #515.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/515#event-272760104

Re: [jclouds] Updated the requests in unit test case to include globalIdentifier (#531)

2015-04-03 Thread Everett Toews
Closed #531.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/531#event-272761027

Re: [jclouds] Expecting 2 of 3 or the first flaky test to succeed (#577)

2015-04-03 Thread Everett Toews
Closed #577.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/577#event-272761787

Re: [jclouds-site] Update aws.md (#129)

2015-04-03 Thread Everett Toews
Closed #129.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/129#event-272762945

Re: [jclouds-site] Updated for 1.9.0 (#155)

2015-03-30 Thread Everett Toews
Merged and published.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/155#issuecomment-87833345

[jclouds-site] Updated for 1.9.0 (#155)

2015-03-27 Thread Everett Toews

You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-site/pull/155

-- Commit Summary --

  * Updated for 1.9.0

-- File Changes --

M guides/openstack.md (20)

-- Patch Links --

https://github.com/jclouds/jclouds-site/pull/155.patch
https://github.com/jclouds/jclouds-site/pull/155.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/155


Re: [jclouds-labs] BlobStore API for Orion based back-ends (#45)

2015-03-26 Thread Everett Toews
I don't know the history of this PR but the fact that it's been open since Nov. 
30, 2013 is odd. 

@aledsage @demobox @andrewgaul Does it make sense to continue working on this?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/45#issuecomment-86485058

Re: [jclouds-labs] BlobStore API for Orion based back-ends (#45)

2015-03-24 Thread Everett Toews
Thanks for the pull request but it's release week in jclouds and that means 
it's time to clean up the PR queue. This PR will be over 6 months old as of 
April 1. If you intend to continue work on it, please make a comment by April 
2. Otherwise it will be closed on April 3.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/45#issuecomment-85718559

Re: [jclouds] Support for OpenStack OS-Services API (#573)

2015-03-24 Thread Everett Toews
Thanks for the pull request but it's release week in jclouds and that means 
it's time to clean up the PR queue. This PR will be over 6 months old as of 
April 1. If you intend to continue work on it, please make a comment by April 
2. Otherwise it will be closed on April 3.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/573#issuecomment-85716682

Re: [jclouds] JCLOUDS-670 Option force no password when launching images on providers (#486)

2015-03-24 Thread Everett Toews
Thanks for the pull request but it's release week in jclouds and that means 
it's time to clean up the PR queue. This PR will be over 6 months old as of 
April 1. If you intend to continue work on it, please make a comment by April 
2. Otherwise it will be closed on April 3.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/486#issuecomment-85715089

Re: [jclouds] Add support for Azure Copy Blob (#514)

2015-03-24 Thread Everett Toews
Thanks for the pull request but it's release week in jclouds and that means 
it's time to clean up the PR queue. This PR will be over 6 months old as of 
April 1. If you intend to continue work on it, please make a comment by April 
2. Otherwise it will be closed on April 3.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/514#issuecomment-85715395

Re: [jclouds] Introduce BlobstoreCli (#487)

2015-03-24 Thread Everett Toews
Thanks for the pull request but it's release week in jclouds and that means 
it's time to clean up the PR queue. This PR will be over 6 months old as of 
April 1. If you intend to continue work on it, please make a comment by April 
2. Otherwise it will be closed on April 3.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/487#issuecomment-85715196

Re: [jclouds] JCLOUDS-642: InternalUrl fallback (#462)

2015-03-24 Thread Everett Toews
Thanks for the pull request but it's release week in jclouds and that means 
it's time to clean up the PR queue. This PR will be over 6 months old as of 
April 1. If you intend to continue work on it, please make a comment by April 
2. Otherwise it will be closed on April 3.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/462#issuecomment-85714738

Re: [jclouds] Token based authentication in openstack-keystone (#433)

2015-03-24 Thread Everett Toews
Thanks for the pull request but it's release week in jclouds and that means 
it's time to clean up the PR queue. This PR will be over 6 months old as of 
April 1. If you intend to continue work on it, please make a comment by April 
2. Otherwise it will be closed on April 3.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/433#issuecomment-85714569

Re: [jclouds-examples] Add an example to create/delete/list Google Cloud Storage buckets. (#64)

2015-03-24 Thread Everett Toews
Thanks for the pull request but it's release week in jclouds and that means 
it's time to clean up the PR queue. This PR will be over 6 months old as of 
April 1. If you intend to continue work on it, please make a comment by April 
2. Otherwise it will be closed on April 3.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/64#issuecomment-85717886

Re: [jclouds-examples] GCS-Example initial commit (#66)

2015-03-24 Thread Everett Toews
Thanks for the pull request but it's release week in jclouds and that means 
it's time to clean up the PR queue. This PR will be over 6 months old as of 
April 1. If you intend to continue work on it, please make a comment by April 
2. Otherwise it will be closed on April 3.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/66#issuecomment-85717959

Re: [jclouds-labs-openstack] OS Ceilometer API support (#166)

2015-03-24 Thread Everett Toews
Thanks for the pull request but it's release week in jclouds and that means 
it's time to clean up the PR queue. This PR will be over 6 months old as of 
April 1. If you intend to continue work on it, please make a comment by April 
2. Otherwise it will be closed on April 3.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/166#issuecomment-85718143

Re: [jclouds-examples] Simplify interface of Google examples and fix the name and comment of userName variable (#63)

2015-03-24 Thread Everett Toews
@demobox Can this be closed?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/63#issuecomment-85717848

Re: [jclouds-site] Update compute.md (#131)

2015-03-24 Thread Everett Toews
Merged.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/131#issuecomment-85720599

Re: [jclouds] Add copyBlob to portable abstraction and add S3-optimized variant (#511)

2015-03-24 Thread Everett Toews
Thanks for the pull request but it's release week in jclouds and that means 
it's time to clean up the PR queue. This PR will be over 6 months old as of 
April 1. If you intend to continue work on it, please make a comment by April 
2. Otherwise it will be closed on April 3.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/511#issuecomment-85715297

Re: [jclouds] Updated the requests in unit test case to include globalIdentifier (#531)

2015-03-24 Thread Everett Toews
Thanks for the pull request but it's release week in jclouds and that means 
it's time to clean up the PR queue. This PR will be over 6 months old as of 
April 1. If you intend to continue work on it, please make a comment by April 
2. Otherwise it will be closed on April 3.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/531#issuecomment-85715651

Re: [jclouds] Throw sane error if one of security groups is null (#515)

2015-03-24 Thread Everett Toews
Thanks for the pull request but it's release week in jclouds and that means 
it's time to clean up the PR queue. This PR will be over 6 months old as of 
April 1. If you intend to continue work on it, please make a comment by April 
2. Otherwise it will be closed on April 3.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/515#issuecomment-85715464

Re: [jclouds-site] Update compute.md (#130)

2015-03-24 Thread Everett Toews
Thanks for the pull request but it's release week in jclouds and that means 
it's time to clean up the PR queue. This PR will be over 6 months old as of 
April 1. If you intend to continue work on it, please make a comment by April 
2. Otherwise it will be closed on April 3.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/130#issuecomment-85719600

Re: [jclouds-site] Update aws.md (#129)

2015-03-24 Thread Everett Toews
Thanks for the pull request but it's release week in jclouds and that means 
it's time to clean up the PR queue. This PR will be over 6 months old as of 
April 1. If you intend to continue work on it, please make a comment by April 
2. Otherwise it will be closed on April 3.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/129#issuecomment-85719557

Re: [jclouds-site] add softlayer getting started (#134)

2015-03-24 Thread Everett Toews
Thanks for the pull request but it's release week in jclouds and that means 
it's time to clean up the PR queue. This PR will be over 6 months old as of 
April 1. If you intend to continue work on it, please make a comment by April 
2. Otherwise it will be closed on April 3.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/134#issuecomment-85720981

Re: [jclouds] Expecting 2 of 3 or the first flaky test to succeed (#577)

2015-03-24 Thread Everett Toews
Thanks for the pull request but it's release week in jclouds and that means 
it's time to clean up the PR queue. This PR will be over 6 months old as of 
April 1. If you intend to continue work on it, please make a comment by April 
2. Otherwise it will be closed on April 3.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/577#issuecomment-85717259

Re: [jclouds] Import rackspace-cloudfiles from labs (#565)

2015-03-24 Thread Everett Toews
Superseded by #705  

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/565#issuecomment-85716224

Re: [jclouds-examples] Add layer 7 load balancer examples. (#61)

2015-03-24 Thread Everett Toews
Thanks for the pull request but it's release week in jclouds and that means 
it's time to clean up the PR queue. This PR will be over 6 months old as of 
April 1. If you intend to continue work on it, please make a comment by April 
2. Otherwise it will be closed on April 3.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/61#issuecomment-85717726

Re: [jclouds-karaf] JCLOUDS-85: Improving the creation of instance of PropertyShellTableFact... (#18)

2015-03-24 Thread Everett Toews
Thanks for the pull request but it's release week in jclouds and that means 
it's time to clean up the PR queue. This PR will be over 6 months old as of 
April 1. If you intend to continue work on it, please make a comment by April 
2. Otherwise it will be closed on April 3.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/18#issuecomment-85718822

Re: [jclouds] JCLOUDS-599 ability to execute function locally before initScript runs. (#406)

2015-03-24 Thread Everett Toews
Thanks for the pull request but it's release week in jclouds and that means 
it's time to clean up the PR queue. This PR will be over 6 months old as of 
April 1. If you intend to continue work on it, please make a comment by April 
2. Otherwise it will be closed on April 3.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/406#issuecomment-85714023

Re: [jclouds-labs] JCLOUDS-664: Implemented Role represenstaion in API (#118)

2015-03-24 Thread Everett Toews
Thanks for the pull request but it's release week in jclouds and that means 
it's time to clean up the PR queue. This PR will be over 6 months old as of 
April 1. If you intend to continue work on it, please make a comment by April 
2. Otherwise it will be closed on April 3.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/118#issuecomment-85718608

Re: [jclouds-labs-aws] JCLOUDS-750: Refactor glacier domain classes using @AutoValue (#64)

2015-03-24 Thread Everett Toews
Thanks for the pull request but it's release week in jclouds and that means 
it's time to clean up the PR queue. This PR will be over 6 months old as of 
April 1. If you intend to continue work on it, please make a comment by April 
2. Otherwise it will be closed on April 3.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/64#issuecomment-85718421

Re: [jclouds-labs-aws] Prefer TestUtils.randomByteSource (#42)

2015-03-24 Thread Everett Toews
Thanks for the pull request but it's release week in jclouds and that means 
it's time to clean up the PR queue. This PR will be over 6 months old as of 
April 1. If you intend to continue work on it, please make a comment by April 
2. Otherwise it will be closed on April 3.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/42#issuecomment-85718345

Re: [jclouds-karaf] JCLOUDS-716: Remove Rackspace First-Gen Cloud Servers (#63)

2015-03-24 Thread Everett Toews
If no one who knows Karaf cares to merge this, I'll just go ahead and close it 
on April 3. I'd rather close it unmerged than risk breaking Karaf in some weird 
way I'm not prepared to deal with.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/63#issuecomment-85719435

Re: [jclouds-karaf] Separates parent and top level pom. (#22)

2015-03-24 Thread Everett Toews
Thanks for the pull request but it's release week in jclouds and that means 
it's time to clean up the PR queue. This PR will be over 6 months old as of 
April 1. If you intend to continue work on it, please make a comment by April 
2. Otherwise it will be closed on April 3.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/22#issuecomment-85718867

Re: [jclouds-karaf] JCLOUDS-635 Always check for container existence before uploading blobs. (#50)

2015-03-24 Thread Everett Toews
Thanks for the pull request but it's release week in jclouds and that means 
it's time to clean up the PR queue. This PR will be over 6 months old as of 
April 1. If you intend to continue work on it, please make a comment by April 
2. Otherwise it will be closed on April 3.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/50#issuecomment-85718919

Re: [jclouds] Fixed VolumeAttachment in HPCloud Compute (#711)

2015-03-23 Thread Everett Toews
:+1: 

Success on OpenStack Juno (with DevStack)

mvn clean test -Plive 
-Dtest.openstack-nova.endpoint=http://$DEVSTACK_HOST:5000/v2.0/ 
-Dtest.openstack-nova.identity=demo:demo 
-Dtest.openstack-nova.credential=devstack 
-Dtest.openstack-nova.image-id=$IMAGE_ID -Dtest.openstack-nova.flavor-id=2 
-Dtest=VolumeAttachmentApiLiveTest

Success on Rackspace

mvn clean test -Plive 
-Dtest.rackspace-cloudservers-us.identity=$RACKSPACE_USERNAME 
-Dtest.rackspace-cloudservers-us.credential=$RACKSPACE_API_KEY 
-Dtest.rackspace-cloudservers-us.image-id=$IMAGE_ID 
-Dtest.rackspace-cloudservers-us.flavor-id=performance1-1 
-Dtest.rackspace-cloudservers-us.region=IAD 
-Dtest.rackspace-cloudservers-us.volume-size-gb=100 
-Dtest=CloudServersUSVolumeAttachmentExtensionLiveTest


---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/711#issuecomment-85235985

[jclouds] Modernize the VolumeAttachmentApiLiveTest (#709)

2015-03-19 Thread Everett Toews

You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/709

-- Commit Summary --

  * Modernize the VolumeAttachmentApiLiveTest

-- File Changes --

M apis/openstack-nova/pom.xml (6)
M 
apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/VolumeAttachmentApiLiveTest.java
 (254)
M 
apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/features/ServerApiLiveTest.java
 (4)
M 
apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/internal/BaseNovaApiLiveTest.java
 (40)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/709.patch
https://github.com/jclouds/jclouds/pull/709.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/709


Re: [jclouds] Modernize the VolumeAttachmentApiLiveTest (#709)

2015-03-19 Thread Everett Toews
Hopefully this is in reasonably good shape now. I'll be on vacation until 
Monday and won't have my laptop with me. If changes need to be made, go ahead 
and push on top of my commits or just cherry pick or whatever. I just don't 
want to hold the release up.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/709#issuecomment-83757647

Re: [jclouds] Deprecate Nova API for volumes in favour of Cinder API for volumes (#708)

2015-03-19 Thread Everett Toews
@nacx Shall we pull this into 1.9.0?

It's related to the bug that broke the rc and it's just a doc change so it's 
zero risk.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/708#issuecomment-83757390

Re: [jclouds-examples] Updated Rackspace examples to 1.9.0 (#71)

2015-03-18 Thread Everett Toews
There are a couple of problems with this.

When I compile I get the warning.

$ javac -classpath 
jclouds-1.9.0-rc1/lib/*:src/main/java/:src/main/resources/ 
src/main/java/org/jclouds/examples/rackspace/*.java


jclouds-1.9.0-rc1/lib/jclouds-slf4j-1.9.0.jar(org/jclouds/logging/slf4j/config/SLF4JLoggingModule.class):
 warning: Cannot find annotation method 'value()' in type 'AutoService': class 
file for com.google.auto.service.AutoService not found
1 warning


When the Cloud Block Storage smoke tests are run in `SmokeTest` I get the error.

Exception in thread main java.lang.IllegalStateException: Optional.get() 
cannot be called on an absent value
  at com.google.common.base.Absent.get(Absent.java:47)
  at 
org.jclouds.examples.rackspace.cloudblockstorage.CreateVolumeAndAttach.init(CreateVolumeAndAttach.java:116)
  at 
org.jclouds.examples.rackspace.cloudblockstorage.CreateVolumeAndAttach.main(CreateVolumeAndAttach.java:81)
  at org.jclouds.examples.rackspace.SmokeTest.smokeTest(SmokeTest.java:72)
  at org.jclouds.examples.rackspace.SmokeTest.main(SmokeTest.java:48)



---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/71#issuecomment-83010122

[jclouds-examples] Updated Rackspace examples to 1.9.0 (#71)

2015-03-18 Thread Everett Toews

You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-examples/pull/71

-- Commit Summary --

  * Updated Rackspace examples to 1.9.0

-- File Changes --

M rackspace/pom.xml (4)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/Authentication.java (8)
M rackspace/src/main/java/org/jclouds/examples/rackspace/DeleteAll.java (50)
M rackspace/src/main/java/org/jclouds/examples/rackspace/Logging.java (10)
M rackspace/src/main/java/org/jclouds/examples/rackspace/SmokeTest.java (6)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/autoscale/AutoscaleCleanup.java
 (8)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/autoscale/Constants.java 
(2)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/autoscale/CreatePolicy.java
 (6)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/autoscale/CreateWebhook.java
 (12)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/autoscale/ExecuteWebhook.java
 (11)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/autoscale/UpdatePolicy.java
 (9)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/cloudblockstorage/Constants.java
 (2)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/cloudblockstorage/CreateSnapshot.java
 (6)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/cloudblockstorage/CreateVolumeAndAttach.java
 (18)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/cloudblockstorage/DeleteSnapshot.java
 (4)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/cloudblockstorage/DeleteVolume.java
 (4)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/cloudblockstorage/DetachVolume.java
 (19)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/cloudblockstorage/ListSnapshots.java
 (12)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/cloudblockstorage/ListVolumeAttachments.java
 (8)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/cloudblockstorage/ListVolumeTypes.java
 (12)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/cloudblockstorage/ListVolumes.java
 (12)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/clouddatabases/Constants.java
 (2)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/clouddatabases/CreateDatabase.java
 (6)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/clouddatabases/CreateInstance.java
 (6)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/clouddatabases/CreateUser.java
 (6)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/clouddatabases/DeleteDatabase.java
 (6)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/clouddatabases/DeleteInstance.java
 (4)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/clouddatabases/DeleteUser.java
 (6)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/clouddatabases/GrantRootAccess.java
 (4)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/clouddatabases/TestDatabase.java
 (6)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/clouddns/CRUDReverseDNSRecords.java
 (6)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/clouddns/CreateDomains.java
 (2)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/clouddns/CreateRecords.java
 (4)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/clouddns/DeleteDomains.java
 (2)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/clouddns/DeleteRecords.java
 (6)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/clouddns/ListDomains.java
 (2)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/clouddns/ListRecords.java
 (8)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/clouddns/UpdateDomains.java
 (2)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/clouddns/UpdateRecords.java
 (14)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/cloudloadbalancers/AddNodes.java
 (8)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/cloudloadbalancers/Constants.java
 (2)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/cloudloadbalancers/CreateLoadBalancerWithExistingServers.java
 (6)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/cloudloadbalancers/CreateLoadBalancerWithNewServers.java
 (4)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/cloudloadbalancers/DeleteLoadBalancers.java
 (4)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/cloudloadbalancers/ListLoadBalancers.java
 (8)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/cloudloadbalancers/RemoveNodes.java
 (8)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/cloudloadbalancers/UpdateLoadBalancers.java
 (4)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/cloudloadbalancers/UpdateNodes.java
 (8)
M 

[jclouds] Deprecate Nova API for volumes in favour of Cinder API for volumes (#708)

2015-03-18 Thread Everett Toews

You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/708

-- Commit Summary --

  * Deprecate Nova API for volumes in favour of Cinder API for volumes

-- File Changes --

M 
apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/VolumeApi.java
 (32)
M 
apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/VolumeAttachmentApi.java
 (15)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/708.patch
https://github.com/jclouds/jclouds/pull/708.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/708


Re: [jclouds-labs-openstack] Poppy service api (#179)

2015-03-11 Thread Everett Toews
:+1: 


---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/179#issuecomment-78336509

Re: [jclouds] adding attache detach interface to nova api (#697)

2015-03-10 Thread Everett Toews
 + * Licensed to the Apache Software Foundation (ASF) under one or more
 + * contributor license agreements.  See the NOTICE file distributed with
 + * this work for additional information regarding copyright ownership.
 + * The ASF licenses this file to You under the Apache License, Version 2.0
 + * (the License); you may not use this file except in compliance with
 + * the License.  You may obtain a copy of the License at
 + *
 + * http://www.apache.org/licenses/LICENSE-2.0
 + *
 + * Unless required by applicable law or agreed to in writing, software
 + * distributed under the License is distributed on an AS IS BASIS,
 + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 + * See the License for the specific language governing permissions and
 + * limitations under the License.
 + */
 +package org.jclouds.openstack.nova.v2_0.features;

This should be in `package org.jclouds.openstack.nova.v2_0.extensions` instead.



---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/697/files#r26171299

Re: [jclouds] adding attache detach interface to nova api (#697)

2015-03-10 Thread Everett Toews
 +
 +import javax.inject.Named;
 +import javax.ws.rs.Consumes;
 +import javax.ws.rs.DELETE;
 +import javax.ws.rs.POST;
 +import javax.ws.rs.Path;
 +import javax.ws.rs.PathParam;
 +import javax.ws.rs.core.MediaType;
 +
 +/**
 + * interface api for nova
 + */
 +@RequestFilters(AuthenticateRequest.class)
 +@Consumes(MediaType.APPLICATION_JSON)
 +@Path(/servers)
 +public interface InterfaceApi {

This also need to implement the _List interfaces_ and _Show attached interface 
information_ methods from 
[os-interface](http://developer.openstack.org/api-ref-compute-v2-ext.html#ext-os-interface).
 If you have those methods you shouldn't have to depend on particular UUIDs in 
the tests.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/697/files#r26171229

Re: [jclouds] adding attache detach interface to nova api (#697)

2015-03-10 Thread Everett Toews
 @@ -457,4 +457,12 @@ ImageApi getImageApiForZone(
 @Delegate
 Optional? extends ConsolesApi getConsolesExtensionForZone(
   @EndpointParam(parser = RegionToEndpoint.class) String zone);
 +
 +/**
 + * Provides access to interface Type features.
 + */
 +@Delegate
 +Optional? extends InterfaceApi getInterfaceApiForZone(
 +@EndpointParam(parser = RegionToEndpoint.class) String zone);

Should be `OptionalInterfaceApi getInterfaceApi(@EndpointParam(parser = 
RegionToEndpoint.class) String region);`

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/697/files#r26171650

Re: [jclouds] adding attache detach interface to nova api (#697)

2015-03-10 Thread Everett Toews
 +@RequestFilters(AuthenticateRequest.class)
 +@Consumes(MediaType.APPLICATION_JSON)
 +@Path(/servers)
 +public interface InterfaceApi {
 +
 +   @Named(interface:attach)
 +   @POST
 +   @SelectJson(interfaceAttachment)
 +   @Path(/{server_id}/os-interface)
 +   InterfaceAttachment attachInterface(@PathParam(server_id) String 
 serverId);
 +
 +   @Named(interface:attach)
 +   @POST
 +   @SelectJson(interfaceAttachment)
 +   @Path(/{server_id}/os-interface)
 +   InterfaceAttachment attachInterface(@PathParam(server_id) String 
 serverId, AttachInterfaceOptions options);

Needs some Javadoc. You can just copy the info out of 
[os-interface](http://developer.openstack.org/api-ref-compute-v2-ext.html#ext-os-interface).

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/697/files#r26172099

Re: [jclouds] adding attache detach interface to nova api (#697)

2015-03-10 Thread Everett Toews
 +public Setorg.jclouds.openstack.nova.v2_0.domain.FixedIp getFixedIps() 
 {
 +return fixedIps;
 +}
 +
 +public String getPortId() {
 +return portId;
 +}
 +
 +public String getNetId() {
 +return netId;
 +}
 +
 +public static class Builder {
 +
 +/**
 + * @see AttachInterfaceOptions#getPortState()()

Double `()()` here

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/697/files#r26171721

Re: [jclouds] adding attache detach interface to nova api (#697)

2015-03-10 Thread Everett Toews
 +import javax.ws.rs.PathParam;
 +import javax.ws.rs.core.MediaType;
 +
 +/**
 + * interface api for nova
 + */
 +@RequestFilters(AuthenticateRequest.class)
 +@Consumes(MediaType.APPLICATION_JSON)
 +@Path(/servers)
 +public interface InterfaceApi {
 +
 +   @Named(interface:attach)
 +   @POST
 +   @SelectJson(interfaceAttachment)
 +   @Path(/{server_id}/os-interface)
 +   InterfaceAttachment attachInterface(@PathParam(server_id) String 
 serverId);

Needs some Javadoc. You can just copy the info out of 
[os-interface](http://developer.openstack.org/api-ref-compute-v2-ext.html#ext-os-interface).

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/697/files#r26172087

Re: [jclouds-labs-openstack] Poppy service api (#179)

2015-03-09 Thread Everett Toews
 +   @Named(service:list)
 +   @GET
 +   @ResponseParser(ParseServices.class)
 +   @Transform(ServicesToPagedIterable.class)
 +   @Fallback(Fallbacks.EmptyPagedIterableOnNotFoundOr404.class)
 +   PagedIterableService list();
 +
 +   /**
 +* Lists services by providing a specific set of listing options.
 +* @param options Describes how services should be listed.
 +*/
 +   @Named(service:list)
 +   @GET
 +   @ResponseParser(ParseServices.class)
 +   @Fallback(EmptyServicesFallback.class)
 +   Services list(PaginationOptions options);

Should this return a Services object? Is this inline with the [Pagination 
section of API/Provider Writing 
Practices](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=49578594#API/ProviderWritingPractices-Pagination)?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/179/files#r26029537

Re: [jclouds-labs-openstack] Poppy service api (#179)

2015-03-09 Thread Everett Toews
 +   @Override
 +   public R extends HttpRequest R bindToRequest(R request, MapString, 
 Object postParams) {
 +  String jsonPatch = null;
 +  Service service = (Service) postParams.get(service);
 +
 +  Json json = Guice.createInjector(new 
 GsonModule()).getInstance(Json.class);
 +
 +  String targetService = json.toJson(postParams.get(updateService));
 +  String sourceService = 
 json.toJson(service.toUpdatableService().build());
 +
 +  ObjectMapper mapper = new ObjectMapper();
 +  try {
 + jsonPatch = JsonDiff.asJson(mapper.readTree(sourceService), 
 mapper.readTree(targetService)).toString();
 +  } catch (IOException e) {
 + e.printStackTrace();
 + throw new RuntimeException(Could not create a JSONPatch);

Don't mask the original exception. Use `RuntimeException(String message, 
Throwable cause)` instead.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/179/files#r26029069

Re: [jclouds-labs-openstack] Poppy service api (#179)

2015-03-09 Thread Everett Toews
 +
 +   @Override
 +   public R extends HttpRequest R bindToRequest(R request, MapString, 
 Object postParams) {
 +  String jsonPatch = null;
 +  Service service = (Service) postParams.get(service);
 +
 +  Json json = Guice.createInjector(new 
 GsonModule()).getInstance(Json.class);
 +
 +  String targetService = json.toJson(postParams.get(updateService));
 +  String sourceService = 
 json.toJson(service.toUpdatableService().build());
 +
 +  ObjectMapper mapper = new ObjectMapper();
 +  try {
 + jsonPatch = JsonDiff.asJson(mapper.readTree(sourceService), 
 mapper.readTree(targetService)).toString();
 +  } catch (IOException e) {
 + e.printStackTrace();

I think this should just be removed completely.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/179/files#r26029099

Re: [jclouds-labs-openstack] Poppy service api (#179)

2015-03-09 Thread Everett Toews
 +* @param id the id of the service to delete
 +* @return true if delete was successful, false if not
 +*/
 +   @Named(network:delete)
 +   @DELETE
 +   @Path(/{id})
 +   @Fallback(Fallbacks.FalseOnNotFoundOr404.class)
 +   boolean delete(@PathParam(id) String id);
 +
 +   /**
 +* Updates a service by applying JSONPatch internally.
 +* https://tools.ietf.org/html/rfc6902
 +* This requires providing your updateable JSON and the target JSON.
 +*
 +* @param service Source JSON
 +* @param createService Target JSON

Should be `updateService`

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/179/files#r26029920

Re: [jclouds-labs-openstack] Poppy service api (#179)

2015-03-09 Thread Everett Toews
 +   @Fallback(NullOnNotFoundOr404.class)
 +   @Nullable
 +   Service get(@PathParam(id) String id);
 +
 +   /**
 +* Creates a service.
 +*
 +* @param options  the options to create the service with
 +* @return a URI to the created service
 +*/
 +   @Named(service:create)
 +   @POST
 +   @ResponseParser(ParseServiceURIFromHeaders.class)
 +   @Fallback(NullOnNotFoundOr404.class)
 +   @Nullable
 +   URI create(CreateService options);

`options` is an odd name for this param. In `update()` it's called 
`updateService`. I suggest `createService `.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/179/files#r26030007

[jira] [Commented] (JCLOUDS-819) Allow prepending a custom user agent

2015-02-11 Thread Everett Toews (JIRA)

[ 
https://issues.apache.org/jira/browse/JCLOUDS-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317160#comment-14317160
 ] 

Everett Toews commented on JCLOUDS-819:
---

Me too. As long as it gets well documented.

 Allow prepending a custom user agent
 

 Key: JCLOUDS-819
 URL: https://issues.apache.org/jira/browse/JCLOUDS-819
 Project: jclouds
  Issue Type: Improvement
  Components: jclouds-core
Reporter: Everett Toews
Priority: Minor

 Give your users the ability to _prepend_ a custom user agent. So if the 
 existing user agent is jclouds/1.8.1 java/1.7.0_51
 Provide a method for your users to easily prepend their own user agent so 
 they can further customize it. e.g. users-app/0.1.2 jclouds/1.8.1 
 java/1.7.0_51
 This will give cloud providers much better insight into how people are using 
 jclouds. This should be well documented and part of examples that are written 
 for jclouds.
 It could be set like,
 {code}
 ComputeServiceContext context = ContextBuilder.newBuilder(PROVIDER)
.credentials(username, apiKey)
.userAgent(users-app/0.1.2)
.buildView(ComputeServiceContext.class);
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (JCLOUDS-819) Allow prepending a custom user agent

2015-02-10 Thread Everett Toews (JIRA)
Everett Toews created JCLOUDS-819:
-

 Summary: Allow prepending a custom user agent
 Key: JCLOUDS-819
 URL: https://issues.apache.org/jira/browse/JCLOUDS-819
 Project: jclouds
  Issue Type: Improvement
  Components: jclouds-core
Reporter: Everett Toews
Priority: Minor


Give your users the ability to _prepend_ a custom user agent. So if the 
existing user agent is jclouds/1.8.1 java/1.7.0_51

Provide a method for your users to easily prepend their own user agent so they 
can further customize it. e.g. users-app/0.1.2 jclouds/1.8.1 java/1.7.0_51

This will give cloud providers much better insight into how people are using 
jclouds. This should be well documented and part of examples that are written 
for jclouds.

It could be set like,

{code}
ComputeServiceContext context = ContextBuilder.newBuilder(PROVIDER)
   .credentials(username, apiKey)
   .userAgent(users-app/0.1.2)
   .buildView(ComputeServiceContext.class);
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [jclouds-site] Encourage users to join the jclouds community (#152)

2015-01-26 Thread Everett Toews
Reopened #152.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/152#event-224733887

Re: [jclouds-site] Encourage users to join the jclouds community (#152)

2015-01-26 Thread Everett Toews
Closed #152.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/152#event-224737596

Re: [jclouds-site] Encourage users to join the jclouds community (#152)

2015-01-26 Thread Everett Toews
Reopened #152.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/152#event-224737646

[jclouds-site] Encourage users to join the jclouds community (#152)

2015-01-26 Thread Everett Toews

You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-site/pull/152

-- Commit Summary --

  * Encourage users to join the jclouds community

-- File Changes --

M guides/rackspace.md (2)

-- Patch Links --

https://github.com/jclouds/jclouds-site/pull/152.patch
https://github.com/jclouds/jclouds-site/pull/152.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/152


Re: [jclouds-site] Encourage users to join the jclouds community (#152)

2015-01-26 Thread Everett Toews
Closed #152.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/152#event-224733857

Re: [jclouds-site] Encourage users to join the jclouds community (#152)

2015-01-26 Thread Everett Toews
Closed #152.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/152#event-224789716

Re: [jclouds-site] Encourage users to join the jclouds community (#152)

2015-01-26 Thread Everett Toews
Merged and published.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/152#issuecomment-71502957

[jira] [Closed] (JCLOUDS-655) com.google.gson.JsonSyntaxException on trying to start a new instance with openstack

2015-01-26 Thread Everett Toews (JIRA)

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Everett Toews closed JCLOUDS-655.
-
   Resolution: Fixed
Fix Version/s: 1.9.0
   1.8.2

 com.google.gson.JsonSyntaxException on trying to start a new instance with 
 openstack
 

 Key: JCLOUDS-655
 URL: https://issues.apache.org/jira/browse/JCLOUDS-655
 Project: jclouds
  Issue Type: Bug
  Components: jclouds-compute
Affects Versions: 1.8.0
 Environment: Openstack Havana, linux
Reporter: Andrew Ruef
Assignee: Taylor Jones
 Fix For: 1.8.2, 1.9.0


 this seems very similar to [JCLOUDS-558]:
 {code}
 {images: [{status: ACTIVE, updated: 2014-08-08T04:43:36Z, links: 
 [{href: 
 http://192.168.24.16:8774/v2/d312a9d1acee46499e04fc2c0cd7e540/images/cd9d57a9-0978-45f3-9cbc-edb99347be6b;,
  rel: self}, {href: 
 http://192.168.24.16:8774/d312a9d1acee46499e04fc2c0cd7e540/images/cd9d57a9-0978-45f3-9cbc-edb99347be6b;,
  rel: bookmark}, {href: 
 http://192.168.24.16:9292/d312a9d1acee46499e04fc2c0cd7e540/images/cd9d57a9-0978-45f3-9cbc-edb99347be6b;,
  type: application/vnd.openstack.image, rel: alternate}], id: 
 cd9d57a9-0978-45f3-9cbc-edb99347be6b, OS-EXT-IMG-SIZE:size: 0, name: 
 t11, created: 2014-08-08T04:43:36Z, minDisk: 0, progress: 100, 
 minRam: 0, metadata: {block_device_mapping: [{guest_format: null, 
 boot_index: 0, no_device: null, volume_id: null, volume_size: null, 
 disk_bus: null, image_id: null, source_type: snapshot, device_type: 
 null, snapshot_id: a900a56c-61b7-4438-9150-76312fa1aa10, 
 destination_type: volume, delete_on_termination: null}], checksum: 
 32c08d302f9206668030d47789b77858, min_ram: 1, disk_format: qcow2, 
 image_name: Ubuntu LTS 14.04, bdm_v2: True, image_id: 
 cfefefc1-eba2-4b1e-9b07-a8c74a872d65, root_device_name: /dev/vda, 
 container_format: bare, min_disk: 8, size: 254149120}}, 
 {status: ACTIVE, updated: 2014-06-25T13:46:44Z, links: [{href: 
 http://192.168.24.16:8774/v2/d312a9d1acee46499e04fc2c0cd7e540/images/224f4c31-052f-4e87-9f36-52c148358f60;,
  rel: self}, {href: 
 http://192.168.24.16:8774/d312a9d1acee46499e04fc2c0cd7e540/images/224f4c31-052f-4e87-9f36-52c148358f60;,
  rel: bookmark}, {href: 
 http://192.168.24.16:9292/d312a9d1acee46499e04fc2c0cd7e540/images/224f4c31-052f-4e87-9f36-52c148358f60;,
  type: application/vnd.openstack.image, rel: alternate}], id: 
 224f4c31-052f-4e87-9f36-52c148358f60, OS-EXT-IMG-SIZE:size: 344457216, 
 name: CentOS 6.5, created: 2014-06-25T13:45:19Z, minDisk: 8, 
 progress: 100, minRam: 1, metadata: {}}, {status: ACTIVE, 
 updated: 2014-06-25T13:41:29Z, links: [{href: 
 http://192.168.24.16:8774/v2/d312a9d1acee46499e04fc2c0cd7e540/images/7c35e28f-fee6-4f0a-a479-67ce8aa1e986;,
  rel: self}, {href: 
 http://192.168.24.16:8774/d312a9d1acee46499e04fc2c0cd7e540/images/7c35e28f-fee6-4f0a-a479-67ce8aa1e986;,
  rel: bookmark}, {href: 
 http://192.168.24.16:9292/d312a9d1acee46499e04fc2c0cd7e540/images/7c35e28f-fee6-4f0a-a479-67ce8aa1e986;,
  type: application/vnd.openstack.image, rel: alternate}], id: 
 7c35e28f-fee6-4f0a-a479-67ce8aa1e986, OS-EXT-IMG-SIZE:size: 13167616, 
 name: Cirros 0.3.2, created: 2014-06-25T13:41:25Z, minDisk: 1, 
 progress: 100, minRam: 1, metadata: {}}, {status: ACTIVE, 
 updated: 2014-06-25T13:38:57Z, links: [{href: 
 http://192.168.24.16:8774/v2/d312a9d1acee46499e04fc2c0cd7e540/images/cfefefc1-eba2-4b1e-9b07-a8c74a872d65;,
  rel: self}, {href: 
 http://192.168.24.16:8774/d312a9d1acee46499e04fc2c0cd7e540/images/cfefefc1-eba2-4b1e-9b07-a8c74a872d65;,
  rel: bookmark}, {href: 
 http://192.168.24.16:9292/d312a9d1acee46499e04fc2c0cd7e540/images/cfefefc1-eba2-4b1e-9b07-a8c74a872d65;,
  type: application/vnd.openstack.image, rel: alternate}], id: 
 cfefefc1-eba2-4b1e-9b07-a8c74a872d65, OS-EXT-IMG-SIZE:size: 254149120, 
 name: Ubuntu LTS 14.04, created: 2014-06-25T13:38:28Z, minDisk: 8, 
 progress: 100, minRam: 1, metadata: {}}]}
 -  Error parsing input
 com.google.gson.JsonSyntaxException: java.lang.IllegalStateException: 
 Expected a string but was BEGIN_ARRAY at line 1 column 733
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [jclouds] Fix for JCLOUDS-655 (#626)

2015-01-26 Thread Everett Toews
Merged to 
[1.8.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/f708d203) and 
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/73600c81)

Nice work @monitorjbl! This was a tough one but you stuck with it. Can we give 
you a shout out on Twitter? If so, what's your Twitter handle?

Thanks for all the help @nacx 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/626#issuecomment-71532424

Re: [jclouds] Fix for JCLOUDS-655 (#626)

2015-01-26 Thread Everett Toews
Closed #626.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/626#event-224901404

[jira] [Created] (JCLOUDS-810) Example of jclouds in a JEE container

2015-01-23 Thread Everett Toews (JIRA)
Everett Toews created JCLOUDS-810:
-

 Summary: Example of jclouds in a JEE container
 Key: JCLOUDS-810
 URL: https://issues.apache.org/jira/browse/JCLOUDS-810
 Project: jclouds
  Issue Type: Bug
  Components: jclouds-examples
Reporter: Everett Toews


A very simple hello world style example of configuring a JEE container (e.g. 
Glassfish or JBoss) and using the BlobStore within that container would be 
useful.

The example would best belong in https://github.com/jclouds/jclouds-examples 
and/or http://jclouds.apache.org/guides/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (JCLOUDS-219) Change disk config attribute in Nova to use an Enum

2015-01-23 Thread Everett Toews (JIRA)

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Everett Toews reassigned JCLOUDS-219:
-

Assignee: (was: Everett Toews)

 Change disk config attribute in Nova to use an Enum
 ---

 Key: JCLOUDS-219
 URL: https://issues.apache.org/jira/browse/JCLOUDS-219
 Project: jclouds
  Issue Type: Bug
Reporter: Everett Toews
  Labels: openstack





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (JCLOUDS-454) NovaComputeService should query extensions to see if security groups are supported

2015-01-23 Thread Everett Toews (JIRA)

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Everett Toews reassigned JCLOUDS-454:
-

Assignee: (was: Everett Toews)

 NovaComputeService should query extensions to see if security groups are 
 supported
 --

 Key: JCLOUDS-454
 URL: https://issues.apache.org/jira/browse/JCLOUDS-454
 Project: jclouds
  Issue Type: Bug
  Components: jclouds-compute
Reporter: Everett Toews
Priority: Minor
  Labels: openstack
 Fix For: 2.0.0


 Right now NovaSecurityGroupExtension is injected into the NovaComputeService 
 via NovaComputeServiceContextModule. This is effectively an assumption that 
 all OpenStack clouds support security groups. Some may not.
 NovaComputeService should override getSecurityGroupExtension() and query 
 extensions to see if security groups are supported.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [jclouds] Fix for JCLOUDS-655 (#626)

2015-01-23 Thread Everett Toews
[Checkstyle 
violation](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1527/org.apache.jclouds.api$openstack-nova/violations/file/src/test/java/org/jclouds/openstack/nova/v2_0/config/ImageAdapterTest.java/)

Unused import in `ImageAdapterTest.java`

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/626#issuecomment-71259153

Re: [jclouds-examples] Update examples to 1.8.1 (#68)

2015-01-21 Thread Everett Toews
Merged

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/68#issuecomment-70881777

Re: [jclouds-examples] Delete all resources in all regions of an account (#70)

2015-01-21 Thread Everett Toews
Merged.

`rackspace-cloudnetworks-us` wasn't part of the 1.8.1 release so it will have 
to wait. I don't want this to be interactive so I'll pass on the captcha for 
now. I think naming it DeleteAll makes it pretty explicit what it does.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/70#issuecomment-70882566

Re: [jclouds-examples] Delete all resources in all regions of an account (#70)

2015-01-21 Thread Everett Toews
Closed #70.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/70#event-222473088

[jira] [Closed] (JCLOUDS-807) org.jclouds.openstack.nova.v2_0.features.ImageApi.listInDetail may fail for some Images with structured metadata

2015-01-20 Thread Everett Toews (JIRA)

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Everett Toews closed JCLOUDS-807.
-
Resolution: Duplicate

We're getting close to a fix!

https://github.com/jclouds/jclouds/pull/626

 org.jclouds.openstack.nova.v2_0.features.ImageApi.listInDetail may fail for 
 some Images with structured metadata
 

 Key: JCLOUDS-807
 URL: https://issues.apache.org/jira/browse/JCLOUDS-807
 Project: jclouds
  Issue Type: Bug
  Components: jclouds-labs-openstack
Affects Versions: 1.8.0, 2.0.0
Reporter: Pierre Souchay

 In our environment (Openstack Icehouse), the list of images with details may 
 return some structured data in metadata, for instance :
 {code}
 metadata: {
 block_device_mapping: [
 {
 guest_format: null,
 boot_index: 0,
 no_device: null,
 volume_id: null,
 volume_size: null,
 disk_bus: virtio,
 image_id: null,
 source_type: snapshot,
 device_type: disk,
 snapshot_id: ce746121-7829-4818-bf5b-2b86d48b5ce0,
 destination_type: volume,
 delete_on_termination: null
 },
 {
 guest_format: null,
 boot_index: null,
 no_device: null,
 volume_id: null,
 volume_size: null,
 disk_bus: null,
 image_id: null,
 source_type: snapshot,
 device_type: null,
 snapshot_id: a659cb24-c84e-472b-8ec2-9e4af8211d08,
 destination_type: volume,
 delete_on_termination: null
 }
 ],
 container_format: bare
 [...]
 }
 {code}
 In that case, the deserialization code fails with the following message 
 com.google.gson.JsonSyntaxException: java.lang.IllegalStateException: 
 Expected a string but was BEGIN_ARRAY ... since the class 
 org.jclouds.openstack.nova.v2_0.domain.Image contains metadata as a 
 MapString, String but block_device_mapping is an array of objects instead 
 of a String.
 This issue seems present in 1.8.x and 2.0.0
 A modification of the test case 
 jclouds/apis/openstack-nova/src/test/resources/image_details.json explains 
 the problem :
 put:
 {code}
 metadata: {
 ImageType: Gold,
 ImageVersion: 1.5,
 block_device_mapping: [{guest_format: null, boot_index: 0, 
 no_device: null, volume_id: null, volume_size: null, disk_bus: 
 virtio, image_id: null, source_type: snapshot, device_type: disk, 
 snapshot_id: ce746121-7829-4818-bf5b-2b86d48b5ce0, destination_type: 
 volume, delete_on_termination: null}, {guest_format: null, 
 boot_index: null, no_device: null, volume_id: null, volume_size: 
 null, disk_bus: null, image_id: null, source_type: snapshot, 
 device_type: null, snapshot_id: a659cb24-c84e-472b-8ec2-9e4af8211d08, 
 destination_type: volume, delete_on_termination: null}]
 },
 {code}
 instead of 
 {code}
 metadata: {
 ImageType: Gold,
 ImageVersion: 1.5
 }
 {code}
 The message is then:
 {code}
 testGetImageWhenResponseIs2xx(org.jclouds.openstack.nova.v2_0.features.ImageApiExpectTest)
   Time elapsed: 0.006 sec   FAILURE!
 java.lang.IllegalStateException: Expected a string but was BEGIN_ARRAY at 
 line 16 column 38 path $.image.metadata.
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [jclouds] Fix for JCLOUDS-655 (#626)

2015-01-20 Thread Everett Toews
 @@ -85,6 +86,7 @@ public static Status fromValue(String v) {
protected int minDisk;
protected int minRam;
protected Resource server;
 +  protected ListBlockDeviceMapping blockDeviceMapping;

This should be initialized with `ImmutableList.of()` (unless there's a really 
good reason not to). All of the other Collection types in the domain package 
are initialized this way. `blockDeviceMapping` should be the same.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/626/files#r23227753

Re: [jclouds] Fix for JCLOUDS-655 (#626)

2015-01-20 Thread Everett Toews
 @@ -221,6 +229,7 @@ protected Image(String id, @Nullable String name, 
 java.util.SetLink links, @Nu
this.progress = progress;
this.minDisk = minDisk;
this.minRam = minRam;
 +  this.blockDeviceMapping = blockDeviceMapping;

Init the same as `metadata`

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/626/files#r23227880

[jclouds-examples] Delete all resources in all regions of an account (#70)

2015-01-19 Thread Everett Toews

You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-examples/pull/70

-- Commit Summary --

  * Delete all resources in all regions of an account

-- File Changes --

A rackspace/src/main/java/org/jclouds/examples/rackspace/DeleteAll.java 
(323)

-- Patch Links --

https://github.com/jclouds/jclouds-examples/pull/70.patch
https://github.com/jclouds/jclouds-examples/pull/70.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/70


Re: [jclouds-site] add softlayer getting started (#134)

2015-01-19 Thread Everett Toews
 +api.getVirtualGuestApi();
 +api.getDatacenterApi();
 +api.getSoftwareDescriptionApi();
 +api.getVirtualGuestBlockDeviceTemplateGroupApi();
 +api.getAccountApi();
 +
 +// Be sure to close the context when done
 +computeServiceContext.close();
 +{% endhighlight %}
 +
 +## SoftLayer Object Storage
 +SoftLayer Object Storage is an OpenStack® based blobstore storage system.
 +
 +{% highlight java %}
 +// Get a context with softlayer that offers the portable BlobStore API
 +BlobStoreContext context = ContextBuilder.newBuilder(swift)

From looking at [Auth 
Endpoints](http://sldn.softlayer.com/article/Introduction-Object-Storage#Authentication_Endpoints)
 it seems clear it's TempAuth only. 

These instructions really shouldn't be written based on deprecated code. We 
really don't need another thing blocking us from removing `swift`. 

The proper thing to do here is to update the instructions to use the 
[SwiftAuthenticationModule](http://jclouds-javadocs.elasticbeanstalk.com/org/jclouds/openstack/swift/v1/config/SwiftAuthenticationModule.html)

When KeystoneProperties.CREDENTIAL_TYPE is set to tempAuthCredentials, do 
not use Keystone. Instead, bridge TempAuth to Keystone by faking a service 
catalog out of the storage url. The endpoint must be set to the TempAuth url, 
usually ending in auth/v1.0/.

Unfortunately that will only be in the next release.

I propose we remove Object Storage from this particular PR and update this 
guide with the SwiftAuthenticationModule when the next version of jclouds is 
released.

The alternative is to leave it as is (basically recommending users to use 
deprecated code) and update this guide with the SwiftAuthenticationModule when 
the next version of jclouds is released.

Your call @andreaturli 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/134/files#r23169800

Re: [jclouds] Fix for JCLOUDS-655 (#626)

2015-01-13 Thread Everett Toews
@monitorjbl Sorry I haven't been able to have a look at this. I've been 
fighting the flu. 

@nacx Can you help with the unit test of just the adapter? If not, I can look 
at it later this week or next.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/626#issuecomment-69770083

[jclouds-labs-openstack] Fix test properties (#175)

2015-01-08 Thread Everett Toews

You can merge this Pull Request by running:

  git pull https://github.com/rackerlabs/jclouds-labs-openstack fix-test-props

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs-openstack/pull/175

-- Commit Summary --

  * Fix test properties

-- File Changes --

M rackspace-cloudfiles-uk/pom.xml (4)
M rackspace-cloudfiles-us/pom.xml (4)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-openstack/pull/175.patch
https://github.com/jclouds/jclouds-labs-openstack/pull/175.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/175


Re: [jclouds-labs-openstack] Fix test properties (#175)

2015-01-08 Thread Everett Toews
Just trying something out.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/175#issuecomment-69256482

Re: [jclouds-labs-openstack] Fix test properties (#175)

2015-01-08 Thread Everett Toews
Closed #175.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/175#event-216189025

Re: [jclouds-site] add softlayer getting started (#134)

2015-01-08 Thread Everett Toews
 +api.getVirtualGuestApi();
 +api.getDatacenterApi();
 +api.getSoftwareDescriptionApi();
 +api.getVirtualGuestBlockDeviceTemplateGroupApi();
 +api.getAccountApi();
 +
 +// Be sure to close the context when done
 +computeServiceContext.close();
 +{% endhighlight %}
 +
 +## SoftLayer Object Storage
 +SoftLayer Object Storage is an OpenStack® based blobstore storage system.
 +
 +{% highlight java %}
 +// Get a context with softlayer that offers the portable BlobStore API
 +BlobStoreContext context = ContextBuilder.newBuilder(swift)

Is there a version of Softlayer Object Storage that would work with 
`openstack-swift`?

`swift` is deprecated and scheduled to be remove in jclouds 2.0.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/134/files#r22688652

Re: [jclouds] Fix for JCLOUDS-655 (#626)

2015-01-08 Thread Everett Toews
Can you add that test code as a commit so we can see it? (don't squash it)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/626#issuecomment-69248945

Re: [jclouds-examples] Update Rackspace examples for 1.8.0 (#57)

2014-12-22 Thread Everett Toews
Closed #57.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/57#event-210986066

Re: [jclouds] Fix for JCLOUDS-655 (#626)

2014-12-22 Thread Everett Toews
:+1: 

And note that 
[BlockDeviceMapping.java](https://github.com/jclouds/jclouds/blob/master/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/domain/BlockDeviceMapping.java)
 already exists.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/626#issuecomment-67863104

[jclouds-examples] Update examples to 1.8.1 (#68)

2014-12-18 Thread Everett Toews

You can merge this Pull Request by running:

  git pull https://github.com/rackerlabs/jclouds-examples 1-8-1

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-examples/pull/68

-- Commit Summary --

  * Update examples to 1.8.1

-- File Changes --

M rackspace/pom.xml (4)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/cloudfiles/CloudFilesPublish.java
 (6)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/cloudfiles/CreateContainer.java
 (2)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/cloudfiles/CrossOriginResourceSharingContainer.java
 (2)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/cloudfiles/DeleteObjectsAndContainer.java
 (6)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/cloudfiles/GetContainer.java
 (2)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/cloudfiles/GetObject.java
 (2)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/cloudfiles/ListContainers.java
 (2)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/cloudfiles/ListObjects.java
 (4)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/cloudfiles/UploadDirectoryToCDN.java
 (4)
M 
rackspace/src/main/java/org/jclouds/examples/rackspace/cloudfiles/UploadObjects.java
 (4)

-- Patch Links --

https://github.com/jclouds/jclouds-examples/pull/68.patch
https://github.com/jclouds/jclouds-examples/pull/68.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/68


Re: [jclouds] Fix for JCLOUDS-655 (#626)

2014-12-17 Thread Everett Toews
   })
   protected ServerInternalWithoutImage(String id, @Nullable String 
 name, java.util.SetLink links, @Nullable String uuid, String tenantId,
 -  String userId, Date updated, Date created, 
 @Nullable String hostId, @Nullable String accessIPv4,
 -  @Nullable String accessIPv6, Server.Status 
 status, Resource flavor, @Nullable String keyName,
 -  @Nullable String configDrive, 
 MultimapString, Address addresses, MapString, String metadata,
 -  @Nullable ServerExtendedStatus 
 extendedStatus, @Nullable ServerExtendedAttributes extendedAttributes, 
 @Nullable String diskConfig) {
 +  String userId, Date updated, 
 Date created, @Nullable String hostId, @Nullable String accessIPv4,
 +  @Nullable String accessIPv6, 
 Server.Status status, Resource flavor, @Nullable String keyName,
 +  @Nullable String configDrive, 
 MultimapString, Address addresses, MapString, String metadata,
 +  @Nullable ServerExtendedStatus 
 extendedStatus, @Nullable ServerExtendedAttributes extendedAttributes, 
 @Nullable String diskConfig) {

Please undo all of the unintentional updates to the spacing above.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/626/files#r21985663

Re: [jclouds] Fix for JCLOUDS-655 (#626)

2014-12-17 Thread Everett Toews
 @@ -56,9 +61,10 @@
 @Singleton
 public MapType, Object provideCustomAdapterBindings() {
return ImmutableMap.Type, Objectof(
 -HostResourceUsage.class, new HostResourceUsageAdapter(),
 -ServerWithSecurityGroups.class, new 
 ServerWithSecurityGroupsAdapter(),
 -Server.class, new ServerAdapter()
 +  HostResourceUsage.class, new HostResourceUsageAdapter(),
 +  ServerWithSecurityGroups.class, new 
 ServerWithSecurityGroupsAdapter(),
 +  Server.class, new ServerAdapter(),
 +  Image.class, new ImageAdapter()
);

Should use 3 space indents.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/626/files#r21985620

  1   2   3   4   5   6   7   8   >