[GitHub] [jclouds] danielestevez commented on issue #21: Adds methods listAll and listByLocation to VirtualMachineAPI
danielestevez commented on issue #21: Adds methods listAll and listByLocation to VirtualMachineAPI URL: https://github.com/apache/jclouds/pull/21#issuecomment-492708194 Sorry, big oversight. That commit was in another branch and i thought i had already pushed it here :sweat: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds] danielestevez commented on issue #21: Adds methods listAll and listByLocation to VirtualMachineAPI
danielestevez commented on issue #21: Adds methods listAll and listByLocation to VirtualMachineAPI URL: https://github.com/apache/jclouds/pull/21#issuecomment-481736540 Just a quick update on the state of this PR: The changes to the adapter were minor but i found one of those nasty ARM API behaviour with case-sensitivity. In short, these new methods return the resourcegroup part of the resource id in capital letters in randomly and this causes some of the LiveTests to fail, so it's not safe to add them to the adapter yet The goal to make all the provider case-insensitive (as Microsoft [recommends](https://stackoverflow.com/a/50082864/2369157) in integrations) is too wide for this PR but i found a way to fix this problem just for the resourcegroups. Running all the LiveTests with this fix i only found a problem still in `AzureComputeServiceLiveTest#testListNodesByIds` that i will try to fix too This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds] danielestevez commented on issue #21: Adds methods listAll and listByLocation to VirtualMachineAPI
danielestevez commented on issue #21: Adds methods listAll and listByLocation to VirtualMachineAPI URL: https://github.com/apache/jclouds/pull/21#issuecomment-479621115 Well i prefer smaller PRs and these methods are just ready to be used but i can add the work i'm doing on the adapter to this same PR if it's better and merge it all when it's ready. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
