Re: [jclouds/jclouds] Add tag support to azure disks (#1277)
Closed #1277. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1277#event-2546055775
Re: [jclouds/jclouds] Add tag support to azure disks (#1277)
Squashed and pushed to [master](https://github.com/apache/jclouds/commit/fcf72e5ea58bcbe16b25f2a12c29ca55cc7c000c) and [2.1.x](https://github.com/apache/jclouds/commit/bd59263d470f4307fe1a70a064e11c1ebeea064a). Thanks! Please consider opening upcoming PRs on the [apache/jclouds](https://github.com/apache/jclouds) repo. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1277#issuecomment-519869490
Re: [jclouds/jclouds] Add tag support to azure disks (#1277)
Unit (mock) tests run on every build. For live tests, which actually cost money :), we run them before a release, mostly using our accounts, so we can't afford run them all. [Some providers](https://cwiki.apache.org/confluence/display/JCLOUDS/Test+Provider+Thanks) help the project with testing accounts. We run the tests for those on every release for sure, and we have a (very) few of them [running weekly](https://builds.apache.org/view/J/view/jclouds/job/jclouds-with-credentials/). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1277#issuecomment-519867585
Re: [jclouds/jclouds] Add tag support to azure disks (#1277)
@nacx where/when this tests run? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1277#issuecomment-519823017
Re: [jclouds/jclouds] Add tag support to azure disks (#1277)
@pimuzzo pushed 1 commit. 6c0c731e071ce960f17cf8a1896507d2c683e86f Fix review - add mock test -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds/pull/1277/files/7f0cd601983488b5e1ef44bafccd71090f3a4438..6c0c731e071ce960f17cf8a1896507d2c683e86f
Re: [jclouds/jclouds] Add tag support to azure disks (#1277)
Thanks, @pimuzzo! Can you add the corresponding test in the `DiskApiMockTest`? It should be as easy as copying the existing create test and checking that the payload includes the tags. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1277#issuecomment-519645773
[jclouds/jclouds] Add tag support to azure disks (#1277)
ticket is coming on jira, I'll edit here with the ticket ref You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1277 -- Commit Summary -- * Add tag support to azure disks -- File Changes -- M providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/features/DiskApi.java (11) M providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/features/DiskApiLiveTest.java (4) -- Patch Links -- https://github.com/jclouds/jclouds/pull/1277.patch https://github.com/jclouds/jclouds/pull/1277.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1277
