Re: [jclouds/jclouds] Handle gzipped userdata in logging (#1061)

[Ignasi Barrera]

Closed #1061.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1061#event-964716013

Re: [jclouds/jclouds] Handle gzipped userdata in logging (#1061)

[Ignasi Barrera]

Squashed the commits and added the JIRA issue to the commit message. Pushed to 
master as 
[e26146c6](http://git-wip-us.apache.org/repos/asf/jclouds/commit/e26146c6).
Thanks @felfert!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1061#issuecomment-280289428

Re: [jclouds/jclouds] Handle gzipped userdata in logging (#1061)

[Fritz Elfert]

@felfert pushed 2 commits.

3dc075e  Conform to apache jclouds coding standards
21d247c  Added unit test for CreateServerOptions.toString() behavior


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1061/files/55e96ac6e824efa03cad1319f508cdd808fa00d4..21d247c65e91f9ddc5fcb691302e5e31a416c578

Re: [jclouds/jclouds] Handle gzipped userdata in logging (#1061)

[Fritz Elfert]

Will do.

-Fritz

Am 15. Februar 2017 11:11:28 MEZ schrieb Ignasi Barrera 
:
>Thanks @felfert! Could you add a simple unit test that verifies the
>behaviour of that method with normal and gzipped inputs? This way we
>won't break this unintentionally in the future.
>
>-- 
>You are receiving this because you were mentioned.
>Reply to this email directly or view it on GitHub:
>https://github.com/jclouds/jclouds/pull/1061#issuecomment-27997

-- 
Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1061#issuecomment-279979148

Re: [jclouds/jclouds] Handle gzipped userdata in logging (#1061)

[Ignasi Barrera]

Thanks @felfert! Could you add a simple unit test that verifies the behaviour 
of that method with normal and gzipped inputs? This way we won't break this 
unintentionally in the future.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1061#issuecomment-27997

[jclouds/jclouds] Handle gzipped userdata in logging (#1061)

[Fritz Elfert]

This PR replaces gzipped binary "garbage" in openstack-nova debug-logging of 
userData

Fixes: JCLOUDS-1239
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1061

-- Commit Summary --

  * Handle gzipped userdata in logging

-- File Changes --

M 
apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/options/CreateServerOptions.java
 (9)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1061.patch
https://github.com/jclouds/jclouds/pull/1061.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1061