Re: [jclouds/jclouds] JCLOUDS-1533 - Fix upload with SAS token when blob name contains slash (#1283)
Closed #1283. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1283#event-3043521538
Re: [jclouds/jclouds] JCLOUDS-1533 - Fix upload with SAS token when blob name contains slash (#1283)
> Thanks for the fix! > This repository is deprecated, though. Could you update your fork and open > the PR against https://github.com/apache/jclouds ? The CI checks, etc are > migrated there too. > Thanks! Thanks, I will close this and I opened: https://github.com/apache/jclouds/pull/61. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1283#issuecomment-586970218
Re: [jclouds/jclouds] JCLOUDS-1533 - Fix upload with SAS token when blob name contains slash (#1283)
majaseremet commented on this pull request.
> @@ -281,4 +284,19 @@ void appendUriPath(HttpRequest request, StringBuilder
> toSign) {
}
}
+ private String join(String[] parts, String delimiter) {
Sure, sorry, didn't notice guava is already there.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1283#discussion_r380151544
Re: [jclouds/jclouds] JCLOUDS-1533 - Fix upload with SAS token when blob name contains slash (#1283)
nacx commented on this pull request.
Thanks for the fix!
This repository is deprecated, though. Could you update your fork and open the
PR against https://github.com/apache/jclouds ? Thanks!
> @@ -281,4 +284,19 @@ void appendUriPath(HttpRequest request, StringBuilder
> toSign) {
}
}
+ private String join(String[] parts, String delimiter) {
Can you use the Guava `Joiner` instead?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1283#pullrequestreview-359663568
[jclouds/jclouds] JCLOUDS-1533 - Fix upload with SAS token when blob name contains slash (#1283)
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1283 -- Commit Summary -- * JCLOUDS-1533 - Fix upload with SAS token when blob name contains slash -- File Changes -- M providers/azureblob/src/main/java/org/jclouds/azure/storage/filters/SharedKeyLiteAuthentication.java (22) M providers/azureblob/src/test/java/org/jclouds/azure/storage/filters/SharedKeyLiteAuthenticationTest.java (2) -- Patch Links -- https://github.com/jclouds/jclouds/pull/1283.patch https://github.com/jclouds/jclouds/pull/1283.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1283
