Re: [jclouds] JCLOUDS-691: Remove 404 fallbacks of PUT and POST calls from OpenStac… (#911)

[Ignasi Barrera]

I'll merge this in short. For completeness, could you also apply the fix to the 
apis in the `jclouds-labs-openstack` repo?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/911#issuecomment-179777384

Re: [jclouds] JCLOUDS-691: Remove 404 fallbacks of PUT and POST calls from OpenStac… (#911)

[Ignasi Barrera]

Closed #911.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/911#event-539014532

Re: [jclouds] JCLOUDS-691: Remove 404 fallbacks of PUT and POST calls from OpenStac… (#911)

[Ignasi Barrera]

Pushed to master as 
[d83282ca](http://git-wip-us.apache.org/repos/asf/jclouds/commit/d83282ca). 
Thanks!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/911#issuecomment-179782201

Re: [jclouds] JCLOUDS-691: Remove 404 fallbacks of PUT and POST calls from OpenStac… (#911)

[Ignasi Barrera]

LGTM Thanks! Mind squashing the commits before we merge the PR?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/911#issuecomment-179316319

Re: [jclouds] JCLOUDS-691: Remove 404 fallbacks of PUT and POST calls from OpenStac… (#911)

[Ignasi Barrera]

This is great. Thanks @devcsrj!
Just one comment: remove all tests that verify the propagated exceptions. It is 
the jclouds default behavior (not anything introduced by these APIs) so we 
shouldn't test this. That is already tested in jclouds-core.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/911#issuecomment-178504571

Re: [jclouds] JCLOUDS-691: Remove 404 fallbacks of PUT and POST calls from OpenStac… (#911)

[Reijhanniel Jearl Campos]

Just to be clear, does this mean that tests like 
[this](https://github.com/jclouds/jclouds/pull/911/files#diff-346bc00a46231f33755b2d3ec420cfbbR129)
 are no longer needed? Since the `ResourceNotFoundException` is a Fallback in 
the jclouds-core?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/911#issuecomment-178549853

Re: [jclouds] JCLOUDS-691: Remove 404 fallbacks of PUT and POST calls from OpenStac… (#911)

[Ignasi Barrera]

Exactly. It is jclouds-core the one that throws the exception in the absence of 
a fallback. We shouldn't test that, as if at some point we change the default 
behavior we could end up having to update hundreds of tests in every provider.
Let's avoid re-testing core behavior in concrete providers.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/911#issuecomment-178551830

Re: [jclouds] JCLOUDS-691: Remove 404 fallbacks of PUT and POST calls from OpenStac… (#911)

[Zack Shoylev]

+1

Just a note, we shouldn't be back-porting this (obviously). But it should roll 
out with v2.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/911#issuecomment-177975312

[jclouds] JCLOUDS-691: Remove 404 fallbacks of PUT and POST calls from OpenStac… (#911)

[Reijhanniel Jearl Campos]

…k Apis

openstack cinder, keystone, nova, nova-ec2, swift, trove
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/911

-- Commit Summary --

  * JCLOUDS-691: Remove 404 fallbacks of PUT and POST calls from OpenStack Apis

-- File Changes --

M 
apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/extensions/RoleAdminApi.java
 (1)
M 
apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/extensions/ServiceAdminApi.java
 (1)
M 
apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/extensions/TenantAdminApi.java
 (9)
M 
apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/extensions/UserAdminApi.java
 (4)
M 
apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/extensions/RoleAdminApiMockTest.java
 (9)
M 
apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/extensions/ServiceAdminApiMockTest.java
 (10)
M 
apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/extensions/TenantAdminApiMockTest.java
 (27)
M 
apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/extensions/UserAdminApiMockTest.java
 (19)
M 
apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/FlavorExtraSpecsApi.java
 (24)
M 
apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/FloatingIPApi.java
 (6)
M 
apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/SecurityGroupApi.java
 (3)
M 
apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/ServerAdminApi.java
 (31)
M 
apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/VolumeTypeApi.java
 (6)
M 
apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/features/FlavorApi.java
 (2)
M 
apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/features/ImageApi.java
 (7)
M 
apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/features/ServerApi.java
 (2)
M 
apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/AdminActionsApiExpectTest.java
 (52)
M 
apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/AdminActionsApiLiveTest.java
 (24)
M 
apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/FlavorExtraSpecsApiExpectTest.java
 (4)
M 
apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/FlavorExtraSpecsApiLiveTest.java
 (4)
M 
apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/VolumeTypeApiExpectTest.java
 (4)
M 
apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/VolumeTypeApiLiveTest.java
 (4)
M 
apis/openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/blobstore/RegionScopedSwiftBlobStore.java
 (5)
M 
apis/openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/features/AccountApi.java
 (12)
M 
apis/openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/features/ContainerApi.java
 (12)
M 
apis/openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/features/ObjectApi.java
 (28)
M 
apis/openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/features/AccountApiLiveTest.java
 (4)
M 
apis/openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/features/AccountApiMockTest.java
 (4)
M 
apis/openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/features/ContainerApiLiveTest.java
 (8)
M 
apis/openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/features/ContainerApiMockTest.java
 (2)
M 
apis/openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/features/ObjectApiLiveTest.java
 (14)
M 
apis/openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/features/ObjectApiMockTest.java
 (17)
M 
apis/openstack-trove/src/main/java/org/jclouds/openstack/trove/v1/features/DatabaseApi.java
 (6)
M 
apis/openstack-trove/src/main/java/org/jclouds/openstack/trove/v1/features/InstanceApi.java
 (1)
M 
apis/openstack-trove/src/main/java/org/jclouds/openstack/trove/v1/features/UserApi.java
 (15)
M 
apis/openstack-trove/src/test/java/org/jclouds/openstack/trove/v1/features/DatabaseApiExpectTest.java
 (17)
M 
apis/openstack-trove/src/test/java/org/jclouds/openstack/trove/v1/features/DatabaseApiLiveTest.java
 (2)
M 
apis/openstack-trove/src/test/java/org/jclouds/openstack/trove/v1/features/InstanceApiExpectTest.java
 (7)
M 
apis/openstack-trove/src/test/java/org/jclouds/openstack/trove/v1/features/UserApiExpectTest.java
 (36)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/911.patch
https://github.com/jclouds/jclouds/pull/911.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/911