Re: [jclouds/jclouds] bump sshj version to 0.20.0 (#1060)
Please, revert this commit from 2.0.x. We don't want to change dependency versions in bugfix releases. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1060#issuecomment-284451216
Re: [jclouds/jclouds] bump sshj version to 0.20.0 (#1060)
merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/014f7a4f) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/8268a2db) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1060#issuecomment-284447710
Re: [jclouds/jclouds] bump sshj version to 0.20.0 (#1060)
Closed #1060. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1060#event-988011469
Re: [jclouds/jclouds] bump sshj version to 0.20.0 (#1060)
cool, merging -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1060#issuecomment-284435569
Re: [jclouds/jclouds] bump sshj version to 0.20.0 (#1060)
Absolutely! +1 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1060#issuecomment-284420397
Re: [jclouds/jclouds] bump sshj version to 0.20.0 (#1060)
I tested the ssh-agent and it seems fine, I think it is finally good to merge -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1060#issuecomment-284216766
Re: [jclouds/jclouds] bump sshj version to 0.20.0 (#1060)
ok I will do, notice https://github.com/jclouds/jclouds-karaf/pull/92 already references sshj `0.20.0` so we need this merged before that PR for jclouds-karaf. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1060#issuecomment-280062363
Re: [jclouds/jclouds] bump sshj version to 0.20.0 (#1060)
nacx approved this pull request. A final test to verify the agentproxy works would be to add your ssh key to the ssh agent and deploy a node with a runscript forcing the login options to NO password and NO key. This way it will fallback auth to the ssh agent. Could you test this before merging? The logs should also show that auth is being done with the ssh agent. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1060#pullrequestreview-21930035
Re: [jclouds/jclouds] bump sshj version to 0.20.0 (#1060)
@nacx, I double-checked your questions at https://github.com/jclouds/jclouds/pull/1060#issuecomment-278970933 and they look under control. Good to merge? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1060#issuecomment-279654506
Re: [jclouds/jclouds] bump sshj version to 0.20.0 (#1060)
in particular, sshj requires
```
org.bouncycastle:bcprov-jdk15on:1.51
org.bouncycastle:bcpkix-jdk15on:1.51
com.jcraft:jzlib:1.1.3
net.i2p.crypto:eddsa:0.1.0
```
at compile time, so for bouncycastle jclouds is good.
I've created an OSGi feature for `bouncycastle` driver which looks like the
following:
```
jclouds
mvn:org.bouncycastle/bcprov-ext-jdk15on/${bcprov.version}
mvn:org.bouncycastle/bcpkix-jdk15on/${bcprov.version}
mvn:org.apache.jclouds.driver/jclouds-bouncycastle/${jclouds.version}
```
and another for `sshj`:
```
jclouds-compute
jclouds-driver-bouncycastle
mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.jzlib/1.1.3_2
mvn:com.jcraft/jsch.agentproxy.core/0.0.9
mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.jsch-agentproxy-sshj/0.0.9_1
mvn:net.i2p.crypto/eddsa/0.1.0
mvn:com.hierynomus/sshj/0.20.0
mvn:org.apache.jclouds.driver/jclouds-sshj/${jclouds.version}
```
which work in karaf
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1060#issuecomment-278976820
Re: [jclouds/jclouds] bump sshj version to 0.20.0 (#1060)
I'm trying to address all hose relevant questions in the big still 'DO NOT MERGE' PR for jclouds-karaf -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1060#issuecomment-278971641
Re: [jclouds/jclouds] bump sshj version to 0.20.0 (#1060)
Great! We need to take care about two things: * Does it have bouncycastle as a transitive dependency? Which version? * does it work well with the agentproxy dependencies? Do we need changes there and to the custom bundles we use for them? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1060#issuecomment-278970933
